From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB05443FC9; Tue, 7 May 2024 14:12:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB08F43361; Tue, 7 May 2024 14:12:01 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 80B5B402C8 for ; Tue, 7 May 2024 14:12:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715083920; x=1746619920; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=vuob1FrK12wB3ZDSpWMCNfDDwhvBF0ZIYzwJJycss3Y=; b=Jo6BPmDTepLF+Y/XGDpitHpEnetlMaqHPLgD3WrMR0IpZsVWmnjHe30O GjKriESWMgHABCZVuXkU0LwOXWcAu8iv988Z61fE+tO5OOwdWXrjnS+Y2 +kVqV5Xt8+0iqM7SIVA2oLZIM/bASwGkjmg2VB4mGI1rkdhsLr9li4grp tzVVGCdsbw1XaVJgzfMtSTVa6Wka4c79Tdpym1ikfYrHqDzwZDT72rwZt GA4vSm6nrOINI7/r6UqSqKut0SpgqzCKfLvdB9FzJC/xWQtUkTw47UeHZ mq1+VpS27XF1WHj0AYfvqKYTeWpH3yhzPh/YNgJ9wDMno2w4rvZO+RwyO Q==; X-CSE-ConnectionGUID: +2LyirK3SBu9KzUrdowvXw== X-CSE-MsgGUID: G9bq47ijQJmhuHU2WmeQOg== X-IronPort-AV: E=McAfee;i="6600,9927,11065"; a="14693295" X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="14693295" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2024 05:11:59 -0700 X-CSE-ConnectionGUID: 3XOzVgBHR228unLKBgIqGA== X-CSE-MsgGUID: jA4QocYvSz+CcJU/eSofAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="28600239" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 May 2024 05:05:28 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May 2024 05:05:28 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May 2024 05:05:27 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 7 May 2024 05:05:27 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 7 May 2024 05:05:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hx67tmsYd+mYZSKF6i0jmOtyugl1SvhglHqgdLXAGkJ+Bg+YsGC2qpoDFDSWuEmK6PzYoN/4KL2gTjpunGjFUsvyAnSwgh1sWwxst8OyEdxz86VGVWnAjzyvlc6Um4Rqxyd5gl/l7Suyhm++PMv0lT08GBmTsumtkbIx5Zmby2ay+Rzo+Hxg+OF8NsZ6rNBoSY9bXIohZF1rqS8TL4TmUkAvfSdxIO/q2ONWbVZ5WaKnm/eIXjKJaizt0GQ+z7s3cmi1WWfwRkAsmhvhh97deyNX0nJeSToalqk/MupjE0iavJ9VuWLpMsCk5Aq3J6BpF16lP96qIPHWXprnOKBOqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D2bqutN89Az4EMO2XTgUTWNhke5WqJlSHmJwOd8HYo0=; b=Ira9n8OAduFMpjLkGrrI6Z063gSjvVJQAU+CwrjmK85ZMSBdQvZDMdWN8Hz13Ub2Akb84/+xm5/Gsh8b6q4XaneAChUNjIAqfXmT1F2vJ/8mbXDyRNYyDzYNr3EztSAtRSHtWGKwSaY9thzCvnVriZncDsYdUcnLw84U5K5A7vj22q6+OMKI7IGQtgzPjG2asgIWWb/j+QzEcgfYhtPq8jR/vfHDxpMAld8Iw4g6MfCUyZANh2AXrmOktOKvjIdjHjPz9qshnnqRCYHk6oxNxaYJ5GuxxhEXB+8m8Aqsdu3f9Ghmv9AK0e16Pua0q0KkkBOyag99o8aUJ+oUNmZOrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB5950.namprd11.prod.outlook.com (2603:10b6:510:14f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May 2024 12:05:23 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 12:05:23 +0000 Date: Tue, 7 May 2024 13:05:19 +0100 From: Bruce Richardson To: Nicholas Pratte CC: , , , , , , , Subject: Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term Message-ID: References: <20240430184533.29247-2-npratte@iol.unh.edu> <20240430184533.29247-3-npratte@iol.unh.edu> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240430184533.29247-3-npratte@iol.unh.edu> X-ClientProxiedBy: DB6PR0301CA0092.eurprd03.prod.outlook.com (2603:10a6:6:30::39) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB5950:EE_ X-MS-Office365-Filtering-Correlation-Id: c747f4aa-7b0e-465c-e53a-08dc6e8df986 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?k/tVat3xgiqz2VGXZBRVszHLWw3ULI9HqVSZ03rRxY6AT3ss8i/SdPOBtr/l?= =?us-ascii?Q?lhfAagDqynmWeCKku6ittZ3pjYNQpMlr6lWqrl0UxSiwLW1Hbr0DIrRAeyNk?= =?us-ascii?Q?GzwkI5qiftnd5h3mz4DVWmo24DCpqh0DCkHIzo8S48oAeX1WlbD/z2ofP0KY?= =?us-ascii?Q?waciL9W8QX/zUKtbubvCZkUBovaCu7yRDsnfMdlR6y08m06z1GTpqgdU/2pt?= =?us-ascii?Q?l9xop2fMLvnGam6ooIXB6tuFYbBuBn6+vF4Kx5HOS4g3iHMWPEvxxaluGLyf?= =?us-ascii?Q?F7pU3Dbh4M/fbKwtGiqgU5RTeZuI8TDcfVpcbq8IdNd1NF6El+RIXpiTU3C1?= =?us-ascii?Q?zKsGIeAZq5IXsVz5ZhcdjkJAkYtfoLUQ9YL0DDEgDjhssY82JyFFim1bMcu7?= =?us-ascii?Q?oTybVneYGNTesQTyNVPHKzizrpazTB4QK8Ak4lRbZv9mGQyIGBEEzgZ3GKGE?= =?us-ascii?Q?gNBAjwtJO0wIrscYGbTIC5kNjBxn40w0VXohEyKmC3IWL626mFEzBimNVx3x?= =?us-ascii?Q?FUuRptU8c0O2eqJCH5exCyG64sHHqw05JZII+r1uId8MXYL6pMfu4bcW4+y9?= =?us-ascii?Q?efhgNB0QM93XdCp0wccO+gcTINTdtkId9QMpuDQ+tl/cVV2KR5yM1Vmb78yU?= =?us-ascii?Q?F3enMUellRZ+UHdO0AR8+LIwFyJSQjNUIQzNUsh3Rqzj7Nzw/cSeLeHjsh0M?= =?us-ascii?Q?JpdASxO/B/ywKNAecmCJKU02pCswkYKKrMWB5FrLYQ+4IHADLsI93emrDwEt?= =?us-ascii?Q?UkT/6ROB2vWcvCN9gF2jqH8j6VHhXMlaoG0gaE5tmBcym/so5n2A/IldZzTM?= =?us-ascii?Q?FF+t/tWRtpj30yOWMZjSCjy5wUMfTvSjrEPZ8jreoeSA8gjDsfVK6NovWj2x?= =?us-ascii?Q?tGCDX1Qo23jjd7u4FmXTnwJlK/U+8jBTbNb0JaBncBRFLzt7AXtB+utcbvsy?= =?us-ascii?Q?QLKlKPoRe3onzEFIefOVzHgtuyopGB3uUQTReVTo8QUuraKZmuuBLqUl+s5n?= =?us-ascii?Q?8JRZC9pEtSw5+u9siNcuE3+6ksKOQn6kAnRwT8ulfInbp9mfFaJZBKMr3oLX?= =?us-ascii?Q?DEeXTOAhrtJ+VlmcsAMuV6hs2H1ByWSZVkhItMUH3jGVtx9OpPrSgjWu59i9?= =?us-ascii?Q?Rlhgvh3swD7swwLWurxZ1DDie9IQHcn56uoZqDSn6YdKuGdFJGhPrtS+p2HA?= =?us-ascii?Q?QyQbv5d6linAQMqX78c6yxTb1dE3acgPRcXWXKnOnoxy36SUH8olUS6rPNxt?= =?us-ascii?Q?u7HMWHtguT2sADVm+JfntKKfke10vmKHh2OeoCRkyw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r149KeVqQyKc0N7quJ0YEfXzPV8yiic1G23Ifeq099mTZiLWd+ogC9GeLprc?= =?us-ascii?Q?5L+yCY8su4CzBPWbtyebMW8It96SySc5wKvBUvFl1hmepT5rLgIsYI28Bfo0?= =?us-ascii?Q?ycaj7KUPU+C0hFQaXcuy7zPcVKwEx3QnBaLPk9tApEBgNeJcKF6BmEej3MgP?= =?us-ascii?Q?09lV2h4IaEQSyEThDcNro/ITioozZUiURV72oOLGA8wiFyyAYLBrc4AiB1VI?= =?us-ascii?Q?d8jP1UpaBM80q3u881dkw+O9JsWmmSsMAMjlYKEtiFRWa5h27SngDh8djcd+?= =?us-ascii?Q?fG11aRih++AUiBc9Ac8Dd6E5x4qY67VKLi3dEBATwPJD0EKATA0hXyiOXyxv?= =?us-ascii?Q?urhw9u867gmyMvfJ6eyOkoG23urkrMGRNJAilNWrewGMAPY3TKWsWOafqMrX?= =?us-ascii?Q?qJkILb30cYaKKAm1wUp/A36noKRFZoXZ3E/2YGfmn3BQGXpm0dRKSc6Mm06/?= =?us-ascii?Q?/upBC20ilM0VDQPnQzYQjIvDKtE3ai0PKkJj2x+bWXAKOZ0izg2tvprRi1Jx?= =?us-ascii?Q?YFOEJzNTea+2CQvgIjo95e7UXOtC/Qg4W1LaWMQ7B/UZvNtn8I4I5nK3r7H1?= =?us-ascii?Q?gzP/9HwQhI6lmiLWC8rcV6m8wJWLkhYbjTf8CLqFRAWS3Xufla34lS4Y3wGU?= =?us-ascii?Q?AUoJ6pCgoOD7xPCJltZ3Hx1tDwbNlFy5KQzqiVZEXXfynFNKd4O+p9Ras0JM?= =?us-ascii?Q?6S1vvoHWruTo+mZPPU252fllyDe0fQuMmxh00R4Kc4Vz/mrgvaYC/W6a7zoa?= =?us-ascii?Q?5LqhcMu7tDmUW0xH5OtLWfMMwUq9G2WKGes2cppT0hdj1TGAlXkK+HyZDF46?= =?us-ascii?Q?MfZ7zZbJK5MoNDxCFjlV/vL9ORYhSFyemtJUR5gS3WxzSjeRK0/Zs9RxTMAo?= =?us-ascii?Q?HBPOvzc9U3IVBSZhYUsTorbL0pf9QfaKy6Lq5JTlnWr6M8UHXQSNINeg2QTz?= =?us-ascii?Q?mpB4JZAs0nrQ0nUdrrDqNqhxiJ6KCKcXQDVJkWWwvib+xCV1BqzhLQ4d9WiG?= =?us-ascii?Q?nZ7dJVLfd80yKckL07ihy4QtgoAhONeR1e38rcCiz5V+Oh3A1klJ9JNTOTV/?= =?us-ascii?Q?OS/Gk3X9BWTf/7I6piRX32mgrhtlPtn6TbMBTKfwn7MyhtYkT5r4ldhB6xX5?= =?us-ascii?Q?6AOY8p/Irn4kT29wQn5uRNLE4/AMtU9VHPfjFlY1nGRIz6nNx+roSTyeJfmY?= =?us-ascii?Q?EYLsmu7r+aaJ+8bPAS423vljiVNiikRo5mFIa2NICmlPVill3xorHLzjmHft?= =?us-ascii?Q?9QI5aB9qdMPq5m0Alz2lctdWNybGmIMUa3l8ipBUjKOmDejJTP/1F9lNzMRs?= =?us-ascii?Q?isUqeXi8hWFURbXhL+Wrp+gf6ruxM7Omm8KVV7TReGf/m3NKQVzZ+6jKRkQi?= =?us-ascii?Q?6Of6yOcZpbwmQK74Pbo0C8TklIzndt/ulS8frrRXD8P9XLDVB58AU4DoLuRA?= =?us-ascii?Q?0Y1UF/PZcsuoljzUUcj+krq25m4YG+nhtZw+bD2O5D0QJauH+Ci/n63Jq0H7?= =?us-ascii?Q?6Qo8hU0kqjXEiSogvJO3VLB1dzVX2JQRNgYZ/w/q57RS4OaqjGTlak1ne+y7?= =?us-ascii?Q?ugIXtKI1l+9DLtPY5gCtRyUHl6AcvLXXBgkr14iqZs9w8w7baSFug1ph3EA3?= =?us-ascii?Q?5w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c747f4aa-7b0e-465c-e53a-08dc6e8df986 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 12:05:23.7685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: joKKIeyxhKMahEYURWUdh4RwHxMiVuRIPjhIq9/8xYNQPbYEyp192momIUDn6CYP0tCIqert/gDetfWL4IleyyB8rtFQg+fMIsS8BIBPYdk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5950 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 30, 2024 at 02:45:33PM -0400, Nicholas Pratte wrote: > The term 'amount' is used for uncountable nouns. Since total hugepages > is a discrete value (i.e. countable), the declaration of the 'amount' > key value pair should be changes to a different term in both the config > and the rest of the code. > > Signed-off-by: Nicholas Pratte > --- > dts/conf.yaml | 4 ++-- > dts/framework/config/__init__.py | 4 ++-- > dts/framework/config/conf_yaml_schema.json | 6 +++--- > dts/framework/config/types.py | 2 +- > dts/framework/testbed_model/linux_session.py | 4 ++-- > dts/framework/testbed_model/node.py | 2 +- > 6 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/dts/conf.yaml b/dts/conf.yaml > index 56c3ae6f4c..44b5e4ec84 100644 > --- a/dts/conf.yaml > +++ b/dts/conf.yaml > @@ -36,7 +36,7 @@ nodes: > use_first_core: false # tells DPDK to use any physical core > memory_channels: 4 # tells DPDK to use 4 memory channels > hugepages_2mb: # optional; if removed, will use system hugepage configuration > - amount: 256 > + quantity: 256 > force_first_numa: false Sorry to be late to the reviews here, but since this is a countable value - as you state in the cover letter- would "number" or "count" not be better terms. To me, "quantity" is just a synonym of "amount", and can be used for uncountable values too, e.g. "a quantity of water". /Bruce