From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA80F440B4; Fri, 24 May 2024 11:49:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 587354026B; Fri, 24 May 2024 11:49:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 28B70400D7 for ; Fri, 24 May 2024 11:49:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716544173; x=1748080173; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/4XshLO05B18d6e0+780oZacUJqVIqBove1K/J4xtto=; b=XGUPH3iWztUeyh+Pgdn6E3px2GV69CF9ZyHAgBVf6+n/X3o2uhudYiKJ l8WgGl4w8dgWsno2uimffdZQ8Do0sVafJP0liT0xWZCVkgwQLu5itsiTJ e0XqDy7q7r78YVmhkix0KjlACF6P7E6GSweh+a20lKpFgjo4cXes2iBNc e8UEG60NhHHNYJu3AeHIHC6kpNlqxn62lsdU2QsTV7+VTGB4rqWkeOdBd ZK7RFY85ra4zQK9SO8L9AMwGLlc9phxZeP8ksagBz++EsM8cqJffPkxLs OxkBIB5NI+nDpJB3qUovaEYx+YqiTrRM3AOixywG5luweHHp55ZYdrZKx A==; X-CSE-ConnectionGUID: AhbyPthDS2GTup0ZnTMcUg== X-CSE-MsgGUID: q6wheX+rRwu3ZOO7O29ZRA== X-IronPort-AV: E=McAfee;i="6600,9927,11081"; a="13032034" X-IronPort-AV: E=Sophos;i="6.08,185,1712646000"; d="scan'208";a="13032034" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2024 02:49:31 -0700 X-CSE-ConnectionGUID: Fs2d3ItAQzOupKXw60a8lQ== X-CSE-MsgGUID: pPTsPT8kTo2ix1LAalLEBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,185,1712646000"; d="scan'208";a="64783996" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 May 2024 02:49:29 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 24 May 2024 02:49:26 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 24 May 2024 02:49:26 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 24 May 2024 02:49:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AjshHOxaDwuJQI9sTxOz+u4n/5M6W63UlaaZlJh3sacG7FEcFR5O8aRAQjIZkc5AjmhTZ8NwNZnv2o0+V+REWh9Tpo3zo5sJgPNUVRBAXwrmVv/ygPQdYtvVMGxJcwTym9lf6awX11ltVPAq8S6eAWsDDgDBu8tNBEdPIqXMoTW381PLVh17+1pO/ZQ2Z0zbOTMUGKZU/9eRvTUQmOJQlpCnNTzJdCqifacf584CW/SXvFkfGIBOkXZYrAv7shK4sPPJA72wI3ApHHYLNFnmioGZnD0RGUDfbE47PgZ5TwJVPDO45EBAY9txh+fzLocDpDez3Ju8amJnH+ikNse/hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uKxphE/OxIeSk1H2v9+K4ZotxFqjwp3dDmDoolSTygY=; b=NxfxDHS4xrS5+rctqdjfvQx8FVfM8+X0Cc95RZ2pMVy8AI5c4HrsB2Z3u89Cq257QbDAkwjB/xOPumcQmoxQCBmoaRq0WutdpLwyj+gtirTuLAysMNQbK97bmrAa9FX7OnuYlRw4pZSxng3m7cOT9HmmmMWHlKtjJdirUX+Hn743X1aiyTz1V0oovmeJTTKSola0vAwVQOZweeuBr2H8P3w7lMF8YNpIXfgmUU+t3bkIfl2104x6xKk9omUE4eKCTYrP1l3oDg27R0YUzChiIm4BL9t4PA3VKmpU+mqpOdAa8x/v9sv/yN9+VPpB2VecM/DdYfluNyDIt1XaCIZP+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA0PR11MB7882.namprd11.prod.outlook.com (2603:10b6:208:40f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Fri, 24 May 2024 09:49:24 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%6]) with mapi id 15.20.7611.016; Fri, 24 May 2024 09:49:24 +0000 Date: Fri, 24 May 2024 10:49:20 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Subject: Re: [PATCH v2 22/27] net/ixgbe/base: add support for E610 Admin Command Interface Message-ID: References: <6014fea5c86f1f48d358c7f2b467a9bb396dc261.1714744628.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6014fea5c86f1f48d358c7f2b467a9bb396dc261.1714744628.git.anatoly.burakov@intel.com> X-ClientProxiedBy: DB7PR03CA0102.eurprd03.prod.outlook.com (2603:10a6:10:72::43) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA0PR11MB7882:EE_ X-MS-Office365-Filtering-Correlation-Id: e80530d8-3a75-4fad-01f7-08dc7bd6cb62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VS7IAiAsEY29E2ceV6FunEHCGMXZKTvvTaIIPUIRew8LfHlhnEMHP3YDL+yT?= =?us-ascii?Q?iMFLLTMmHPAGFpw4cheKHnU47qzCvoov36Quj2+eyDIa6aSSLZGGpg6ozzPa?= =?us-ascii?Q?zznp9pDcFk4XzPMsadNMMrYmyyZyM4by3iyq5tJJhtwBkMwX7g5myKtgUTF0?= =?us-ascii?Q?ba7XZaH6f7IVNbnyrxs7q2moCanLWKhVhUn1IKq3vWu1V4OqCx8I3PaykEe1?= =?us-ascii?Q?cjfaXf632Ipe9IvlzLfABtH5ab5uvH2xLH1bppoR90UZCE9ZcmGra12KaZkn?= =?us-ascii?Q?KSx+EGwcq7dzgb7eda8DcbRd1AMpxaXav/tLXOzEvPMpG+OB9MWv4BnkxoOD?= =?us-ascii?Q?p2k7N1NUl8aw0IeY/82gn46P7maRLYXvu6cmiC4XrGR6F2rz6wUwGwvvyUNR?= =?us-ascii?Q?7GgTIgPYNgNmMTHgHsGBKjzYj6u82fCWXJE0gz03kcdnIy+58/qjFg8Mpk++?= =?us-ascii?Q?aoQt7+cpBSFX9EsV7MC/DircnPMCynNHIyYcrk4SpsOH4J6XFPOo7DmieIiB?= =?us-ascii?Q?/f/yqmOz47fui+k/4wdAqo0sf3s/2lHU3M8J7rgsb9Z1SFNxcvvztbgl20yl?= =?us-ascii?Q?X5FdoBHkMIBkTiH2XBSb6lTX5Exl5Y0Mb8cMykmVorbDUd0z13h2zfCqlnY/?= =?us-ascii?Q?qepA3+Hy+g26lEbuZoP3wqN/dGgIJJiSscwfceU178EMBmKH9SuV3Ryy9YFf?= =?us-ascii?Q?cYUbkeqGkbOjaGBlgCInLG37Dkr61bm+uHtIy2ihkSx+fSzGfIbZb4ZNrvaP?= =?us-ascii?Q?dgYjf4J+G+gjv3TJR9ahhe8T9V4j4zw1MDbz2dW7xnPneZGq7Ivg+TPtYELF?= =?us-ascii?Q?RNwwohRqAexoLjoTRSyFA9S5x+RwaRXwO/L8/pHKerCZCGrwEgj3eIr8MN8q?= =?us-ascii?Q?bz64CW3J8CfNu5LS+sEnaYci2ndJPiJ7JsPwl745eNnynXofTeZe/vDzSyxL?= =?us-ascii?Q?ea9pPZMqWqpmxb1HYafPUOsWGDX4oUYL9IJ8dsnprUAPpJ0FyIBStF62huqR?= =?us-ascii?Q?NA369VVSzfrsuxzs98X+N1du/ZucEfTVHGNvVjtrC4b4xRgrQckp3YGRSnFS?= =?us-ascii?Q?Yh0yLaIGChTqOkrLoWxLzXqfceSgQtx3UON51UcmxoZxTnf29ghjo40vWAL/?= =?us-ascii?Q?hTOlEG9w3QC+2+xFnflwATgWN1TJQLJ6ZB4V9tSr3xNj2rHm8ts7FBkgKvPw?= =?us-ascii?Q?yzKKBde+TS1SA8vN1/jPb5LMPsQ0qi4fQ1U2YxTOzX/PQHEO8fDQM+GDuZ5p?= =?us-ascii?Q?ckM4cpg+xCFfNVIQxHBMgIdJK+kkw7XSGPlGHFcVHA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/AbKPWzs58SIn6B6iXRgazfSlz4diRdBQMVwW5gbZ+/+JUF744liRmUvobMo?= =?us-ascii?Q?8SXxGXli4JZBb0h6rsfPEO8Pk5pjMB8hMB/fLTU8KLUlc+7orijvi6BMSmV0?= =?us-ascii?Q?+FKkO3zrlM7Y7HqE3sPYZBXQP4YQQ7QZJnis0l8WUHWTpOj1wVF7XfEd0L1l?= =?us-ascii?Q?uHTlVU/G5CVzXsQqeC1t50mAOtFC+BB6jcd0sDZmhgJo5g0f4aFISyzM8ZJr?= =?us-ascii?Q?UUvLn1H3btoOEisSvDRzqd/4oB/tKd1MlpQvgdm1sgWngC/SPNZC1QbgwSk4?= =?us-ascii?Q?gh18gGM8NSZ07u5H6gm7BNlvO4UoCdtbuGv9hFneJmRTjWOgM+1krFF5N4xD?= =?us-ascii?Q?M3uV6vnHeMTJw7NWXAoL2hTwZpN5WY99tHDth/1aD3gXzBckP/U4JRYAgjm4?= =?us-ascii?Q?aRVdB92HByLZQ0yh+dZk0K1iYLkGyYXYbZUdmoCWl5gAEZyqINegxScMaA8O?= =?us-ascii?Q?Iwhg/9iDesUk4OlM5Dzu6Z/qQRczmoAVvlstUYv5FBI9cXF2ES9/KgvB3e8n?= =?us-ascii?Q?+90YSpQrc28MgZxQHlTfZauqKOnqI8f5fhVhRJTrYXQmL5LbP2g1F4J7dk3j?= =?us-ascii?Q?/vrqnYKU7k+f1fU9+nbh7A7WOh12faGy/MIoSMZ2Ktzb2l1vpJBZl5uUD81R?= =?us-ascii?Q?XcWFjEVvVF5Io+pq/vtpGjsFJFzLSKuByma0Rgap6L6u61Y6iEBhCnYY+S1v?= =?us-ascii?Q?fAFFZGEjrVUMrQarBFeZqzAxZn98b3l6j4kSQMb++YKqaI2os3jUixHEnq2n?= =?us-ascii?Q?LeBV5Ty7919D69+WfXS8hxTbUJDZkZ3nOCArAjHsejgAykBKLJ0KjXCVdOlp?= =?us-ascii?Q?ZLO9IzJrLDB5QZCHGum8+teGgMugIWSMqJerDs7hUUbBwBWSOaF7ty0o0oR3?= =?us-ascii?Q?ZxfHmHCKX25vMXIVc/MYqeH8p1rPGlS5e00rRHqVBAlgPgc7W4A6NgDDyv6G?= =?us-ascii?Q?+OEflLNr3YNaZ5cSHSIPIPTPLaB9eLcQLGTqyTC5g26t6NG04Wyt08oNP1MB?= =?us-ascii?Q?TjIZkuLyXr7SOfrmB37Q3aI1gtks3ULcbqITcuYh4qfVAFOyFdjEvNU+cbX+?= =?us-ascii?Q?lGE7dPSTk4C2iU+0sUvqGS4GspGM0iQJ7yrcgbXPoveSs+hJqN2quALcB27K?= =?us-ascii?Q?ja8ua1zGRvuor6Hbm21DWSgOxxShSnwB7F4tbibp8KJH0ZwGcFdJFA5Cyqlk?= =?us-ascii?Q?GFBhE0fXOrLIpNvbXOHNY/2vRBmNGz1MgqB+y5FV5l6/TADROwW824rjO1PM?= =?us-ascii?Q?HYflqaV5MKUZnubgPL90xXiLO6+tzk6yyWR/Su3Cz7Q/Wz6Z1HpBW/u8F9ij?= =?us-ascii?Q?xVL2WdqFbeRyjhtdItgTbthUX0N2OK0mxz4anAS7ErGeL894UghOmOXKZlmx?= =?us-ascii?Q?8dijiXlLpUmFmB/8LHsKCGmcVn9ytvazDAB5/ht/7qZaVVEvvc/SCJywzlXp?= =?us-ascii?Q?EZhx4QLEZIIyL/8zqhE8onxsUFNYlXi3u64hCkr/J5c2QtV+h4wY6LXu8fF1?= =?us-ascii?Q?BAusc+gZkzqb62Ezh2XL++WwhcsuewCb2SLFzVwfyIO2hDjpE+jmcutDy0z9?= =?us-ascii?Q?dy/xaPqDF+Slqiek/sMGvvNVJQd+7Ux7B2+fTOMtURm3cMhw2IeSWcMhY9Kx?= =?us-ascii?Q?sw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e80530d8-3a75-4fad-01f7-08dc7bd6cb62 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2024 09:49:24.7044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GUNet9ykM30Aow9vNNKyl5CPkwByInGCXt4UkhgUNr1Jlh9tc+yIP5c//ONn02MyhQ559NkuYRNhKWfg6d8vpO4Wt1058ywd3eROfX6L5ms= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7882 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 03, 2024 at 02:57:53PM +0100, Anatoly Burakov wrote: > From: Piotr Kwapulinski > > Add low level support for Admin Command Interface (ACI). ACI is the > Firmware interface used by a driver to communicate with E610 adapter. Add > the following ACI features: > - data structures, macros, register definitions > - commands handling > - events handling > > Signed-off-by: Stefan Wegrzyn > Signed-off-by: Jedrzej Jagielski > Signed-off-by: Piotr Kwapulinski > Signed-off-by: Anatoly Burakov > --- > drivers/net/ixgbe/base/ixgbe_e610.c | 569 ++++++++ > drivers/net/ixgbe/base/ixgbe_e610.h | 25 + > drivers/net/ixgbe/base/ixgbe_osdep.c | 47 + > drivers/net/ixgbe/base/ixgbe_osdep.h | 18 +- > drivers/net/ixgbe/base/ixgbe_type.h | 59 +- > drivers/net/ixgbe/base/ixgbe_type_e610.h | 1682 ++++++++++++++++++++++ > drivers/net/ixgbe/base/meson.build | 4 +- > 7 files changed, 2400 insertions(+), 4 deletions(-) > create mode 100644 drivers/net/ixgbe/base/ixgbe_e610.c > create mode 100644 drivers/net/ixgbe/base/ixgbe_e610.h > create mode 100644 drivers/net/ixgbe/base/ixgbe_osdep.c > create mode 100644 drivers/net/ixgbe/base/ixgbe_type_e610.h > The biggest part of this patch is the definitions in ixgbe_type_e610.h. Not sure if it's better to split that out into its own dedicated patch. WDYT? /Bruce