From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 452FD440E3; Mon, 27 May 2024 14:00:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D481F402CF; Mon, 27 May 2024 14:00:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 7C3E1402BD for ; Mon, 27 May 2024 14:00:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716811233; x=1748347233; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=QjeEaQrEmfEw++iEgGhI+HLEOhkJ2T/UJK1g1O/XURM=; b=S5KJ54dg+LQKKhQ9C8iVxb3hRFV35fPrSarnJKgN+oXKP5BvvQrdJPy4 etA4troOO8k+2FLG90JTP1Voq27uVQ6xMXHcmbWtQXsEpnjl1Ln/R0MYD ybLb+q1Iw23t0v9YTufPof0fLIGOtaB3NroqHuPZnehwn57sISmU2o26t SzBMw0NyrojkasPU3xl5m1BzSyuLwu1m0QzCMINiXHfSiClApSzWgHZj3 pPoqTPhJPSgnmHgQrr2ZclBuNM7wUfhN2OSSQ0T2X/EBjgSUiY6fnpOV0 RTU4o5XRf/INDLFHRENXDkeUmFwRKXOUOJowSLgKfx+7r+KxMscY5WnnD A==; X-CSE-ConnectionGUID: ovlLlSvkQIKymRoMYrQPfQ== X-CSE-MsgGUID: 6jlsVlYbSWmKgv6aZqJbeA== X-IronPort-AV: E=McAfee;i="6600,9927,11084"; a="12905508" X-IronPort-AV: E=Sophos;i="6.08,192,1712646000"; d="scan'208";a="12905508" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2024 05:00:32 -0700 X-CSE-ConnectionGUID: rj4RxKB8SvKI/oAM+y8dDQ== X-CSE-MsgGUID: L7adVy/2T6+vdaHkk7spWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,192,1712646000"; d="scan'208";a="72158394" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 May 2024 05:00:33 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 27 May 2024 05:00:32 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 27 May 2024 05:00:32 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 27 May 2024 05:00:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QNjSI1n+ysFhCzvaj+nHSy+uzVhxwPx7l1NATFrxAgVejQsC/0URVieVWhDA8QR8O7RX7Vx7M5fn+SvWUZVyY8HPb0RDEfB2uwTE+aisSe7tZdka3Sm9psqeEKPrAYyLsWQyL3GBPlMFrO+lHuEy0heNCIElQUJ2/HFrVBg2CrNR2XEs98Dh1uhYX99LAZlMoNJTMqmdvBlwbAj7ZtkeTtg85s2wNUH7GUvyxVzVwAAJ994hskVrsl6HmLK0nMH4yvcYemoLQMM2z7B53tuXvp3EXC6D/fJ+/tKDPt4xfDVAO2Cc1XWLg7BkMJc/vYImpdWlCHCAofioQM7wS1bpdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RRJQAlgHOfRK4TwxLv1eOiuQsn9sLxSDPrZUNZKdSfQ=; b=ZK+dgUysYdVsb9qfN/OzhPjDkfEXgiV4y/p+hlG9ErROlu8ES+9Dv/pnR+2uVLACTO+mDdjhgqpQXlg0GtRwV6wPKx6wtFd3Ylt9rTkpGV27lG1Voz0znnUIqqDNdJ3wll60jjqwGK5oZenpZztpV+zPJo2G9/pxpIGNTZM9FNScG6KYhPdA5wrhPg+Q4N5+YJi607OZBuPpdRTOcDYaXc2j/Zl0Cx3e4C3c7JhAH/rXmPoqqwRrj0zrzvw4N3lTgqEWxWUfIOQHvKww+PU65eg4WA83VI4BPjPJLBnUbYUmX9CRngfiwliO8rj+osb9Qe7UB5JuZfJyKKS1UG4o6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH0PR11MB5218.namprd11.prod.outlook.com (2603:10b6:610:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Mon, 27 May 2024 12:00:18 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%6]) with mapi id 15.20.7611.025; Mon, 27 May 2024 12:00:17 +0000 Date: Mon, 27 May 2024 13:00:13 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , Morten =?iso-8859-1?Q?Br=F8rup?= , Andrew Rybchenko Subject: Re: [PATCH 1/2] eal: provide macro for GCC builtin constant intrinsic Message-ID: References: <1710970416-27841-1-git-send-email-roretzla@linux.microsoft.com> <1710970416-27841-2-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1710970416-27841-2-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DB9PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:10:1da::27) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH0PR11MB5218:EE_ X-MS-Office365-Filtering-Correlation-Id: 51638ac7-108b-4998-80fd-08dc7e44936f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0LgR03rzxluroaURKVqJQB3nYWKxRjX0ZeLnHsnE2GJCjCOHZTQf+KuS5kYA?= =?us-ascii?Q?2evI+QD3GFqD/DumC1uqy7knNg6HmHB6xJdEbv9p5+zmg24sargtmTrBTH1W?= =?us-ascii?Q?81saHb6veoLAvgzc4RGrr1Za4CO4N1C18UZqOb8rzxgL65pww0qIdN7UF6zB?= =?us-ascii?Q?YRT0phwYT5g1/SsEq1yD00GbRufkMAR7jC1RO3kq20Kk3ZZ+D8as42T7bQPx?= =?us-ascii?Q?NXu6g6sCQ45YH/8bCC7InHdNNQJeuwWe9k852nJYV5y6HzWCdECpZhFwIY2L?= =?us-ascii?Q?BekUk2mWg7mYJd7eTaXaY6yOhy+jiN7AalavUnZG7B805NKuDdoELcG7tO8p?= =?us-ascii?Q?Vp0hVCnbvEee6lA7Z1lnqexOszOSEovdqzKHXfzRZKnkvSGhoJvuuFHQZv6b?= =?us-ascii?Q?uF9xgsISCxPXE1WtVQA/At3NyAT8CyqeZ/gBWSca+zbVY3Xz/iJ8Axac4Tz/?= =?us-ascii?Q?VNC34BhBnw2c1yNGlwLDlv6fjmBkJtS0AXqnYtR6NvPSyoZwVEn5REobjnNo?= =?us-ascii?Q?ESIhEmsNRElClTnnYS3Q3qjs0ap+CEW6w/91UDDkPJQFWoRoGFH0++n8wEfd?= =?us-ascii?Q?T24agk6Is28Wno1DZgu7brSzb1Ih6RSunfWw8Kp8agwMZgXCfxZD7VLGDZ6g?= =?us-ascii?Q?FlkvrFFgGwRsSX2r27Dq7xBAlM65sU+v0JnSz+0cy/FSYtWFvR61JXa0asJM?= =?us-ascii?Q?VTaM3CGn8lkyPbNRrqW0C2zbSPUtk/Gia+n48tM0lfY92pi2ZozSCEyPQlDL?= =?us-ascii?Q?tUz1lhPWSVGyUEmds4oEWZUB3HycUBjnmO/oDsZkPmnEIsgMeoh8vxt5ok6n?= =?us-ascii?Q?IncLLUzJRzMzndTmWBfjlArTeRPYEimv7yQg7VShSuwQDJ0aG80DTBo8Gx7u?= =?us-ascii?Q?8875q6G79c/OSGsx13ZMvPMN5jPg2QVw8M4YhBPenxrG+GjOMZZInoy+J/AU?= =?us-ascii?Q?JmSptV3wYGPkimLmoZMFws8j8U5KxXXRgtciPcWQTjAVbXeLbpAAIDkaSxLT?= =?us-ascii?Q?lMVoHYBChBuyn3UtELc9OkLstABrQoN1vZYG4LzZnclcefbz0kqeVcTIXiVA?= =?us-ascii?Q?LiGnoyghxcwf6CtMFcDPJ1FIYviNikanP16UHV8riBMfOm2CH9TpEFjlmMBQ?= =?us-ascii?Q?nomVmTVJhmg5BnKkHHcy2HSIfyFQp0zgry3djRdGzTd6Al0kgbhK6GEy/GIt?= =?us-ascii?Q?RQaxj4pFehHHlKuNObxXRNz6pP/Qhb1UIXwnqtQqnrmwPnJ114QWgUJENJp1?= =?us-ascii?Q?4v+Cuk41BoDM4CJBon8pUGlnh27yRI/BCC/FB+ZXug=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3dB7Nb40TmXBMDDH7ZRCKmHxqhfftGJDs78cUfTovo504/fMeul57uLSAhfB?= =?us-ascii?Q?P+++80GoFqX67ASHNvB8e5hpKarmwobU+8xd+dnBNhjy3HtLMoaytclvgmqC?= =?us-ascii?Q?0qze4sEYwxJrSaqKAdHz4IBrDVFG2lah43ztY20t/29dqDZ2XXMO1zXMync6?= =?us-ascii?Q?3+/1Vab1IwmpCOYTWmJniUoMMHYdfHnmPcPDg0YpBVq3kuwslzgyKHHcDKAp?= =?us-ascii?Q?TXtMLgCacVKeTExDKY5NmgDVE0vMZMUCvg3VSbUMMjQJW6umFGFvlDwVC8A2?= =?us-ascii?Q?rQk9RMcKdZ9aSxuA9vG0vvNFpDq+KQQBUv3LCnfD4eVeX34OpM55scQVeKPp?= =?us-ascii?Q?xDntGrLSnNhVUqL9lLczlWnzHOIcfzbbEIP7rM6lBS4S8Q7ubMfMV/EXVcHe?= =?us-ascii?Q?TBdg7habykQvhEIsHTm2NBCzBodM6ihyO1yKIcZcy6nB3yTHnGcI+F2+TCty?= =?us-ascii?Q?SVg0VEYDzqw21XPHjKqfy9W/I0BC6D0UVRuhDDTNhDGe8q8b3PJPGJ/H9t1o?= =?us-ascii?Q?nyebuUwuzqEKOHR1qDMus6+tHeNz4U4xSj6FFrTqGaEKC8cV1FV/JOsrwpfA?= =?us-ascii?Q?iX/AsXyueCWfwVfpUUHmRH4lPzD6FG6zz1nqCRh3zRg0Td+hLAIX35hr6X0r?= =?us-ascii?Q?PREqK3JYTb74FZ7LOmrCgyEnn33KysWIhgQRTrRnWisSlPIYxqK+bjLrfRV/?= =?us-ascii?Q?ID9Q6M39+quyDD64IRbxcMJty4PkLSNFqKs0zGPHCZIdNC+YGtwr4LmuwLg/?= =?us-ascii?Q?hOSLkWbjo9AwEQLIaPcFUQVaYBLj+PGI0XlNUK2WK+34zv+wtQwq1Dm3Oo5j?= =?us-ascii?Q?oY/cuSqHgBr+m3DAEPIe0PC14cokGA4rBbpH118XZZl/Us+BGfnNMLzEvbKT?= =?us-ascii?Q?R+phhR6XBgxTsVinrwjoQy0ODIuyc6hXEbJngMztJMJjIC4fcCQWvzVsx55Z?= =?us-ascii?Q?fi4OwlN22a/7pecfpzSuciTA4j9cDwGOyPj6Erh5IxiC2CJXetc69orue6Ch?= =?us-ascii?Q?8of7v1VPiJcGAIqhWP9Q+3ItF10Lsq/WPlinoBUd0v6IC5ICAiuf84ibJbOH?= =?us-ascii?Q?0G0bMjNH0tgB1rdKu8S7L3FnV7bVmM7RyrT/mCQgjZ1vU2Atzx8AIF7ML/IP?= =?us-ascii?Q?Uj4QNtYpY82+QUn8rAWtOzdrGcmOgq/Z4tgtDzi9Fmge2LgWPR975vrrihFy?= =?us-ascii?Q?QGhN9+PsdQzFImIwKycD74ttljEYcLONjLxAJoGt+nh5qPubjWULbwGZTZI0?= =?us-ascii?Q?zHU1gxHchPbcpYUclPVTUI8u9E3ZKYqJXDCa/L73hVLwOrkXkA19p6fq26+k?= =?us-ascii?Q?j/xsHwuT1PkUYr+uL28WiO32bDL+9vvZn3lCiTALWVyS28J69a8ixF2VuE4E?= =?us-ascii?Q?NynbdXoMABTYV7KX5aVmu9VwQSHqwj40Uj2r6ZMN78VNQXUPsoBfybNtvcKX?= =?us-ascii?Q?haL3XhidspwXT1sf/5ozkZJq9nnJ8r0Bz3BFy4TOwQQb2Wdv/YFpPDEppPzj?= =?us-ascii?Q?2Bp8UswNJUaSe02cKd4L+XiqD8GLA3rHdErvbK3J/M1/uMn1MKguWPaf41p2?= =?us-ascii?Q?URZSnoNgq/hndxM4cK3LR4X0z5UBGrKm93MlQY8KpJwH3hEoJYym7P5IPJ6c?= =?us-ascii?Q?cw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 51638ac7-108b-4998-80fd-08dc7e44936f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 12:00:17.7390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gnM+BeQK5BzVFcFKHZhiuxJ28Ft+w05Wx9toNMlOl9rJKvaQmwjNcfBIUd1PNmqhBJ2FKbUgSq0xEOuq5n1tPEg1dH0ND/ozlucZfOQ6KOY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5218 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 20, 2024 at 02:33:35PM -0700, Tyler Retzlaff wrote: > MSVC does not have a __builtin_constant_p intrinsic so provide > __rte_constant(e) that expands false for MSVC and to the intrinsic for > GCC. > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/include/rte_common.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h > index 298a5c6..d520be6 100644 > --- a/lib/eal/include/rte_common.h > +++ b/lib/eal/include/rte_common.h > @@ -44,6 +44,12 @@ > #endif > #endif > > +#ifdef RTE_TOOLCHAIN_MSVC > +#define __rte_constant(e) 0 > +#else > +#define __rte_constant(e) __extension__(__builtin_constant_p(e)) > +#endif > + Acked-by: Bruce Richardson