DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	"Satha Koteswara Rao Kottidi" <skoteshwar@marvell.com>,
	Harman Kalra <hkalra@marvell.com>,
	Shijith Thotton <sthotton@marvell.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [EXTERNAL] Re: [PATCH v5] cnxk: disable building template files
Date: Tue, 28 May 2024 10:39:56 +0100	[thread overview]
Message-ID: <ZlWmbEYFH5B46dcp@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <PH0PR18MB408626260EE05E4143EADEC7DEF12@PH0PR18MB4086.namprd18.prod.outlook.com>

On Tue, May 28, 2024 at 09:23:12AM +0000, Pavan Nikhilesh Bhagavatula
wrote:
> > On Mon, May 27, 2024 at 09:04:29PM +0530, pbhagavatula@marvell.com
> > wrote:
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > Disable building template files when CNXK_DIS_TMPLT_FUNC is defined
> > > as a part of c_args.  This option can be used when reworking datapath
> > > or debugging issues to reduce Rx/Tx path compilation time.
> > >
> > > Example command: meson build -Dc_args='-DCNXK_DIS_TMPLT_FUNC'
> > > -Dexamples=all  --cross-file config/arm/arm64_cn10k_linux_gcc
> > >
> > Should this option be set in CI by default, or in test-meson-builds by
> > default? When do we need to avoid setting this flag, vs setting it?
> > 
> 
> Yes, we can set this option when testing builds to speed things up.  We
> would want to avoid setting the flag when we are packaging or generating
> release binaries as it will negatively affect fastpath performance.
> 
> I am not sure how to integrate to test-meson-builds as there is no target
> option for cn10k/cn9k.
>
So, are these template files already not built when building for other
platforms other than cn10k/cn9k? 

  reply	other threads:[~2024-05-28  9:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 18:51 [PATCH] " pbhagavatula
2024-04-05 20:25 ` [PATCH v2] " pbhagavatula
2024-04-05 21:47   ` [PATCH v3] " pbhagavatula
2024-05-22 19:21     ` [PATCH] " pbhagavatula
2024-05-27 15:34       ` [PATCH v5] " pbhagavatula
2024-05-27 15:46         ` Bruce Richardson
2024-05-28  9:23           ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-05-28  9:39             ` Bruce Richardson [this message]
2024-05-28 10:01               ` Pavan Nikhilesh Bhagavatula
2024-05-29  8:01                 ` Jerin Jacob
2024-05-29  9:00                   ` Bruce Richardson
2024-05-17  6:40 ` [PATCH] " Nithin Dabilpuram
2024-05-30 11:30 ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZlWmbEYFH5B46dcp@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=sthotton@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).