From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CD9144102; Wed, 29 May 2024 15:26:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BEA240696; Wed, 29 May 2024 15:26:14 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 34EF6402B9 for ; Wed, 29 May 2024 15:26:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716989173; x=1748525173; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Ue+xHiMKLjHM7XrYmLbdqvV3sr/fHTlMdMPaXX6PA/E=; b=fiW5yzHcnXfT2tqwoAf/BmrlR8i1sOM/U2WWcklkHowLtu7fYNGo1+dT kQUWh+Jyz7oj3yiVBHUA9bocRSrCYvQLjtCMrCqQr5VCyUggxx9RdUWe0 xTmqckz9emOlOhqTPJ60XAfP6A6JtIsNDcCzsW9+Hl2H8MU2vBR4sow5o LrfaI1YfMkn7LYjfcuC6QDq9PcJo8pZU06SlT8TeitXoda06bLFCTd8ui +oupGpZWsEGfng6fb5M/qFHfElZqwgTbwM2vWdIj6bWmkfW006r0l17Gs x54R0L+vR7Ci+IeReg/4uzZaZvO+g6kEu3IeISemOy4ycLxGqmk7lJtTe w==; X-CSE-ConnectionGUID: pXPp+x6nQ9qDjObA6+EEWg== X-CSE-MsgGUID: cm3BCBZNRYWYcH2lShxW8A== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="17222657" X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="17222657" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 06:26:12 -0700 X-CSE-ConnectionGUID: x2lP1pELSP+e0PilvDxUKA== X-CSE-MsgGUID: PAkxkc60QRaESXttDUXTww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="40329857" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 May 2024 06:26:12 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 06:26:11 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 06:26:10 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 29 May 2024 06:26:10 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 29 May 2024 06:26:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLZakLKE4WBgZKLhS7U46WUrYuiL3HXxOONbOR8UPnySVNaSEkg+2ODCFhK9ShVk8JJPATUt3V0nIzI9eltZB8/B6WFTQ5keOX7BIyv/IxwgsNM2R4qJv9GZSw0Gy/277N6tyet4yqFgD/sUEai42HOfERkZD/gzX/62lttyxIumN9iy32bGOVKaMAhLX7bI4YuUEly6lTbOo4MscGmU1LtHnHI+FWU9YK8vJ/bAiM+571hwyxzeBjRmsTE4i2Xwu7YOVdUTV3DSpsjjGTHalUweZWJ/qFtdtTADb4vOzi06Mu09FNoA/F0PKW3eqGnFkPpY6Oa5LaEgDXix+wzarA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9VHA9WfgNeIkE8TbO4hdJ7M9pdbxqBV7EY32OUqon6Y=; b=UNsieUx0o6QSbnIBljhDQjdTbSaT3YmmSFvS6wSxl5AHSvaBQNwl1Q0qj4ejLCyKs4i5o/l45BVJTCCs7ycZH4JjHKOUIiGvUowNNtxKukaMN/4gvOFXJRmsQcY0HUQyWO+XtrQabaHP7jrJHsIIeiVRrsZkXULMy3wcoTRbLEXKzbhn8IsURYm/tu8y/77L1R7o2o3ebRDD1MRFfAvTk8qNfcBEW30j2S9RPTy7qvKFgRtIOuDCWahkkSxDEjK6UbS03mHG9coP7qXTGNLfa4r2eEInssAHTSIiUxzLfkU2/BH1SLc8ADMpvzaQHBH87asvRC5rHz4I36pdQvF9Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB4802.namprd11.prod.outlook.com (2603:10b6:303:94::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.21; Wed, 29 May 2024 13:26:08 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7633.017; Wed, 29 May 2024 13:26:07 +0000 Date: Wed, 29 May 2024 14:26:02 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , Subject: Re: [PATCH 10/25] common/idpf: avoid variable 0-init Message-ID: References: <20240528073559.867121-1-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240528073559.867121-1-soumyadeep.hore@intel.com> X-ClientProxiedBy: DUZPR01CA0203.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB4802:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fc76078-234f-4821-2459-08dc7fe2e5f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4DoAKsQNC388Y8Ewo8AaCi5dhY0oA15rsiFlQ0pVE59IdWpAlUD0JhdX1esS?= =?us-ascii?Q?0Zh4+qrkwnCYtoz78skNNl1rwMCNDVeom8E39723+JcNiH+MrubaM2jr3Mad?= =?us-ascii?Q?tNutN9ulJtTgbvzLQAUSYmcAHY/aT5GlupJJ1hwuX8yOqmiRpNU30qs0K4Z/?= =?us-ascii?Q?EwH/SouqvxkvamWu3moRHbuxbRWBHJqYjTpqvQyfeOfUmvwL8dwhsV4oz4fd?= =?us-ascii?Q?QSvBf/spILleuVLoe2ELe1PVSUgIKzQq/KC6QJ0tbj/IWKgTHfAIpUYg+eZa?= =?us-ascii?Q?/SA69c6hEDuj2ihSN/jVv0llPqewAKNtKqXczUklZEOBABg4QosecC/k+Yq8?= =?us-ascii?Q?rEypu+W6Ka+TNtTh8+dSD4zzYHxh0OV6ph/N8aOpAVlBWcIXKtURon2uPAFh?= =?us-ascii?Q?+a61ZYXfvk9ZruZ09FuhT/4Z9kNxD3mYHXYc41GY5K/jKWqtctoEUTusVgsM?= =?us-ascii?Q?gJbhXcLvldop/zXIh+ly/Jh12rxaOFlB1Mgs0DL1pa7fefdyPL9rVNIdPlh5?= =?us-ascii?Q?yi6lrsSPujdjCC9jCvbIgkkYE9dDNVjG9USzrKqmB1sN9uhDAJ1ySJs+hWdk?= =?us-ascii?Q?YJkalxD9E2IjETuKZJNWvYacPc99O4HIKrRJ/Q6p2OBNJM5O07XN2Qm7dN2x?= =?us-ascii?Q?IDw7jGDWW8vqojXPL9fHymPsiNtalggIrh5I0XOtDpgOJzgld28aqOd943mf?= =?us-ascii?Q?zbeaqJroH1EgsltoyQOKX/sL2wUDVHwb5TJaJPu7OLgFRC26D6qmqRUs/vqM?= =?us-ascii?Q?rIVSCsjB4a3dxq6CHvlfmezwK3D9CcYjy9dUwYhIIQKPggFe4EjL6qHKOGUK?= =?us-ascii?Q?qg05q4vRtLDKzwek+FVnpM9SLWwBrsgXDCnlb2tUqzno9PQtrIoIms12+SVX?= =?us-ascii?Q?oovlIz6zZd0UU0ozTpMy3U0BLGxK4wI1oU8yBVwW1lzUAsAyY3qd+MKG/LRT?= =?us-ascii?Q?3RRdjFGA8RM2rmrTOqdQdkfzRv3tDZRUHY9ujidsCgq8I9zgCOmqYlzuthc9?= =?us-ascii?Q?3Cnme1mT2QpzEYxqcuUI0E38lQMdkiXk/Z5nx7FDSmH2wJKrxgSDoXPZDaED?= =?us-ascii?Q?eg865Y6gZWbgM0fSn4LZSoIMVassHmVHQ7Yp0aJYgqgWMxG3KgImoEFX8SRV?= =?us-ascii?Q?33tjZRFJC5Xk5RR+53OAXKpttkgo+geJuhqV5ggw9ea0i31q01AdQD4hO7pv?= =?us-ascii?Q?TEy1mb270mLT4RvW/5vi895YgqG1QuAlGVSGJ0bwTkejxhRs1KiYls7iis5b?= =?us-ascii?Q?+hgO0jE+wFW0Zc3cDMctczp6gqQLJQ14WnUYRnTMxA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7ETH/QzjU9SkxggdfcZ6AgtbHH7qLWwByzfHfORQRyVbFE3CcjsVDXjqsyaw?= =?us-ascii?Q?fsb7TNsH3krnyfJcaOoTwO0+pUgOq9bCyVYAfyVe/v85C2m3d0E5C/24w3kJ?= =?us-ascii?Q?GUSJaRIPfNQhZh1RMJGdiGC81lBrg0ocTLNhYMjv2+B3Sqs5sXj9DPPVQ9gr?= =?us-ascii?Q?S+mCG2NhXX1BnJFoPC5o/7vXrHi7I33p1+QOaqkRs6n8G5gdpNnrGCLRJao2?= =?us-ascii?Q?E0IobJQZJ3CY6uG0lCiowK59b4eRUF4NvAcNHnR2VA/4c8OLQsinf9VGGVYb?= =?us-ascii?Q?1r4YB+Ta2kZYojEacEXAyON24gYe27QIz0g+ewHtVdk/UuweB5c3aouXUlbY?= =?us-ascii?Q?YHv+ZXhQq9pePMFY54ifUAZ2aFUOgKfd/+W8opUmrci0JxByOSS3bc4ZdXAI?= =?us-ascii?Q?xY6MqXEMpww4y/3BImmBYvBLwuRgnLQZE/4UaeHPuuL/xuk5PENKNd59Ki8W?= =?us-ascii?Q?dH1M4t+5r2jS2qDzzihn0ft99bgDodpiy7IacMzNVCtjsZVwkfwUomXZ7yik?= =?us-ascii?Q?NBS2d6eUrpKTG9+ef84qIpe/OAqAV8Tevbdw0vdNo1+zqAK8mQRhme2uM+w9?= =?us-ascii?Q?ycTc4fdHwwMQHp7YpwIVQWH/RqDa8Fn6wqMZmZpDecxOv76Xyx0oe8Hv+E6A?= =?us-ascii?Q?MfzpCndz62VDt64VY/PyzxME9z9Oso1+2vxVWOotyeo/xhfAAPZfwWkbjyHK?= =?us-ascii?Q?4punZOWbeHlwwN62TM9IOikV/8Dvbs5uwglsN7IFJcUXOCIPeYGE3QDp34z2?= =?us-ascii?Q?S/S69aOFf6CpPp7eKmzjgaOyEJNDeMY4NqQnRnod1vlp5/IrX4hjtEvgDBY4?= =?us-ascii?Q?bziruplgaUr+eKFQWi0Ze2flE2ElwgLppLqwqwFKORH5uPCjl6ikvn9+bxIm?= =?us-ascii?Q?fJ5NUMDnPJBdCo53qHAMeuZfVrZ8Sork2FGmS0zqlYUvaMyXyYkEM3sn2dkq?= =?us-ascii?Q?lcsNPNyC6fgkP1V3DvsWj8J+IsmeHXQqv9HiV8fgerjyXrZBbT/9OHrO3QZF?= =?us-ascii?Q?R31yJFi8KQpvIqowcsLYGASHpKLLjTWrP84EXTthQfmrRA9LBvfDwmHd+YzX?= =?us-ascii?Q?R+7zkmQGSdqmpi2RAj6Z9x3Q/UV3jpm5warT9LD3nQnEgh7HQF/cpvz3llVj?= =?us-ascii?Q?h580fsoPN2M7/bmKNwe0BZ9ngZ/SZ5fvfk+vv8Yn+Ff015KvKWCF3+wOeGO5?= =?us-ascii?Q?3KYvHn4k5JpDeOBYv2P4KwFfyTOgxi4lk6BV5iac7blfkCROBD2x5Fw/V0J0?= =?us-ascii?Q?0rQsH7Cb27+YSlvGh3yPFvD533K+VLa8QezCwwA2azAVRsrAWF6V6j8jTEEw?= =?us-ascii?Q?ba32NqgeWAP3ysLM2Smh0Sr6y+PDGLhA24+sId0HvBmfNUzy5TMcO7/4elYr?= =?us-ascii?Q?H9EyLMcGiMAE0g8kJxzKVRM5jwJLXF2gQjp/+cbWozeq3gE0M1Wy35xfGLKU?= =?us-ascii?Q?1Xq4PFPSx0RwFJfz3BHnb/35+AnRQjxCxpgpWQEaurxy2+ZeyqZ3cruPpqpl?= =?us-ascii?Q?+dNxEaVBo7zDimzOFrAdt6TJFBKIjbYxEAcLA+ULyZXRxJmPHTVsaEBdZEUn?= =?us-ascii?Q?do6QYPOy3H0fKG679jCnffXUoX3qpXV2pmVKJevYFsni1XmxK6XKmzdGkP2I?= =?us-ascii?Q?+Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc76078-234f-4821-2459-08dc7fe2e5f2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 13:26:07.8283 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bfDLeyNI2doGmymrIuNA7No6Hrys71rRhA7t/menITG/6bGOduGuW80NjRR5tEuzCQj7joIjAiEVUfxjv9pNU/A0+iKBxYOfV/p/Ce5OFko= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4802 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 28, 2024 at 07:35:50AM +0000, Soumyadeep Hore wrote: > Dont initialize the variables if not needed. > > Also use 'err' instead of 'status', 'ret_code', 'ret' etc. > for consistency and change the return label 'sq_send_command_out' > to 'err_unlock'. This is consistency of naming within the driver or file, right? If so, please clarify in commit message. Also, this patch does not appear to be properly threaded. When sending new revisions, I'd recommend sending them all in one batch using "git send-email", so that all patches are in reply to the cover letter. [And when sending v2, v3, don't forget in-reply-to to thread them all off the v1 cover letter, thanks!] /Bruce > > Signed-off-by: Soumyadeep Hore > --- > drivers/common/idpf/base/idpf_controlq.c | 60 +++++++++---------- > .../common/idpf/base/idpf_controlq_setup.c | 16 ++--- > 2 files changed, 37 insertions(+), 39 deletions(-) >