From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE5BE44102; Wed, 29 May 2024 15:35:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAE7F4069D; Wed, 29 May 2024 15:35:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 988F5402B9; Wed, 29 May 2024 15:35:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716989750; x=1748525750; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=GSJhAYO2mTYQ7yCSO5qqpE5l2VTddUTusp1dZsSxw6E=; b=awcamz3zM815uyoynFlVj9LLnk9UlNacJmU6TglDI5KrzJ3wwBcLXsNI sJEVvtiCjBHvMnhPEPy9OK3EG0OUSPCR+pOe89Qf5M6a0we9LxrCGUbyU PAZ9epJmO+pJ8F7aL1dP8W6C+KlUmievY8KrXx6bWB/ZZlKxXBRhuo02o f8ugS/acm5IVa402dWOkfOtGLZ6gKLBkVOTKLT/EALPZTX5hIX6/2ratI iCCt/uhOa48cfW9vfOXtkfahWYj5Ws/F8wFHQWU7cDBvMOaoNYGdP1p4c Ili7nlx5zEoY/f5slb3+wnK1JGxh7axkR/fYpKHeBxLh2/OeT/4oyRE6z Q==; X-CSE-ConnectionGUID: eSFg7HlNQ4ujXJuVV1EZmQ== X-CSE-MsgGUID: JuVh0aNAQxWnztCBoiXa5Q== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="17225770" X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="17225770" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 06:35:49 -0700 X-CSE-ConnectionGUID: UMtSSKfYSj+lZyfb18tBkg== X-CSE-MsgGUID: 8xGr7C3HQE6OKMH+p0Z7Fg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="35390832" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 May 2024 06:35:49 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 06:35:48 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 29 May 2024 06:35:48 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 29 May 2024 06:35:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZcdRbAuh4dYm9hrWYdORuzLQDB0hHI9pD8xS+eWL6m3yeFQu2dOn906uHAja94z6B53Ia56M5l9aNSSNM6pwAcRM6yTBO0Htf10kaBI3Ai2K5Jz21EAtmqwxMCSN1u8MlX2eDRjFHcIGIyP9yFsLusne2HB4n54Kyy0ssJ0yKcZjBxcMhmxTfG/eMCPeWzh/lYmGRMooS/wx99WbZWQ//MmZ8maCdV+MZTUIRPPm2R7S+Gf+7UhJ7hHbKYL7nf5oB+uXJY+WfxBgM3dDTjyMhILzRFrRvEF3dyvPijELDna7OwgehfoZAqJpU0T9b4/3qqxgnEEB8ZeK3jcuR8+aHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZrpH+e/olz66syqfSWW6ue2TeQKPg11pSVz8xIk7W5U=; b=MZVJg6koL7xjyzaX+SlqR560y4OtfTb9flbYj6G/l5hb32NSkNdPLRIsVuDOIRkVns8ly2r5oYDPjDe8mQVZrYGKsqBgmAOqYwbu7AbbvQkxiQyO8dhuGNXtzGp9WFHP4P61THO2+2UtkL768YvBVesp6rad6YyDCLFD05PVEH8ggsIXb0XjUBL79uJ+vhh3NQTrB0CMVM+DZfFrIxGtVzp8cAyWeKLbzPnWbx527E2jwpLeMeam9Eyhh/lQWelFHaLQrvRqNQdXe3mUL2yeOB3gekbO87Z2nE0Ni9RNX1VvtShGbZFFGhBQSL/z204Yg4lC/A/RxeyYcsxCCnAn8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7361.namprd11.prod.outlook.com (2603:10b6:930:84::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Wed, 29 May 2024 13:35:46 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7633.017; Wed, 29 May 2024 13:35:46 +0000 Date: Wed, 29 May 2024 14:35:42 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Sasha Neftin , Jeff Kirsher , Guinan Sun , Wei Zhao , Subject: Re: [PATCH v1 1/1] net/e1000/base: fix link power down Message-ID: References: <5362cee0c903d9769ec38f34ee71d4a061727eee.1715699832.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DUZPR01CA0291.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7361:EE_ X-MS-Office365-Filtering-Correlation-Id: 55cdab95-0891-41e9-a2cb-08dc7fe43ec3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xWu7gGqaq2Nsa5ThV3eTdTjZyY0vykxy1j/VhFVjHtB1PopEPnmVRW5Yv++r?= =?us-ascii?Q?HbUhiWqOtIKYJXDuDfPlsHk1V+BS+ew/y4HzRaYcpUtzgCOYTPMkOk1J3KH0?= =?us-ascii?Q?nV2f5HsRdh81G76Hgp1KD9hy4jhYi9kwstk/7Kxxu6P/CgwQdrBCKr9LyC4l?= =?us-ascii?Q?HeHS0RjMZKI14th6ALoEXvky1zCXucjsNYA49ARYoRmt1Ht0rgyMcaWkj40P?= =?us-ascii?Q?yeTjQ2Pq2sPwnKKXPjenPvKRurYMVi9Hk6pc6LUI2IkfXA9QtPoSnmUYR4WE?= =?us-ascii?Q?dH0splqAKt+URmBmZ9Gk6/2sBkCX596ssheDmZTptd7WngCfcRPV8BhgrAeG?= =?us-ascii?Q?RhvfpG/QjkxdofoOJwSwBtyFq2FEDdfqPNvleaMeoBRKS9AkGs/qsl1kXskl?= =?us-ascii?Q?t1V9hhhuohpaJk+JJ0Gakddi7dq+l+TcrxdInFHdvpfkkoR7g/iEeDBZDuIO?= =?us-ascii?Q?W5o4Isw3kIQswZnNiKVwDCTMB3eqPqZuoMgFRjcI9DDV2zuS9vsDYs+vlMi9?= =?us-ascii?Q?9Fz083nT3U6AeUrVKWKQeyU5j7QXusJElNiOotbuaIqeyIfM6+g5Gq4ixBdT?= =?us-ascii?Q?32DP+ns9ybxHPAUTWoN5rS/6TCrsbNVTtlxMLkaFa76V8+CGkZE7J6KKVLUl?= =?us-ascii?Q?JhCbAD3hQNMN9V9s9wdSDaK17RuyEDVwH8FJFDJzAL3lnCd0vcSBPASl1F0W?= =?us-ascii?Q?sRPJ3YKpPHlayH+WkY60IHcODXyoLb9UQEB6aAZbK+l3k61mpAtzZ87xHX1N?= =?us-ascii?Q?EPMSmQCx93rHiUlSj2RaeAYbSlQu19/N88YMLhasiMt5AVjAmYixi3YLGcYm?= =?us-ascii?Q?0ehJozTtNRLQ8PubDN16sRWnhYFYMd49PlAHlzBnEjOE6rarWviwAoB2iPWf?= =?us-ascii?Q?Uk0g8x+Z8Ho8/AkrO6JJ922g4SSj7OnAMhcUrwJnZCXrKDIdxyGDabe+QY5X?= =?us-ascii?Q?BqzZNeoYrFEA4TIThk9215n50BIEluJdOfJll4BheOmbxagnBfbAiRwNmlvo?= =?us-ascii?Q?6wzeb80FVj8apY3JQIz6QlTGQabJ8WMOjR+n6FqBrxKWJCm6TkveRGeY9RE4?= =?us-ascii?Q?/yfagmceWozHVGGbkmEmNWLPpu7vOhP/lUSnE9iG4i0yah3AGQl9N589l1hV?= =?us-ascii?Q?0haG/ST4aF38yqC6rXk74bCwE5uH7Wq16VkWjszJvi8vfxdLrB5OQUDNRqL6?= =?us-ascii?Q?+aO18NepDTiyM7Sw0b9L0H1uOcBggIA76TwA4ACaE6qr67FHczOjCMz7k4NC?= =?us-ascii?Q?Eugbfk9gODRbllbbTQ6YMC2vfUetJrWlmSwIlwIjQg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D7+8SmAYc3dmDbpTwMOW4ClqRehNTROHISAgbgOR69qNawL0egLgTnrdUXJA?= =?us-ascii?Q?aI4KkHATRUhMHDuiXUsUOWWtvhxXAkyhISaUsEnS3mTYlrAl4PSLygA05w3g?= =?us-ascii?Q?VJs6GG1Qirms5UBgH5PpdsYFjTcAg0o7M+m+rSSwOPC+SB4F73Yk2NhrEPKC?= =?us-ascii?Q?3LKxlQH7OGMGJAtwZ/kayZ6vOBQGIotShcLFbzAdIX0tCFb3co+SdA1YVOXz?= =?us-ascii?Q?IzhiyYJ33/7UQuHUBn1WRipYLMMkcEooan8o6K/+qnH+JFJPIZYbSQ+3vJTu?= =?us-ascii?Q?pIv94e1AWK3w0RCUzFvAXB5t12DTfPfNulLN/LNawmK3i9A2f1xlgj45OJaz?= =?us-ascii?Q?eMC+mL8d3CZwcFdt47YUwazHV/24q8YbdBxftnsdnZHIvqVsW9TFCkK48e5q?= =?us-ascii?Q?vrsOexFrlwimeoD490HyMEMEtEo1Ho/PJOMXApkkscq2ByGQAyEAOwayHNKD?= =?us-ascii?Q?YOgyW6NTtCHxKfoSfgFPppZ8b5TrAQNWJDmRQFPwjanFlfj31XcYA+lf5Chw?= =?us-ascii?Q?rC6yc7Mcc0uwCHcZFCTaW/6ipBUuXQm3WHjrgfE+wrxHUgJx+nkcoKSDmdqo?= =?us-ascii?Q?3ld0TeV30h2QcYLFnwWb3BUyouYPiwJssLOvgSZ0ahTIXeN0OZUn1dKM8XeM?= =?us-ascii?Q?hh1zbroaeYu1iYrp1TCAxmlvx63gbpCxpA2fu5DOV7x0yIrQVFG+MotawXK7?= =?us-ascii?Q?cd+jkCKwCA1mzykU7xi8TBasxXNg8Kptj8QTkCADyXPU5uc3IJksJz07fdh+?= =?us-ascii?Q?N1hr34jclD2uuQ3fJD3tGCj8g2FhIk7FEUDoJNoE1jj4cOV1JPHJFkWacY9u?= =?us-ascii?Q?L2lv8TJ4LqlOa6wx8geGXdnOZtchyeqb6Weu6ZJYkcwTkwEjmdnH7EE3z4wO?= =?us-ascii?Q?DCbP02XdD134inn4FGGMxikPjThlXHJXfjgA0kIzOn1pMIFwL9xzs+xa4zmI?= =?us-ascii?Q?Rcq7DZS3F3jX+qXtCzApIB4VvN3BY3uOdECQLznb7YKhzvFKV4TZ1FLRY+Eb?= =?us-ascii?Q?GyrbbU3K8n+OpXUvW4v0E/ShpnAmVmpiIS9JGdb0gyxAy/4PdXWLaEXErQFs?= =?us-ascii?Q?MxXJLERHLVBoc8qt++cCTrpPWz3i+Q1UnutUjkNKIQYptLKNBtLLGHgKkGPN?= =?us-ascii?Q?dsish4M/ne86ava4p7ZCnx3Sw5ByyPYYYO+RI7f3ich/+s5sYB2AmTqr0ys0?= =?us-ascii?Q?vwT8GiM0kHsWdxnmS2pyOeJe4TGIBVDGrlwUexH6dpGqgUbWEuIi+ObPdYdS?= =?us-ascii?Q?ZhVqZuN5x6tt8fL6sBhcjF5LFwd4CrQI5j3bSDH/wtrXR1qSQ4Bq6PlUGjZs?= =?us-ascii?Q?/tKe2A52POhDKjmEHt5CZgNuK+JtVA5W7lAQPelGsq2OMHKo1sxXi0+/2Iz9?= =?us-ascii?Q?VESJnlijFhaNgi3i16OPw/iNe9OLjzVBX0wmj3KuLHFvhU/DHfpEbBDek5rJ?= =?us-ascii?Q?cp1vrJfgv5VSfx+ztzaaF8iSR5l2l+14gowefEZCIhUE/v00rRY3tDyoTJsC?= =?us-ascii?Q?vqfaZ2v/r7lj+dQ8b3sHkhkrE5Ee2lXcwQ5IigH/9dk2D58vxf5Qlg6goGd1?= =?us-ascii?Q?xH5zTSSCp5Uzrcz2T2RJOya59G9B81PId1+3v5GS3qxVrRI31pIZgCr23XGJ?= =?us-ascii?Q?Ww=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 55cdab95-0891-41e9-a2cb-08dc7fe43ec3 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 13:35:46.3797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YzxltYK2vIhzCNOfEkdZ7YvCZuq0a+1vQ+E5td1YNWfJBMoEVCptm9ESb27vnkEthNVBtBrRlNv/j7F99O9wdo2m2xy9WvkTl07sJr2OyR4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7361 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 29, 2024 at 02:34:16PM +0100, Bruce Richardson wrote: > On Tue, May 14, 2024 at 04:17:16PM +0100, Anatoly Burakov wrote: > > Current code is a result of work to reduce duplication between various > > device models. However, the logic that was replaced did not exactly > > match the new logic, and as a result the link power down was not > > working correctly for some NICs, and the link remained up even when > > the interface is down. > > > > Fix it to correctly power down the link under all circumstances that > > were supported by old logic. > > > > Fixes: 44dddd14059f ("net/e1000/base: remove duplicated codes") > > Cc: guinanx.sun@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Anatoly Burakov > > Acked-by: Bruce Richardson Applied to dpdk-next-net-intel Thanks, /Bruce