DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Wenwu Ma <wenwux.ma@intel.com>
Cc: <dev@dpdk.org>, <songx.jiale@intel.com>
Subject: Re: [PATCH] dma/idxd: fix failure to configure a device instance for DSA
Date: Fri, 28 Jun 2024 10:27:47 +0100	[thread overview]
Message-ID: <Zn6CE66iVqEYj2YJ@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20240628053458.78337-1-wenwux.ma@intel.com>

On Fri, Jun 28, 2024 at 01:34:58PM +0800, Wenwu Ma wrote:
> In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs,
> DPDK needs to write a correct value to this file when configuring a device
> instance using the dpdk_idxd_cfg.py script, otherwise it will fail to be
> configured, this patch fixes the issue.
> 
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> ---

One comment inline below. With that addressed:

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

>  drivers/dma/idxd/dpdk_idxd_cfg.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/idxd/dpdk_idxd_cfg.py b/drivers/dma/idxd/dpdk_idxd_cfg.py
> index c0c833ade9..9ca4c4d76c 100755
> --- a/drivers/dma/idxd/dpdk_idxd_cfg.py
> +++ b/drivers/dma/idxd/dpdk_idxd_cfg.py
> @@ -104,8 +104,10 @@ def configure_dsa(dsa_id, args):
>                   "priority": 1,
>                   "max_batch_size": 1024,
>                   "size": int(max_work_queues_size / nb_queues)}
> -        wqcfg.update(parse_wq_opts(args.wq_option))
>          wq_dir = SysfsDir(os.path.join(dsa_dir.path, f"wq{dsa_id}.{q}"))
> +        if os.path.exists(SysfsDir(os.path.join(wq_dir.path, f"driver_name")).path):

I think this be simplified to remove the extra SysfsDir call as:
	if os.path.exists(os.path.join(wq_dir.path,"driver_name")):

> +            wqcfg.update({"driver_name": "user"})
> +        wqcfg.update(parse_wq_opts(args.wq_option))
>          wq_dir.write_values(wqcfg)
>  
>      # enable device and then queues
> -- 
> 2.25.1
> 

  reply	other threads:[~2024-06-28  9:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28  5:34 Wenwu Ma
2024-06-28  9:27 ` Bruce Richardson [this message]
2024-06-28 10:08   ` Ma, WenwuX
2024-06-28  9:54 ` [PATCH v2] " Wenwu Ma
2024-06-28 10:25   ` Bruce Richardson
2024-07-09 10:18     ` David Marchand
2024-07-09 10:22       ` Bruce Richardson
2024-07-09 11:14     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zn6CE66iVqEYj2YJ@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=songx.jiale@intel.com \
    --cc=wenwux.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).