From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAB6445484; Mon, 17 Jun 2024 16:52:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99D8F402AB; Mon, 17 Jun 2024 16:52:40 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 2545A4028A; Mon, 17 Jun 2024 16:52:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718635959; x=1750171959; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=EGtXaaNft4GFoudaQRx+lOR0xXSrPIs08NBTgpzDwE8=; b=cb4iKOYHbygW7ZpgqEg1vn4yHIri08rGJeXCYxoei+mkLrzmBp4YKgRX z5lqLe4DbXMnLTJbK//HMplcXLYa133PnBnhJsCo9Mvpe6gsBEn0w0F2a K7waHTs3n4R37XXKxAK0i0swjGasv+/JjMFJCeyr902rVQEoGQCoPBatg tgIUCfRovx0hQZcgRGILs5yqYkyKFGXXvw1Sx1UeT/8I2WoTahB3Iv3gv NYN9U+9h1qU3cvL8sDqfruVOBYArMxBx/8LqEK5JCyGm0YY+C/DQTdH/x yOWiptdsZzgiD1ImqddF+GMB+2PI7CZnJPKErxcE3LDNljFMY9E0YNm8b Q==; X-CSE-ConnectionGUID: W1nixjxFSfq7BdhjndOgqQ== X-CSE-MsgGUID: 67hNHa15SFqbxDdOxDiaDw== X-IronPort-AV: E=McAfee;i="6700,10204,11106"; a="15589792" X-IronPort-AV: E=Sophos;i="6.08,244,1712646000"; d="scan'208";a="15589792" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2024 07:52:37 -0700 X-CSE-ConnectionGUID: OgAo82E8RRCbitoZwXfoyw== X-CSE-MsgGUID: RdiaCQtDRCKbIrmYpZ3Y+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,244,1712646000"; d="scan'208";a="45653194" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Jun 2024 07:52:37 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Jun 2024 07:52:36 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Jun 2024 07:52:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 17 Jun 2024 07:52:36 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 17 Jun 2024 07:52:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a6qWvAPqB2KLABqhcGda8+IdaHnHJmuehgRWADE1KefLe3/8k4vfvOVs0ALq5hVVnQWSrr9xKwD8XXwhfloLxKyoEV1mkWGA4ZA5vbIPVmkkpjWksrX+DkwMubdueFTUxGxKUBA4Mg0xuRSRu6kLnCCXPC00DV4vczeDBHsr+3glK5aL2ui4Ip/cLufrIAvI9f3eqW41wr0WE3u3zpdDPKlBgk0KmC1LMPD/WxLVMDEQplUBlykt0N7gudV4e59TzZ9FivYKf/ZBtTOa9rLRGM6+BhJn/PEGjeaisYZuxzeFuMyo3x2lzQmrJNdSx5+amgXdtENQLWiLLInlwyCZaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TYzsVdktAvOjH7A4FjsmO9nZjxvAJQi6tNpG3P+hoL0=; b=NsD3fJxA3c9ysJPC+8C1IAqAAtzUG10HQAj5GRDnnd6+6r66BwRPhyMjm8+3QQuy0wPCW8E8Wh/pu2oyT9KM+rYjoFCsBDT91lnOezmVJew4o/U7NwPlleI4ZMKQy7NMeBEoBRjpCmkzM6Jfj1hJnqp7eKV40++sxZqCycw5vRPW6gaF9ZW4xgLRyu5JWqSmRMAzEPdQgglW8RrqTwKnbtJyt4PaWCMqOKUh6Rg1J/A73ACaOESpxon/NTjR4aPIc8s1nJLgs04rRMY8k6x14vZqctjfRZ4j0KPs+vlQ9q8t0v/sOfvPkUFRFfXxv/TkYG1qHhzsZluWlNPomq03vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB8064.namprd11.prod.outlook.com (2603:10b6:510:253::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.27; Mon, 17 Jun 2024 14:52:34 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7677.030; Mon, 17 Jun 2024 14:52:33 +0000 Date: Mon, 17 Jun 2024 15:52:09 +0100 From: Bruce Richardson To: Stephen Hemminger CC: David Marchand , , , Chengwen Feng , Shaowei Sun <1819846787@qq.com> Subject: Re: [PATCH] telemetry: lower log level on socket error Message-ID: References: <20240606122654.2889214-1-david.marchand@redhat.com> <20240617073943.16cc7f66@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240617073943.16cc7f66@hermes.local> X-ClientProxiedBy: DU2PR04CA0207.eurprd04.prod.outlook.com (2603:10a6:10:28d::32) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB8064:EE_ X-MS-Office365-Filtering-Correlation-Id: f591ec6d-b013-4948-c377-08dc8edd1316 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PdMNjdA0ksYsC9bhr2chJen1+QjwPNMtRCDAYD817Ifv2Rl+/71B2HbQuolw?= =?us-ascii?Q?IzXmpXVtXD9cr6wSMaTSyfF+D209unzstQCBUq2/cC73mB+LJ2AEwL8tK2Fm?= =?us-ascii?Q?6mnzObsIellwT2Eil7N0OE4NkjptaE3iR/XKNQ+Hsg/ktjajI/LAdUzg5Y0L?= =?us-ascii?Q?CnjN33pqKdUhIYmptwrx3iGgadoUWARyhkGPLpD/W9TTfYpCAJ8uh15wZhE5?= =?us-ascii?Q?1N7LbakYE5OIATuRUqqbhcjB7H7LrIBGa4y3CFtvlEgkGuaZmES5gJoRWD8/?= =?us-ascii?Q?2b/880aypGNYmae6FVmAWx/9SU5z9UhwItLTZL9HHrwNx6FX6G1sH47Nazak?= =?us-ascii?Q?bjoTWa/rnFPYYbtrOo5n3KWVryUtfov20byXgu90NgD9XvSTUcvehMxqJ59j?= =?us-ascii?Q?1k5si1cLcw1fMA8UlIGLVugoIVJoqU14Exvlu9dPO3QSa5p5EmDBMFoi8whG?= =?us-ascii?Q?Z16rC4rGQ43Jsr8DiwuSwHKbNDT+Qi+gatKTcyofMtJ9OKB3Sqbu2zPm86Ff?= =?us-ascii?Q?vC/bPuiTA9EYegZs7u3IRr7wWBN+TdyfuVDJFxIWUTH46f9Q3VC+JHWLLi3b?= =?us-ascii?Q?hVMIG5zGcbqi8iBsWk/Yw1jkuy5O6YKxEKPRiLGYxMVoiuVNO4Cw0ZllH890?= =?us-ascii?Q?PX1bMOKeFLITWwWqkmoptQHZ+ZSP/A9VQJ2TTn7X5FRW7K8cpHYspZaiyZrr?= =?us-ascii?Q?rUwbLG4eU8d52RJBGnC7enCdQIlyAFXFn7Ta9dPd0UQBle8b9mPQDvhCblBM?= =?us-ascii?Q?TgxIuFeykgV3jYH5ltj9jRL6zf2+lj5yjQ2ramo8BQNf1oIHdzrgqt4F7rEh?= =?us-ascii?Q?tkZp5CY3Ibq2mGIttuNl6OGHNCoO1TECpvvOFbenMaCqM4aqUIyAFA1waSk+?= =?us-ascii?Q?4n7mOygEjeULTc7w8r75DSHFVOkfxT1T/Qa2p3SPbi4sEsYQ5qAxZW5r4OKA?= =?us-ascii?Q?alE+9w0+qQfoPwz8ut7iG5vHg41squutSI5x+6YM0iqTjPTAQizDCOO0lnq1?= =?us-ascii?Q?vw5kEt/TT5xZmnLwWRatOPrMYCmdachKEbCT6zAqsCBtdSrzEuUI79yA+/fv?= =?us-ascii?Q?VOSlTF1CuE2fU7X5EQQR8Rrc2N+aCqXU1Ach6wL9kTlJp3g9LQlDiUMNUFVt?= =?us-ascii?Q?w71C9imppzFu+SJgdiVQHCtjDeutXn9CuWeIOxQUJzhvlodMObjhSg//OtZA?= =?us-ascii?Q?DkY1kMh/I9HV00kbp+pfZ5a6w00PjK3DVmm8MY5mfQsMrj+o5rVpJvceutT7?= =?us-ascii?Q?wBtVQw3XfEWUGxgCggsGo5jnLBORmKh8MZUBG8k7yGlp2o5CXM8OlxqBT5vR?= =?us-ascii?Q?KGmZFQ+TbNrbsU3NaxBiv4HJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OUMwSHMfJF9azf9uJHCCn1VLoVT8i6ryh1814jHi3gF39E3N+k/EH4bBlttZ?= =?us-ascii?Q?z0bpDavCkhXFBACaTGxeDz5reNX8/rSMtV8pZEIaNn0tMHE6YbjTQXfKe/xy?= =?us-ascii?Q?vf8te9E5TwuBgXNRihn/tkRuvOzewBelR2IRt+2/zkHWDOq2OfrXqYo4Je6S?= =?us-ascii?Q?0bQp+jBJQL/+luPHDehaNhi5PMSElG7dJQCHSE3nITXWNGvCpOIMZMJHAQol?= =?us-ascii?Q?FdtvC+IRAH+SwnDNPCpyl1tgRsPIeFv+jSwLbmDVgF8DpkkhjjoDd6SsqwWC?= =?us-ascii?Q?AIWWQWD00WIp0ALanHKkX3X3UY9DfQAs4dyGm9WhGEJaUT+qHZxx5XK/IgOv?= =?us-ascii?Q?9Qwb+9XjKB2Wa59IPc0s6BnLG3NibYx4QYSopFGZp0RhPAcLiIpgGBDq4pc9?= =?us-ascii?Q?TbxOoeK+MrwgnQHDFkWsUzw9x3zKQumihrK0GeYcrI2JHdCC/4qFWLfFKn1+?= =?us-ascii?Q?8KbACIXEzlceGSR4TUL8w0W67KUV1D+TTt0++TTjcZxwK7RPk+L/+yhlH4KE?= =?us-ascii?Q?4E2uiYQxpEF1h9aXio0y/3aDAW6W4yRp4wKPbrv0rQW4kRosg6Te/gzAmHMV?= =?us-ascii?Q?cWwElXMA5wmkdikuDIKd0TIMLuNbGn2g1RGajewjhEGeO3wgpPTq/n3NHFLR?= =?us-ascii?Q?X6B7tVnlrh48RjgiKclSyrzCp30uCxxDk/ruAXgmqMVn/k9jCLbCu0yRtSxi?= =?us-ascii?Q?jkqWdSRiJtxOrlDQm3cRy5E6llvc0jIQhmMA/b/yw0yEheGeNPf1Byj1t1pw?= =?us-ascii?Q?zj8cvRzxCvF8/D6OMX1+8bT+lHgO3pAXvePiLH02xZ2U8If7h54rJnOHMHNi?= =?us-ascii?Q?7DUoZGNIdXg2f9ZSlJdaOF0OpJv1bVP8IAjsxVAonJVfWoh5LUAtyED/STzD?= =?us-ascii?Q?O+PUMPVm8PlovTPEh2YCQ5GMcwC/8K8rGTGbZwR2lhg2GuQWE/8LrEAx1JzF?= =?us-ascii?Q?Dd7tPdmpWqFXC5OQ5YFASvlHwuIRd0b3wBA3oU8x1j7pFBGcccAn5Pgg9O6V?= =?us-ascii?Q?TW5cv6v4moNzzX28+YwXlN0jVs2ocgyJzYVTRlOC78cUdd8IORJ6yPMTkhMF?= =?us-ascii?Q?m/+acu9Fa3qlbqWUfdZNB1/eq2qPRQ5aVdmJMgRhOdaX8C54C5IYmUh0Lfpo?= =?us-ascii?Q?sKLxrw4og/WnjwCGpgdIS8GdRH6W56OB2ztwFC9boN7yGvfZbxQDpadw5T4/?= =?us-ascii?Q?1UCCTOozRhgmlUcZqNjfEqBe5doG0J23INdiWz+RfopYsxwHixpqCnC2ItiI?= =?us-ascii?Q?k9aUolq6IYL67QvuD6GP2xmy02ZPMDAzbo5iVee0CIViUk03si2hjCQKoek+?= =?us-ascii?Q?ODporPMyNO8KHrNTmkHmwOWnQoT/Ssk6MTKlDU6XPnoFkAdcoxMEotyIHkz2?= =?us-ascii?Q?SG6nBIuV8eSVW6AUukwsl7YozP0vigZYo9SMipKUCO6YKq96yvttfXB97254?= =?us-ascii?Q?f0YOoMGzdX4sW7+Gn7yjOvTMZpiYH8y5nw5ZBN6Jmeku5btFZV7Ub8PfjquU?= =?us-ascii?Q?XSaiqKbupeApamlq2RfLkaOcq2PtPELF1YoF+0NnOOcy2cjQcHqSF7Og5lEG?= =?us-ascii?Q?E+/+Iz27yLSe0qIY3/F0IeupN1o6wyyxdfcEDPQNhIEm5kSjRkIndmFokhlj?= =?us-ascii?Q?dw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f591ec6d-b013-4948-c377-08dc8edd1316 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2024 14:52:33.2851 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fTpOXOxRGh4vqvYXS0IMXtTn+9vHbVzYeuyohqycxYHIvNS1w7LhbnO9jtpQ5k1J/qpA6tolCbMGN0Ck3mEMWd10nPCp50421vqB4WY/tEc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8064 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 17, 2024 at 07:39:43AM -0700, Stephen Hemminger wrote: > On Mon, 17 Jun 2024 15:28:17 +0100 > Bruce Richardson wrote: > > > On Thu, Jun 06, 2024 at 02:26:54PM +0200, David Marchand wrote: > > > When starting two DPDK programs using the same DPDK prefix (like for > > > example OVS and testpmd, both running as primary processes in > > > --in-memory mode), the first DPDK process of the two spews some error > > > log when the second starts: > > > > > > TELEMETRY: Socket write base info to client failed > > > > > > This is because telemetry init involves trying to connect on existing > > > sockets to check if it can take over an existing socket file. > > > > > > On the other hand, this error log provides no helpful information. > > > Lower this log to debug level. > > > > > > Fixes: e14bb5f10509 ("telemetry: fix connected clients count") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: David Marchand > > > > Acked-by: Bruce Richardson > > > > Would it be also worthwhile having the probing process wait a small amount > > of time or check for an input string before closing the socket? That should > > avoid the error message being necessary at all for the case described. > > If telemetry used abstract socket path instead this would not be a problem. > Using regular paths leads to races and problems with restart. > And all the stat and runtime check logic could go away. Are abstract paths not linux-specific? Also, would using abstract paths not mean that we need to implement some form of authentication on the connections? Right now, using real paths in the DPDK runtime directory, a regular user cannot connect to the telemetry of a process running as another user or as root. /Bruce