From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B50254548D; Tue, 18 Jun 2024 14:12:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44D8940E32; Tue, 18 Jun 2024 14:12:26 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 740A740DF6 for ; Tue, 18 Jun 2024 14:12:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718712745; x=1750248745; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=KqxdjUujSXUWjXeC3TyxFKq8iMCiuNtse75cMZyl1lw=; b=Nl+oJComvXgc1zxdyNBgBIjmQCWWZePHWHTXxni9o9u7Wx7Fa+BUNCXP 4OoQLbzVP/gTEBj4YqWzouk4rn5DDr7APhq0AlHwh9PnxeFoaytDX0Z+e uuQZZVbe/mOxZO2LKLJJCNtgZCYEBnjdRmCml2u1bhZIep/k47+2v9l05 l+FCzsgf1b8xrXRi4fhx7il95bwRH9ZYhn+8fq1ePIFBAjx5F5gyGbWUV Oz2/jqr3/AtQoZ23lDYdVIAGWGjiEbQJh0ejR3kJiW5DoRAu+a1I4dLpa qqfiwg/YqbiZHtwI9v9biJuFst0fuGZP9MJRUqI1M3L2vLVo3AR+veXZB A==; X-CSE-ConnectionGUID: K2CkiQCKTj+MC/eASqJlSg== X-CSE-MsgGUID: pcaZYHCkTluhsNdBc0Jo0w== X-IronPort-AV: E=McAfee;i="6700,10204,11106"; a="26704620" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="26704620" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 05:12:23 -0700 X-CSE-ConnectionGUID: DfGRqPWcQ4Gl6P5ORCs3Uw== X-CSE-MsgGUID: JBlLp7XlTa+ktUA9YnH1SQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="78992391" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jun 2024 05:12:24 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 18 Jun 2024 05:12:23 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 18 Jun 2024 05:12:21 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 18 Jun 2024 05:12:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J7ck+XQfdnCG1A852OM6xnHulZUjujCVzTK1www1WBITAiyeMtJ/9ldUgwPNU4KYL2q/p9s4+v74mCMRIanTEN/7dauky/RGF8HH91t8TrFjF60Qsqzxeju3e6cps8zTN8BVycEIP4in33g4Wi6j1DD5wiVqe2n6SW47OnYk9KVX49kbB+lrv3eshpu4byUq2n5TVyXBJ9ncHR6YgKCkrPmgj8W/4QcVCSJORgoxeGACz3q3teDI0VsVCaTW1oJPVJTVE6AacgdFwjmzu9pe5ypmC0pj/njMDZTMjLKSm9Gh1mvDoMWXOckNPRlgoeITK9bsckkKhK5wrgL9wr30qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o5d9DUZWMSFe6yBTjAWhsTXLLuGD/9HEVmgdJ3/K3w8=; b=fmadknjMftvuwdcHZo6IKMGnh/S40go78F4/DfKxVvM9/Ib8SxcsFVoxunTm6MJ3Mnfq349+HnvDFnKPOuGs+Ig7iLuRSDVqiKItc+jydYN21Gt1oNTw0aoVBbuCQT+oL9ODxwz1+LXBltwuSst9MmCTcWbpPUeppBFYGuQCFNnqKTHxkyhPG+uXF6vvfv/EDS0Zz+GISm9wrao+Tp1xZFMPGL+AzRAhm1fWZga4vcd5gaaInr1pnCMOzPIeUxVhTocNTtMdMzNseBKOr612fTN0TNkV2oY70E+VivVDcN86tA1Ppl5Ayy+4PpJJDFCNlrgMZu+zIbPjvYdnFwaXlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB7071.namprd11.prod.outlook.com (2603:10b6:510:215::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Tue, 18 Jun 2024 12:12:19 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7677.030; Tue, 18 Jun 2024 12:12:18 +0000 Date: Tue, 18 Jun 2024 13:12:13 +0100 From: Bruce Richardson To: Igor Gutorov CC: Subject: Re: [PATCH] net/i40e: increase descriptor queue length to 8160 Message-ID: References: <20240527161921.183866-1-igootorov@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240527161921.183866-1-igootorov@gmail.com> X-ClientProxiedBy: DB9PR06CA0011.eurprd06.prod.outlook.com (2603:10a6:10:1db::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB7071:EE_ X-MS-Office365-Filtering-Correlation-Id: 51cf79d5-20a5-493c-b962-08dc8f8fe64b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rQaAhATy2268dCSclqm2pKi7leCVX2qGPn33oTFkf40JxhYxSKuUHpRrE3fx?= =?us-ascii?Q?2tDOd05G8aDgyqqFnYa924GspdoCLeUf0pFzThksFain4ae+q67ofpn/DqaX?= =?us-ascii?Q?TENB/rNFPcI/64FnA5lcyblkjPZSw71/Ly03cwTUmOFi+jxF5vXYPDLagkI0?= =?us-ascii?Q?jK5Hi+Mqhec1saoq2BEoVmGQr5RoEUz6BWDjpXykWTwnhvttK1KqHIdex2WB?= =?us-ascii?Q?lW5GRZQvcydtgiY6ZKviNk3hLZQ8QByY7xf/UaW+diTzIvcg4O1hguAWZ3P7?= =?us-ascii?Q?J0+esIMFHferi5x5XvUq0/FwWzjLzZM5J6qkm5k9LGjYCXGRpLFdG7G2AVK9?= =?us-ascii?Q?37R8F0tpMJrhOmfWoRlv+rT8dEo4cjsSMco0YUAxB2+cypqfu/BwqGoT50tK?= =?us-ascii?Q?vXix6ru9XmHQbAr/n4TTCPypdJBqYvEFTxyupsdBOXqgh8By8Ckgmhi60uMu?= =?us-ascii?Q?esO9JByi32x314JqO/dEWrEU2FDSXFnA+s5xeq4TC9DWhZ47EYslTASXVBUR?= =?us-ascii?Q?s2A6ijHITQsqg3TgVDy+TMKJXO5U2040yej3MC/ItIS8lE1lpOTmAUjQQChs?= =?us-ascii?Q?xbPBzMk9OoXPP9OrSZ8x6Q8soBkr6kfm6d6umL86ihRim+mWBhlfvrQjreqn?= =?us-ascii?Q?CihL9yQZDxfErSliFWna0inlKnQl9P0rJRZyWO+UpnnlGpQCHTmwhc17EI+Z?= =?us-ascii?Q?7cXv8NRfJL4b3ZXLmidabgDPdmKkSoJOq5oxIejyu3ZXFxLKj5GiVECaNECx?= =?us-ascii?Q?HOie2jPWfA/jSrr5SzeElqUUnQ5A6zo47vPLhbWWBtQQNq2ssgzLybtcEXhR?= =?us-ascii?Q?p1JGv6kBoxXi7+9zz+oVZXSK2UGIJIqKo+CulKBcI5qf4ek7yn/GrlcMVAbs?= =?us-ascii?Q?4XbzWAXvChERI/+0/dISEpfSGaS5Su9EfG/3GqlzIJzdyZz/uM9QSNy2DZYw?= =?us-ascii?Q?tp+H8oc5Tl53vYrVahhVWbdVVTt4oCF/64hHj3NzleSPmUIcqR1jiZyZTV4K?= =?us-ascii?Q?YQPGpU84m6kSzJyWJQ7h8QO4/r58+naMQixi+IA8uO0ovyDQ2cqld3V2hyeb?= =?us-ascii?Q?tTbI006wZ9T4McVST5JKssEt4wHWWkrv3vQgMi9t6dtWE/tSCENSifLpWao5?= =?us-ascii?Q?MkrJ90hdtayflxupsuJdovPYXovfbhxCJKUOAVBeYzQgKRpLNvSjJKPY2gks?= =?us-ascii?Q?l9MpA5slar6W4wrT/5+TJbmmuDY2Mxi7hqnvdYvqr+JD6sliurf4zkhPcuUa?= =?us-ascii?Q?eHXBzcbToq4Iz9GE3LPceJ5SqhNXh515MBgo58wyW1rmlY6R6N09nEzM/X01?= =?us-ascii?Q?YYXGPPLe0zWiap8cNp5sFfkt?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wsZ2B+PpIpwqTB3rCJTe0X16rWEVWzFxQYdH/cuqrEK9AFBhztajuUIilWXf?= =?us-ascii?Q?ZUzW8xoceS6vOxkrgWNO+hiK0jCyRwP+RoEZ/PHVMf9yJz862y7OZj8P1UJ5?= =?us-ascii?Q?DmchsHNBhgEUrhdCzxeBIDEegKhfCDGAK2uu8WrRE9FckdfrfrwAJmfQwDiz?= =?us-ascii?Q?0FVusZLtyWqaySp32nDwBB0xVSp5iNNjIs3x5moQ9jDu3Fw1gV7oB0BTXV9o?= =?us-ascii?Q?MQ9qoPUlrB/tGu/qcWjoJn4TmNJGbiUbHkDFrGO9rtnTOeOr9dFyZx9JnRJq?= =?us-ascii?Q?ba7JuKxiVIY1M+fu0psQC0MKF7Ft/u81LXjbt7jtdsV+aUm6YjnaffAY/gYB?= =?us-ascii?Q?hZqNvlFBTY1rEMlw8JhbsqKZCP4D4CTIHc4Ks8A0oMLc/Hm9ITPtcL2/lFs7?= =?us-ascii?Q?wd8g8pUcfIhGK8M2SaFVMtYnhfS6SrVcmA+vdA6sUl8cu9DJbNE37FUgZrn2?= =?us-ascii?Q?+q+C//TQ4MmjajTy9lqnrVerkjvV+Ew5blGytfVEQJG9+Lr43OHBLFNWBGYd?= =?us-ascii?Q?JmFMGkNQCPCn86vfb2iQkh3D4ydsBErfaQNqgyEABBOKQQ1vCx35C4xbXQrP?= =?us-ascii?Q?D3XsOMI1Fy/WCS7Tgg/Y2trdkoDehHdaZDkp+fZFd77Yk7Jde252UKyFbmn0?= =?us-ascii?Q?G+N/1G0dczFsE4/soAHfAtex8ANZhL3Pv3jy4lGiLvSya74sxIITqnJLEKeF?= =?us-ascii?Q?NlcUmDZy4sArFpfv1jCT5oEkmBk8JZdvmQcjBGQql7YXpKhmQQuPPU+g/f0m?= =?us-ascii?Q?WO2MEKlL/RnoJBzJbTv1tr0tx3yBSF8mU2iWbVuxuAV0tE8+z6VR25pAqZgm?= =?us-ascii?Q?01WrtXxtWZ3of4e3e7ME1iCTuiM4YuCzsUCBwXYzKkH8fZOGovzIohy3CtYs?= =?us-ascii?Q?8fG2yIUiWl7owKg9Ww+KZX6ITM6p9w6z/z+aCJniGLHW74tNXYyh+skr2yvl?= =?us-ascii?Q?R6FcHb8lSOwD10T9Tb4uQ76eoMkiq59KvPQUrOZeRfluq2qrd7qFI7js1kvA?= =?us-ascii?Q?OrjWOslDlhUE9FhIvJ+LPo1yY2rb3Cork1w74/4HNiPzxRjuR/APvlCvulId?= =?us-ascii?Q?voBlNawv9yZBfei4T/mjbff5yGJnuiTXJz1erEK6nukK3jg2id5MtVcFk4i9?= =?us-ascii?Q?fiUKwkJpf/MQWgEW4ItTgSrId9fmcAlZffffKWGIsoCTmGP+peeA0gOdBJX8?= =?us-ascii?Q?0pMiI9ZDcZ+RuOcdzLPsULrFwxQGprTl6UmQn0y2F3Jk+4FUF5n1VTvwmbHB?= =?us-ascii?Q?YdWAjX5Pgbv4h/Tz6NvsZeZs0VXA+UTZICG2fKseCnUn00J8V9NKbpUnQs0N?= =?us-ascii?Q?f8cSbML8HTdxy7GoUWQihLRCfOCdeNli0smyJK2+wsBaYUvUZWOGN01+mX0b?= =?us-ascii?Q?MXxqWpj1/Eq9kcHdt9E3gmmZyK9cIM+PgFIPVsWtV1IPoreZunI0fWWBp0hy?= =?us-ascii?Q?8XR7LLiSB3jexVzSgC4/5wBNyAP2OcQHIDW97a6/wRk+6zHX5H5ztz1LpRqT?= =?us-ascii?Q?/yGVvRktQw/2GX/1YWme2JhMXP4eGq/o+vk/5eDWrBBgWK7s1CWkwar/TrIM?= =?us-ascii?Q?2fRUl9WlGOkEZ11w9K0Z7TRJej8AkXJvQ00hQ0YEPSWAmYiiqXwQ1I+UCXvJ?= =?us-ascii?Q?fA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 51cf79d5-20a5-493c-b962-08dc8f8fe64b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 12:12:18.8531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6ghxTC+cFKUMbZAjeAlDsLV5op9GCeWaz//mk6n8CVLaDQcZCb71mrQc90ib2Twp3l97TGZJ/rd2NtWAnUbQKuKN+C7f5DN3j2nzAp4On44= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7071 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 27, 2024 at 07:19:21PM +0300, Igor Gutorov wrote: > According to the Intel X710/XXV710/XL710 Datasheet, the maximum receive > queue descriptor length is 0x1FE0 (8160 in base 10). This is specified > as QLEN in table 8-12, page 1083. > > I've tested this change with an XXV710 NIC and it has positive effect on > performance under high load scenarios. Where previously I'd get > ~2000 packets/sec miss rate, now I get only ~40 packets/sec miss rate. > > Signed-off-by: Igor Gutorov > --- > drivers/net/i40e/i40e_rxtx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h > index 2f2f890855..33fc9770d9 100644 > --- a/drivers/net/i40e/i40e_rxtx.h > +++ b/drivers/net/i40e/i40e_rxtx.h > @@ -25,7 +25,7 @@ > #define I40E_RX_MAX_DATA_BUF_SIZE (16 * 1024 - 128) > > #define I40E_MIN_RING_DESC 64 > -#define I40E_MAX_RING_DESC 4096 > +#define I40E_MAX_RING_DESC 8160 > since the ring memory allocation in the driver always seems to allocate space for up to the max number of descriptors, this will lead to an increase of memory footprint of ~128k per Rx Q, and ~64k per Tx Q. However, I'd view this as relatively harmless given what we have now. If it is an issue, we should look to fix it in a separate patch, rather than blocking this simple change. Acked-by: Bruce Richardson