From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91A7A4548E; Tue, 18 Jun 2024 16:53:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BC6640DD8; Tue, 18 Jun 2024 16:53:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id 77C73402B4 for ; Tue, 18 Jun 2024 16:53:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718722413; x=1750258413; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=or/I1cehsGOTffnScLDpFR2eU/cMhblbYGnbNhQ5deY=; b=BgstrWs7rKpt/tkvLXw+3ftmKrcDu7jbaR/7VIKDsH3tb9qcgrt+8xpI EcefFtF6r2lgowRbYjqc95dnncvUvHLwJNMfz8eXTQ0HHfIA4SAL/PiyB i3yFKi7LlMXGCR8cU3kLT05wv8oDC2JqFri18ZuozgzfsVBnunjuuJQZb xGN4S2QxPpANi6anc4BYY02CzEozfBUPwkgSU+qwnLCic1kBpEi5WXAHj uBKtiEiNqGz33DvjB+p4CLG1CXjPxzKSt9dKOlTXy8ICxmAUKSzQM06sh 8GDiwTp8PUGQgaqrk0iRlUxenanfprGTUS09tbWJ98q9ZtVpzArjUQ1sx A==; X-CSE-ConnectionGUID: 13k1DBB3Q6Ocjd/jFJ3Gwg== X-CSE-MsgGUID: YsEdQ8znT5249hRGDgAGpg== X-IronPort-AV: E=McAfee;i="6700,10204,11107"; a="12131344" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="12131344" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 07:53:32 -0700 X-CSE-ConnectionGUID: ouLd3heoTDipDuQbG+CmYg== X-CSE-MsgGUID: MD5f5IHuQuixBsFTO9Go4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="45942875" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jun 2024 07:53:31 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 18 Jun 2024 07:53:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 18 Jun 2024 07:53:30 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 18 Jun 2024 07:53:30 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 18 Jun 2024 07:53:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GdPAtp5BfuuVJom68GK8Rgfzt5aNVC21gTiSXnV6dK4SliBhxw2Po2hE7He7/w1bs/PqaELb2OOW/yMPgKDszn0C/NjtmQL/ytRW8CFBDuCVY72D167PsedXUfIiavV0rAfyOVwNwho4OgzeTYIv9XZ/uB9cSK2aRRFfD8GAFOatwpyResKUK5ewxOxva2gpejRz84+9C0bHepY3Jx/ySNIA7QbQ3odWhVc+R7c8LOl+md0j5/WRU+s4z2l+XBi46iq4Abj9kGbW9pKvYEJ0iE3BZtIduWKquQEuL971szd0sbdPlRpahiSMCOPz2xNnVFY6dDISCqU9AG+s5bDY7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/dwW3RhvM4RI54KEA5zjtoKV4WfNjL35If9o0mQiNYg=; b=InaFwZlW8u4r8/jAW9oIlEIyXCVUYdBnLafRme7MEpmXguZD9zhT5C7WfB2/nztemcqLL0/opdDsV/CiUr8iOurwblneDHSEzRmIcTB8+xUDOeENy1DvSFtpSwmGCqrDz3OzpvYAo5x/ApvdIttWreAz+wUsMDWTT8rD5Srmb0WimmxhOl1Xfy7pJhNvo4xzojTHWIZw9xa6YANQE1yyQZsoPD2lcz2RU1NkLMn2UrX34n/aKZ23rjB5ITLEGY8HuoH9hvzkbm/wU2ceniRXPmgIKGuP3YNEfXnm8c/3xUpeY0MYx7qvSKCVRiRMgWTBjgVWmiqyq5X8gN3kUyO/6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV2PR11MB6069.namprd11.prod.outlook.com (2603:10b6:408:17a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.19; Tue, 18 Jun 2024 14:53:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7677.030; Tue, 18 Jun 2024 14:53:27 +0000 Date: Tue, 18 Jun 2024 15:53:22 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes Subject: Re: [PATCH v2 045/148] net/ice/base: implement switch recipe reuse feature Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> <74a3104269c42c046591d46ef7de8be4ddf8cd49.1718204528.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <74a3104269c42c046591d46ef7de8be4ddf8cd49.1718204528.git.anatoly.burakov@intel.com> X-ClientProxiedBy: DU2PR04CA0221.eurprd04.prod.outlook.com (2603:10a6:10:2b1::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV2PR11MB6069:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d22297a-56f2-42bb-2a8d-08dc8fa66965 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|366013|1800799021; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?S0sLfpsZby+tAZ35CxaBOdhPxQzjey0HKkjh+xkKybeL2qSK2IbEsWIfZGL/?= =?us-ascii?Q?Or0hKbqwntxeQXUkpHcCcZpL/SFoD3pS097K1oedUpxm0TQ6fiRasEjiwIct?= =?us-ascii?Q?i2CQ0ik4t2ObxFPdUlVXv0+1JSn6+uBv33gfGpvameY71UG4EoWXqtM71AVC?= =?us-ascii?Q?CFLp4fbu+BEYTAa4GdUn2NQwLwDLbGT/10EdRumkxl6Rqlj0MRZ1ToNWz5rd?= =?us-ascii?Q?cA3nLCKVTQYmkaVqDg8zZKk2bZfw2T0XNDFsLvQbUers/8NiKK6C4dczpd47?= =?us-ascii?Q?m8uG5Yt6HqNdxYxSLBdfFQ3xVXSDzCRPkEJ3xpgBliQU8rrl8bwplolZPgnK?= =?us-ascii?Q?bfF0NZLhYgM6Cx1H5kWZ1IN8KTXErLZixHifiqhoiW2eob2Kn8BIxI2CFYAM?= =?us-ascii?Q?CmKBvLopE+pbEdJI5o7+uBFUsBpkzrYD4CgZ8TNJc+s4gymCLArSsI5Mud4U?= =?us-ascii?Q?kL9hkJ7wXdyRkJgdSSwzfsenE2oAuCqwUSr0zB/88i5pQVIM+MQzTzoKJ4Um?= =?us-ascii?Q?BnhIRTzkC3Xu+idRW1xoFR6RIUd1Kyp+86+IVPtA21GaBnd/R6h7iBA/z/bG?= =?us-ascii?Q?S7+69vH/MUfeS3m5FTDsvmLs2u5Zqyiu9fnJXGOkHw8or8REuYTXrKajZJ4P?= =?us-ascii?Q?OoQLFDZnME+3zJ5zHBbMW+0A0kfIe4I9GyEXvRNaXCvpVnvqL3EpZetBoP1G?= =?us-ascii?Q?m+06gTCSGucMI6V5bmhIYZi1ClI4143VLjuKBqEMi2RwAj4Csq6pqSlq/WKS?= =?us-ascii?Q?rzkWLkSpNvwNJhIrQjyDL2cCRxmijAbdXk4QzUPJsoUmTiyOn0GF2PY3QBUr?= =?us-ascii?Q?Eekgt1h50MXaL8+TXTOgN09/3Mup/PinaZD9IZ04eM7EXmlh1TEkhHD3MnZW?= =?us-ascii?Q?A2aVitsQWy8fDgFNUL907cLzo3bKLFyhHVm8yTiS/kOS9pGzdewMdbeTcFKC?= =?us-ascii?Q?p3OHPvYbfTNdHBphoErj0usQ6F/1DYiQ3YnfJ/7vHmOQXxW5dgv8LiN1gBF/?= =?us-ascii?Q?hXxx9IKfrzU1xMBbQKQGkLp+bR6hVNa5E0UBTawlufw5tZow3pVnnAdOV5n/?= =?us-ascii?Q?L/6Nt/6sHBGyy0T3gRVz+xz0Obe7qXCDv0hxcOFYLKMnkgfGIVk9veGr9osS?= =?us-ascii?Q?xK5DvZQ0Sx5+Jz8qGvmnVYeGuGzbJnKOf0E+k4to8mrFPj0zFaO6aITAUZj0?= =?us-ascii?Q?Mg2kC95azGA+7qzo8ou2yUSFd6YWFjUXnRMGKc0Fo44pRdXB3zD14R6qzltK?= =?us-ascii?Q?FyFAWakpnYbMqYEOlxMnEiyrC9jhsz2bGny1jkcKzfj29fX+1NweeFA2ciBb?= =?us-ascii?Q?LLiXWFigI0qj+eKKJplT3URe?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(376011)(366013)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K3VHyItJ8G+qWh9uq7uDDqY2FaNQAKgIj2zbb1NfF3+jWL8zJqjWlUk3R5bc?= =?us-ascii?Q?Xw36MFtxU2lrS2m9spobXQIIeXlcVXXSEFAmeG1fhdiAYhL8igkfJcV5OqLr?= =?us-ascii?Q?AIIRAZBZirWhHWPpojon6sc8ZY2jkLlvxllAuFWAmZeLzkDZDQ+GCngkNpI3?= =?us-ascii?Q?iZREFxgG6qL4L+GWfbA5TgN4dHZ5MyHyb8JMKMP4mKaCdGNxPZ40OUug0kaQ?= =?us-ascii?Q?L3BIKtY5TG2doMaq2Q227ZG0gFc6/tVqlpwBtqVMGxyG3D136Ythuj/IS6pi?= =?us-ascii?Q?1yRJ3XBGTbMc/QeHSrkBImd0dazeWO7OdFwDCMwAW6L1lUI+rF7tjZEcGcdw?= =?us-ascii?Q?GqbjMlmmeBh+fUHZUR8AKQXzcozc6nQhAW1zmjJlQZOuArtKi2BqbKw47SkM?= =?us-ascii?Q?mo9oAqdSLVDmT+fj+2vksN322pGgFqR3r4su6qSiWDXIo0VV1vMI8UVJ0jrq?= =?us-ascii?Q?KIJHq9KN4qzsPYS2tdBJhcKsUyqlp/VJqEU05aIbe3jk02DEW3ZOPU0vWba0?= =?us-ascii?Q?KL7o1UxB2MZ5WlgVq7VfwVnEVTSNuKle8UWndG4SrgyK7WO7PH6FhiGK+moi?= =?us-ascii?Q?PilYpeTAyMwwiQiIeC/m6PdxQuSYgKKxYhLPa2NuUqOUoGg0eujXq0v6H94r?= =?us-ascii?Q?g5ZW0d8vL0YASlTJ0WqzWX25rhpQWmjRQg16jtcLR24IeWRhczboaC0O253Q?= =?us-ascii?Q?iZX4ZVResghWmw9Ne8CCHTAIAvZe2ryDygA7jsAsyjWPeXaa1Skw6IR0VyA3?= =?us-ascii?Q?tx7Ce1G5TrUcf7SMvDsLVKD6scMFL+SFEL/GQOZFLCtK2VF5O9MGJdyOelcF?= =?us-ascii?Q?oPCQxrUE3sPGWW0vid6lQmMlOmrIyK6jWeX1M3N/iN/63h+MZOtpjtyz6sNx?= =?us-ascii?Q?9Xq1l6QF0igx4GVhWQZkGtjyxabRqk9WZqgdCXP+VQ+hKpgpnimRhpNGhpnI?= =?us-ascii?Q?2CwOtBOvLeQwwTWWnpehXwCLGZ9T+a8DhNwLTTm/W7ReL9Zvga9cz2xydl+3?= =?us-ascii?Q?Git+2MlBrndjX5e5s3PGj1aZ07H0auMIJKNw6WrQWh4xeiHBBlNQicP19WIQ?= =?us-ascii?Q?4EvzM0YFVueJLSJy7xnHnsJkKAyBDATAsZDLv6iVcWDmT6/Zqmjwby2oFS7/?= =?us-ascii?Q?8KzSDVVIq5y+8OtgPQ9U6zWI5ukd6bKy+ykHX14lJQ0yyU/PTdZLeZG0ujGx?= =?us-ascii?Q?MiLuU3IDiTIycWowh8BLaW/WgQtGcUixw2KgJFtTmH9ejU/6bXFzI7iUF7wI?= =?us-ascii?Q?+yel1gOUGoRugO/vftnU8afk80jv3g5HuZ2bmmwpUOoJiq7tlu+7kByYQ/qm?= =?us-ascii?Q?HVTZJioeUp21RStuJXXTt29JiZ3XOhcjbARgIXEYtze3mOqvpE1BhAKz6hBA?= =?us-ascii?Q?eZq0PKLUhMa8gVWZhDBJzAo412gYLR2T2VBqDRCkkFnlNxzVYnjfvgvbQ7ts?= =?us-ascii?Q?klSCdu8b3SaMvbxLhMbpazJJxpt3oFwVzKQ9b1iv2OgEwzEHuFZlKObwViHb?= =?us-ascii?Q?s2gSNjP3lIn8Sy6u9uGcvMFvS9yeVK8EwaymzlE9BmaLzZLCnoSeJXhoqEom?= =?us-ascii?Q?FcnVMLdV5GfE2N28Qawa/ersnZzwuUfaQrMsImUmvHrCwYK7xk3biQgz7706?= =?us-ascii?Q?Xw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6d22297a-56f2-42bb-2a8d-08dc8fa66965 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 14:53:27.7530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MZEX0QDwz6z9dDscQ0jjCBUpHfUHs46CrqfLMkI+wE2hfJloBn346AqAdyPrD9sMNd+QrVKGbr31LnoSIzi+fq7LKCCofgxbVSVSWhlD1Eg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6069 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:00:39PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > If FW supports the corresponding functionality, the driver allows PFs to > subscribe the same switch recipes. Then when the PF is done with a switch > recipe, the PF can ask the FW to free that switch recipe. > > When the FW detects that all subscribing PFs have freed the switch recipe, the > FW will free the switch recipe so that it can be reused. > > This feature also fixes a problem where all switch recipes would eventually be > exhausted because switch recipes could not be freed, as freeing a shared recipe > could potentially break other PFs that were using it. > > Signed-off-by: Steven Zou > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_adminq_cmd.h | 2 + > drivers/net/ice/base/ice_common.c | 2 + > drivers/net/ice/base/ice_switch.c | 277 +++++++++++++++++++++++--- > drivers/net/ice/base/ice_switch.h | 2 + > drivers/net/ice/base/ice_type.h | 2 + > 5 files changed, 262 insertions(+), 23 deletions(-) > > +/** > + * ice_alloc_recipe - add recipe resource > + * @hw: pointer to the hardware structure > + * @rid: recipe ID returned as response to AQ call > + */ > +enum ice_status ice_alloc_recipe(struct ice_hw *hw, u16 *rid) This use of ice_status here in this patch breaks the patch-by-patch builds. error: conflicting types for 'ice_alloc_recipe' due to enum/integer mismatch; Probably want to convert the ice_status's to ints globally here. /Bruce