From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B30F45491; Tue, 18 Jun 2024 18:19:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0DC1402E3; Tue, 18 Jun 2024 18:19:52 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id C8ABC402B4 for ; Tue, 18 Jun 2024 18:19:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718727592; x=1750263592; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=H89Iw5F2gSqndT2UbDhasjVXZewlQ+b+1EEfeM+fUSQ=; b=c809/C6j2Kw8lRmo+cH/V4932hGE0vrRvRex7iuculbmh8EbaIJnMIne WWLOAeXe3PtxAwVweGlmxmOzNfXyfckQZd4dhuxdbv4LSPEanLgMTwn4A h1NtYArFmLHECnRzyWWBm7TvPwwQX59nVUO3I6Lznfcjtg9vsFBjz8ty3 yfNqNjwUyT5yezxXhWI7H5D2WwGQmmlQlfZ0n8yRaVB5zGLc9kgEkF4oO ocBw5Q6DlcbvTituep9nkSEBVAVFhRGCHD6wHb2BZLsRjbPYzVnWy+xtr qALYYu/ZpDC9dGrbdrJ6TDODE7x3z1+cLnb5946XLgnDn/kxpOYlnJnKK Q==; X-CSE-ConnectionGUID: lx+1B0gITDada4dz9xf+mA== X-CSE-MsgGUID: DyZJiAZUSuOTISyo6eEIFw== X-IronPort-AV: E=McAfee;i="6700,10204,11107"; a="15591296" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="15591296" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 09:19:51 -0700 X-CSE-ConnectionGUID: El/6U+6LTZuzrVEntRWjNg== X-CSE-MsgGUID: IFl+Em7wRgmApi5SFZ4SPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="72358450" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jun 2024 09:19:50 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 18 Jun 2024 09:19:49 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 18 Jun 2024 09:19:49 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 18 Jun 2024 09:19:49 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 18 Jun 2024 09:19:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DuTownYOarYBincBMIx7XkW0tO3gQAnwvjMPPfY6Hop6OC5Oz8+UTS6tubW+LNKksGDhU+nTCvXsjAGplsMD+cKZh27yFlHIOBfu2EbjhE4yk0yGG0Coj7z0jzukQMkzidez6LxxT04Jq3wp9jK9zXQIgX4s5f6Wo56zQisBji2OOAzkSZPkJPTR2bRDldq+/xv7VZkNwPQS9nHHnCLh2EvRB5uKcVQJDVqAUvTES0lTSGwASFr8udOxWuT+4mT93/DmLVPPRXQ7CM+knP1QyZzhYsP0TfGraV64SsVt6b1Q7/aaEuQRZjH0zSrz0yxJNEBOeYJVdOEt3M0Kp2G7mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i4/taJpLPXhbYJMLcH5lfB7E4ep5PrHkMBM3Ude0MlU=; b=LzRp6lO9q5Y493SdUB+qeIluVHocHOlL3ghH2uoNYrLE0ZCkRRztRcybrXWZTv4dFO0FT4h3r4w5fwT+9BY6fTUi4cPSioLnxJrlygK93Nxep9jykqKEKmOe3X1IbZakRIWcF2irjbrOfmLYO4Xr0aAgrBba/Awi1uESe4Sc4zu8rHg1BPQOGPDcomn6fw/lW2Kh2mzcHo0FjemNw0pG94fZn/a88TxPbADjzT4gvIKfEcIBvmF+8P3kqIIZOLFF1R1Sqh1+/enBwT0XENdblVDEdbDdQKg7WKhZY0A0vcov6ZSjtwgKP3q0jVy1hUZdM6K8vjlY4Guqlm+3aYdxzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BN9PR11MB5227.namprd11.prod.outlook.com (2603:10b6:408:134::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.18; Tue, 18 Jun 2024 16:19:45 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7677.030; Tue, 18 Jun 2024 16:19:45 +0000 Date: Tue, 18 Jun 2024 17:19:40 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes Subject: Re: [PATCH v2 104/148] net/ice/base: refactor ETH56G support for miltiple PHYs per MAC Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU2PR04CA0313.eurprd04.prod.outlook.com (2603:10a6:10:2b5::18) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BN9PR11MB5227:EE_ X-MS-Office365-Filtering-Correlation-Id: 064e5460-3143-41d2-93f4-08dc8fb277a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?pveDWKEYYnS2rbFXFvkrO72rFOCJMm286D23ncAOneCFsaRou6mgZCQpwzrw?= =?us-ascii?Q?xSuvtLNG1H8DBUxQuopwbd3f1/9DzaWk0yKfSwMH5AjbYHWV/Vs4CqbqxEZH?= =?us-ascii?Q?6BzlBSZsGPJEXkt1BSOThOojSTWn5dntLcmpk7ZOWzCWL3Py1NHHoIzutQOk?= =?us-ascii?Q?GGqtbwOyzNxRkPAwSVAmPUJ3lun0t7KRrgFgrlWQ7OfrIFXASkBejlS+5O6w?= =?us-ascii?Q?zAa87AYON2qnjHnO6OL9T5oMvTvewYuNE96+jenhpOwZEai3p4UufL9P/nIR?= =?us-ascii?Q?4u/5BhUNlh+2oVHzeneUz7PWIH7kK6x/OFLPJbQFU/sZgaQ+UNGs80gBqGOy?= =?us-ascii?Q?FkYebYz7wKk+tGyOxUCjRgqTM7Ln6cTBUDxm8eJFwlqZ4kUW2LnhAe3DAdMQ?= =?us-ascii?Q?c+45CaIL9DcOFXdWHoXEqRnDp9PlyNn2a8ihmKzbFk5yctEoPpN69nyDNGZm?= =?us-ascii?Q?qjUsPl1WR+NYXkThzi7nI0sVgliwnVXkdAOxUDx3THRBa3x5DTBPVvIUTiyi?= =?us-ascii?Q?1++3jOmMoxNXk8uBkWiD5lkKRI8x2h01NswQv2vx+Yd23p0Y9SV39v6Ya6Nf?= =?us-ascii?Q?2FQpZqkrlp2gfhVBB1COH4dDziyb0NDHMoGDwgi3sFpLb6GGk0yhr4sK+Qkq?= =?us-ascii?Q?7RFx25izLbgZaGNCXd+7qxlwsni3qHlfBbKRcNv8cM2d3PJjhCtqbDgGdcc5?= =?us-ascii?Q?MT52d6RYNVyxPkF0IfUCotjB37+JLszgxyt0INS/nLyIGxKBkMP2YVvDh/MC?= =?us-ascii?Q?3jVJzU092tcg6P9BkEMB7uIphTOmLl8QucVBkkF3ZBN7QNYRi3wYqEHEASY9?= =?us-ascii?Q?vnok1ZplceEPJC8vBrBT1pfdtMyPokcJ5t5pekjiw5hlG16ufKAu/0nH+31Y?= =?us-ascii?Q?9K1D8ZxBEQZIgssl1PrXD+8znMeJL5kycf3w9LvIeihwabsuq5OH0VTad+Gi?= =?us-ascii?Q?T1L4ivOIADqTOTZdH4bzEOUDC3YYdqXgUjr/uTCr3NMoQkXHl7J8/fdaNNAI?= =?us-ascii?Q?8W/zUFNg9u3hDwtnu/uwDnpOzxVmBaM7qAacOutjUUIPNxlDTWffFxBcleR5?= =?us-ascii?Q?vCf8XLnHn8SQ1G5GxNy3Ne0q7BCHCdieu0B6xYUxJZBAGT8ieKzENcv7x43T?= =?us-ascii?Q?0CyhWkzeL4knL/R9yXQTjX6PdLhQJOV7C1MPnjQ5S/u+c1p5npWcuzzQCEX8?= =?us-ascii?Q?UPMmD5Kn/K225x7Ogz5YNoxZ9xsMku6+4NrEqJyM/6neHKBOhZ8Ampr4ztDV?= =?us-ascii?Q?3rJsaoohZdACDbIi+KvLVoXScDov5DyY7r4/EbM+YlvcuisLPd4uDg0C3wKV?= =?us-ascii?Q?nBZfhBOHSnL3J0XoxY7P3hL8?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pTh6QKMECzvoUQQpTC1vQQ/0vWKyS6wmokqC5zoJIYkm5ShuijTSqjkreRMK?= =?us-ascii?Q?bTeJKbFzvgkmtWXQEUfvShCfHM08UWFqCxKKOrXrGgGNZcdZLXJ59iwADlJm?= =?us-ascii?Q?qi6gLEh2cIC4j/BdA/9cDjkUPbojZ6B2cVAatZAbnPV+oRgKn+yPkGM9ymi/?= =?us-ascii?Q?kxhTEkOaLRsjYkd9oIG7FCrr1XCECi59kjVJZ6Fqg2CjsYxzmeQgK1rtt9T6?= =?us-ascii?Q?sIROKD1JEIgfjRPxEeDyhDVpkalfBGy5xQ89R7MXz8ySVawSiUVCSc+KB1oH?= =?us-ascii?Q?Bezf6ExIL4S3ApX2qyu0xyb2hveNaFW/cL9fBEV6YX22N9z2uKe1O5ZAZjQu?= =?us-ascii?Q?YpljG2j5aoq1K/XL3dq5S/hTGtgqLrnrQjkYcNUCK2T+Xe1IfBUgwFyoj5j1?= =?us-ascii?Q?bt2eTBiuTFCzfD6xh5Hwxah8q86LumTt1TJR03kz6EkXg0wYhbxy3YK0Xl8v?= =?us-ascii?Q?gn8Pff6yjkkP7FSnXtSlqxEAFpGAmPS1un+5dVigHvyJzifg3kaYxQpD6hKZ?= =?us-ascii?Q?1NCny1mY/v0i4jFsTGmryA9oAcIbibifPZA5ulRLnAWp5wp0WoEK2j0WPSu7?= =?us-ascii?Q?jy+C+hOF0Maufr7pBsdiHom6jmmN93cI0TCE9Zcjf/EwfovJF0NTDDcujYJ0?= =?us-ascii?Q?Hg31xlaec99yb6J+53Lvg6xldoW/Frq7BwWAocH06rpdbpbCT9IR5hVSAluJ?= =?us-ascii?Q?I1pprsoVjJWz1rvxdm1MmYSOjDbs1Mep+Y5q5NAc4MijDN6gmsOeNbDmTTvc?= =?us-ascii?Q?S63GvunnPbDQ4WAWN4Z+RBZu+3tzZzAF9cXX9bTcG736vlbaKOYfkgRqzSna?= =?us-ascii?Q?uN16kG1/fp5tvqSJDe4onaYupSmvMaiGs1t+4VTYaxXw5ir0VnOM35OZBIum?= =?us-ascii?Q?DT2PLynXD1q5VxXz2BS1244P+RKoSd7DCB7QQC8/jAWHQ+tyUUKTUMFO1ejv?= =?us-ascii?Q?VMqk1/9ZpYgazQ/VDXNxhgVma0EYpbHj0Q0BuvEzb7KiYn3ofoha+wVlNuJO?= =?us-ascii?Q?jlwr6Lvk/0LWmUu8V3bp2lbZuKVXgdTBOfaGblB3Eccq7gr0TZChA+FjvscJ?= =?us-ascii?Q?rmuXckVAOiEy7r+y1MrNFWsJZaMeaQ8oUl8Bw4bURb9IbJ0e4wVmVgz60TQU?= =?us-ascii?Q?PxTUkooeucRBFfqJ9+sNEvK2RSB8TCCqvrS9jqv/Yta4sh5tBPtQZ/9c9KlO?= =?us-ascii?Q?HXF228ETKVtGbDq/5pWlW0J0RFK49cbBX2GvvOBxZGoPGL4h4zSTVCUIY+nN?= =?us-ascii?Q?ZvcOfmQZ33R1670cHcLkZv9+py9oPi0acw5mp2xs1NPCfH0w1oJQJGlSFRNX?= =?us-ascii?Q?1nxITSrcwPu50HtudBY1jyzJRpZ+7YLz55O87dPY78ACRL0sV98tV+nza+W2?= =?us-ascii?Q?pTsNOO3PzpqCRFy6Po7hBp7u9BI1Gv26mkyPpkXV5d/uvjF1gmqKZCFozgQU?= =?us-ascii?Q?/ozMzQzngnl0dqZyKlUwMDrgGl4Li3yj1ankMEGHHuaI0H6uyAD1w3wRYkAM?= =?us-ascii?Q?bztC+WXVvsiijqV9jWh5x8wiTYCpqVeTNdcmn3rOtalzICSpSM6n9eZrPPpc?= =?us-ascii?Q?7YoF9zAajIJnkRoLPiqfSkSQWkbo8Ohhi8X71fKMM48kzYSl7JjgvamffMfL?= =?us-ascii?Q?Vw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 064e5460-3143-41d2-93f4-08dc8fb277a5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 16:19:45.5174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E40N4qBz6y5Aw/VcyAscZ3IHpw+A0Y8ihMTJIZl/1mlxIodBvMqrwXc1bFZyTvbtlFlhUQJ1ERWf1L0sNAcnQixxPJu1/rzeawM4v54anhQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5227 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:01:38PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Support configurations with multiple ETH56G PHYs per a MAC complex. These PHYs > have their own addresses and are supposed to have their ports numbered > contiguously. This commit mainly provides port number translation for these > configurations > > Also, handle dual NAC correctly for max PHY ports as they differ from everything > else. > > Signed-off-by: Sergey Temerkhanov > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_ptp_hw.c | 234 ++++++++++++++++++----------- > drivers/net/ice/base/ice_sbq_cmd.h | 3 +- > drivers/net/ice/base/ice_status.h | 2 + > drivers/net/ice/base/ice_type.h | 18 ++- > 4 files changed, 169 insertions(+), 88 deletions(-) > Typo in title - "multiple". Patch-by-patch build flags that "ice_is_nac_dual" definition is missing in this patch. From what I can see, it's added later in patch 112, so that definition needs to be moved here. /Bruce