From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D26A454AA; Wed, 19 Jun 2024 16:53:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F11A540291; Wed, 19 Jun 2024 16:53:45 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 9BEC740289 for ; Wed, 19 Jun 2024 16:53:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718808824; x=1750344824; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=2cK2E0TU8lX+84+P+rjrzPmSUoewm/zlgEyz77wCopY=; b=Wo0vcT7ygBj/3CSAAg9EhXG/b21J7pN8xjnxt878MuvC+MRHD0Nj0sZ5 cagarTQMNzAqu0Bh3HQHYDrnEMBp2TZmpnn78fmEC4pqSrnMqL9yUpt8p sLefMkTkyS/c9IZ5SUBw6MIgapgUz5FgIj2PSFQ/gqA/H/0brvyQ+K6Uf tJxAxcvfn96mmv1s2d92Y/Oi85XkogtKahAZ1/IOLE6pdfuKC1CKuVC1c 1qNJutWTjvum1Q6p04snsvJBpuEp3s5s4yQ0Ai4T00oDG0kXE+m/BA0ZW SfymCBh+DR+B9kod5he9jsmKdn0TNo7TgqJbexoR2NkXlRRrspBMiW5uj A==; X-CSE-ConnectionGUID: 7IXX4rm+Sh+GR9ithzA1Dg== X-CSE-MsgGUID: UsvK1zEvRyu3H0yt5lvlZQ== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="15893296" X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="15893296" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 07:53:34 -0700 X-CSE-ConnectionGUID: dLggCdRPRceV2bVKfxa0TQ== X-CSE-MsgGUID: B/Ht4nJ8SkW1Vw2R/jbTyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="42404224" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Jun 2024 07:53:34 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Jun 2024 07:53:33 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 19 Jun 2024 07:53:33 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 19 Jun 2024 07:53:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAVQrYzR7vGeGE/8Ifl5Sm9LzzTpQ6ikXdleHlHKcG0+oLCK9GFf/4wEUFAvqL79C6bb0X+cVmZr7wAjSLHE1armAlw6hdzhEe6NjS+dZcbLdJhZ1qslPG7AyqxpB8c9881cbw8Pk6ndyocrZeswbkaYDk/RR4As3QYWdHAl4a542e6G3KFLHRQOUwPF+qJIHHmXFzgdmVORzmjJ5JydYtsA9NhXZAZ70RwMdnzGYO9T2nG3HMAU5FiFbO3fsiaUs2blIXRQrqoux2lfWEixXRCW31MW+JzDpaN2utSZKFJGL1v56H7qqAagIZojIXMRkH8tJDhgbE/j6mE5V8N7rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s8Nt0hjyc3fXFxBEIEo9NIDIR78MfwcCs8hWe7bVBrk=; b=bk0bYEs3XgBeWuP7Hft4Xe2QHV4EDhX/OnpPKNs+wgjl6yFcjmZG6aaLLcZIqurEQrnM1doCq4ArMUWSbzYNRwJkp85Hx5VeeaYXI+oT/wEDFiG2FhLJ5R0sFKC8ZabRdfW7xAQOBLrfSyoHvI+hFtmC4qamfKljvp0F14eGBbHrvK5+lHzcDZWtmLv8QKS+IJDCR39Hp6nE6lqSjFmnmUYsIQdDpQ884U96s2IiNQzJh98Q7dP3jEYMfllH2Zy2iM8PDQahXe9M19Evzx27fqCjzEU+aZ0u9a5f6OlFnnjxfnejanOQHGzjEqbb5aZM3cLP/ActaslI8EP2iyYtXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7830.namprd11.prod.outlook.com (2603:10b6:8:f2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Wed, 19 Jun 2024 14:53:30 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.017; Wed, 19 Jun 2024 14:53:30 +0000 Date: Wed, 19 Jun 2024 15:53:25 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes , Paul Greenwalt Subject: Re: [PATCH v2 011/148] net/ice/base: fix get media type Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> <55b6751736d5f47676da021427bec3d2039bf90e.1718204528.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <55b6751736d5f47676da021427bec3d2039bf90e.1718204528.git.anatoly.burakov@intel.com> X-ClientProxiedBy: DUZPR01CA0153.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bd::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7830:EE_ X-MS-Office365-Filtering-Correlation-Id: 93f40c92-0283-4303-7c0f-08dc906f9594 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|1800799021|366013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wsRvuyQEyF8/FgfxeD4r9iho8dRiaq9WlLSHo5mjOhlkF6phfEkNh6V9ZKKK?= =?us-ascii?Q?ZlE6BVWMNwgf1S5MMywUsZuQWepe6PnnID8egI4h43HM/r4/b/q9B56xA6DZ?= =?us-ascii?Q?UKXfR8U9mBCp1cGouSLTYkAiEyr9pJqnp+1NsbbbfyV4cz3ZvlXi8hYFSDH4?= =?us-ascii?Q?PAZ7iR1Zf9MAxRRWPktSWT0J3IrS0/Akb6WKkcU+yh8cRwA1XZqS9qqBmcYX?= =?us-ascii?Q?0Xvx7ccHngdwtppM9W+Qp3kMDWq/HupnUdUni0SpOW4lKDxrg72nknUsT3mQ?= =?us-ascii?Q?zuIDAlltwjenpEO8IyosZji5dgF4ctxos423ZpM1SIYlDjLgumDh5ebnD38f?= =?us-ascii?Q?LeumW/+fWyC3NR4oAs69uy8ScX3vjDjuKCyYpO7kN8YmhqaMcNCkfuZzMR5a?= =?us-ascii?Q?DKjv9CcoX8pXym2NweCck2qAhbeJbruvDIN2VFRAr7vnhB8N0l/TxgQt2cGn?= =?us-ascii?Q?q398U3SB4YxIm3G+rypB1qQUPuPItHe1MiKnthseUIXg+qO0oNzwLjzv1heF?= =?us-ascii?Q?mQpPboVqXxIiekyuwWjwTNq8KF4/5ydMH4iV2NieoDFUEcSmdrs51VhvXI3r?= =?us-ascii?Q?TyKEmt3lHPmCmkxlbZEouam7vBOizGDNiGwC00TA/o1LgDbcc2pzlOq8OLmE?= =?us-ascii?Q?Fq4/iaviayRWXS8K2EQHuPxYSNCeTQXHpREnmpbQUeHhXjgvOERHAtPTWie7?= =?us-ascii?Q?13JEv5B7HCwVZQWwKr7nxq/o3t2Yzdy+gcMJGYmzBbvv3t3CnN6MwQe4FWHT?= =?us-ascii?Q?HE7gd9FgupgsqI9iGjpf+/U8TUP1E4pNpX/tOWkl8BC1eXCYJD/4T6Ziyux1?= =?us-ascii?Q?S3D9Wa4UV0R38BAw8LNdWxQYgwV1FAazskM2XnPNVtSeunxT19G+wduxmEbc?= =?us-ascii?Q?iAo85C4el2cQGMk0Dx2FJArhruFwJn80Ex0AxdW7DI0M1026fCtKcGSlxSJW?= =?us-ascii?Q?cxsR8aarAIawu44BmBrOjit4Z0h2B6H9pls/Gt/5/KQ7TmpoOBxKtDD6VVGO?= =?us-ascii?Q?xoNb2ZoYRvk0UZJ31AW8osWJdTti9LeK0jUIURFYGMJQfiyKJkH+oXSotL9f?= =?us-ascii?Q?m8uz/RhcY+mMf58WVlCYb38vK9cwbQYQ03d6/cfFb9vUUMNbeWvcs/IZJczL?= =?us-ascii?Q?0Q832zTNKccu19jQ6huyX8+B+6WS38J5wJ3SNRlup40wI8OAgnHnL1SozSPR?= =?us-ascii?Q?DzW2gMeRHBGaIWMVntKrUFA3OTevU6OSiBw3Md8XAsh3pN3uvZX4/wgMrleH?= =?us-ascii?Q?OQMZD1B4S8Ifn1shyRm65pDrCOO5t8wI6Ey9dggXQJyVV31mn9foO22FPFbj?= =?us-ascii?Q?A3pdr5m2l3/di1z0YvCqTm2x?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(376011)(1800799021)(366013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O56eRa/TXoaiugS4UIgzGERZPTGSnJCOWdJTkDuDvSnW5DRaaWRz87Icza9D?= =?us-ascii?Q?wTmMRzpCNFJxL3/fUkwNopWB/dcIYruPEWJsiSqvwQSAx3yirayE8odq/spa?= =?us-ascii?Q?K4vNppQ2gHftNPRStoKEoDg4fgbN/bGC3gKH4HVwapsL28Rdh0oHuWlgmkgF?= =?us-ascii?Q?XZrW0LrOK6Ov2HRVUCfg68ygqBq0pU7g65cvfxwQmQ7hHyt1xQr5tqK0IQZ7?= =?us-ascii?Q?mkL4z4kEiMOh1ql69hsZlUG3KWZL5F4I5f+Sc0N7IsNvM5QEoI7AGQXVeCSo?= =?us-ascii?Q?Ap3C5OJxtHIZU9fWCNvEjU1Hsb97bNv1xmYG87ynkpVqgurZa8kaQDzfp1Rx?= =?us-ascii?Q?92ez6n+K3Oyg4f1hAebzVfSCahPX+yr65j0+8xpP8stUfIHIviSSuSV1BJd+?= =?us-ascii?Q?/seN202+yKJrY+OwRgWzw3zrPOvX5Cmv+C9FgrWYU9xsE1naq8IxeTFAZmz4?= =?us-ascii?Q?E+PsD3dHrs7q8b+tTAvBTl2RQrqsHNcuICWYy9+PLbu8Mt26R4LgxxuCpxV1?= =?us-ascii?Q?wnqOzkoM8/ppUoaPDZNE69PXz5N9LkHadq0P/lAS1oZPTVYFGR5Lc7BTMt4g?= =?us-ascii?Q?LNYV2imk5lFbFGY5PgQ5/RVkx++NTr17A7QZ1L8TXklOuNsBJmGQKGjrB3YT?= =?us-ascii?Q?1klZvOUU3/Un6CxtKt7Wh3f91K6tJFHrAhi1yW7P+FPD3q4y4M8Sh8oJxCRJ?= =?us-ascii?Q?ojZxH8EzD6og3BWSegVzN/s3hi1ZJ4QmbMAulyXWGGFnI2+fq901q8YUQ2pg?= =?us-ascii?Q?2AwcZBXPozhOLO/qHN/Si+/hL/GA9NZ+0uHqg35Zbn53uXPkLHvs94MtDkPz?= =?us-ascii?Q?4uirncRymqqxCQyotl4A/lNFtj1SVBvA2jLCPleOqy6D7lTM0m0ojPEaX/hL?= =?us-ascii?Q?tVFC3AmzjUaL+jvN1+YcD3amPVeOjuhSu4r/5rEsp/X6z4lORqy4Yt9gd0sJ?= =?us-ascii?Q?XfNiGJEo3qqbS5FzHYqY1tnosRlebCiEfB7bdPNEG/Yb3jadAtmSFn96WgE9?= =?us-ascii?Q?MWgqc7daIq6z17goV0cLbsS3QYw5KxtzI3dPsVBUx8c09Cak30hTmE93AtDP?= =?us-ascii?Q?YCKGeH7y6FJEbWDqbnhz6WVUPgvyQlCLXeDoopy59Nk8/tzMs3uMp5YCYbrE?= =?us-ascii?Q?lGs58jDW7dCQ0tvB5audXgg8MwOhFK/x+/LUKSCyUhmd8SXSDff3exr+s14S?= =?us-ascii?Q?S5gNBHD8usJLjTC1Tj0yt8TyTd0Q97zZwp4oF1Bk/3Tz50cj3B4Sbok4yYoo?= =?us-ascii?Q?haOh/5P/WeTD4E1nUi7zdDc9CZYFqdM539+x9EUKf7XRJEh3biijgeQK+Xox?= =?us-ascii?Q?2Khfy63RjqnJVrP9Z8dW9zzpI9na10Kz7MUGpEkB+ObDZ81SU9xmywd5HYNu?= =?us-ascii?Q?asUWoLbHDK/wrzvdHQvSk3yrfw4HIj9VOoOSfb/NjaDE+r1UfYdzIf3TXrGg?= =?us-ascii?Q?M3Sj8PSFb2/O+cl6Q1egjS6focdRKyTH3wNjlzTgSOt8bM4Ds0xKCtQ3WKpI?= =?us-ascii?Q?aL0MVrF9xQGzwQ+Dw3OCfyerG3+hcPPhBkuQ9WrWk4USh1KGlvGemghraS5r?= =?us-ascii?Q?v2VBgqFUUBzjmF+hf2/CbPCXn+8ZmxfDISKayLyDSOLlWMM8+2GcGxksqA1X?= =?us-ascii?Q?Dg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 93f40c92-0283-4303-7c0f-08dc906f9594 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2024 14:53:30.7446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ni9g9LlA/cxpi3v//BQBfUj3EBqP/QbHJV8sn4sjzCw6UhNLJBSHvbSk/XlvCsfzJlq88VgOpuqaa86IfaCkbHKgrGk0XoLLm/jLr8ZSdNg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7830 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:00:05PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > The use of get link status PHY type for determining the media type can result in > incorrect reporting the incorrect media type. This can happen for a couple > reasons: > > 1. The get link states current PHY type field can return non-PHY type values > (i.e. bit 127 indicates link state disabled, and bit 126 indicates PHY is in > auto-negotiation state) > > 2. Forced link configurations can result in incorrectly mapping on media type > (i.e. forcing optical link modes on copper media) > > Add the media type ICE_MEDIA_NONE. As part of this patch add the new PHY type > bits needed for 200G architecture. > > Signed-off-by: Paul Greenwalt Signed-off-by: Alice > Michael > Signed-off-by: Ian Stokes > --- Nit: beware malformed sign-offs. No worries if any slip through, I can fix on apply of V3. Also, for any patches with titles starting "fix", consider if suitable for backport and CC stable if appropriate. [If not for backport, perhaps "fix" is not the best verb to use in title?] /Bruce