From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF64A454AB; Thu, 20 Jun 2024 17:41:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8B36427A9; Thu, 20 Jun 2024 17:41:48 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id C2E474064F for ; Thu, 20 Jun 2024 17:41:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718898108; x=1750434108; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Ot/sfxB/gHWHvhJjFq78vnYPBh191K3yTe9NMuhEWhg=; b=I0ELjlwXRFPz4TtisiZ34eVymFfXByIdg3G4eXpIYrbQU9O3xR4BnrL7 r9nXRK5NQZogrx8nNRdeI6rSa5G91cSgbZ0IYwYLM3sOe/O1bggEB2wx3 tAYODn9mNiWXR6f5HAKc/k1f7//pJXo+FWS0UGN/+2Zed0ZwKMEB9aJ/h omjwqAnGdm3G+aKQYNvruTvkqP6QVJlOJObCcSF3n85vUVO1spYF8Qg6R xgDyElkVScQPL4rnSi9x9DbibgiP7ieG6Ylkp3uIYOyV5F725DbhliwVP 2XDVHtJWobEXUZ8LeO2ytWiE1RLZmdv1olZgEs+IqRHNW3Vrv9Ru/2LNU g==; X-CSE-ConnectionGUID: QIGt1BhgQ+ywab/pECPnJw== X-CSE-MsgGUID: MyOrx9+5SK6Ifj49Y0dZAA== X-IronPort-AV: E=McAfee;i="6700,10204,11109"; a="16006147" X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="16006147" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 08:41:47 -0700 X-CSE-ConnectionGUID: 1NoH0OVsSb+cVCNlfbGvbA== X-CSE-MsgGUID: SsXOMTRDRZSguifYV9efSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,252,1712646000"; d="scan'208";a="42394805" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Jun 2024 08:41:46 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 20 Jun 2024 08:41:46 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 20 Jun 2024 08:41:45 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 20 Jun 2024 08:41:45 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 20 Jun 2024 08:41:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QQznZg7hTUrIztiGliOoGx0W4bsFkuBIyp1oeAIvjdz2Z/1bfVvtb/sjr5G+Yp30VA5WlSxtK+lyRgTqcxzJhqujJn1fxInaSorwfiIlTa225W81+RHLmeFlKfwluYJYcOalS0whtQjFykxfIfPfqrjx1azjYP71oHd5R1FkLzuBE8CTaI1FDaxPKF4x2VTSjrpTtRewwpNuA1r2CaMhMa0gFZ3FA0JiwellmBqG7orhsW1DixEa282jrhzggJVkUHr28IAd9UEfN79/G/zjSl8F69QAoOlp/hG3OgM+NekpT162on2cSA7pUDLsVkpNpzyoEZOMGCdSl53uVWJdAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=88ah9e+onWAuCWAwGCmMk5nWcHTWfK7b1r7ehE56ago=; b=Nw4l+DZ7CC0Wv8WhSwmnKMIWecL+TujNnUYx2gjNtogVvNusuKTnMSJ2b408xIzDCV6hy4OJIcoi4vNqpbwV9lMmgfZonSDHsDHG/vVtZKoFCshMvbce2jpROOrgATN31qlfqCrL5oPRazt+gdJ+of35DA6KG/rRHLYme0kKfriPrhHolgbcNIi+ALw1yhdaCas05KiNraTcEP0L5GIpPHizKAfdwr3YRYRiy9xseCDzaahIVtEfRIS5zmGii0KxiMmYPX9f2sh19XLl6HMYcA7WecptohX1fOkOb2/RwLhS7fA2UkcQskM1LNqEsz7nXACLmdOzmzT6HAdARbqvlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB6127.namprd11.prod.outlook.com (2603:10b6:8:9d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Thu, 20 Jun 2024 15:41:44 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.017; Thu, 20 Jun 2024 15:41:43 +0000 Date: Thu, 20 Jun 2024 16:41:38 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes , Dan Nowlin Subject: Re: [PATCH v2 093/148] net/ice/base: allow different FW API versions based on MAC type Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> <893ccdcefc040c09c9f7fcca6194b34a8cbe4770.1718204529.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <893ccdcefc040c09c9f7fcca6194b34a8cbe4770.1718204529.git.anatoly.burakov@intel.com> X-ClientProxiedBy: BYAPR02CA0072.namprd02.prod.outlook.com (2603:10b6:a03:54::49) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB6127:EE_ X-MS-Office365-Filtering-Correlation-Id: d6a82e81-c65b-476c-89ae-08dc913f7c63 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|1800799021|366013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7iUiUeSUQ8xr+uziBFkMXpKMxu6zYIOQNy6+t/EYB1aomDOMNtFHRZ4+9WrT?= =?us-ascii?Q?U8VW/1cF1p4wMZ/XkdzVCa2vcV6pkMKoaPS/NNiKr2zf71krk3U/5X1VxQJh?= =?us-ascii?Q?3NM7qRCzhhp+LyqyxYLlJnMP19v6IniY9GxBmHzl6q4bLMYAQWy9Dx0Fui2K?= =?us-ascii?Q?w89FdXHmEizvRVIiMmGhQ87f/elXSdvXYnEDVAZ2l8Xg9QQiMs9/RMUb87T0?= =?us-ascii?Q?EcoqF+TGiyb5Q9URkxL0nEKFW+WxT/1i5mj2pVpTJuNeMnrtPOiXMyedWzqW?= =?us-ascii?Q?Cyt/1FxSLilZPG+Ks5g9hw+62Il6l3yqmMRMNuQVuQZ4gTZiQ1EwHNTtGJeE?= =?us-ascii?Q?q6RXJLyYYXtp/FdOT/vBDfdmwi8tgiUWRT5UrheObGTVHu5ChbEP47h4ukjJ?= =?us-ascii?Q?mkdE9/VH++CKF/JKMfepl/kx2+CxrSJbhx1JuhmjpuG0VWoymBKDz6vu3zow?= =?us-ascii?Q?LSHg+KzY+CPyDCOGuxG8Tj5K0vUAsc2X6qeaaEoz/NHW3Rxp8TH/nqddGicC?= =?us-ascii?Q?LcZRsvw0J1dkygc+xaG/0/zuOEXtAGSmW9QcP+g1sjHpGehDxmJLv8DnZDPz?= =?us-ascii?Q?YlrJoWKXk/8KPcFwvOgXrKp1TNyvDSEUb1W6CQMYDW7oJMlhrHH/ey3atQKF?= =?us-ascii?Q?W/hB9W/eLOegYjREIO0RLDCGClPE/vkuzrH3HQJxAx0ruKFmtLyU+C1vtASX?= =?us-ascii?Q?HLtCdjTcWRA7Dx+DuaBleqwjKRN+UClN3iJsIEPchUa1Rg4d6lRY49V6ADs9?= =?us-ascii?Q?WhyZoXJLiwJmgCQDRnpgEr3xs91EYELpUUDOLaz00L3cQ/L6IY98xIki3ueU?= =?us-ascii?Q?ikvEQidDFrT1tCWn1cvq1l0ugwu3vBxq+1w2lgybBmh2pNSylUhlicL3D3cf?= =?us-ascii?Q?5LaAdqOC2q52cPn0CYcHZlLGXWjo/QKZUhyC679tYrCBqihRJH4koErMe7du?= =?us-ascii?Q?9bCT7ZmBU3vSQYk433y+fQ5TABcWD0ZnFTa0eN1oxnsi+BEqmayBpi+QJD2I?= =?us-ascii?Q?zUEPBsUGVei7HQzw0U4Tw5viyvOsGrngQXyMvNln+HVAk+lpJr0a/hx+gvZ7?= =?us-ascii?Q?NcOfXIojQE+1U328B6Z8mgwcvPPtQz1Wg8HKAZGEyU4KZOeb3iK0i7QAb9um?= =?us-ascii?Q?hJ15kTN6n7ZM5NnCWgj6WZOvzcJdOXJ2G6EXSi44e9aCp0cRmi7FeoybmF4t?= =?us-ascii?Q?vuud4zVkZBOKkCCi3XyYWUHDmhoQ1d1/S46esTg9xZRXPT5bgBft5RQbh2bj?= =?us-ascii?Q?nVd+IlJt5z81eBQYiyeaWdHGZvjZlbv/uhVn5YEeVtdztgIRla6+foyqyLVc?= =?us-ascii?Q?+Fw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(376011)(1800799021)(366013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mF7bk3GNt+w9ArCMYem4wDLt7bVvcxSDsuRQHYTrkyb9TZG/bLHPAjlpNI9z?= =?us-ascii?Q?i5aBJpsU21D9guFwHqVhYY/A33AjaanJBw+l4rlV+FNKcIBVqG1BK+2j6IZZ?= =?us-ascii?Q?txPAHLRPQPBbR9xqzTpM91mxXwuAgejw89gxM87C/Peq7chwCmx6Ntz4PNsO?= =?us-ascii?Q?6q3+T2qg1LojJTe2ir4mXrd+NFR9n1XEKDqCS3Fj4w2KvIe+w4N3NuPt+fI5?= =?us-ascii?Q?4Fh/a169H2A8C6Du1cRj50NkKHS6DxAI3VRnVw7lbQ/Us+xNeHuxyqYdbs7V?= =?us-ascii?Q?kx0I4krR3Sj/hj1dOGD0LnusAZkTtm4jXHnpDykGDS6TxBT1hzkzecJehaPm?= =?us-ascii?Q?Xamp3b0GjXDvQgDitpLxetKqlqhZoMfYnNWWbHxzGyDgawGe22SWaCbSCgQR?= =?us-ascii?Q?xBSpTuDPbOBXG3AdtgDOc7MUO4XXEGLPzWP2GMjfvOcnnYw1gK0Gy4GW0FzN?= =?us-ascii?Q?EgLlT6jQ58lH+mKgVWygRDGZB2zo6tW7PNLSABCQx9wJt/LOSSZ1ZZe/KPjf?= =?us-ascii?Q?70/2DRJdXn9Pv1QlGJGsstGVaveOtyAd+GzfFhVknFzIAeNVYEiPuLHugz/X?= =?us-ascii?Q?wP6qI+buuvCDiuTAfbMZVXp9K/966GTa7vPIBCUcUU4hPOCfQVxWUytfd/OT?= =?us-ascii?Q?VNnhrbvB0cybt+He7WjvWmZ6AKZEYTAo5R/ZV1Rny9Auwhe0PTNx1cDoOUh4?= =?us-ascii?Q?Ej3CgVobz8t3ZjBCu594KBGIK3bAAWOO0uQ2+bNjVY7i3OdWuVWfDuiwMWUh?= =?us-ascii?Q?UHa3XNnnuaXpkdgzMwdQ7haEiRw8Ue1QsWzM0shNj0J16pXrSs8WaoITDD1L?= =?us-ascii?Q?OLJimWBPcNNErnAia4cL9fLkbNoaqxcXuH6+BL8uht7UpgWDiom3OPQ533EL?= =?us-ascii?Q?opmt8azZr2L7t9yAm8GPJ0b5dcLGVHWfEBVvvnk9wZEYoe0UYpMTFm0+QcMq?= =?us-ascii?Q?mX1q52jGBWcIHaQ+0agfBG23i/Q5Sc7FHNloRatjs4Dyj3L8BmTr8XO71NjP?= =?us-ascii?Q?ygcW9iUCFuM07z47hQ72NhtgZsM6ueDyDu4ifTBCvmrwGMnJn3MgZejaxMit?= =?us-ascii?Q?vvMzdO//btilhv4kNfUs4F4kVVnIozHYNopu0Kbd9Klx+6b8jP83beOLwjFD?= =?us-ascii?Q?3lWLlMzU1zt3BC1yZDeA4lZER69xMMlb6fLgBgnOJ5740HzXYCnkHtEToaH+?= =?us-ascii?Q?36sktBwxDoM4nHNOcsNdnen6gImNuAWvPRcDZ3C1P8d/knlxlq9fE/MLEQ/h?= =?us-ascii?Q?ywU/yJwCfJIKweF9yu9YCKPfXj2yFiK7veuVfbM+6EJMHp+IAgD+1gXIBLer?= =?us-ascii?Q?P7zkbEfszSZCXL+SM63eNdFRSKF+IJhvxnVUzmNMLgf+js6oWEoxQwiE9oZC?= =?us-ascii?Q?kSM/+DaXF83MihITdiDIUJP7FSluY7eNFybBClYfYs0bsqvVzaO9mEWfqxkf?= =?us-ascii?Q?YFKFOcms1p3XYmL+EwI0ZGa0Ty5ucryg7nKmdRbYcakBJ5EtHg4mgbVqcikn?= =?us-ascii?Q?Bfd0aQTM56KlH9HRWpa4p7lj0kJMtPTi93e2n4n8ciE655Q9svc03vQ2RjDv?= =?us-ascii?Q?AVyTDuJCgSa078A8r36o7Xdh6l2SdpwbOYEtZRM9jr5JbxTJukhsQB3iSBK3?= =?us-ascii?Q?Cg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d6a82e81-c65b-476c-89ae-08dc913f7c63 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2024 15:41:43.8484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nCNb3g5BjHz31Pp5cLaSX4cI/WDflq0zuj0KARrartjAlgGrUvObRGBoZsrsw5pJMroTdz3MJ1cs4AkN7UuEfgKc1ZGaAnEe7SSw70a7YOA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6127 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:01:27PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Allow the driver to be compatible with different FW API versions based > on the device's MAC type. Currently, E810 is only compatible with one > FW API version. Now the driver can be compatible with different FW API > versions for both E810 and E830. > > Signed-off-by: Dan Nowlin > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_controlq.c | 17 ++++++++++------- > drivers/net/ice/base/ice_controlq.h | 22 +++++++++++++++++++--- > 2 files changed, 29 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ice/base/ice_controlq.c b/drivers/net/ice/base/ice_controlq.c > index c2cf747b65..edc068481e 100644 > --- a/drivers/net/ice/base/ice_controlq.c > +++ b/drivers/net/ice/base/ice_controlq.c > @@ -479,24 +479,27 @@ ice_shutdown_sq(struct ice_hw *hw, struct ice_ctl_q_info *cq) > */ > static bool ice_aq_ver_check(struct ice_hw *hw) > { > - if (hw->api_maj_ver > EXP_FW_API_VER_MAJOR) { > + u8 exp_fw_api_ver_major = EXP_FW_API_VER_MAJOR_BY_MAC(hw); > + u8 exp_fw_api_ver_minor = EXP_FW_API_VER_MINOR_BY_MAC(hw); > + > +if (hw->api_maj_ver > exp_fw_api_ver_major) { Let's fix the indentation on this line.