From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9260454B7; Fri, 21 Jun 2024 16:00:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F1424026A; Fri, 21 Jun 2024 16:00:55 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mails.dpdk.org (Postfix) with ESMTP id 3B55540265 for ; Fri, 21 Jun 2024 16:00:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718978454; x=1750514454; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=2L+v63jlWZQ5lEaPlrcExjLFGYZxNwPmdUF5UcLm3EQ=; b=azlkns3QvRr9MmzHo/3RrLJTdMgVaE2lqHFGt52DY/XxOPTkR+11Ce1h oHnw4XcvKX5jFzYk9BwnSqD6MG9xaIfnJU1J3FJdFhj4tr8MofmxXRlQ2 rWQ4finppLctiv416jFf0jzTKSmEPwuSQewRHGUsfGmdzFuYya8G3U14p BQbg28JEWeMxMsfnf8BtoNP+L5roHsrwPtb6qklfuzXaKspQRZLmTVYiT FjEOhgPyv1colycaSkhfaOFMsmuzfAiacLcltZRn1trSVkIKcCaZtJsFE 1lbuCUw5m0aTpXUUcpwLLovwsjeLpitfLbiGCi+B6DLqh+CSeoMpjDygS Q==; X-CSE-ConnectionGUID: iF0jMEAjTIa2H/L/l7aXgA== X-CSE-MsgGUID: z9iR/zOZTseDRStODdTr2A== X-IronPort-AV: E=McAfee;i="6700,10204,11110"; a="16245040" X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="16245040" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 07:00:40 -0700 X-CSE-ConnectionGUID: LrpfPRuhR4q/cwNOIr5wJA== X-CSE-MsgGUID: fccYYDwvQjukr3+ZZwkxcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="43269408" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Jun 2024 07:00:40 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 07:00:39 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 07:00:39 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 21 Jun 2024 07:00:39 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 21 Jun 2024 07:00:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lmlN5GPZFfzic1qO6Ju+o4nkqEFasNt+vAGbQpaul423tBL0QO75YM3TWIccFVOP05eteuX9ysUjcSfKv8sP9QHeyv2TI6yKNq/doCpdkM6qhNRiRNbp57NdKbp/8Ul3E3dzqOybhkvjd5HBeHOBlidHInmIqyMJDvvxJcw+fQdiPWgH91rk3zrfTPD9qm9RcjZrIWVEKmkB6aqw8e8ivQPBR1uS8XSPH40Ro8O95J50zEjDfnkaJEGQ99Rz2cGDie7Ij4ozFZhCK2x/FWweRb9m74WG0YzggLjQLJWeErZzGYYB0jWQe6Fn81YgirE/HjfjY7d55CKU/75k473yXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GeOBv3AwSkT/RtGVmh46oBNYDJ23dH4FUOrSdvCagmI=; b=C2EdABYRvyzQVD7zEF1Wpfhe7MjOyzXcqJ41KG9iyEXwEBBCxvbizq+xqv8O7q63Uv6KsU4C2CB4vDIQln5DzoKT4iOnQcpJFWFZcWorvAQy4Yq1ZutLUIsKzQ5zxgrrJESgosGIOc7aSIMZOBKFbHETkzQRV+E1J5fp7gWHwWsy/5rxfEadP9L+i8j+QxI3Kd8+HOfFFcL553JcV4/hl+YXPryW1kirKob2u8jqxKNQ3EOlgtJK5jAiN36EgnWDgFRYROulSmBaWf8exmrmcqcYZWaKXkz+A9MStP8f0YMU0TblACaDq9qR0IyhHgWusGqxuvIeoN7mFwOHL4KR+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7065.namprd11.prod.outlook.com (2603:10b6:806:298::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.19; Fri, 21 Jun 2024 14:00:37 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.023; Fri, 21 Jun 2024 14:00:36 +0000 Date: Fri, 21 Jun 2024 15:00:31 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Subject: Re: [PATCH v2 124/148] net/ice/base: use const char* array for storing link modes Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BYAPR02CA0029.namprd02.prod.outlook.com (2603:10b6:a02:ee::42) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7065:EE_ X-MS-Office365-Filtering-Correlation-Id: 61a4f4d2-0047-48d8-6bad-08dc91fa8692 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|1800799021|366013|376011; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kAB509vq4tkAOFWvqBucEMq7mtJRfhnqd4zoWU0pPatQ2LKfFFSIuIv/6B5V?= =?us-ascii?Q?QAYot4lomyyU8yBh443afDc3vHfvtIRVthIZFD895fDms1mhmekrLLV9LLhG?= =?us-ascii?Q?pHnk8oyEw66l0Qy5kpe++K6ldIg0fD6zW2NjMpw4sGN88JcAFx4tGMjlSZzl?= =?us-ascii?Q?KEbzXkE2VYH+cQaxbiYY9QGQa8THJ6T6iVOb06mxF999w1K1tShzRCaWVz5c?= =?us-ascii?Q?IIoHA1UGAZqXDc8jE8h3ObWA/9m69F9M/6mYrGLhv1uet1G/IOL+/jU76ca2?= =?us-ascii?Q?dMG3gxaK4qUB3xRXz791bzz7RwGt85P4Lj9bvDZjS6YB0JGf9wlbqIQxM2Td?= =?us-ascii?Q?LcFXu9M19fjd8GSeDiWsUtprMeHjXa9F+8ZQAlTWMWRqo7HWZ5RPm0+VKTw3?= =?us-ascii?Q?yv8CCeY5yRFwt1HiS8MYs7/FKgx/yIIVvxrD40wVyXX1jPubNV46BKYjIodz?= =?us-ascii?Q?c/WOj+lvMmpwlxjemzUXGyS7hghP6Opk3xdiKQBnsOQ6bCX5/vnxaDEahBaI?= =?us-ascii?Q?19blB4pk2JK5sJdbrVCJYC6Igp6Sy5Ca8fpP1hAVbrF8/fT7G6CFW09NetGO?= =?us-ascii?Q?DGAMJx2/CJ/XoCFfziC724tHYehgTmRpuq+8Ob4FjKCsWORbbCRI41Pl3EWB?= =?us-ascii?Q?Yl8HInb9Wpj0X7fGbjvbxbo69KZNahkYxvxpAWgnYN7oV6wptTRLtJtTh2Yj?= =?us-ascii?Q?wpDSD6+DXbvPAszwkYhr+/F/FcZy8vWgCGfHOxeXpYTfQg4z3krCT9Ze/wFs?= =?us-ascii?Q?L3D72hq0xj4q3Zv3oLVq7twnUdK/SDlb0uv5FYvMhXR4aCGtqNDxENUq8InC?= =?us-ascii?Q?rdK8OrBRF1Q6oMw8OqqwsUriYZJE9Z0TtqB62aExVoyMkgbkF1Dmr/oEHL1Z?= =?us-ascii?Q?W1jJCe9MwjSHDYvRaYFCULUFzV5+NMOIp+3XJj1rZzoTWS8AnNm+Vg5MkNqE?= =?us-ascii?Q?yymVX29UMzOJisiOfH8K3tPv4zxfk5dt/MJjXcTxuZMRd+jHfjlNzxPkc8tX?= =?us-ascii?Q?DiPQQrLzrEEX33gFQqFb5dluIxuICY3uJhvINbhShZPoN7h1KYI/2rHAIZvc?= =?us-ascii?Q?2I+2KvsosqnLe5wEJm9cWc2FrIBlQikJ9AzTUWPS4SJa6YUV7wU0xmd+xmr2?= =?us-ascii?Q?TF+YrWk4eKLg9AQShIn5gWM7jKZHl1it2tUjQDMZ4ztF+zhHbHx0HeOs3aii?= =?us-ascii?Q?NU9BFEIkeAi8fAyabtlUJChT+lweEZCvFKE3rtL5kmP6qzSw9o1cHMYG1VtY?= =?us-ascii?Q?kseJ/ZhvaZcfmLcUVvRGrj4JkDt5mLdRo+xYg3jndNhsU2bBlXt1PjgroPY/?= =?us-ascii?Q?xoVffT9oYhbT8u4iuhJ/R40L?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(1800799021)(366013)(376011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jLWC545MXbPAXIAuqAYKhsGzHTyyykppGGxu720iRU0PD1OiouGeckfxuSXv?= =?us-ascii?Q?CAlZ5PlMFpiaAyRd/L79KIGN9ql9E2pNt1UIcN3BUh92igdr6i8MQcoc6g40?= =?us-ascii?Q?WgJ2rsxOm8VAceEQPNafI1UZLpBRrULezZCz3v6bxxl+5PD+LYgjEeusnogY?= =?us-ascii?Q?G0/Z80LBOWuPZUIz2Qbw6rFmBn5U5DTgO8FAd88p092ypVuNEG/L3bGS/w2U?= =?us-ascii?Q?I6cJyeIDwPHJsi2gn46D9Tw/H0Dv7EuZzZBE1JMNRzBF1aIZsRU08VYEM1Ht?= =?us-ascii?Q?OvJM/udZu1goeJLCIAS6zEAF/dh6OHb3vtN7k4/7CdclVj2oThx8nMZOoQXJ?= =?us-ascii?Q?AS9giICvD132n1u5sz0EG9uAYJcUW+0m6LaEh539nc1F7le4Q3EG+J9B1WdU?= =?us-ascii?Q?n2I3ztVXX+rcMqLApXSDtHM3/SwCZxDYsoJBgyRDzRN8ue9FzKzPjwROXrnh?= =?us-ascii?Q?g5SzvYP25vmk2bGwFtk2dAxE4j0j+VaSfH+s9bLufacDzwgM6vxsSaky+B1I?= =?us-ascii?Q?/cWpyf9ljCchwBsn/gSsG5i/0N8bVSEvSwl8c7iribkrAvhXuy22yfYGzOMh?= =?us-ascii?Q?5XKxsBK0GuoEAqjZ3T4P7ripwa6RaH+UnbRTY9UXiajIgFQOuJxjvlVoab/4?= =?us-ascii?Q?STGydXaV8Wgp3XcxazPNjIa5Ta/ENo1KEWjPTYw764chy0n2HozuccoZN4K6?= =?us-ascii?Q?WwRJ9UoKKxMHqc1ajqO2VOArM3b7GCoo/7S5SuXOUeblQNu2MD8skn6IhDn7?= =?us-ascii?Q?7ewJskUkT7a3xh3a++qBAxpjlBMVwS8FBpfIyaWQVFKxOqpVEVvPyMjkpsB8?= =?us-ascii?Q?z6P+Nk0sU9/nfBF1RlvrayIUrfeOhu3GHVVa4Gl1uU+jj/IAwv8cxzv2VPRH?= =?us-ascii?Q?eYbjCKBWN9mW1s08qJxRVzlhu6gDSJkHFoAiB+ctt7QLPHcWKhpOg1r8ePlu?= =?us-ascii?Q?7bX5EaKjSwpfN81cngb790RcWbtM5PbJhFV3YAXnFIcQNEIMXS7IYSTizbuf?= =?us-ascii?Q?DRY1+HxZLdWUjqPZHMlH/xaeTSnpvL0D0HOhR0BgjN3o/vzxItS/vs66Ygm5?= =?us-ascii?Q?cCrOXppTaIhJrCQMdz3RvZ59imALuJyWxl8KjIMD9aWnOIZwUAkIcJ9vJz2i?= =?us-ascii?Q?3ez2Sy0IB38s4uE4wAR9N5kkH6Texm/wLmc4zTJAWd3BnvKSHemhLefK5u16?= =?us-ascii?Q?Rd+wkw0Og+Z61W3jNOImDuulVv6/8ya8o6n95S0I64YgCA4Ne7Wl/NHXd16w?= =?us-ascii?Q?vxQdpxD4k/sgv4OzU0XlGdea3oHuVaxZopzMdUQCiI92Cz4he1NgQuB2upi2?= =?us-ascii?Q?yPg1i+P0ODwA2b4B/Cm9s/7z/ETXmfkVgwtOfO5EVMK2eqJk/fQvvSGEqhpP?= =?us-ascii?Q?xQqInl1tpFfQ91DHyUZsvo72bEEf/mEl+gCYzgek4Plm2/vTbtIwy/iZY5GB?= =?us-ascii?Q?qDqZ6ZcH6EQumkUkAny/y3llvEhSN6iQ7RZpiMLgv7roKChKeGA5S3kRe+SD?= =?us-ascii?Q?63wSu1DlzMw/NofoR6uxGu0DoVAB3hBsaDnkYIsCfqAD4Z9vwgSi0/erXrLA?= =?us-ascii?Q?YvJT7YZF0KPOd6tg3Dx2M/cvxNc6+tlZ6gSvar0UFkV9kXXmg9Up41kI8hem?= =?us-ascii?Q?4A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 61a4f4d2-0047-48d8-6bad-08dc91fa8692 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 14:00:36.7775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WpH4Kj181reGqEVesJATVrlYErBxVXmfZbZGoh0JmkXVmBLJiKQOndUzk8qHx/f8uKVWzfY7hdHZOFRRid4dQcZ4EgdWY2kEW0PQOKXntxU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7065 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:01:58PM +0100, Anatoly Burakov wrote: > This shortens the amount of code needed to do the same thing. > > Signed-off-by: Lukasz Plachno > Signed-off-by: Anatoly Burakov > --- > drivers/net/ice/base/ice_common.c | 133 +++++++----------------------- > 1 file changed, 28 insertions(+), 105 deletions(-) > I think this patch can be squashed with patch 116. /Bruce