From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33A9E454B8; Fri, 21 Jun 2024 16:49:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 107D442E82; Fri, 21 Jun 2024 16:49:30 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id E44DC40265 for ; Fri, 21 Jun 2024 16:49:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718981362; x=1750517362; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=H9Q3AgWcZtHlXMBmyIec1Ve/QGNWbkzK5wBtQAQ+klY=; b=R1xH+7MGERv8mZDHFo60J6Magy0aEVzQujM8qn0lF2pgOo1dxl6Um26f T8SQbv5GDGio785jWDaP/BJXsnhGti2XwbgcD59YP338z3Sz9NsFUtuTY 4lLy7MZsaYY+fotBw+JuuuYrHBcgt51+gZBe2A+b2j2VXetyaiNxrrgYh x3RklGtpTbo2h62RxhnSsZmwEO6irxMd2O9xIOVY+MNkwFLeOuEzj5toE c2JBn/ATEvPiNTT5xkdk50GphnBKafpGwxJoLeIvoY3beyKig+lwzWDWf el4INUrnhY6NKnkVlA5B4PKwg7R9cZMHR6rCieSL8PYn3rc/WB0i7lqUu g==; X-CSE-ConnectionGUID: kcWbzjzVQc+GbiAUAbIR0g== X-CSE-MsgGUID: 0PpT5aW2QvqNmh5uJfTmSg== X-IronPort-AV: E=McAfee;i="6700,10204,11110"; a="27422936" X-IronPort-AV: E=Sophos;i="6.08,255,1712646000"; d="scan'208";a="27422936" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 07:49:21 -0700 X-CSE-ConnectionGUID: fO8jIRK1T6myBdv2qAGfjw== X-CSE-MsgGUID: WahPnLz/TvGB70+y/YUA0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,255,1712646000"; d="scan'208";a="43055081" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Jun 2024 07:49:21 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 07:49:20 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 07:49:20 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 21 Jun 2024 07:49:20 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 21 Jun 2024 07:49:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h0nUUATWaYn7GOY88o3kGo6imjOuUBBerksmhPMaRf7KZInOUezKvlYe8zl+oo6nuG5pgGpb7SuqXK3FEvWhBMa8SI9kaAnZhI8JIJpoHMehHwLbL/7hEuWIEC8gucIOkGZsnW2T08n7R6F1l8PWFSuUeE/fBsc4Pp93TsP1bLAzCmPagcg7YHYWHoweXq9OTjRc2Up/ELWlJfZrHFymUU6ANbzo3KixJ43cj7rbIBVFZ2FZOsUQuKH7EkQAEZjsOXNYT4dzhs8RehZ5n64T35W3N6yeWIh1FagNRjDO/kcJGnwcGZjxXgMKS3amzJ/D8S6oQ6ZyJg/4EEVg6/MtCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xwD9s/sQoMY5nT5oC/CcswzRgmUa6MCEsKluOVPRnwo=; b=NA2a5H050xSJQgl8Cno2N4bU1y1wD+osfC8ZBac4fakjWr4w1Du7J2V4WRZt8/h4Vrs5WgMQ90+1T/3sOeMHjmWJa01sjL/ezvC8QrL2DO+mbey7F8VkPt9DsRUmk9zPKD2FYXP4UwcPPcRNBv8kyvedEau50iD/1WN62PxzLq0KXQmIQsEzRdzulmfvu9zrGCGYhOE88HlUAAUh5g8LlQ/hKTS5vGjnITe04l8iytW++F1JFqsoH3giJ+Z51A08kq8PdeN3BZGq6kB7/viu0nxdwYKluEHfChtdmAbY9Co/C9mNvxcyESN2Sj8/1GWUA42BHVRib0oZr1Nrwhl6dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB5017.namprd11.prod.outlook.com (2603:10b6:806:11e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.19; Fri, 21 Jun 2024 14:49:17 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7698.023; Fri, 21 Jun 2024 14:49:17 +0000 Date: Fri, 21 Jun 2024 15:49:12 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Ian Stokes Subject: Re: [PATCH v2 137/148] net/ice/base: support DCF query port ETS adminq Message-ID: References: <20240430154014.1026-1-ian.stokes@intel.com> <0c6f3f7cafed8268037cec33e1eb50c4d8986131.1718204529.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0c6f3f7cafed8268037cec33e1eb50c4d8986131.1718204529.git.anatoly.burakov@intel.com> X-ClientProxiedBy: SJ0PR05CA0144.namprd05.prod.outlook.com (2603:10b6:a03:33d::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB5017:EE_ X-MS-Office365-Filtering-Correlation-Id: 493ed089-53b6-41ed-3803-08dc920153a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|1800799021|366013|376011; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+LAonTcP7V/U3YUrHZPGpsEPPkzlT5Y6sjZFaXc6FtnxtEhJ5o3Pln8/E0ZH?= =?us-ascii?Q?rKzqmhY3Vg+FsyX4PYyT3pNQWnZw6jvIgo6XMBXnvnWcPABifLfy253RLxKg?= =?us-ascii?Q?RhN8Afa45H4nUtVbXlb4+/PXWmVAAbn2llPZ1BStKFL/HBa4Qzm3zakmvamt?= =?us-ascii?Q?MIvDGVhaIOa+A20XVhoMAOv6M0FviZfpCiXuzrlGT7PJklQW3UN0846K4WOp?= =?us-ascii?Q?3zDGjU71zyOLnrqQuT55sNrQQbNwl5JvAaJWtctg2XgX2Ys+qTgjckYBrEK0?= =?us-ascii?Q?6sJDwqbMq7ePC+g1rXd5GSNgVajXJkhwaRHpMdwJFNHf+K4SjKQh1P75vlVs?= =?us-ascii?Q?eZjbGA1eCbdI19z9ZMbW7ILBSsRtzse5Iz0xfcwIzkcauKOztnbJiVmNJbIz?= =?us-ascii?Q?T1iwTSLOMH0aKNtOGKL3tlrqK+YWZCx8HzmdKCh0rYYA5J6DbLbvx14UsvSR?= =?us-ascii?Q?0111jusoTiSYqqNA3RZfe4WYqEt+okb1tfEIjNT5pWkhF/xrJpAAws3Nn+lI?= =?us-ascii?Q?D3aeJBOLvsGFThIOQvy+aXvJLtXFjxsQZl9GU+c+4Oj3lDLUlRfAfZjmqJTY?= =?us-ascii?Q?gRu6jyb+rYMyLSPs7GcRqDIfPdu6e7irnAxVuCXhE0hAOUWwJshFWCwkJ4Ng?= =?us-ascii?Q?67bqxjFVEaJFCQxz/ZU5ZiWU5h2+OH7h1b643PvFktuY6keMDJi+wLZTitkG?= =?us-ascii?Q?LYM9NviHjFrH8nXNaI5JQmgAcaXRFTIXm0BdhS+bP1FeDojSSrWtkIHdhRfT?= =?us-ascii?Q?ijtHesAjSqJN4G326B97+XLxPxOhsyax35K1WeFq+Q80KmPJSyWNIn/ZO4s8?= =?us-ascii?Q?/TVgip84CKGkruAvJheTa+xdxGi2CW16/gCbu0fnI1SvTa6DJZTrKcwabT6p?= =?us-ascii?Q?cwujiqoo9C0IsTZnszMli/mrP589QMPGE+J/02S/++VCqYY/toETBFDgTk3j?= =?us-ascii?Q?x86Q5/XCk8lVwadr5N1yDe1/IM0IJy4gMggwl0oiN3RX3ujqw0Gg4IRq5P2m?= =?us-ascii?Q?BDmLxeUyfHYpTsTvn/rpWZptAzdfnk1n92ReZuxbq3WifUrnlgr2ip6dPmSg?= =?us-ascii?Q?EYm6WdVLJn1Msbus2eHYtvU72F7NoJ7DEMi6tMKQLpWqMRHSHuTHZOfcTx2i?= =?us-ascii?Q?Pt+Qs050RfdI9Yrthv6G5md4ogGQPwg3Yiy+JTgrvJnx2qGgi1BYkrhGedVx?= =?us-ascii?Q?ifwHKbs6r5eslInXrnoR1Kzlgd9s+OPC6l0hPdefBlFZwg89B8e6Yd5s7vGG?= =?us-ascii?Q?l65n7hCTPuB2r+1ZkL7gncS++ZZSM+32MmiuVPjImUJsQbZc7Azwf6QlyFB0?= =?us-ascii?Q?9Nn3Z11HH1yhDYHEWukDLl+m?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(1800799021)(366013)(376011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z6ST8pybIiKQXDcwOgRKoMB1F92N9mdsTefDhhQAu6uA17CRJy8xUWo1xzq2?= =?us-ascii?Q?ZHOkwFGNJTSZQ+KBekD+cEIfbOWUXaqt0n9aKhre65hoALpngcRZLeuMt0v1?= =?us-ascii?Q?gv846tsW3czMXW/PjMPoxv2CyRQ3fpPtQoiQE3L77AIi1A2RdLI2TPa0RwyP?= =?us-ascii?Q?Cw/VmXpIuqFerp5+4+pM+66Zs7wzekEye7hkSNBWCjO09n6LNhj/9VkG0KIU?= =?us-ascii?Q?605sQSfPrpRFrccVHjT5ZiObSghz7PPIVtf8fI0Vyc6fLb6atgDtTwtBZ7tP?= =?us-ascii?Q?5xaVWrWWy/yI3RrUcuuIDZiBYZGWhNuogt+km48ajfG0FSr0SNdAVScv2g/0?= =?us-ascii?Q?BN7BmYaInZzQ78XszKKW/YGOxK49B2EpyCnqDd7O0/HZjykX0Fo8SD5BvaIo?= =?us-ascii?Q?dCvJ5bHd+QDr63bOQ5L2u22XS2a87OnHfhrbkB/uzu9181xcGvEKyzYoaSD7?= =?us-ascii?Q?bvHdsyVmrFqhOYNp3meTA3IU/XCnlxxArevqttSGWlLhlzsS9x7T7ErpVF8I?= =?us-ascii?Q?yYATAj4xlvrk5g7eTn7/ABakawgBmurQ9aI8YTxGsXspDWG5CXQqPjyAR3c/?= =?us-ascii?Q?SI4hhf3G9+z6juIH/bHy1n5mpSR99Kkzirc4nW5iCFPc/0tsXpQ9c21uhhBr?= =?us-ascii?Q?scGW8A2cgZIAnv+Qhh+cEBPYcrudhrcVi/oZ0GD2I8jvfuo06F9PWSa4wqEt?= =?us-ascii?Q?KlHQGN7gkttxWYbo/hd6RNvQJdUF7GYVh+sVtlpM6+0s/x9ooxpWccJX/vqE?= =?us-ascii?Q?hWV6e8FHRiMRVqPG8PptGCct8XljeivTdJerUkZg5asZGNtJN452GsMkfQEa?= =?us-ascii?Q?4kAWjrDQr8Yk0wO9kpbdDkRxo0XbE+WmCoz87dBpWYMITTaYJNaitSq9lkvj?= =?us-ascii?Q?cbyPTTqrrtSv59tNY+ddCd5JjkmLxvxTRKkjzzCIpAHNaL6OahFdlkjjU1Xm?= =?us-ascii?Q?ixRs746ImcW0ioj2FP57orIAj2kwMqVn67YuMVcSyzmlVNSTm05KGNYiqCMG?= =?us-ascii?Q?MrXGs7B/F9hf8xizExEGg0G91FDuV+y/hw8nYW0tT27vI6wgpBBaEkVz31Fg?= =?us-ascii?Q?L5VsbnfWjFrNY7C1LKROe6HXw43kKHgAObpoT6/5mLtooMBr9O/TaFU/JIxf?= =?us-ascii?Q?v3bI6KfIzDG3oYxTfG1xzJ/KdoOJhF9l4nG7+f1g8FF+z4T/Te2m4XCmHi4E?= =?us-ascii?Q?DKMIiAOfAsnjgpQQK9EYMKskrdzO81cC6/33xijjq+v/Y1N/+QO4bbvYbXSr?= =?us-ascii?Q?TcJmGU4nq8P8iYjMlIzlbiQ+TQOMVRlrhD56v2LUas4PJgc3C1ahvniuIeJh?= =?us-ascii?Q?KthL3IDiJ1o4ePXdIFFkb1uh1EKta94dwLxC+2OemDz5jBUsxc9TFLO7zFQe?= =?us-ascii?Q?ZR+XUbkbfn2EQ0MUv7ppEHOSi6n8MihwF37aMC4PKXqqkAS7JS2q9D+2rc1X?= =?us-ascii?Q?V6rmCFOVj4UWXeu575U0bAxce8yI/bTAk+PEJuvAfQgGTcC/6L7Pa/lS0siE?= =?us-ascii?Q?0JWYJqOnhPQJu3cmsDOIRLMVK6WnB7X2QKn8zuQu5PDUpjgTzXz1hZn+v7uN?= =?us-ascii?Q?VIqb9hIivLIihnLY6WE8qtzX0S80nfo9cNLbci7nxpdinmFagccasN0mkghI?= =?us-ascii?Q?eQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 493ed089-53b6-41ed-3803-08dc920153a7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 14:49:17.9087 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d6vxuPbcHCFGohfeoauqW+NIR/x7c4aDS9Hpd2BCVb90Yub1uNkKXaIvSPkHhLN0Ym5FAVaoMiv2zvWgkZC/a9QPc7D0sPtrsQcjKhqGZ8k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5017 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 12, 2024 at 04:02:11PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > In the adminq command query port ETS function, the root node teid is > needed. However, for DCF, the root node is not initialized at parent HW > init stage, which will cause error when we refer to the variable. In > this patch, we will check whether the root node is available or not first. > If not available in DCF case, after receiving virtchnl message, PF will > add the root node info before sending adminq command to FW. > > Signed-off-by: Ting Xu > Signed-off-by: Ian Stokes > --- Validation has thrown up some issues with this change when used with our DCF driver, so this patch should be dropped from the patchset for 24.07. /Bruce > drivers/net/ice/base/ice_dcb.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ice/base/ice_dcb.c b/drivers/net/ice/base/ice_dcb.c > index 4ef54613b1..81ce11343d 100644 > --- a/drivers/net/ice/base/ice_dcb.c > +++ b/drivers/net/ice/base/ice_dcb.c > @@ -1559,12 +1559,11 @@ ice_aq_query_port_ets(struct ice_port_info *pi, > struct ice_aq_desc desc; > int status; > > - if (!pi) > + if (!pi || !pi->root) > return ICE_ERR_PARAM; > cmd = &desc.params.port_ets; > ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_query_port_ets); > - if (pi->root) > - cmd->port_teid = pi->root->info.node_teid; > + cmd->port_teid = pi->root->info.node_teid; > > status = ice_aq_send_cmd(pi->hw, &desc, buf, buf_size, cd); > return status; > -- > 2.43.0 >