From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06455455E2; Tue, 9 Jul 2024 12:22:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE86F402AF; Tue, 9 Jul 2024 12:22:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id B6C834028B for ; Tue, 9 Jul 2024 12:22:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720520553; x=1752056553; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=i6B8X6s1ktWwFhzrqB+qh8QryL/cLFxF0kVupiYpYr8=; b=GlGC0gMWhiSXmbZlUIMqBWiL6FpIZZcNvRoMPyzJFcYVs4o2cLX0e8CM 2QtIryQ+j+3WiNV6uajNw2VSj9flPYzIOWoSynAnJ+CfGVrSWb7WvsdAb MPomlA9Vyain9t/JLpCh5E41p4yDdJaG8/m1+oe8lw0HkXtD4eJmUfkaC wuKtFZFEgiX/nxHRuOwTXTs6DCptm3B414aT8moDkI9+tRXFJ+1KcejDk IOtkp/OKIu5ePHeqbgVn5MNRtb8P2ASMR6z3W6G3LmArNd6CboL9nZQVc Z69F5uSKeIcwS1o3NS+XeRP68smNjaqC7d0l++py7jipPJZjDYXtgowK9 w==; X-CSE-ConnectionGUID: sfYhz3mRRS+f+J73bZF2ew== X-CSE-MsgGUID: mvCkoB5LSm+rWRvYvzR5zQ== X-IronPort-AV: E=McAfee;i="6700,10204,11127"; a="12449328" X-IronPort-AV: E=Sophos;i="6.09,194,1716274800"; d="scan'208";a="12449328" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2024 03:22:31 -0700 X-CSE-ConnectionGUID: 2l4XIA9QRkCeY6nNN/3bgg== X-CSE-MsgGUID: oz0dFmxPSI60RE9gLKYfBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,194,1716274800"; d="scan'208";a="52214259" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Jul 2024 03:22:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 9 Jul 2024 03:22:31 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 9 Jul 2024 03:22:30 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 9 Jul 2024 03:22:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L7+D7ivUOAdnPKSY/HzThq2wgFhkIZ+lQSxoELyTT6owrRiKmMan4uIvGs7M9zoeQwPJfaFFIA4VqkYX6n9aCL+KJGCqaB0sFz2E5gF4CehYt1bP+pb0Sc+02V8OhF+7C25wFyk8SVSBboB4Uu0F7/tONYfDB1bbJeHvPVnZQjPngQXe6JYMx9PiU4FBmP16++LEq/TOT0mIDbw3+NVExFA13/Rz+ug6OLZ/12iNXMa9ZTz5qsnptE2WC1vizDCerDcIGhm54d5PttUBLpHlm5I+gKRuahKCiBdpDl0EQbM5jni0ybIzvGPBTixSjXRWv8W+hVprEINtxtRecCQNXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9EWk2EmiEoCa/2C3QCmEPDkdwsfwWwpS1tZyzCfHIAs=; b=FeSreULnAZEFFboBi5NCSHbGX30kDwauvgt6gjsDtNLhFpZ/7ST+zGR+Qsoogy+nuomnR3ucsGcxZgCUzEiOFmaZIfq4NN6mu+FowSt4cAfm+ed7PvXCZxyysmr1TIeD0MH2mha7NMcMnPYNI3egGFa6BIRwiBOMvma4fIuvJ4wArPAJ2CCuwUV/rd4ltwf503iYoFI1N0f+vDQqYPCQKs+bCDht7eIFCRR4DA6f8QM7EWfFAQZ/3DEtXJIcRk7JJuin9HJ7qNt8oplG95M94E4ASzcIIEDcUBFx9tqCEezDCIk+TX3eJbHzYfnoSvhYa1XXXVTn6xr/inFZvZgKHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7034.namprd11.prod.outlook.com (2603:10b6:930:52::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.36; Tue, 9 Jul 2024 10:22:22 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7741.033; Tue, 9 Jul 2024 10:22:22 +0000 Date: Tue, 9 Jul 2024 11:22:17 +0100 From: Bruce Richardson To: David Marchand CC: , Wenwu Ma , Subject: Re: [PATCH v2] dma/idxd: fix failure to configure a device instance for DSA Message-ID: References: <20240628053458.78337-1-wenwux.ma@intel.com> <20240628095400.126083-1-wenwux.ma@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU6P191CA0046.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53f::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7034:EE_ X-MS-Office365-Filtering-Correlation-Id: cc35f821-c2c5-4637-ec61-08dca001050a X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SUVscGtPWjhjVXp1ZDJ5Q2dSZXpFc0lQVERQcGRIdk5xQzRTc1dmNlk4YTNo?= =?utf-8?B?dFVTeUd1NUF5Q2F2YWFJQ3FzcGxoVnRLZ29NYUIyLzNYSDBqTTNUTDRWZ3Ay?= =?utf-8?B?aXZ6Ly9GbE5XWVZJSzBLcmhYU3lCNU5sOGhMYU52ZjlqZWY1N2t4dERlT25H?= =?utf-8?B?dDJLTkJadWorQkNzVTRQa2tQb3RzVHlaV056dnNDR0tqMHJkaHorZVptRkM4?= =?utf-8?B?WXkyeUE4YlBuZU9zN0IvVHRJcXFZM1hxRjh0OUZBc05uTmsvdkZEYTR6M1M1?= =?utf-8?B?WHo2cXRncGUrSEd6YW5xeFlXOFZFSjIxMDdBSTVNQVJFMnRJdStWZ09hZ0pK?= =?utf-8?B?MkQ5Zlk0MjhpZ0NldXNEakZPYm04SzVBTkE2MEhvRlpDNTM1Q1RRWHZmYzNy?= =?utf-8?B?MnQ0N1Q3WlRsZEdXRWRRZE8xbFg0K1BTWDJCdUdleUQ4NGZLeS9jcGI1eUtP?= =?utf-8?B?dEgwK051eDdJOHRHYnUzc1VSdXM1eWZObVpRd0tRbHFTTGpRcTl3NWlQYUQ5?= =?utf-8?B?bHlTOWxYZis2T0xSODFlRFlYODRUb055K3FPTXdIVWZLV3RjZEhjTXRrWEJp?= =?utf-8?B?WXZRWnFBemlTeVJ0V2RmV1hlSWtDNkwzdEI1RVFDTVZ2WEdDWFNSVTI1Nm9t?= =?utf-8?B?MGJabnRiWVg3c1dCZ3FWTm9qTHBXMXlXbjN3cHFCUmZKWTBTNjFZQWg4djlW?= =?utf-8?B?Q2MvMWNkNE5zWHV0YUNXMHdvVVd1UUg3UDh5bEFPaCt6QnBYQkhKc1JKUVUv?= =?utf-8?B?YmgzWThDTS9RTjVqd1RkMHFUUzlhQVk5eGZSL0wycU8vbGVsSjlhSHM5T0NB?= =?utf-8?B?dHpSck9Bc01uTHpnK2kzQU1wYjN2RjhBQXNiOWM3L1YxNndvc2prSEFNNklt?= =?utf-8?B?TmltR0xmL1BFL2dSSjJQWmhUb1o2WHpXbkcxRWI3Zm55MURjczBpbG9YWmxT?= =?utf-8?B?aFpic1RnZERKRVhuYVo2WTkvR0FlNkRQTGlZR2xiZVp6UmNxd09pdGhoTHp1?= =?utf-8?B?enNrN0c1ZUNnenZnaUU0TFJYVGE0bHdzTXRtWWI3NGs4OG1PYWY0SFNjQml4?= =?utf-8?B?cmVSUFF0ak12RTFjZzdldm1SMzAwMmRjeTEwUlgyQk1VN3g0NmZDa0cxQlh0?= =?utf-8?B?OW5JVUxyZTkxNmVhV2JGMUI5S2Jlb21VQnQ4cm4xTlBnZ1BJeDA5eDBVeU93?= =?utf-8?B?ajVvdkFpMkFZZHpYanJQRldzdGE2K3VaZ09SRVdBbHFZMXFoeGFBQ2kyZVRG?= =?utf-8?B?RUpBUGRiZlcvWVY2cmd1eHB1c1Vhb05oSjJuMDlYMStQeEI5ODljSHNoSTdU?= =?utf-8?B?ZkpiVFY4a1AySmwyRjlQMlR4WGR0bHMyem1TdXpWckNMZHcrYTJUVE10N0Ns?= =?utf-8?B?Y0RRL0tGRVB4YnpsTUtVY0JWb0xjdFd2dzRoaVhLUDJCa0QxdGRSSWQvVmIx?= =?utf-8?B?Nk11VVo0RCtaQXJSRDNnMk5DejF3Um5PM3JUeXZqbXJsaGJBM3JlT3BMREY1?= =?utf-8?B?d0EwY2g3UlBrZmxtV1I4cVZSa2tDQmtka1dEdUdRT1RNNFgxc1N6TTUrRGZV?= =?utf-8?B?bUhoWjVxbVV5VSs1OElEMUJ2R1d4dzFWUERXc2ZnRVdTYWtiVktBY2ptS3N2?= =?utf-8?B?MzFWekdoem4vUTRVd0wyWFZPUmJUQjRuL1ZpbFJlODlZMW1Hd3VHWXVFSUd1?= =?utf-8?B?VDF1M1QzYzlzZ29BYVdIT3RUaUVlQjNQSWxxM3AvUmJZZmlnQVU2dkhZSERt?= =?utf-8?B?S2lxMHc5RnBHOW1iMVlCbkpUZW9xR3BjbEV3cHgyR09reGpqb29qaXQyaEZa?= =?utf-8?B?NlVsWEJnVVFtQ3NkdDJmQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wnk4aGhsSmVKaFZZU096MHZZVHBFbCtwU3VDblpjd1BEVm5VY1F6WXJqWTFV?= =?utf-8?B?d0dQR2o0Z1lNUVBRN1FSWUpIU04vaFdtWXhsZ2dmdCtmR1pDdzRvTGpkMC9Q?= =?utf-8?B?eTdqdGNFK3IyakgzTE1UM2lFWFkxSjZydlVic3RrVHdpTTFWcjNMUjlNRDZW?= =?utf-8?B?S1lzdDcwN01CeEVyZ01ZU2o2am5OWGxQRUNTajJMWENnYWNBTFlmUDRQaTF3?= =?utf-8?B?aGxKZ3lTbkRuZHBPcmZ5QUhpYVFkWGVMNWJrbDR3Szdja2M2d3lsNS91bkZI?= =?utf-8?B?b3YwdnNCZWhuMms4ZnFRTWd2ZUpyeGp5VzV6TWZPS0ViejFGcVZhR2xnTmkx?= =?utf-8?B?UEEybGNPNmdXek80ZHB4SU1veTZOM2d6UldlOFNhakN2SnFnWVBKbjllK24w?= =?utf-8?B?ayt2aUhIT05RRWUyQ1FkamltcjZpRTBlTW83d01UQzJkK2ZId0ZWM2xNRkxR?= =?utf-8?B?RGNTTy92Tzl1S3ByZXliV1dERGcwZ050Njl1YXNsRWFZU3FkSFk1c3NmenV3?= =?utf-8?B?MUF1dGtlSVRKbFRmUnJaclVJY2ZNK1kvWmtHZFV6Mms0ZWxaK2tZRVpleFZB?= =?utf-8?B?ZCtOMERwaFN3U0hIVDRTVzFicDlQMHhHMk1aVytaOU5Obk9OaTY5WC9rTVVx?= =?utf-8?B?b2lka093MzhqdkZ3UDhsRk44MGVaVUVFYmZaUjFEd1ZQOTVjTFVVSmtvVnpC?= =?utf-8?B?VXRzbWdySlBrZGVvdVI4aCtrcUxYS0E2QWtDWkppb240bzA5eVV6U2UxQkNw?= =?utf-8?B?MWtONEgvSDZMQ0Q3UVdPLzVmSjBpS2lvUitseU5xQVkvL3JCWkNIcFVBTnBP?= =?utf-8?B?eFg4UGIzTjF4bS95TmpxbHcxSkIyUnA3bTY1OU9RRGJWRU5MemNYWitJejg4?= =?utf-8?B?bHBxVk5mU2JNeTdtMXdIWHlDYllpY2NKeldxV3F1V2tXam5qRnk0clpZMElH?= =?utf-8?B?QXlibm43Njh4RnRQSmE4ajZFUVBQVVBFVXU5NHo4QUxuSFFXcmZSM2p3QXFp?= =?utf-8?B?NTU5ZXR5UVhxNlFKRlBvSDh1NVppeXo1eEN1MlE2NUVMQktjVHU1UDZRamJG?= =?utf-8?B?TTdyNmU3dldFWjFJYnUzVmo3UUk2b1BTdkhsVnkxcUMvVCtxcFgwVy9WMEZM?= =?utf-8?B?NEZVUzl0WG16b0lQM21GMFI0cVVDWkxqMFMxRlBncmw2SWxsdCtlNTVFTVRW?= =?utf-8?B?WjZsYUcyZnowcWRPaHNvbkk1c0Z6bzFwQnRURHVwMFVyTnQ2TjZpQ1RNeTFR?= =?utf-8?B?Y0lkZlBjUW8wd0JqLzJ0bkZ5aHpZSW9GRXVxcmhVYVpPTjdOVnZTVVhZbEQy?= =?utf-8?B?WC90ci95d09hUEZzNHVVb1p5K1BCdmE3Q01zVGVPczF5RC85OHFLSHhrYVds?= =?utf-8?B?dTY1anQ1UXZMR2FCK2ptVWV0ZnRZdHBONlpaRnM4YW5mMU9qbHJXYVk4Rmpo?= =?utf-8?B?QzZLSlJEOElXbVFjRjdzQUs5WCtCN1hhMGNsMVJ1d3Y3dGlPVUx2MFpVQUQ1?= =?utf-8?B?ZlN4SUhUWUNNQ005OG5JMDBvYWMxR0xubTd3T1BZdHJ0dzc5elZHc1FXUitV?= =?utf-8?B?ZUhUbFJCdSt2WUo4bkM1cDdXdjdmaFEwbjhyZGVmRDIxUFlvMkpHTEtQQTk1?= =?utf-8?B?L0dhWEVlZHp3amFTZkQ0cG5YZkFicHdJbmo1TTV0ako4akIwRWJMaTI0STdt?= =?utf-8?B?SVBCQll4QUJYN2JmZDlyelRlVCtGTFdhMko2dGZ1cUsyMzN3dkhmc1p1R25u?= =?utf-8?B?RTZxU1V3RUtaYjAyeHpaL0g2Ny82N1dFNXQraTczZThPcHQxeXo1Nm0rYjZp?= =?utf-8?B?QmFWbXRaSFpkU2JTMTdJSUZRNXE4a2JkL3lrRlFNZGVUZWlIdnFXWndUZkxX?= =?utf-8?B?a3ZtWjdnT0tvQUhaZk9BVGttMVhIdVRLZWR1MG5mblM5SXo3aTk0UVhwcDAv?= =?utf-8?B?Slg2d0pzR2tqMXl4d1ZWcHRLMnRFRVdoVS9EV2lleVcxQ05SM1pETkpLOU5S?= =?utf-8?B?YnNScXAycFhxOWRUTU1VeGZBR3JON0xJNmI1VFRyYUNKeXRMNVg2cUFoZVNR?= =?utf-8?B?UGdQNUJrU0VpaFlMR1doemZ3V0R4TGpKUk95VDNlK29aUnVzODl3NmVITDRz?= =?utf-8?B?YldMTTVScGYvcFRFcmVUbmhPUFNCTW41blh6ZnlhSnVsQ0VabFU4YWVvbktQ?= =?utf-8?B?Q3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: cc35f821-c2c5-4637-ec61-08dca001050a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2024 10:22:22.1488 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XFCAnjkctsaHTpX4UbyDAX32wlMBlf64nPdyyZ5tSftlZRfHqsalpqF6oxWvxXUd8+9Cjkjjtm2AXNUkoYvM5g60VZ9lvJ6QrAs3y8mR+SI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7034 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 09, 2024 at 12:18:29PM +0200, David Marchand wrote: > On Fri, Jun 28, 2024 at 12:26 PM Bruce Richardson > wrote: > > > > On Fri, Jun 28, 2024 at 05:54:00PM +0800, Wenwu Ma wrote: > > > In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs, > > > DPDK needs to write a correct value to this file when configuring a device > > > instance using the dpdk_idxd_cfg.py script, otherwise it will fail to be > > > configured, this patch fixes the issue. > > Pointing at the kernel version would be useful too. > I suppose this change is introduced with 7af1e0aceeb3 ("dmaengine: > idxd: add wq driver name support for accel-config user tool"). > > Can you confirm? > Looks correct to me, yes. That commit introduces a driver_name node in sysfs. /Bruce