From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB6BF4554D; Tue, 2 Jul 2024 14:27:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C594B40E2E; Tue, 2 Jul 2024 14:27:46 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id E42A940665 for ; Tue, 2 Jul 2024 14:27:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719923266; x=1751459266; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=bWrjWz5slERKp2BKPhClw+0+GbyYSYfpe8vHVLrShIY=; b=eUoU2nNB9IaFJtM8LkblrILP7Uy6B1eGzxrFXsDYAf+BK/h4EmJUE6Dd 7f+NF6PMKDmapO78s8GLZ2jXexHPGTscZW7J7WMB2RwyA0i7NqIOkON1d kxcWxpJRE1VfDK8+iHx9LcLoWiDVmeTJO+ZMf/Jq9hYhcEHCx28km+BU6 yDBLBwTv1pRsxyngoTiri11Cxp+hCTDbXbAaOX/zBxHdbucWfPEIfBH9W RLDecSAPYWBEF6El6Bikjvlh4J+4G7nh4yQU+ux43UhHgh4iw976koE5Z lmeanZmvwhIztKgArdI4Q6ITX9kmq1v+aYqdFFxnD1nBysCayDdaD5EOl w==; X-CSE-ConnectionGUID: 1CQaOfP1SASIkxP8yCWuoQ== X-CSE-MsgGUID: GyHbZhS8RSqYFMh9Ug+/fg== X-IronPort-AV: E=McAfee;i="6700,10204,11120"; a="34542933" X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="34542933" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 05:27:45 -0700 X-CSE-ConnectionGUID: /OdKzV/NRaqPu0bviKHfWA== X-CSE-MsgGUID: Xh12SrNLS8y7eh6i8G1Q7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="50756965" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Jul 2024 05:27:44 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 2 Jul 2024 05:27:43 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 2 Jul 2024 05:27:43 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 2 Jul 2024 05:27:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gOV1nyAWzupbghOZEpz7RDCNoTJPIhJemKxeP463Ax55gqS+LGbYD/iNls+2VPSuPQGso4R749/y9Y5qF42LOu+8OJy3ZXGYpttJutYiIximN3UVmipb0HfUf5E9QJHsU3FwfWyaK6klkijUWqSA533QuutZ/o224zTArjdQpzEgd25AQ6UChUbmUlpTHBOhmJqS3zns+K/p2OXT3ZEe2zvXnqRlKRdXrPzStqVOAyWUj7pAm7VMRQ5o0vZIopSP4P2e28s6+5JBUZfoPKu2wNpLZ0w3u3rDdzdwuX6OgXJLrYsssOLGvg1WwcrU4d0PcemAIbfAcdyMOY8U17tF7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vaECYqEQXod+bwSOPhCWUNX9CDyEfh8yjHDSSplF60E=; b=YgXn/WVEVV6trJDSsR0rFuzZDQ3zyflGf9wZYHCgkSJULrtI+6WSl7Y9HOTLn/9wGwENDWxMWDw3ZJcuyrD7Z7XAa/wkRZ4Vc1Bvmaj8XdL/OcUsTr8EO2kUI3YvWYVFwCqG7XY4PIzoFZFk5gisHLGPckxaGKtJ6721DxpH49HMbZ4GwEquuthXJ76hFMVQFvfVMtEVf4Z7dMw9edQv7iNA2b7p0tCXZ7o2n8PHgba5Q8sFrjlTyReEk5GJq6lPnx9TqwpNQKb92InWFc35vi4KDwCq8TgQ7fgMUeD/VDOwzgG1IyJtYwBVblkWAPsyc2znWrhdGK/3KjxELccO6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA0PR11MB7380.namprd11.prod.outlook.com (2603:10b6:208:430::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.29; Tue, 2 Jul 2024 12:27:39 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Tue, 2 Jul 2024 12:27:39 +0000 Date: Tue, 2 Jul 2024 13:27:35 +0100 From: Bruce Richardson To: "Stokes, Ian" CC: "dev@dpdk.org" Subject: Re: [PATCH] net/ice: fix use of ice_bitmap_t in promisc functions Message-ID: References: <20240702122127.22401-1-ian.stokes@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU2PR04CA0258.eurprd04.prod.outlook.com (2603:10a6:10:28e::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA0PR11MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e4e17f8-e9a2-4369-7abe-08dc9a925d0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?h+Cupi6oEdRRS8lj2iA234JPHKg2kMjlz58GHooKpEtFLIEGwHq7xW2RirQU?= =?us-ascii?Q?SvIOaG73PPO5Q+qpQzdTSJKyIHfNLTwFcWN8U7ytXXqTxaKQe/Jo6WdviLn7?= =?us-ascii?Q?3esfO6vOovOb6/keuyhKFspAJHJIDkZiMgz7CFur6YTryPFvV+1BDiqnv19h?= =?us-ascii?Q?wZGuYmfhWcnoUxadcnEb4v4JBWU01mF42ipcrUbV5YD8PVUPmDg1UmVujuP9?= =?us-ascii?Q?vazE8TPthoYtBS9MB+Wml/mYDQMve93yxVBArMJ+HI0YVCu1oN2AMFQuYWbk?= =?us-ascii?Q?8E2ewAY72zDnq/EFRpY2gn8WynwVvdhtxgVLLKujRYWx/yo7D1Sz8ZJYgQhA?= =?us-ascii?Q?7CNnXDTLqPys4IBbbLcZRXOcLjotWYsnRv0j9AHJRGuITHc7FgEDpLjW2zWx?= =?us-ascii?Q?583pqOCEjaopnIby2mMLj7TiCfIza1+/tTpo8hI38BqDlxXN9UCeBSHse69S?= =?us-ascii?Q?HlPUJCHuu7lOabacW7TueTYIijBjRd6AaUNSza6InyE1UUOITUyH+pYnXKVk?= =?us-ascii?Q?o+EQPuG61yqaXZxtWP7KVA9GnmkT6y1pY3c11TiPfRNENAP8jGUmIqT90p5e?= =?us-ascii?Q?9aE70R/t4AQ0YA2wr6WF6gDUFmQIgrwiMzlHMtC3k+Dr05ESkzFUufksH0BH?= =?us-ascii?Q?Jb505jigCPEln//nMD3+imVv9hApzCOAAdzeWg1BjUKjGGSyGa16MdFNpOlj?= =?us-ascii?Q?R4ovCf/dOA2UczpVJwY0gMcTRKRrRknwBEzI313mc7d3M7fIYkfZwjF+3K7b?= =?us-ascii?Q?UQo2aOPN74+0W/vK5e7VugCUr/SlVS5yqg/zQNVeo+I4Nqq0Ij2DGltU3YVT?= =?us-ascii?Q?jELywFNtnyLuICHljbIlD6MFlUGi7vwgU5iVURjbgrwLMNB1qZ2uK8CEGMxf?= =?us-ascii?Q?wTC4ZNA2s18O55W4PUYa+DtPKLXhR83xg0K6yZ3ARMSgZiF6xe6r0nKTDMXf?= =?us-ascii?Q?tZQIqmsSv4xEiZqwhmIJM+U9qWJpDF0GDTwTt4RIBxE/l/NvxKO9TIvWqW/T?= =?us-ascii?Q?AWcBL5T73sqtZrs9A4WMvBD0kMMaHKGZ1MY0tdKJ6NXDVxlZNhx/15yhVuZH?= =?us-ascii?Q?5+bxNnaVGb6/MLef6SkiAx5MmOrKN52U3hNzDd7VNsab5/wLT9gH2pIEP2mw?= =?us-ascii?Q?x+Ah7ckEshdneCRNGDbfLT72GHxJ/LerEC8sGQ35GquYVAlfsePUzh1Qfwrz?= =?us-ascii?Q?2qG8bmyTmEAGh0ZrbxqcGgNUVXeVcKTjzwnRVsJaD1UD+JFpC2J4UAjCeddL?= =?us-ascii?Q?OxHqx63LjJZUZXwksnIV5Ewbko+1rw4ttZiZ+eXLZMrthOX5TeppNRmTtzqh?= =?us-ascii?Q?qnM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Si31U4A0FPwTQYSVygkTk8llYdqm7lP+5Ea5TyvKbw6yy+xlCWNQ6su/CGG+?= =?us-ascii?Q?IL0rltl96ZCGyLwBdloI/UHj5lIsbLFUtataeNaT9JUt+fg1/85fvliyVlS8?= =?us-ascii?Q?DpKSGWdSi/jEfpNHKn8R0q8Skl47pMUKmckqQtxhYuuxRQwl4D238k1luF5Q?= =?us-ascii?Q?crNiYrNdBBTZVomYDPH2U9o5tx+aM3vqEl+8A5BiZ9fqAcyIno9AZdV3TQT5?= =?us-ascii?Q?4v5KWBhHP8g/TzqqnIAPfKirwIen1e9aZiAe4FZWYGwnyoBSVK8H7afmIne3?= =?us-ascii?Q?viCCCDf5VF/LG7U9TokuId/+oBRc/LtJPyPPmCGWm8nSmR141vV6blgMhq9S?= =?us-ascii?Q?IcVzIm9mtEBgV0z+Hgtpf7gB6PGjRMcx0ie/ne0tswQ4fjMomyCVxZgTCimz?= =?us-ascii?Q?LQtKGiu5zTRsbXj/GYHB/ULyA+6Z6SCA9HoMearws70D4KnbK7EZofMnMx7o?= =?us-ascii?Q?212SZ52D7IgHe4SesyFMUTrpRF9EFDi7lAJA2rNivj0rUFg5ykyGnRVZwXLH?= =?us-ascii?Q?lqBg8bPk8t0NQ43MFuJf5c1BYCXaV/PPFBcv4BrCTVyj7Gr2Fkv0rg75pWzu?= =?us-ascii?Q?dnehhqwaq4dM7grNMtPef7jvJeVw9CABiT7XM9Q2N2p23wRyHhXXhBbuXHsO?= =?us-ascii?Q?kqEiI/3L1OIxidvpQDTuaIFpjLoWr/pFGgoxJkdUViBys0XncRc3Hf+/bs/u?= =?us-ascii?Q?vaIwDATRIcOfNMJR37S3ahixcBo7qwJlII34u1mryS+bNeZfSlP5fmSMSNMj?= =?us-ascii?Q?CPV75ztPnyPICD9NKkema/wvBC1owevRifhYFEkkclPLW44fJ0Ek5sVLnfql?= =?us-ascii?Q?U9Lbj6nlieusJuSReEqGKyb+l1l42FiRkFcZte4zDPahapl89fupKT7SPyat?= =?us-ascii?Q?xV3EY7SkK2D6dTouLtRlxvEKP+ODwWA3uNl26o2TLck9znQ7TsMYafhh2gPO?= =?us-ascii?Q?TzCz1DnDAz6Y+TZcrLXP4JR9epUabiFuxZ/PPSarSzzbP+jWOohRfUxxVNMv?= =?us-ascii?Q?Y+TuWK210cl8gi5hEi/lY1O48uA6Lc8zLyminPlPd0tf2dxLvuOJdOOtXoZ2?= =?us-ascii?Q?lL3sNazdwa7LFcGY06ZJUtIJuBruuz3foKyGFrHqAzgRiy2OAvxsxMF9rbYf?= =?us-ascii?Q?u433GBDcpDYRFcDI7FxysvSsnuiKqFbeNAVMk9HDCswwgcdKNHbXrb4OneoS?= =?us-ascii?Q?5O+PNHDEk8grtjKccLSpPWtKvSWzjgF8Wzs/4BeHKL6Su14YKZo4A3M3YPmw?= =?us-ascii?Q?DONKZ+nGVfokMfayhARuhPEBba+xAGkfOxT594P7/lg7y76Ol3/+83FZ2AWI?= =?us-ascii?Q?kI8QH0oTpr+GekuEJWaAZR15K/xlJstlsKcrQuUxAnh+Nk0wMDZwuE2G3T+5?= =?us-ascii?Q?q5rbdjnfCfCBdXy8XOBCtvyG/jyb8SVa6GsKhHFJJ+DxW0QbHACgp3PPyqgD?= =?us-ascii?Q?Iugb4/6O57o/BCE0yMflqW9gPyFqUUPJAIAZgeD9ks/H+VBzk4kQw2xG3S+j?= =?us-ascii?Q?SrgZ/Ex0yXcZAraKP6RRPs2Tgp7nGZQgWHtC4bpZStLb+ezhnS+yNz0+9iAP?= =?us-ascii?Q?cpltvfeONn2PCqLUrUMOkuMxHaK4Wy/6on6iL51vARgODMR4cPe2lJFq6cvF?= =?us-ascii?Q?Gg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2e4e17f8-e9a2-4369-7abe-08dc9a925d0b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2024 12:27:39.7770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mrbyyltnuo1Lh0W93JhubOEpH2BFkR2wuLks+FUrcTD9wlnhb2n7kzZiRbn5IUZGkUIZ9i3lCtq8UxiNAgEBVgKGhgAfpsSds39QklB7ZFc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7380 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 02, 2024 at 01:24:03PM +0100, Stokes, Ian wrote: > > Promisc functions were modified to use ice_bitmap_t. > > However use of ice_bitmap_t requires specific helper > > functions to ensure correctness. > > > > Fix this by adding correct calls to declare, zero and set > > ice_bitmap_t within the promisc functions. > > > > Signed-off-by: Ian Stokes > > Just to clarify, this patch is intended to be applied with the ice shared code update > which I believe is in net-next. It can either be added as an extra patch to that series > or merged with the original patch, whatever is preferred. > > Thanks > Ian > I think this change should be squashed to commit [1], since it is part of the overall change from using bitmasks to actual bitmap type. /Bruce [1] http://git.dpdk.org/next/dpdk-next-net-intel/commit/?id=126916f331dfa9fd6e997c0d00b12222e29de9cc