From: Bruce Richardson <bruce.richardson@intel.com>
To: "Stokes, Ian" <ian.stokes@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] net/ice: fix use of ice_bitmap_t in promisc functions
Date: Tue, 2 Jul 2024 14:46:07 +0100 [thread overview]
Message-ID: <ZoQEn_8E1J47W0HO@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <ZoPyN-7LSgKIhUQl@bricha3-mobl1.ger.corp.intel.com>
On Tue, Jul 02, 2024 at 01:27:35PM +0100, Bruce Richardson wrote:
> On Tue, Jul 02, 2024 at 01:24:03PM +0100, Stokes, Ian wrote:
> > > Promisc functions were modified to use ice_bitmap_t.
> > > However use of ice_bitmap_t requires specific helper
> > > functions to ensure correctness.
> > >
> > > Fix this by adding correct calls to declare, zero and set
> > > ice_bitmap_t within the promisc functions.
> > >
> > > Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> >
> > Just to clarify, this patch is intended to be applied with the ice shared code update
> > which I believe is in net-next. It can either be added as an extra patch to that series
> > or merged with the original patch, whatever is preferred.
> >
> > Thanks
> > Ian
> >
>
> I think this change should be squashed to commit [1], since it is part of
> the overall change from using bitmasks to actual bitmap type.
>
> /Bruce
>
> [1] http://git.dpdk.org/next/dpdk-next-net-intel/commit/?id=126916f331dfa9fd6e997c0d00b12222e29de9cc
Fix merged to appropriate commit on next-net-intel tree.
/Bruce
prev parent reply other threads:[~2024-07-02 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 12:21 Ian Stokes
2024-07-02 12:24 ` Stokes, Ian
2024-07-02 12:27 ` Bruce Richardson
2024-07-02 13:46 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoQEn_8E1J47W0HO@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).