From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40C534554D; Tue, 2 Jul 2024 15:46:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F435402EC; Tue, 2 Jul 2024 15:46:19 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 223CC402D2 for ; Tue, 2 Jul 2024 15:46:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719927978; x=1751463978; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ncaaZ+hkDIGtG8kkBVUe8sWYKgO//mWW2iNWSag8fK0=; b=dzu20JREXvky93gSfyjWfdLTAlJh12kXEWb40kBw1sV9CC2SwtqYd3PP DbdZwO3FCJ3T1ontS4/Sa0x0LCZdH6pZsTHEMrDT1UiHwrdH5ZhRD7Ki4 rrI01HScGHLcbkuvVUqiV7xn26Utia1tfP6019pUkZrtnVJJTSYrDSm5P TtxcY/tnwEjydtD1ohDyXcgLylfnCQ9gLZOzpLK7yq3Ri6bOgmhEeuz3+ g1yDoH5T4pA1eTWZxnAycNB6MzmIGuwwqRGNM6jcojts95wFnX+Mfbkg+ eR/irdzvHILf3Sqovjq0g+C6ONamWGW0BKnsbAywzhF1TgEa5Z0G6v+DO Q==; X-CSE-ConnectionGUID: pGl5TCU+TiGEseC2S2jbjw== X-CSE-MsgGUID: wsYgJONeR8OEsCvwCGp3nQ== X-IronPort-AV: E=McAfee;i="6700,10204,11121"; a="27720703" X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="27720703" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 06:46:17 -0700 X-CSE-ConnectionGUID: zCPaonSYRwmFpuLl/zPlSw== X-CSE-MsgGUID: K6FZiVaLSLK1i6GjTlysBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="50527023" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Jul 2024 06:46:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 2 Jul 2024 06:46:16 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 2 Jul 2024 06:46:16 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 2 Jul 2024 06:46:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jE90n0pMAkQMbuDPi+xEOMjltXTpno1Nm0B/Ns9WSc0OnEmuxuAYzbDjB4QkF2tmwTzPyt7eRnBWIvw6vwwUQt+RTL/9vCeqCoF4RNViukrKxmIhJqFUOPZ9Kuo80MRjUmzNIVyvfFt8vTHLOWxmk6O6JOVgsRkA0EsxSEo33/wXmSn/fMrT+q3Xin0QaJJvGR03e0fNzbJ7l2P4LmmjfW/ER99A95HE+RZZf/zkP/QJhOckt6X+1fSvSu8Lr2jrDH02xKxS9fDZXsj+Fy9h4VTqDXBVIy2cvUDdHJmHNQRwdS6WA/3XcMX+bPgZXfGO3hUspZM4z5OEk3vCxX5+ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+86QW4ZuxonMhW2HAmnS1aGZYUSBGTK20z0CFGqPBvQ=; b=XX7fi8SUEeHpSaij5AnFlPXJBM2X4ps6hQXs53YjYMjZm+0V5eMds6lrQjpN/z9gN/OQAW0D7Xx/9gd0cBdLJAsud5bDoP+JP2rTBM3D/1bMFvJUgwqp0QtNaJYslay6QCQTxIwH43lNCXK2s+nADac1d6U27snQ8sYztbJelbMCicHcOQgOKnDK82grwYhCLXcPymEBzHNvKQOEkwGaCi1B4+G9D8t4X14CnUoNie6jKYXcn8ObQ9Tpru/ux/uzwW9jYSIA/c4OwUnF6qEUytsflZCN0gt+D35x5jPR6D7iNLVnZCQbTugOBakuvtDncVrP0IY8UIBmeNZzY/olEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6379.namprd11.prod.outlook.com (2603:10b6:510:1f9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.32; Tue, 2 Jul 2024 13:46:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Tue, 2 Jul 2024 13:46:12 +0000 Date: Tue, 2 Jul 2024 14:46:07 +0100 From: Bruce Richardson To: "Stokes, Ian" CC: "dev@dpdk.org" Subject: Re: [PATCH] net/ice: fix use of ice_bitmap_t in promisc functions Message-ID: References: <20240702122127.22401-1-ian.stokes@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU7P195CA0027.EURP195.PROD.OUTLOOK.COM (2603:10a6:10:54d::20) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6379:EE_ X-MS-Office365-Filtering-Correlation-Id: dbfe7dda-ea8a-459d-23e3-08dc9a9d561f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JfpMMjNMDEZ7bowIDB4bt1GFCEHNVsFDO9A05epXJTh4Lip8IPnl6dXJLnSJ?= =?us-ascii?Q?gzOogvRi4cBXlndQvb62I6zGwimKb2TDKUrtrg4quMWGW47WPwqMIUKTnmhW?= =?us-ascii?Q?K2rZ1fM6Ft/wLjOIwqdJu/1NNoOozgtBvgVdyRReQ7AQzFI3iEgID3OIyS97?= =?us-ascii?Q?tVWsPkUmHSKLlXe4sJ/8Rzo5Dvkd5Gilhlx6eyeRe78EiF892OUBYbxJnICt?= =?us-ascii?Q?Y65zCuiurkr+jVfZQNTzrc1j17RLle3ksuQeuXd0Z0MYiN5UHV9NtVu0XinY?= =?us-ascii?Q?/P54ObUcJCkCG4+hNC3O+IJLWTVghuG6cPuMIUrQYoL1HLSAOqPSourYdhlH?= =?us-ascii?Q?omx7YD3HZNk3r0KcEV65pfNxgy9f4LiST15ddCAChTgbGocx4waQLpeejBhL?= =?us-ascii?Q?rv6cqBHXuo4gtbH9O0bgjjqiitD2GXbssvGdUK0Tyd6WMyugtAGPhP2kZRyG?= =?us-ascii?Q?fefNBgHMRcmtZ7WVdtnYEaAOQ8IxcdzskjVV8GxkieltJnlsdyfO/8X6kR/3?= =?us-ascii?Q?GrDLoZQkL4VJ2otJVZiCkc5j7vX7py0eoww6yZhAnWoJCJNDR5rj1YXW8wa7?= =?us-ascii?Q?8YPtVuOu8CCqdhCx/oYodtorpQKQyXBh9ojXI0H+nuqw/hfU7EGE+agsBY98?= =?us-ascii?Q?4vRmZ+3lqP2YjBoDV1+7PI1OqOi+gl13DveTx6U/BpO9813fJxK214L5QG3M?= =?us-ascii?Q?GG/2LNnVkGDEv+4c0z12AWOnuRrCTIX8nBkXBE2rB+zr46wxw9GUtFKKQeDZ?= =?us-ascii?Q?48aMkBhsXqQEyIs2Q8PVH3Z/yCqiiMcCUnfI4L/xPYGLOPCJmbcL4ySVPiWT?= =?us-ascii?Q?HKPP4g4Ymn3Bnxlimkgne6xTy9RUaFKRj5afdrjvgCQdY7LhzwpgKD3iMlhj?= =?us-ascii?Q?An1peR1Wi8qZn/Okb0UXzOHUavx8mp7DnwnRlDDDuRi5/xTY2psgJ76NWkkP?= =?us-ascii?Q?av9pH+hAq7hW2o9v7s7sDNPO7rbEaHCAnStUPhTrP8KrMTxU+0zACEk3rWjK?= =?us-ascii?Q?QXc9PuTrYriCZ1gPre461aD+khO126STl1LDpGDn8dBHHsdyWwGpdeXJS/LJ?= =?us-ascii?Q?6TpxoeWM4HaH26d5v3v53ppUrr6/j29uTNNAjDTkygsz5pXXsiJfTRyVUUjm?= =?us-ascii?Q?ZhYyZ/D9pZLLECH1Hot+/AXZOXJvFtxBDYx3oQFmlGCrDzS5I41e9gdz1e4B?= =?us-ascii?Q?updJdLXCDwb+dsbI44v8hPPLY2Ow/PtTT+9+j/01PDSgGhFB/MG5isvVbcJ4?= =?us-ascii?Q?w86YunCVCW3Sl6yE56xVKYCaTH4hP6NlVQyDKN3D2gNhQCFfPlQFHhWOCbW8?= =?us-ascii?Q?iDc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RbgQRMmtmkqjZaBAYb96pchHpjfVUoTOWfSSZ/hGtPqk+TlE8zDKNsyXveEm?= =?us-ascii?Q?kMRbDTL2eC/yHYllRCxxJu1mMl6b7HjjL+KdAwwz9bhwTKMMEU2M7PsRaCPg?= =?us-ascii?Q?/NiPstchMZztYKlfFwm3I/TSZkZGRXD5F8JjlGSoZtvzS0mW8Bw6F3F05LND?= =?us-ascii?Q?I9qms1If9YTIMvoayOkZH4e/Qw+JstppDELHolAiWGKGdjKnpK21W2kZdh8g?= =?us-ascii?Q?BC8aRCaexDnNQLcOoxTTaqb5GCLLbmrKe5lolXPbvjURLhQl3w2tj6vH+Hn9?= =?us-ascii?Q?wcAG8BH9osXgI6vczEGv8hguCNMxzbh5SYuB1b0GBTWYFmXXta3MM+D37fLc?= =?us-ascii?Q?fO3ITPO3y2NbGM7Olq3u2+LI4cV7fJ/ptz0egenA19yCLn7Qv+WyMygniP/A?= =?us-ascii?Q?hfLdR66UCpQsC6x/IR5OY8luBUFikRrVnww7J8KwtHf3jJSrHYgf9LcQWJ8m?= =?us-ascii?Q?W94Tl4nPc4ExNVj6HAHxUPLMYXWzFuOI3grjbW67QgfYqwPA73izmVsHZYw0?= =?us-ascii?Q?b0H58BqkCBU72jkqcPg3mfysq4gJOy7+GDiuMD5NiqkkE4aRtiflYOb+SGHu?= =?us-ascii?Q?2FqDzwGpGt0d2luieks67q43u/NAQKps7gJqsNi0PzJg2UZQXp+jFud3yApu?= =?us-ascii?Q?/MG85N5tAIEP0q9OiALD2aD++NDCu1S+72DXA63X3LrOwmwH+UD6gLPDnTge?= =?us-ascii?Q?CaEF4uDt/Ub+cZpxwHwTzLML6yMjOvUBg7+szuQ9tKaaqYO060V8Sp70LhKQ?= =?us-ascii?Q?F0tA4TOwh1l0SXZMdl7JU3Z180y6/h+OvW2+dvZVVrBKteuaxfICXATLxRF2?= =?us-ascii?Q?huMFZ/hqDUAeT3IUwon2nE7dEV+7xAEsRzZyVwFVkpZm5OdzrG6NjYuhe4Wp?= =?us-ascii?Q?adcM6qvCupBV1rYLGb+2DC3z2DljMLSBd4eQUh23gP75H35Rhgx4wf+VHER/?= =?us-ascii?Q?jsFahbnlQI1i6gWF5dmgA75LBiHUHgZa/QZJ8mUezsGkVt5prHx0StxQ16hL?= =?us-ascii?Q?emZps6KDyewKnEsZiW6mNrUoVqmAQjqhLo+uxPaOgeafvw1ktVnxAHuoxsdg?= =?us-ascii?Q?EssPaEpfcPsbl3YrwQjPzV6eQaMMO+QrTpDhW/P3ygXQWaZ6eCQ5m8XsSK6O?= =?us-ascii?Q?Yw5jm52se63yGEiVQXagqePibhoyRGJHBehM15lbzYWvhEoY7SXtNMVrROJa?= =?us-ascii?Q?9TJQwbOHd+JJxpWSuJIq2w5WDYmIgJdXd7jOyziOT5X+LpQ+iZ2cBas3Cgjo?= =?us-ascii?Q?VvzbLb3BAWZsL//mWT3qQ1BKwFWyMsBGqx87lp1fAeORLkhBMFyMXY7NsSZQ?= =?us-ascii?Q?RfKbc3Cxsfc0YLxfCpn7/mo8xfHp2A4blrnWcf/EVQWmeFEG6glE+H5SFQKs?= =?us-ascii?Q?nj4Iiebq7w28Hqvgf7PpGUxsuydm6WHpbc7Rmq50n3JS78UBw7TwOFGZYYok?= =?us-ascii?Q?KTxAeetTm1Bsrg01uFih7rbXwhb6Vm1lzVV4Zr6C0sL3iP/IinUK4bnJnFqV?= =?us-ascii?Q?xwnhVcySXmTTLQ7z8K9rEfaUtdvFGhBnszn3if3OFgog+a8mbU2lHE4FnYIo?= =?us-ascii?Q?26iu4OiNDJxj3eFNe4ZW6jjh5t6qfa32Z467sZ7rd4yLYrqWNQrAxz2tmcEk?= =?us-ascii?Q?1Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: dbfe7dda-ea8a-459d-23e3-08dc9a9d561f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2024 13:46:12.6367 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1SkBnu1JXRCB8Kgxqmn18uwfMfn+73VoscfsljxSHhNtxG5cXkxEcN594+JIdVHSZFzbudostAw6D11zKPe4jz0erKlpPCdfGsxvw5cXh1g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6379 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 02, 2024 at 01:27:35PM +0100, Bruce Richardson wrote: > On Tue, Jul 02, 2024 at 01:24:03PM +0100, Stokes, Ian wrote: > > > Promisc functions were modified to use ice_bitmap_t. > > > However use of ice_bitmap_t requires specific helper > > > functions to ensure correctness. > > > > > > Fix this by adding correct calls to declare, zero and set > > > ice_bitmap_t within the promisc functions. > > > > > > Signed-off-by: Ian Stokes > > > > Just to clarify, this patch is intended to be applied with the ice shared code update > > which I believe is in net-next. It can either be added as an extra patch to that series > > or merged with the original patch, whatever is preferred. > > > > Thanks > > Ian > > > > I think this change should be squashed to commit [1], since it is part of > the overall change from using bitmasks to actual bitmap type. > > /Bruce > > [1] http://git.dpdk.org/next/dpdk-next-net-intel/commit/?id=126916f331dfa9fd6e997c0d00b12222e29de9cc Fix merged to appropriate commit on next-net-intel tree. /Bruce