From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F4AC4554D; Tue, 2 Jul 2024 16:48:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67DF840E0C; Tue, 2 Jul 2024 16:48:33 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 6ECB140DDB for ; Tue, 2 Jul 2024 16:48:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719931711; x=1751467711; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=77MnQhwg/veAXnKEnIpeg/pSWcaEvNG0aUneH7brHEc=; b=k/L8d3Eu74S7AJmpiwYE6wgcyTlLI3onzqLrG0CcvxwRJspXIyYpRfYr 1dowOs9YZi4hCp0eLDVJfccvyUEqaWqAWJSHJD8UlpdFqyWj0YYbqfKxo CVSUR+hPgSb2YrfzChJP1fyeC6MEZmay9oAwbA4YsIRvRlQ+foMZL3dct 8sPXZ+EbqwoM4V0jg4QIVy3LBunXetcHEFpb44pcQZj/5jZn7Iq7CMMIm TksF/wCnEuurtp/WWfrDgUUFaeV12qY19LkdaghVWnggy24jZP736+lzl Nd9xGME32CXzwR/2X80fJ8v4pRQdI/vgCU9zL+P5qlODBKCXG9prpVONu g==; X-CSE-ConnectionGUID: /WI4lAFkQaeCI/2GsKBlfQ== X-CSE-MsgGUID: /u4FrxZcRCqCf5n0npUNog== X-IronPort-AV: E=McAfee;i="6700,10204,11121"; a="27712151" X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="27712151" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 07:48:30 -0700 X-CSE-ConnectionGUID: ulS8mSvtR76cMe75ySvNKw== X-CSE-MsgGUID: 1jcG6+i5QmWS4ZzInHw4zQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,178,1716274800"; d="scan'208";a="45936113" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Jul 2024 07:48:30 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 2 Jul 2024 07:48:29 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 2 Jul 2024 07:48:29 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 2 Jul 2024 07:48:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ORVKg2u/zJHJxQUXAdEOKHwOj5lEYly2+smzyneiXtKG/I3FaUICY3BKjOZamyW4GWNfxkpjfSEEGw4PKR61tfvfPyI28Ov3p54kHdLX8CWzyFt+N28s3o3uHed0SjLqm03GL7OfTdo78/GRPfzMng5c4Wf/isJCqGnxF3UXestm6Se8/dHFvjnHoj2bhasuM8SseHhbWzN9T0TjB/71u9GHYLnINI2MwGxfocnx+Gyl4uhvqTO7H4yCbooiK4tCljXuMQJPq1sitT+VWVN6uIC9FYBeYcw+SiK/fz2HvShqUfdWsJkDiaPYvBN28AMglVT0Naq3v/37qGPCq+5NnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i4U5jpJKqkyrKE/QX2bbN6nNcreXqozuVAhsa78N7JI=; b=nJDTpWq/t51QtXiJascrzB9bAtSEPUZcOYd2F4asvgD0DjMB6gaaI4YZsvuhHICQmiZtKxuSNoPdEk7/TVerdRCvlrF2bqUYJPowU4pw9i5pWpsHPx7QfEuOnx02OQaK1oqsn3+qJtyOL8ed4luDYNb8iGz/NgQ5OJz5Dq9q6dTTIx+GBoeoOXUh7HWl0IcDIMsIRD+V94ZDYA7zszoqhtlx63hqASVlSCn/WHJzvKQNV77fpB+m+fEwHcZns/G1ItotJSZMCKMBqxlV2jfemZNxBsEFa0F3CxbJBf51myulSfn4mh/+wEzETmgYQ7D4Bjp/QvaahpPjZNqeBwMfaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB8038.namprd11.prod.outlook.com (2603:10b6:510:25e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.26; Tue, 2 Jul 2024 14:48:25 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7719.022; Tue, 2 Jul 2024 14:48:20 +0000 Date: Tue, 2 Jul 2024 15:48:15 +0100 From: Bruce Richardson To: Taras Bilous CC: Subject: Re: i40e add UDP GENEVE tunnel Message-ID: References: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR09CA0013.eurprd09.prod.outlook.com (2603:10a6:10:a0::26) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB8038:EE_ X-MS-Office365-Filtering-Correlation-Id: f8ff6fb2-169a-4f73-e9eb-08dc9aa6040c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?gSydRtVCotVDjnS+pPc5njcm+2v/uNOwHb80t2AKKLhg8od3u4YSLxcJfX4F?= =?us-ascii?Q?MbhfCQLXDgAC3YIxtenW3O3I5XSkgbPXEyFybBQ/zFQ7nNVlXq0mAx38Hv+N?= =?us-ascii?Q?QK42r5ZXWeycSzThCvlEGWaCFUMUAHflcN5YE1BlAI1etUXrFchw2Jvh9A/u?= =?us-ascii?Q?BNJttQjazQR6MFUrRoXv7Kr3tYAv036M+IppmI16eT0WzVTnS3Hariksee4C?= =?us-ascii?Q?e/OZ8t9+0fUyYuc4e+jnon9PHQYQ2UGagAz7RqB3hOO3d+MWCZLMDBnUjfy3?= =?us-ascii?Q?Sgsoud1i4S5cE2WdTp42GLXDCElWnulLWyoFWCtPA4L6frujanGIvTVvbX2j?= =?us-ascii?Q?W12v2JeFofQYS7Gun4QtwG+1NAN0ce31x/Ai7vGwyhLfq1giQiLnwdlr3KHb?= =?us-ascii?Q?vdjSq+xRCVSZtXp04elsvNlrZDYoq87dw1g1qpriM2D5V4m8USMeZacfn1U6?= =?us-ascii?Q?iW9XFmG0E/3+eyHbvi9IZh4VIb1W7R/UodomAURfzHDP2eZeIVuRGwoZjPBn?= =?us-ascii?Q?pS2jKP1ia4L422kGt9f1MHBFXDKRvfpWZg4eJMwybI0Mza+6HTnaujddpfZS?= =?us-ascii?Q?qzVLzsfx8juH/ZFfFFb0BNJHHgy4v8+Uwt1KiWEreug4uUV2NLYtizfP3XAY?= =?us-ascii?Q?g10uQmhYOwgPnCSP1nIIOKCstevDislNWbBxzBU8u7X/YdLuEhnuR7X0dIOo?= =?us-ascii?Q?o3/fBFWjpmri30IqgiHZuiLD+k0B7raaAwmIlrUQjuJFwQGM0cZbqkV0R/bV?= =?us-ascii?Q?idCf5KkrpKyWIJ/l72M7TkZN7eUNib0UiWTylYoP+6825lqlDPMkOz7XGF/T?= =?us-ascii?Q?PqM2HY1bRZTvg5+YQuwsA9ytLJcB/oxMoQMzhlR5J3aBu2Ua5JimZ93mdYep?= =?us-ascii?Q?kiZMnEeJCAK0sPu2wuJVKLiXdopacGf5YwVNwX0VZbatpacoDCXo+VY1EFxV?= =?us-ascii?Q?A3zJdxW4r/15iiRB/Bv3FIzGhkkjr5g/eiQnd4DYbPT+TLtAb6LOXVS+hZOJ?= =?us-ascii?Q?jDIx5fbhUnCFuUNbbabcE2V5zef+O15ejQra1/OnnooEOQAxCOyXb1d9BcR/?= =?us-ascii?Q?RTQ7lXouh7g0ioQRYi1+JP80H0S/CcplUTZ63wnTP/BwnqoyN9YcvvrHAxp5?= =?us-ascii?Q?0EWLS63Y+2KK/pt/U0byNqmi5TCvxeoGHH9yceKMJdwAFhAcdufhYBsHttyv?= =?us-ascii?Q?7djFbtug/cZ0c6MtdIxpm8187Pf7lHzGsP04KSvtgZX0PER0KADz7jV5JKir?= =?us-ascii?Q?XaAXbmj8U6ETalPtI54nI0Ea+LO/DMkPeMKXkFHcob54iSIXWPfaPfvV29iU?= =?us-ascii?Q?VDY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Gfo2TCTnk247pcZ/KKUABsDDqaFudkgLLPbPJaZl55G5uTac0dqnn5Hz+6x?= =?us-ascii?Q?MT5nKXpgeItzeIwmElECcTfuCAGOiIK53dlMfKc5VFK5rL5A2gRMtjRfdY+i?= =?us-ascii?Q?vTjDmKvZzvwuPDGboeDAlmsBMLKh6ImQol/GLlRQHu0MGdoqHBI8nvIyuJTh?= =?us-ascii?Q?yeNwze2Y/TgffJAbIUqjuq+xbN5p12kJ+ATvD1CaUb37eseJYTVumsti/BBn?= =?us-ascii?Q?Ck4+Zvw64OSE93AsP+tkcaFzjKbDX7KSNTgV4TXXOyUJnipovzsynBWKK5NP?= =?us-ascii?Q?MFQMeeihmsgC5W7Bqx0/vViY9pgN96sNK6JYiLgf8iQpn4m4DbsJUuj6Lnbu?= =?us-ascii?Q?RVKNwW2PKGiO3OVxr7Ll0niYkh+Y4UdOtuIPr4dPKW6uJ+arMALsptZJLZ6n?= =?us-ascii?Q?xqN0zlmjBkgrbYOvowJyCJMkYeVke4TU6wQEbCqKR0BsCc4+TJ7VmBVc8wLi?= =?us-ascii?Q?WEu0eeTIeJEer9dRJRUJK01Jiz98moD6/M/e1CG8fONlM5cJLWzphs0zYWFU?= =?us-ascii?Q?LHXK2160btbXOKHUOrHIfEtYlvWiOsb6bZj+zZIHnNGw1/7kavN2b924fCIi?= =?us-ascii?Q?CqzX3Qpv3Vqmt1tu8i+XPgHKLX0IiEqsU1HJ93nJRdeFlmeXKirpKDOBKb4Q?= =?us-ascii?Q?eKVTsA9N1GcPgL584O39f+/RZBu2mtQnasrF63cGRqSOmW6geDS9HmQD9q40?= =?us-ascii?Q?smId19yx0tULEmLueaBMZdXzcQBqJTD6r8osv+PBFqFx7ge9KEPT5O3xeXlh?= =?us-ascii?Q?jb4ctTfEa8520d9YqhgpBpA1LrysU4ZtVYRhNI3t/sAARo9lu/BYv358J9+J?= =?us-ascii?Q?D/srco2B5bBSjgJSnz3dqNCe2dt6EN1ehjWVBwiUQGhZrC5BcPqL+mj8M7Hy?= =?us-ascii?Q?E5gyBR0nTPVhewvUelumSDqfUvcFgyjqZ+5pLTN8sSuecMCYUOqVbhWjPxEr?= =?us-ascii?Q?kIIRXVW9dbw3p8EgHdkUvRNXsJWaEDevcMn9SCkwb+YdC/Ldq5VHuJmrMO4U?= =?us-ascii?Q?1nqJBBOZI37blegbTQsOkn+H2m8rjp+HQ/ASr5VRhCPf88WtSBbF5J6rTQ4f?= =?us-ascii?Q?bv3u+tpoN8y+6i2Ft1rVS2WOetAwkRW8i0OxvT0j+lXTmMdPMdglxS4rnMbz?= =?us-ascii?Q?50TdsYpQJWiJNNyRxVfH5/2wwYfnEoMp8ZFOfW+xX62G2x1A8nQ7xREyo8s9?= =?us-ascii?Q?fQ0lY14d4xUSC/KYiMp5c7gzyQPyb3NyUyI3cOlK9R3/3VNqpWPcoMIldjWU?= =?us-ascii?Q?+umEjaRklByPW8R4ZVzT+bx7ebLy1mUShgQsfB7rMGBcB2xeoiQfP9HQ13xG?= =?us-ascii?Q?h1sXz0giPfI6MkAUMe+mMLOpotoEySatu7pkWeTLztdxu0z/qAeH9+blRor/?= =?us-ascii?Q?+toanKACYtNVvR6y9kyQ12D0+RcUQKl7C1ZrVU5yO2CRiCPGJc9jydeYF9Ew?= =?us-ascii?Q?pFxnT/ad0oQ5vxVxhy5WdVEobCc0UiyPlnLaukZoXCHna/W6tkUQs8BFOYBB?= =?us-ascii?Q?ysOzLqkSJZMQAb6FQfKdMshLGToraf+Wofycp3s7gFMzLLioTiE4xIaUAsfg?= =?us-ascii?Q?+fyiEp5xw/DRiJxNNeRiTIDhnANbUWfWD5O79lfF1URxIyl8KZV4TsKFK+PE?= =?us-ascii?Q?RA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f8ff6fb2-169a-4f73-e9eb-08dc9aa6040c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2024 14:48:20.4926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lggqq9U6g6uhp5OudLacRuGl0Tt+vtUBg9Y1e7CxQfzcqc0Ng17LGvmISci6eLn8ntbooZQxnBDn84hAl/oMe1ckESEfgmFbXIb68WhyowM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8038 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 30, 2024 at 05:04:39PM +0300, Taras Bilous wrote: > Hi All, > I see that GENEVE tunnel type is currently not supported in > i40e_dev_udp_tunnel_port_add(). Is there any reason for this or a > roadmap for when this is planned to be done? I looked into the latest > DPDK (24.03) and it is still not available there. > I'm using XXV710 with an i40e driver and want to associate UDP port > 6081 as a GENEVE tunnel on all ports so that RSS works correctly and > distributes traffic based on inner packets. I checked the XXV710 > datasheet and found that the following patch works for me, but I would > like someone else familiar with this to take a look at it. > --- a/drivers/net/i40e/base/i40e_adminq_cmd.h > +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h > @@ -2800,7 +2800,7 @@ struct i40e_aqc_add_udp_tunnel { > u8 reserved0[3]; > u8 protocol_type; > #define I40E_AQC_TUNNEL_TYPE_VXLAN 0x00 > -#define I40E_AQC_TUNNEL_TYPE_NGE 0x01 > +#define I40E_AQC_TUNNEL_TYPE_GENEVE 0x01 > #define I40E_AQC_TUNNEL_TYPE_TEREDO 0x10 > #define I40E_AQC_TUNNEL_TYPE_VXLAN_GPE 0x11 > u8 reserved1[10]; > diff --git a/drivers/net/i40e/i40e_ethdev.c > b/drivers/net/i40e/i40e_ethdev.c > index cb0070f..464e0be 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -8753,6 +8753,9 @@ i40e_dev_udp_tunnel_port_add(struct rte_eth_dev > *dev, > I40E_AQC_TUNNEL_TYPE_VXLAN_GPE); > break; > case RTE_ETH_TUNNEL_TYPE_GENEVE: > + ret = i40e_add_vxlan_port(pf, udp_tunnel->udp_port, > + I40E_AQC_TUNNEL_TYPE_GENEVE); > + break; > case RTE_ETH_TUNNEL_TYPE_TEREDO: > Best regards, > Taras Hi Taras, Follwing a quick consultation of the datasheet, your proposed patch looks fine to me - especially if it works for you in reality too! :-) Can you please submit your change above as a proper patch with appropriate commit message and sign-off, and I'll try and merge it into the dpdk-next-net-intel tree for inclusion in the next DPDK release. Some guidelines for doing a proper DPDK patch can be found at [1], with guide on doing a commit title and body at [2] and [3] on that page. Thanks, /Bruce [1] https://doc.dpdk.org/guides-24.03/contributing/patches.html [2] https://doc.dpdk.org/guides-24.03/contributing/patches.html#commit-messages-subject-line [3] https://doc.dpdk.org/guides-24.03/contributing/patches.html#commit-messages-body