From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1A2B45589; Thu, 4 Jul 2024 14:49:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEFEB40280; Thu, 4 Jul 2024 14:49:42 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 183F74025C for ; Thu, 4 Jul 2024 14:49:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720097381; x=1751633381; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=oO8txy48k1CBvV2lEP8J2+L9vFqWzes1ibl6NQc/WgE=; b=Sll3ug8ES1E9Rtat1A4vpE6FBDp4va1Izk5xOAZ9XLQ3d6i+frWdVycU ZbVzFoF0DrISDOtsphYEePqGC2IX8GPW9AMAbfZKphGwHZvJxdChFOev9 glc+6y1cuHdHD6pShJEZD+fclHiIdJal4ldGvCgcdVj6Gh7X9LKUBI82E jJYIPy5DjZiCy1OOXP3pGvASA9ak5c7bJ7LCFTfEnSAPcoNsFfdGugDTG 2+WsDWi+MfHfUhc7248c8MRxkSfDhLbZvUMbYoaYvaQgs8mBmtbejpHsM XBEOpqZK7VvPzgL65+tz4lQbleHTZuoAhPoX+4/YuV2jxI6asxb+KaDfM w==; X-CSE-ConnectionGUID: PtvxZBDoTke6v4w9gjKOcg== X-CSE-MsgGUID: uJIMDRgsTE+F+xw62kulyQ== X-IronPort-AV: E=McAfee;i="6700,10204,11122"; a="21184158" X-IronPort-AV: E=Sophos;i="6.09,183,1716274800"; d="scan'208";a="21184158" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2024 05:49:40 -0700 X-CSE-ConnectionGUID: IFZyWugNT92lomdcXdkGMA== X-CSE-MsgGUID: 9FhX3JA8SlONjVh0ofGHpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,183,1716274800"; d="scan'208";a="51545900" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Jul 2024 05:49:40 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 4 Jul 2024 05:49:39 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 4 Jul 2024 05:49:39 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 4 Jul 2024 05:49:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gejtw5SMoT2bv8+B/yH1ovAGQaoimLiPpKYH7bSJ47KmTw1/3sXRLF8UcacwtKEXthZtXG7ClxjMc2m9f9mBTtpa4sdupGUGi9yS6kWksRkWrJUhv5XN4Kz3mpYfzlxMWR74o0VveaUyC7jyusX9gn0efxPalAcjwieKv6p4gbEv/HMPL7L09bMrmyoUGO7ECc2MgUrPa7PBG8uJ11ywFfXku3nsYW6pMVHzi+jphnyhymGH6CPdCGlerbk1bJlQS4PNIE59RRgNadeUIssv6etBVZlGWl21y+H3m+EHH0IMn4/N5x+OidTpwmUrtBi/wYzSLa9gHJLwUz9J1vzLDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ePsCd6HTjIXbYGv/KJdjDmjincMdnYDzua+50HXEaYM=; b=A4LEgF7RFJm7h/prsydnfnIUWBgP4MbfM4zg1EnkPGjDtkuWz32A3hicWd1yiWcDjdt9rnqhLlYwxrttZ6aJQZy8s0DOg0e2hZRI74krJ1ckkRfN0UpZabQSeTqQgNvWhd2nrgLPOOw7UkQqeK7tWjtB9ZP++4o9p8CjI7lv42nmsf5MF0anw7OS3LD/foUqyBdjGAoey+2/WRm9TP7igoyihX7hCMGb+jZOfCsvw2DAmBuBdsBg8H2cCcqOfYXaLo9P8a/tbQXgftzOuzgsNkHOc89nejIZ24p5kSALqVZUucbbXnSrFTSCt9E3SWQxEnuWT0I7OfozgVORUv8YmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV8PR11MB8680.namprd11.prod.outlook.com (2603:10b6:408:208::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.29; Thu, 4 Jul 2024 12:49:36 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7741.029; Thu, 4 Jul 2024 12:49:36 +0000 Date: Thu, 4 Jul 2024 13:49:27 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , Subject: Re: [PATCH v1] net/cpfl: add checks for received ctlq messages Message-ID: References: <20240704051835.2630052-1-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240704051835.2630052-1-soumyadeep.hore@intel.com> X-ClientProxiedBy: MI0P293CA0005.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:44::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV8PR11MB8680:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d6063f3-8d4c-46fe-8389-08dc9c27c2ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GjBvrs6SZWo11E1cPwZfXIEAXMCxq0v45LkPqbBjvnD6Q6TXCMeCAmyI5L5M?= =?us-ascii?Q?MknW9HMOB+WljZ2PZCnQ7cBAW0lwV30gyPGH9U5v8sUWdV5THQypysUcTiCu?= =?us-ascii?Q?y00G3auMGuOGclxQmpcLl/yGkYpZM1uVPeb0dbYJl1H3pdP6UWgNZj1HYjd6?= =?us-ascii?Q?1dbx3sILzWk8eso+LDzYq6J4egPVHQN88y2wPN4wfcxOOL9hbR0NZ2qkPY5h?= =?us-ascii?Q?3NVQFSTx+wDGxSHzH6VPrGzf6JMh+zRekdnVBcFyaOHwM+tZG4N3mK+Nvbw+?= =?us-ascii?Q?piqJaK1cfjLWHAtJ5djZUoRtM7yC0vPfUPakWFC9D90d/FigITzwHYd3u156?= =?us-ascii?Q?6LX/c6NO1dV47zcZAwp25tihJueNDvit06rKbnw943xUNTVdem4QgDTyiZto?= =?us-ascii?Q?+hQMcyp2jUv2PMjX/gQiXp0Z6HTI7k3jbxZ/wiVuyYR56M0VLdWSIcdYXKeI?= =?us-ascii?Q?4/PuoeQJ63Wxl+cXiuRzyrSNglr3UPVRMw9bJA1meDJ/CeSRjyOh0fqmovC8?= =?us-ascii?Q?ULd1vQ0XgBG3FVK8wtJ6i1FRg930Cl5kJc7VTzG22/RqnrWH4WDrayL/u6pj?= =?us-ascii?Q?1FeT5cojjgqTo1dvx1i2XdX3qD0ptB3E6u+aKaS/T11s3mSBUxUxiOlb8xAU?= =?us-ascii?Q?z5/oE5D1b6lYMzXsNuGjfXF7ulrqS8Qbtq6utHKVGmMO9IdX5mw/DAOUCO9V?= =?us-ascii?Q?rvYe0yyYLh02+z23xaLaYkst/qTgRaxm5YcV2I8+8FoTItNaoNE6WWx8MaKO?= =?us-ascii?Q?cw25YZBinHMWXGMWpJA52q4Adj2X/z1TPcCQPwCq8oPDY6a9NCVloy/ZJ0qr?= =?us-ascii?Q?2Lvi9nS2i7sYH2hId60g42Txm7QK1OWxEoVTVt0sOmoFynEvPsL5AlJ0fdii?= =?us-ascii?Q?EcuQNeRJYkqkiLK/IOJ7zz6odCT4FVSZ+GmeDsVCRd2TdIIS5Nu2TfbpYc4z?= =?us-ascii?Q?8W/3dEzWKN1adfp+M36x1p91unL2wqmC64seSriN3MdKnBfKdf84QGX0bYkd?= =?us-ascii?Q?wYzEPk6B8We93+WNoy0popWvqkCV0przhp0yztYvj46MyowS/mnUZ/Ms66S5?= =?us-ascii?Q?JSZPHssN7uWHVaoBkY6n4RibIW8ZqyENlV7AL83t9idRsy+9o78pxTnnzjFI?= =?us-ascii?Q?RwlWheFVNjwto6FQXEcFmzf76BKZKHD0/Gbtb419WIWqYKC/eSt1O8WTmOGc?= =?us-ascii?Q?9VP4hAx2M9sW1y9mux2ILQozN8hBz9ZtQpoGpzPozoMkUfPX1xtRMQsRqb7k?= =?us-ascii?Q?Cqod8FoRqD8bMpAzIv7Zu3Iu960svn1I9SCKrxktaE1e7xTajRfSeycL5cC5?= =?us-ascii?Q?PqsoFGMhbb6I8twpYt9p2M7RUmulgxKl+tli6KWAxq8VNw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WJeuMLfOO0bKp/6FXmengL4tVfyY/1dOoaB42nrj4k4iZ3XuODVz9J+Q4oOe?= =?us-ascii?Q?qcNHwho0vlwZTQ7akTt+14VjwpSqzOw6ev0k9TzAwSAw81iuBG+jF71FA3Dg?= =?us-ascii?Q?hwd0T9mXzHBqAxudvnsKbCJukvv3BaQsHeH+7S8X2IYW3t7RPT9/oTiU15ad?= =?us-ascii?Q?amWHdNhBKnOpKKfVuLOgwn6kHtXmKjvOllqB9EQeD/5bUPTOa7WzrkxYw2wS?= =?us-ascii?Q?+OKN2qcI0U4AulMRJPdUTnE5uPg5CwW8S7YobsQ8jgozv9s4Iqtt5vQhp8CD?= =?us-ascii?Q?E1uqgSXoX0JrKx7qylgEl6DCY1O9uySv9eGZmDpIXhruGwSGIa7OVxcLbn1V?= =?us-ascii?Q?WuB2fwyzSuk7Y2UUqC5dca0l3nz3NRaEqWkpsJSJyZH6PvECPc/T8suuNo54?= =?us-ascii?Q?8tZhdOwt8GT8ZELKVkiRiqKFhpy9eizC6obvoCBS/5O5CCPPp0mzsAvKP4sO?= =?us-ascii?Q?txlwcHZIQz2PRTo2R8d6d3j8TPh90MdyOdWL4Ruo63ozuE1rg6YeNuHaT8Ni?= =?us-ascii?Q?jQ31u58KIiVbZqtgX81MA4ggv69Xa4BvOz+Jdkmux13HBhlRpRq1xHhFdmSj?= =?us-ascii?Q?6JeVaykJjUePUfLTDI3XKutxaiZek3Corer/NqC/p6cqZ0/b6pCnOQfsqwCz?= =?us-ascii?Q?6M/X517hrBONzu2w4lHy2Ur9gzEq/mO34bBjhUpt74LezqnxIH09NSAUATo9?= =?us-ascii?Q?vinl46bIAgPzS49msv17vF0LrnsACJDMep7gCK3eoPzPUhcE1iJQNLv8IE8x?= =?us-ascii?Q?QAp2XTMkqehkmZV9TI+h6ytM2ot/7cus7ryYwtma3GAwedSESWE9dnvj+feq?= =?us-ascii?Q?RVZpzpAzJvo1dkkL9M3v0aFBL3RwWIdSdddi/s0luuosruBNZDKVnP3nE5qW?= =?us-ascii?Q?U2fOUp3NeJvlUHSz3XLLamCoSa++lAyLEl0BeLzpVoF+te0zvacSrewnt3Kz?= =?us-ascii?Q?Ckd41zE5CPfVFpdPDgPFtMn5mQx0w/M2LNUdFpY9YqfYPcK/BIP1zAsQI0CS?= =?us-ascii?Q?twZrFhcpp1254ICaeV9rZlH1a+rvBd3RrmvRgwsX6qw66meyZMDNWzHyUYxA?= =?us-ascii?Q?5ZyhLs+iC4D5Ho2dvbkEtYNkokPxxeM0529ULQFOZn+ZTmO6yCAQGp++Y6pi?= =?us-ascii?Q?7keL13hRQG+/LyKiXAbFjFUszbdYcumYGwzmciZzaOMt4LHWwgInxre25mfw?= =?us-ascii?Q?FC2c46BD8XzRYxVlg0Me8jrDgs/2NAnXd7WKpzW63DKDjGW7WADjw+L98nEM?= =?us-ascii?Q?s97Bc4cJuNGMPJReNixz126j5WHqKgcbBMJeJuUZMNNEWQgw/BHjtgz072CG?= =?us-ascii?Q?/Cpr3NUsZshR386pmXwGEs3lqC9zGi2x7jqD4qKvF65iB1dWUXMpcz0KVRch?= =?us-ascii?Q?Njrd9X9fcG//O+cFRSvDvVrsDHOCsMxIonyzsMFlD/dhUCWUr5mVyi4VfueW?= =?us-ascii?Q?jViOvPwBMbXX2iZ4F5zmJhJSaMNUPdz+CLNkdOOWBb/CeysSFKInfQb4QDO5?= =?us-ascii?Q?hiVgWwE3fSxuQCl5QsRNkCC/hHRkAC/8O3XerNawOFmyz7liTIh5IEvl7cmc?= =?us-ascii?Q?YIX//94QX0knrR0diVLBB2f+qOVSw3SSAfFRG7VDIeMa1jLUG8OrUo4LLMwX?= =?us-ascii?Q?Vg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9d6063f3-8d4c-46fe-8389-08dc9c27c2ac X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2024 12:49:36.5629 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ctU/hJc7C2aZ4eFDEy9GwHusj+B785XqYXKLSRP8dzcuBNKoEFItsnKvthibGj7yd5SQ6RYWeegN2MrzyrOv+EAlOnFujKXtT9VdpsMgq2U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8680 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 04, 2024 at 05:18:35AM +0000, Soumyadeep Hore wrote: > cpfl_process_rx_ctlq_msg() is used to check error status > returned for specific opcodes. > > Previously error codes were only -ve for > cpfl_receive_ctlq_msg() but now there are +ve error codes. > Hence code changes are made accordingly. > Is this a bugfix? If so, please reword title to start with "fix" and put in a fixes tag in the commit body here. If it fixes a commit not yet pulled to main I can merge the fix into the original commit in the net-intel tree. Also, I wonder if this patch should be split into two commits - one adding the new function for printing error messages, and the second for changing the return value check from < 0 to != 0. The two don't seem to be directly related to each other, so should be separate, I think. > Signed-off-by: Soumyadeep Hore > --- > drivers/net/cpfl/cpfl_flow_engine_fxp.c | 2 +- > drivers/net/cpfl/cpfl_fxp_rule.c | 52 +++++++++++++++++++++++++ > 2 files changed, 53 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c b/drivers/net/cpfl/cpfl_flow_engine_fxp.c > index 39a281fa61..983b4188e4 100644 > --- a/drivers/net/cpfl/cpfl_flow_engine_fxp.c > +++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c > @@ -95,7 +95,7 @@ cpfl_fxp_create(struct rte_eth_dev *dev, > > ret = cpfl_rule_process(itf, ad->ctlqp[cpq_id], ad->ctlqp[cpq_id + 1], > rim->rules, rim->rule_num, true); > - if (ret < 0) { > + if (ret) { Style nit - put in explicit "!= 0" for integer comparisons. > rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, > "cpfl filter create flow fail"); > rte_free(rim); Thanks, /Bruce