From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE11645594; Fri, 5 Jul 2024 10:39:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CC62402DD; Fri, 5 Jul 2024 10:39:51 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 068B24027E for ; Fri, 5 Jul 2024 10:39:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720168790; x=1751704790; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Ttdz4audZDT2e7E4mXD+t+FybtHfOVVURfhW3VCDmFw=; b=jo6g7I59jJ0ylPVyNdPWdGMhWZEHtwuZPNSwbTKV1EtmK6xLGOhJ14ck ApqrDtI4t8aeeXw1RBMl1rSEpM07yU7UEjy3ichOoG8mnmrUqFlXoVruQ OsugY6OP+Sm8PskfGuwsCEMnyZmnpOC1dFB7hrOyRLzeWPMEr8Ylytlhv ifGf64d+bsrrYRfE+ApAggoNy3hKhz0weL2VWFhgB8V5SiLp3RxzL8ZVE gHlHcjcadEdVson8SQOk3Gy4ubAuQVV4C57iQ2nSOvZ/KcS80D6VoXeZc mBu4HM3ChptNYjViopwI7vxmQLw6vYI2UMaC8fWvDaTzRoqbnYuBhIBIP w==; X-CSE-ConnectionGUID: /IazyZYkQGKZSlNLrBajDw== X-CSE-MsgGUID: y8dNsLGmSxq+DHRQmMufIw== X-IronPort-AV: E=McAfee;i="6700,10204,11123"; a="42876774" X-IronPort-AV: E=Sophos;i="6.09,184,1716274800"; d="scan'208";a="42876774" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2024 01:39:49 -0700 X-CSE-ConnectionGUID: eOn0FuOJSz2+u2yfFM0FhQ== X-CSE-MsgGUID: RKhI0EYgRVmqwHzmDnqLtg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,184,1716274800"; d="scan'208";a="46782398" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Jul 2024 01:39:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 5 Jul 2024 01:39:48 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 5 Jul 2024 01:39:48 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 5 Jul 2024 01:39:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JMgDKePBTUhfYqTP8eGZi4JhbMQB6m+vN835BD3RyhPpCz7QL+TtC3YPtRnzM67jjBViGOodvtUbZOoCUVqsiuS9Tmbj5W2XbF5BougmwzaNgi5WN+J6moQoVJOusJi+05YBmuofe+483yRy1c/bySddNjTDHmNFUnK/g/38I1bmWY5sYpWnNn4uJnSZuxkWR6UiUypYR+s9eoOLmaTYau6G1p+7Hi4zHRjT7QEsqA978aHmRnxUdkL+/Mx/NcOBtAKuQUrihisC64UGMe33sWf+9lCYeUeuwuZGC3tTfjsRxMzVGM4qUN/voZfuHr+d2YuRsmaMfIB67rdhMbexQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mk+QUDa8IvXy347ihB/uy0+qaNqY8ArOYmxGIMXyauU=; b=UNt3xCWuQdk7RKVPeTdV6hH187Kmn8lKY9c1YEIHkZzRx0/W09RjN/HWWOKYS1A41Ug9pGjBho9cW022G6lqMw8ou4yI/GgfeS7aSvHVyQ5FKod19M1VcUaGWHzHyy8AJSe9VGrhXpYEPJd9muUqEkFICcI80eYqtJYfSH4aHdaP6T8P1KOG7r5LqDzatfFXfQHMVNCzvW9lgVQw2ExANE4GnVlDehoq/I0rc8A+N74gGxiJ3ex1qGfQ3WJE3gB2CCYnsOj9SgEPaW7aq9A518QKhRaZEZ/I4G0b3yaxYQRp6moUpYiGN7gf0jBFQ0L83EJ4F45Gg0Z8o7u+7LZ81Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB8275.namprd11.prod.outlook.com (2603:10b6:510:1ae::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.29; Fri, 5 Jul 2024 08:39:45 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7741.029; Fri, 5 Jul 2024 08:39:38 +0000 Date: Fri, 5 Jul 2024 09:39:33 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Chengwen Feng , , , Subject: Re: [PATCH 0/4] cfgfile: enhance error detecting Message-ID: References: <20240220035840.32978-1-fengchengwen@huawei.com> <20240704144055.524c65e0@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240704144055.524c65e0@hermes.local> X-ClientProxiedBy: DU6P191CA0024.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB8275:EE_ X-MS-Office365-Filtering-Correlation-Id: bdda6a5e-6994-4bfc-3638-08dc9cce01d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2SnUb7jNmROMliRtKP5xYn1UWEJKlR2xk4TxhpXqeRoB3DZ/f2ph8a0egmmU?= =?us-ascii?Q?EV/rzR8Gv3hQeNlZCenA40QGvNdnHOmwUGCeUKngD6wSumSMeO6EVeol5e5z?= =?us-ascii?Q?YRgTDys64VKzLr1pD3cCEoyGhicGQjBZ5oF2z/9ZPG91/JG0m8UzQNBk8bBb?= =?us-ascii?Q?8+PLr1cER0RsXAMaCZwCikID/Y0UHCm+/0OWiDsfZ6J3lcEzzdXNcgJR9dVi?= =?us-ascii?Q?bNXHfcc/ITESKBUWg5nEavONd1JKNeXk3hxt29DcXJY7LnuzoPD3HNLorUi5?= =?us-ascii?Q?IWOuK1yVQiIuT3X8dc8+OX6ul1lGgqnIG5cG+M2r0WoKK0voJay5C87GSirQ?= =?us-ascii?Q?Z/AxANamqC+ApmfAGxIqMFJyd5ZbtOA+uz9RfDjXsbIqWc5dhIioVBUaJkrb?= =?us-ascii?Q?sFpB0bID/HWmAWqtnuZv9db0zF9XauCUngTg8/OXJvqx293cjPgxGnTLXX4g?= =?us-ascii?Q?S0Y3bMP+UN53jtxJ5ZUH1fV26Wr/vDJZ9cUPY3P6GnKMf+Lm4ywAczuaHYC5?= =?us-ascii?Q?y8DldiTeTeFBO814Ck5mGHJZqoYK/bJuZnFVV0ME11C50iW6dYeg7IpPUt8t?= =?us-ascii?Q?sCcElorZxskVrXJDDHLUSk0UGs1fUoAM/kLzddDlR5Z0C45A2B/aRd6RVgmF?= =?us-ascii?Q?CGWMlX8PKZFGWJRGMIYlYLLkyjwCS0IGiWlTgxr4+l/gO/CvOsCE8uLxQ9Vl?= =?us-ascii?Q?6wMckjMeNaJ7mZddau9pjdON2XpJQWXzxcGcy0gmAmug5CvcJshYjZ2uQ645?= =?us-ascii?Q?EPVb/nSxa5u0WPQEOOUIU4rNSIhu7BBEVixOuvv62zb/ZzJCUhjNhvQLxC+U?= =?us-ascii?Q?NBdJGCv4DEznBJEXrauS9FirSdFXTYXATw/ET46bQpayNhWtcciTL6fQ3xZt?= =?us-ascii?Q?6UE0cf4pX0fTlBnXANfD/FFbyACWhYChA7e6ST0Y7PQTyfR+bdDAjf+10b1H?= =?us-ascii?Q?bzVvMetbpVCq4sXRuuje9fiA3b/kQ1IQ64q7Gw2bh/ojo7uc8ijQm9SCDW2F?= =?us-ascii?Q?ycOcc8iqovETVD9OzdDtMBxRWAyWxehH8Xr1jJlJL6lcbybWr6EbaS2dZew3?= =?us-ascii?Q?EKVdyHt4KHygDR5P4ubTo2pFWErPKyensOvOQVybonFcGpq3yFxPLA6fBzVS?= =?us-ascii?Q?2SyuLAIq26eCd8PAyrqyR2dC4jODnVmEr5RCGL1R+A2+S+z9CuC8j1YisMIy?= =?us-ascii?Q?T1Zs6do6Ya9Fz2ULjQDilGBpc7g7tCkx5CGirVj9aQhiGWLb7B72jXDoF9gc?= =?us-ascii?Q?oKC7nCQcFbd9AFzY5WiWHeaq9FWzVdgYeNW+g4NxIJktmJdD/daQYNeWqr6/?= =?us-ascii?Q?PMsHQB2IdZVlv8031xoJaLNjBFZ2Ybc35ENVv1pvZ8K1pA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XJ5HDDnHj0q9yP5hOIaSNkfhb03svdZLm03zfg+SlXA2LCozNBvW1+NE+9fT?= =?us-ascii?Q?+nKUc/7uyHB3ig6dojAfEGIZFFGSC1SacKUgt2UihE+8vXSm4hAxPw4FRESE?= =?us-ascii?Q?hbWF2yCPQ+CGVq/e+4cflW5tVKsN1YMRqcaou1s1VDx41DYLUKodT8HqKVhh?= =?us-ascii?Q?EoqKhppEeMWBq6lmOwHgwZ9p5n4bMzCeGjU5vE2PwCYX4e98diWFSMuMgxai?= =?us-ascii?Q?JyCMr89MAtpy+pNUf5ETZpmbAdhR07LxQeWEpSKCOO/p6NA3/QAKm/sHD1Cz?= =?us-ascii?Q?/po0Pknt5xBfc/7+cSczHLuqFtNXgbI+/zTaVsALiQhxyZPV4AiPA2MtBMC9?= =?us-ascii?Q?GzUs1Ou1UW3smvD1JpfHiGJE6ypJhfhcxwehXL9zaITB/wZf7GtzrePZHIEc?= =?us-ascii?Q?aGUYyz4ZH1ruskURuaekqHFUFf4Cnu4FuVwnfcBsg3TXaV7Xdc06d32xwxuZ?= =?us-ascii?Q?jszEJKyETXIV2ty55XMLRme9/7aK9RulYSbVXDQWOvwzM8Xu0vvf5bha1Krq?= =?us-ascii?Q?hWwHLxcrlToOBF3f0skdJp6InTv5HW0o8Zoe3Lk7kOCiYVdZY1HMF3FtDoVb?= =?us-ascii?Q?A3BTOL3MBi6tDyAVh7bQVQIOPoy9whfrcYxJIfjpV0tFbHCKz6KYY6OMZ2Zf?= =?us-ascii?Q?03Fr2X0ARIbbn0BeafxKXq8iyGtxt2R/oEnYIali4zDAh0dEdvHYt2IaPw7r?= =?us-ascii?Q?SBH7JoWBKL/L3xhas3CmjjCbB7TFV+gqmq2nkx69DubjUIKugEDdt2r4IKF7?= =?us-ascii?Q?vdd/568gQBMhj+/5w0rFiqGEvPSDHAuPwBUmEGp6YIb1uRzNLW2TnAVqTw3a?= =?us-ascii?Q?82TWy2+J6rsGNm1mz2fhKrK8MzqddQWupNUrCbQ8uew2V+mpCHkI1UGICODO?= =?us-ascii?Q?e0SUrGMZA0dgn4EGoCqGP5CMQwXX+LH2WaSAsCnGIGQj69N3E+6d96a/Fr1y?= =?us-ascii?Q?L120xfMF7UMXy0D/xgezA/i562kuXwHCGKY3RV1tHNooW3y2GksdwBCVvKYN?= =?us-ascii?Q?SdEyCK3fYGFufitj0BhDfNzBKyjf441b9RcVN7PocP6/YXRDjplCg9TUDI/4?= =?us-ascii?Q?g89ALfX3dsUfHSu9xVDtZLiyZXs5xXdlCXL7EwpDgE20tImrt//mnbioPcEA?= =?us-ascii?Q?Bp3mIacQJ6SVbHBF2oT4GUM6pdFWQc7M4KKv+GWhljUuxSdxZwRRDhyeDhlh?= =?us-ascii?Q?viioyDdbwkkxdAAN5OKc/yq2qkIxYhYOuZpb8uEKZhhH95/wa8ort0tw3KWb?= =?us-ascii?Q?xEUJ9bEbh5bZLT/ARG8DyWp0NVeftCJEGADB4HroQqkljW268XKO2bm9MMb5?= =?us-ascii?Q?3WW4h5fMadMdkBRoFdWuzpCfOQy0jkSA3sXJlLYnCl6seWD1NS3vbFSstiJz?= =?us-ascii?Q?+IjxmUdIugeVB9rjXXQqmN/qKrZcOQ2ufa2ELihk+eSdjGweCrJviU2CBTVe?= =?us-ascii?Q?0p8/CCxMWfuUXSwmJiWpzIYPSpha98XqswJjHbtQUiG7xBSvtu9DMCfAPgFe?= =?us-ascii?Q?I9v2c2GdCo9ImEuvYGbvjbBnMTKIYW2B8qUOQUZnoiDMXCSAcKT1n48+6pae?= =?us-ascii?Q?Bsp3iPmQPk+oGfc17u5Fs9gFyOj5fUjKYzD7jJ6BDnka71mz5bw/5shPox6G?= =?us-ascii?Q?KA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bdda6a5e-6994-4bfc-3638-08dc9cce01d7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2024 08:39:38.8799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U6+7FwBmG8rn337WOYmxy1VIQPhRSFJ4Q8QHckRIhZ4V6+V3jHUWEpWz+59r32nYx56FQKDn3ks/ytdvXlex7k9lMX+CSS3cTC2fduz9+ic= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8275 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 04, 2024 at 02:40:55PM -0700, Stephen Hemminger wrote: > On Tue, 20 Feb 2024 03:58:36 +0000 > Chengwen Feng wrote: > > > When I was trying to debug a problem introduced by config.ini in > > test-dma-perf, I found the cfgfile library should enhance error > > detecting, so got this patchset. > > > > Chengwen Feng (4): > > cfgfile: remove dead code > > cfgfile: support verify name and value > > cfgfile: verify add section and entry result > > cfgfile: add unique name flag > > > > lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++---------- > > lib/cfgfile/rte_cfgfile.h | 7 ++++ > > 2 files changed, 59 insertions(+), 18 deletions(-) > > > > > The existing cfgfile in DPDK is quite limited, and there are better > libraries available; not sure why a reinvention was necessary. > At the time, it was done to avoid having additional external dependencies. Since then, it's generally been relatively trouble free, so it's never been felt worth the effort to replace, I suspect. /Bruce