From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07D1B4559A; Fri, 5 Jul 2024 16:21:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2E43410D5; Fri, 5 Jul 2024 16:21:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id C85A6410D4; Fri, 5 Jul 2024 16:21:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720189293; x=1751725293; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=yPQnBP0sziAJeg7W6lmGOxbIQeyH/gpPUi4n50+DZZs=; b=WbOwf8gcz4ohwsbCvZpr/b1Ji0LxKI0Z+RJC/tgFsRsSgqu1yNzCgLVZ oyPt79TUoCpLgBi0jJSFR2nXqPuUUZfYxXp845Z3rDrGC4Msn5B9vkFzN /MQ0Ur3sL6D+3KHLTtVHhAriFqowDsuS9s0c4nE0QLnhgMneVJMaA3y4J ADXF09ihi3MiC42bzO15r9FuerqqCIhvEwyXYvMCBQlRGtKxgR3B5EoKg CgaJS2yNvhceLGeJNzOVtlcMq6lPhmE0m8UDZ4KxclzTa1gRbp+DVKxeq aN/SkvfpHBtH/5owrb7fqlJgASnivsK5MRQ3avf4QyALoEv2p9Juheyj6 Q==; X-CSE-ConnectionGUID: 6CgbCB08T7ePfEf6z0EEBw== X-CSE-MsgGUID: +n2pTRDnRlyyayF54KYhcA== X-IronPort-AV: E=McAfee;i="6700,10204,11123"; a="17627037" X-IronPort-AV: E=Sophos;i="6.09,184,1716274800"; d="scan'208";a="17627037" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2024 07:21:32 -0700 X-CSE-ConnectionGUID: vStKTq8ATUSbzmEXCfiMlg== X-CSE-MsgGUID: wCW15BeySpuvkeUQRcQYIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,184,1716274800"; d="scan'208";a="47544917" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Jul 2024 07:21:32 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 5 Jul 2024 07:21:31 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 5 Jul 2024 07:21:30 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 5 Jul 2024 07:21:30 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 5 Jul 2024 07:21:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NemTuHEAp0qDd0gKDUxfx/zxeWKAuHQ9lQeKMuhM6gMeLcx22CFvkYhg+nG7MdRQclmBD1EeDYbCTl63sZXdHWJow33DLSIe2bwhUrxICPxDRGG23s7PKJil+GBDhVkDcKgYroB+C2GpfayQjG4wqjdYOxWoNRMkPUG5SmvxNIa/lrxTR4gj6Y21i1osnjJQ06OBqGlVdLJEf+oLL8b7hfiY/WbZG8A+h93sfJQSx1KG7VQ1BHdORgSqor+S7Xe1R9w8RmkmihyZBEhuwFXHFsIMz8wkxpOYfyLqUcOJ+VSZv3WWE5a5WZXtijFN3c2NlhHzt9DvBxjyuocpGFw61Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RnHX35ZnxbUqnlAa9PfBx0JbduFtYVLqUdoqybmdVkg=; b=U62jZueVXbXVEWlg7qfs6Z6H9RUTHALjAZ12gzdp2ERQggV3athW7SlDtcBlcJVILZv5D4BqjKSTjQAW05yLd3i9G33jFxrts3xSeprivHr0cvITBQmpty6lrbNICgpKZkBKz3oUYp20ifPKQtrB2FOqDU/+hf0CzEuEO5RJabffdGBYQ2lRvlJHgRuxm9l9Q8JNPQX93PZt9zOyzqVNbGfyOvdmwXnNErWHoWGFcGKvsaRahhbpOVtstx20dspzY3sz2ck5dnyyJ3R5aqLyTeXjKnVmCwRdfzKZGc5XUaY1tp9Ng4wWy3QeJ5D4+1jqfFC/NCVZ7ZiuYRM8M/455g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB4961.namprd11.prod.outlook.com (2603:10b6:303:93::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.28; Fri, 5 Jul 2024 14:21:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7741.029; Fri, 5 Jul 2024 14:21:27 +0000 Date: Fri, 5 Jul 2024 15:21:20 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , , Subject: Re: [PATCH v4 1/2] net/cpfl: fix check for opcodes of received ctlq messages Message-ID: References: <20240705083032.2756071-3-soumyadeep.hore@intel.com> <20240705130515.3090598-1-soumyadeep.hore@intel.com> <20240705130515.3090598-2-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240705130515.3090598-2-soumyadeep.hore@intel.com> X-ClientProxiedBy: DU2P250CA0023.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB4961:EE_ X-MS-Office365-Filtering-Correlation-Id: 16612468-2f19-4d07-b4f6-08dc9cfdc1b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?vHs+wUGuRu70/+xaPqsyIT4+gBwbcpPVBIRXBqmz2IFtMuPMdjiPdT9QYyse?= =?us-ascii?Q?hU3H//ifHVTdsUoczG90hkvBO2WFZGscSf4pB2HnfhOsVf8kX4O4WgJHU/cg?= =?us-ascii?Q?yL1L8+4+XJgfm3xPMOo/FiEGtX4EGdr8FoAGV8dLVIVOIpTS/gycIRRlgNxs?= =?us-ascii?Q?AkRBfhCH3jFibyMOt9Qq4T3mpaL3qm/fZNKuwJWOVGtgsuJBb9ldOmSp1oAH?= =?us-ascii?Q?UDuA+0io/hzNEFCpasuysMn6ZaAOuEgC1aT8GTuJ4VrB21x49YkRjsKeCU0T?= =?us-ascii?Q?+/3orCYU0hbs9lDGcNBgmzM8dEglVz7Cig/84JgH1SgZJHqHH+YKwgOv2XLW?= =?us-ascii?Q?Q8EhFEYhFU4u8vXH8jHQqQ7v2wPTlM0TiwOmunW/zfQy7lrmgNZYjMhsX2FY?= =?us-ascii?Q?TBPMPV/byTtA8LVZ16rP8tsd7R7GA4V2BFB/MCSkWg4YpkbyKd6cjSV46Dfx?= =?us-ascii?Q?d9iPpdplL1wlxQjgV+QF0IrE74Rr/GCsvoVNZJplU/3yajITj6GWJF/gaoeJ?= =?us-ascii?Q?NEXGTqQHFklcQi32ewr+t1Wyvsq/egviwTWeXDsQdKfoVl03OJJkk9CQM5Sk?= =?us-ascii?Q?PTdcxr+oRfqzsSu1luSQkTJaZa+gHawINvK4VPMRABDy8iugB/143wmS7JYe?= =?us-ascii?Q?ncjkD5NkhWM1B9lWQbnCXGXoKX5E99GF2b2ERXOxzKbZ7Z28plWDcdV7bcbR?= =?us-ascii?Q?z3f3bx92kRGlf9z/595vygD7nPZ9zhj7RdfbQEuBFVZ83uXMz2fmLMKmiS81?= =?us-ascii?Q?XoI0jSRAlGe8R7GA75qiWOCiNK6aDhSCs1eqT7zzRXkD1W3q1P8agfZJtmJA?= =?us-ascii?Q?tcB0CDHLM2ydRDRQzsZA5rfp3FCcvBbRyr62HHOXJUeNLrKGgUM3e15HLxGW?= =?us-ascii?Q?WrTXYhVEIEJh7Ig70buFSMUfKCeYn2dzBXLCSXjBWSvB2u9Yesu/EPBcnd35?= =?us-ascii?Q?QfSrllRpi2on2kYXiCm1FOfI+bM8txe0Vfy61BhINRSlu0IS/WIlrlkw8/iq?= =?us-ascii?Q?FVWpWW4Z/rR3ILkx+GUw32P0f2xGE9YQprW1tr23ZZ1sFdmDWwFYVMRQ93JI?= =?us-ascii?Q?DKO6vgSmw6tt2XdERr+ecRGXymFyyB25PB+LD8n8GzMx7RccKjNmilFkEd7I?= =?us-ascii?Q?SPii0dZC9X2Y8atVuXoX5vKURMNKOTe5x1lzXPAKLjgFoh20Bh8wOYzEqf6J?= =?us-ascii?Q?JahjEBYaN6QTuIbMC/DOXXCICiMkTdKrEEcFXdGyDkLF+9xSV4Z1I47OAuXW?= =?us-ascii?Q?4xEh+9GseukdZkM9lAs+C9umXAk4Pkl9mi7erXZgoiAXsPL8jmFqCjlpPpm0?= =?us-ascii?Q?HUFLscPmsf9ovlk/tpms62fMmTt8U7ufvVYDZwWrc8rHAQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?834CjEsMlRvVaX1TjRtU49vpC+Kfwl63rehqoeTPdJ27EsEVbUd8BT1qnBY6?= =?us-ascii?Q?E1gKNOKMKgmgKfvVX4ny3oPVGgTlB1oJDiADG2hJSJEP1V2LOw6MaHbErkCM?= =?us-ascii?Q?Ra458sXZSUXuaIYnGSERJb0sdCKKvHhhxyNxMI63kac5NQKCSm1cfVzk/XVi?= =?us-ascii?Q?ncEwnA6tcmlYAcw6O+qAVcqh4usaqiqIhNkABSmYE6AAGpJ1d0IDn1MnI1tA?= =?us-ascii?Q?ejS138jEcV1oKAUcik6pA1oCijuoyywGIJpDixXKc34S8VIvizg3nLQzpgy9?= =?us-ascii?Q?sHWD2FfnnHdKNh38Qd/ycZK7A8Pk5TwkZZFpqWn/3XujeUz73JfIDdB9yRcc?= =?us-ascii?Q?pcCd4MBTpNnZN7xwMr/Rcm9KfkBmUQwRyr08JNLoQ6l4m7EkmvfJe0GF2bZC?= =?us-ascii?Q?cW4bcMPjJ1Ck8kOpuzGqE50QjSHa++F59pFx0iSGqIBwl5FCpSlIzQKib2F7?= =?us-ascii?Q?HWOHldPxKAsWr4z9PH0crxA9SJpt1fA99skAZBj8D9O4FTdQeO0qQrGx1tvB?= =?us-ascii?Q?axctnYOhkCpmrH3CGLr3elwulH6hoxX4b8UIyO0XMSVm5J8zsc6GAWIxvLZu?= =?us-ascii?Q?OM7pvLelhtYt2BKRKupG97COObCzSXYNas3kYjL6g8FWb7+nKHBGEWO2TJ4F?= =?us-ascii?Q?8fOUIS+B9l3adq3BMBnJlgccwYxOAfK40CCcbjmm19EL/d3WI9gXmFTY6Oae?= =?us-ascii?Q?78LUkGMP+crCZZDHcUFaJSqjjeQcqkHO+SPiIPzUd9Xrye00tptVVDdnaKjP?= =?us-ascii?Q?UJI5tn/FL0JTxQOhx0qRtmpuBp7qzUr6kcLZEQGmHAuw92+sWy+wvEbh6UO0?= =?us-ascii?Q?p/DCxGqlwF/jutUD6gWINcYtQ+0IUVkk3Nt1pX8RxEfWp5zQLAMBT2J/tErS?= =?us-ascii?Q?uHAgKjZ0DH2ZROP4/xX+ul6BHmLdmDcZdq9bfo3bOYhgjKiXxeJQ6Ht9ZBAf?= =?us-ascii?Q?N7/jH3rNF3LWWFbzBIccdAgbRVGA+D+0Y98aicQxu/4zr8o6mcPxh8e6cGbV?= =?us-ascii?Q?9fM6s68cpoReiBUxwWitjnrVml4P56q9E9V7X7DNF3mkNOjoOHy3upeubY3l?= =?us-ascii?Q?jfmuRwmJNaaEInXvpwLO5oWVp5J605G2Ry2hCqnnYzkD5Zfo9Ad4/l77y2+u?= =?us-ascii?Q?1YrNIl6T/tAdyOf9R3eDo62H4fCTTMujGdcq2TD+NoIWXW5AzSUEBP6iOQdf?= =?us-ascii?Q?MEVRpg0Fe/KcRmtfxKCPSmhZcBLpUXzJ8YbBlZrLm7sJlGWaX+fCm6FM/Rac?= =?us-ascii?Q?nWGqd2EhVvFv1OdpqVSpqvBE3QzGUdfiKuaH9GbLOlYlP7rAmTh9FntXy4It?= =?us-ascii?Q?2rBUy7jHZXuKRQGZMi0EDuZojkEi76Up/15Jc6yxg/f+vkhU8Tl+YkhVhT88?= =?us-ascii?Q?w0M0L326qKJdrP67KO3juot99uHoQwwCqEyg+ip+AkTHvi79m3Dtp1575EUK?= =?us-ascii?Q?tCEx+hmnkmwby3U3tO48GrcrelnUwKXszfBF9vpLgfYsq6TVZx+rvZtjFAmJ?= =?us-ascii?Q?pw4WTyLmg7Sv3kYn8XsbX4JBOhEKGnbiRBDUXPQ0RB9DxUUF0wPQAPRk+kSx?= =?us-ascii?Q?4GZOUJsoUmTiyV1uGA3gD4tcQ74761ASYFNbSPNAvCNBWwAXcExLBHKBtfMr?= =?us-ascii?Q?yg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 16612468-2f19-4d07-b4f6-08dc9cfdc1b1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2024 14:21:27.2244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C0As57gDzSEn54roANYjl5RjKrN4TBodnvuzeJa/xaMgt1gKg3URxWgHXNdFW0tFpgayiOaWGgex3oluel5MLpOhfDDtCWGrzpAQPuvwBX8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4961 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 05, 2024 at 01:05:14PM +0000, Soumyadeep Hore wrote: > Include checks for error status returned for specific > opcodes and display error messages accordingly. > > Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") > Cc: stable@dpdk.org > > Signed-off-by: Soumyadeep Hore > --- > drivers/net/cpfl/cpfl_fxp_rule.c | 8 ++++++++ > drivers/net/cpfl/cpfl_rules.h | 11 +++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/net/cpfl/cpfl_fxp_rule.c b/drivers/net/cpfl/cpfl_fxp_rule.c > index 0e710a007b..f48ecd5656 100644 > --- a/drivers/net/cpfl/cpfl_fxp_rule.c > +++ b/drivers/net/cpfl/cpfl_fxp_rule.c > @@ -92,6 +92,14 @@ cpfl_receive_ctlq_msg(struct idpf_hw *hw, struct idpf_ctlq_info *cq, u16 num_q_m > > /* TODO - process rx controlq message */ > for (i = 0; i < num_q_msg; i++) { > + ret = q_msg[i].status; > + if (ret && DPDK style guide recommends doing explicit comparisons for conditionals, rather than relying on non-zero being true. Therefore this would be better as "if (ret != CPFL_CFG_PKT_ERR_OK &&" > + q_msg[i].opcode != cpfl_ctlq_sem_query_del_rule_hash_addr) { The indentation here is problematic as the line continuation aligns with the conditional body. Looking at the rest of this file, the continuation style is that of aligning with opening brackets so that should be used here too. > + PMD_INIT_LOG(ERR, "Failed to process rx_ctrlq msg: %s", > + cpfl_cfg_pkt_errormsg[ret]); > + return ret; > + } > + > if (q_msg[i].data_len > 0) > dma = q_msg[i].ctx.indirect.payload; > else If there is no objection, I'll fix both these comments on patch apply. /Bruce