From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D2514559A; Fri, 5 Jul 2024 16:47:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 094E9410D5; Fri, 5 Jul 2024 16:47:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id 36C0B410D4 for ; Fri, 5 Jul 2024 16:47:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720190855; x=1751726855; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=9vkcOapf0z8TD3CcWodSDfLld9te+oeI578dctXFrk0=; b=kXNX7UO+cogjx3t59WlhvmSf4OVar5ArQahcWqJdUyiv/dWFbo5Hliid KAqpeCmjW1G94w4ut/Ufe+KttBjPEiIV4VGvVO7Vjia60xNL3phmcciND Jha2JvPEqz+Ex1+tanDbsMxBx/DAM5hms+vHLs7aNdRzlKY8vu6nEFyjJ qRNY9xw1jdEu7WyN5AjAlTdRQsUNgZ2tzh4vLPeB+hcR33TaGQrzW+PQu VVoevlD17jLJTSv5zI9hAdio53Df2tH8zVuIW1+cmU93o9RGM39PFYxWb HbY7zstmFQMRyyLfyRBuM2fLyC2fPU3OU18Cyht54x/PwERYJBGv5AXod A==; X-CSE-ConnectionGUID: zH1WvGapSHWWLIadYNlGvA== X-CSE-MsgGUID: 8kYoAHDwTWiTDQXKSZd/uA== X-IronPort-AV: E=McAfee;i="6700,10204,11123"; a="17619404" X-IronPort-AV: E=Sophos;i="6.09,185,1716274800"; d="scan'208";a="17619404" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2024 07:47:34 -0700 X-CSE-ConnectionGUID: eLN102nYTZ6cCjrwI4UfXQ== X-CSE-MsgGUID: Y82qk/TUS1m8V78teUlN3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,185,1716274800"; d="scan'208";a="46894906" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Jul 2024 07:47:33 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 5 Jul 2024 07:47:33 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 5 Jul 2024 07:47:32 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 5 Jul 2024 07:47:32 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 5 Jul 2024 07:47:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oC7J2DSIPBEEsiCBMfgsuhUHzwG9ZljH2BSJ5DbZMNUov5hq+XtqdFoMqEHLx3JgxAE+yepwVgxYHuUHxck3PLpYMxxXXo49awtorI/psptei7BXbOLi8gK/P56IrbU/lRM4yiinZfq8lpUQYTba90AP7nvDjKsuWdRPkAX4MVSRcV/hIbF4Ys/SE7fKOrfwoHbaowvjc5ce+KK6rNAQn4wHQYo30oHuRNluknfO8GpAPauu7a5ZHdPAH83WBW3fQw+Qtvmw4r71AUAS3u3Xy0vSnDp4+YcBlMWNdR8RHIOcFqctGhCQx4kGm4VRJfr2qZQMQKT5QYGq+/F/Dcl06g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sNiDi3ZhRSqk2HuDB1+YLcknCICPFZL3jweb+BhB7+w=; b=Vqw3VAyWFmQLrNpOsonJruT/1UY/iI3zTUw8kEBbVmNv3+fXCrJrFiETDrDXa84PC4PqwTfRvU0GAqL//dQvQySg8HAwwBg+3lZXF60VfKmhbGX/uKAdWD8Af61KixwJwXgJHHTyCJqMu9SYqd6Cn5hI0dMS5WhGcn5aYsfPCmySrSmZS16t+NDz0vcAQcsCtEiMqdQaWGXYNA3SntUqkkF4+j40zk5UvvnJRZTf7iygZlb7YTMdHeGCbnWXLJ+j6LxbyZLv1U1j+K51GfcII9Qogl5wvkz72/eYDsYj+oOo/cz0Trrb5Y/8DvnGYqTB17bt+bF8U83+1OllRD10Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB5029.namprd11.prod.outlook.com (2603:10b6:510:30::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.30; Fri, 5 Jul 2024 14:47:30 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7741.029; Fri, 5 Jul 2024 14:47:30 +0000 Date: Fri, 5 Jul 2024 15:47:25 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , Subject: Re: [PATCH v4 0/2] Avoid rule duplication in CPFL PMD Message-ID: References: <20240705083032.2756071-3-soumyadeep.hore@intel.com> <20240705130515.3090598-1-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240705130515.3090598-1-soumyadeep.hore@intel.com> X-ClientProxiedBy: DB8PR03CA0010.eurprd03.prod.outlook.com (2603:10a6:10:be::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB5029:EE_ X-MS-Office365-Filtering-Correlation-Id: 547f7e36-9bd7-49ac-71eb-08dc9d016554 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8MVimBAxDRYZUv+O9NdLIZvVacLmAC42rZYlMQmApnNS0ESupQ+5575yA5tc?= =?us-ascii?Q?gf7e3gPd3d9W0QY+dTRHd+WyK+Wf/NxJb02IvdrBUnSn8peI2h5QOrFTwKPX?= =?us-ascii?Q?wHLWm4NDz9LJHaEPlqlLJHMM0peNPGj6a5ac3JRwQrXovwBH2WtWuqyLNMBx?= =?us-ascii?Q?2brALnjDvaGW0Z7w86GP4391UKv4ZLN6bO1ATiXOSyiPsj8JkQQ63pCCdxm1?= =?us-ascii?Q?wOLICWD9nZsqEcNSR+RAAG4tgc3TA9pYyFn36XNSPy/S7IUHCQGFWlD134k/?= =?us-ascii?Q?/AVGE5EzbEKc9oImHL6fXTa7QCKvDaJMRI6uox7GSF3H/UMQB5XKwF/lRQYm?= =?us-ascii?Q?SqGhYdOUxKW5gxap1EuPdVtf0ODNKUc/SO4X9BGvDzn4klwDte+vONmxr7JC?= =?us-ascii?Q?6R/xTOQFGzNHjAjg2lhL0tAnDjnaGzqk7L3N6Udz9LWNdvVD1qAWQ/gK3QL2?= =?us-ascii?Q?veUbfHf79+s8ybAVRnbiZLIHwbKZ6sALU3/CX8BJ3WExfLX10Kuc7Ekfcr4P?= =?us-ascii?Q?FDkfLVUUiRPHJlYzYJp3/bv/DqASk+uGUYAxFHCFsId+C/6mumdG8hwnn9Lj?= =?us-ascii?Q?ODOKu1sV95FImf/oayFZZqOW+NsyPfYfo6racoBC7IGPqvhQQOEtGKAsjeVR?= =?us-ascii?Q?VUCZ8L/vrfJc29F8tVGBACo3/Eaa0P73dqxNJBKUqSItYNw5C/Gnp22jXZYa?= =?us-ascii?Q?m2S5r9Qx/1DDCYV/ioMCIDjACRS9CeejQZROxiBm0tojxYRwoFrpZ057ofMa?= =?us-ascii?Q?G8HUUwef16F/v9eeHoj+rxov9uoHcUfyP61iFCcEuHStx/mwMS19fWWWg5Cm?= =?us-ascii?Q?YkMrFkIhxqPIl4eJVz+fh0tCf/6paJJUnH+KkU1cG9pCUxoBQ5uewJwS/ZoK?= =?us-ascii?Q?3awztymHisAIfjEKkKTqLO9WNdDmmaJh+APQn10iS5P/ooWUhON4knxTPsA1?= =?us-ascii?Q?Z7EhaUHOKlhIDb1sIif0llrDM1+NtfxwK4MnAfIAMpXqCtdcNV7XoinU/OP/?= =?us-ascii?Q?6j1c28nsjNY1Ej2HiP9IEAE/zdfUf2onZelzs93moFZTFo5pCTlWEbhzUqIK?= =?us-ascii?Q?GwgMyya/5eTvHcQgnO9zaRs+i1/7F2SPYPO9jOc62kSo7rSDXpkarLqoQE0Y?= =?us-ascii?Q?R2RzzyCNsF7nGnCQfBwBp6uAY3bbEiQkHhFnf/bHLzKlcDs1SwrG1vENIBqj?= =?us-ascii?Q?tiY0q7ooLBgQFsFIwAej7Fz0T6QlEQHERRtYdN2UGbC4I7jqKYjaYTJcXmvT?= =?us-ascii?Q?E6TSSeanNYhSYUq+JDAWZ9F91uvT7GfUlQw3KusX+HNDWMPltrTwUJRQUUqd?= =?us-ascii?Q?++Etcl9mJ250x2Jw1HJN3uuPEGSPQ6kg2K7s+WyAErRlag=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KvY3kTcVnNJmYeI1LOY91clv9e27Ux1yrfR8+/nl9m/iAqRM14qA0sF6F9r6?= =?us-ascii?Q?HB8p8mPN9wXK8s6w1hR4NlF1SAQPFvO0fDQfb75fvoTw0seuPscmWt6kyx+I?= =?us-ascii?Q?7W4FTSyNsIDDTHkGEQ+Ft487zbLQPp+65UYv7hKy8MmN3+LCxt5+LJESucBL?= =?us-ascii?Q?pE0dj6/CPwRpFRdJUkxE4hoqNJFw5skwqnEbMTBuYYE7SaTN3w6qVX+HZn47?= =?us-ascii?Q?GkHYhNMfrr2mehOHc2MxFMMNmIgFwZTdK54YriTQlJYu0PJrdOYlaBKM7xty?= =?us-ascii?Q?O3AMh/JtVBC8l4KmK1hDwpiwOeDyb3VHSMle2AiAoMy6ot7pC/DON5y8x44D?= =?us-ascii?Q?JNHCOyuHQUS8IHIxqaSHikTFS13yHiGNG2mjQLFQ9gI9y7pBM8o+2n59o7nd?= =?us-ascii?Q?eEg5DV4t7VWubt+hVILz62tpeK/yc2ia6LN3NIYVeUDEE+rDYORomNG7xoJy?= =?us-ascii?Q?6/SXJS/yyjGa2t8ct/wsUhiJbAnCw2iSqh/IGMhrgfSm+Y8pKHXfRzm9fMvo?= =?us-ascii?Q?oQygUOlQhlXSHO+xhBnlv1PTeJOKY70+VB7gGuqOz8sHXZW4Jq7DBRvJW7Vv?= =?us-ascii?Q?joIYpjtLhSlA4Br5Jkzsc+T3VF52p/eC1UPQye1IRLmzMDaYfDlnvXwPkj8E?= =?us-ascii?Q?bctwbDAIkODcIYPQIsJXesJpRDmvEKUsOEMhZivOG91zT8zpz3SAJT61euYe?= =?us-ascii?Q?gHAnnFRF9M657CNgtUM/iRbYdlM+Jjb/iSHYeYJJpkCJeElbyRRJoRWbmTXO?= =?us-ascii?Q?GMsMnAuzIuCJhsK/62gXxsno2PSjeEDncwo/jvVfhEG/+cGMn75lMu9beJdp?= =?us-ascii?Q?onTEYzVqDQnJkXc2txMnOF1f28vT5XW0t1iI/33Euze/8MEPbbtaMqvBhjRj?= =?us-ascii?Q?uEheQwpCOSfaI/Faa8bfOeaRo8jAwM9pc0aMi7ytSxOWx/FYT3HE011kcvVJ?= =?us-ascii?Q?BcLN2V/ZUwsQCoSZ7fHgH7GCEkd3Cqk1cdhpKNERRTz6E28oOar1h0IVXKAt?= =?us-ascii?Q?Pk4RBPMoG9RVZwhMQzYFRHOZ958hytaWL7snYxuGAaz5byIfNqTMpHAcgxmU?= =?us-ascii?Q?B3OYjDS4FbQCpJBX9w3Kgd1fmJIECFsqxsv1kUQiHLvLv8ld9fHUYdzig2GI?= =?us-ascii?Q?BbINsJ6wMTjYRpZifoYbznx600ux6WFVEGWtcxp6yEAZ76UNICWQMtT6yxBf?= =?us-ascii?Q?uvQzYEyuGn6bCaf4v/VEciiNfrOA7bwFbajRjXiRrfzLaVHGO0Th4g4dfT96?= =?us-ascii?Q?no0sckhDPPu5QXdoFkB+IJnOn2Gpjc8SCAFnR237orl+I5rwDrBsUSrB4GYO?= =?us-ascii?Q?cH+J1vbJNqk5eNNueyB/kwXmbDhiPfKE+rolZRj3+cSexyWOKzj2PTW99FV1?= =?us-ascii?Q?VPPEqg1rKNopMrtCnPxDpByX08CUDNRjZ6sizjTwMFDsyxQkhavRy2zSJGlM?= =?us-ascii?Q?HbsnIOECeNfaCc1MhNfwxCsIDgbO/JG4Ma/tldfEr2nZadK/KesZCYGyfCss?= =?us-ascii?Q?P9TnxP+h7wqLGk9aSluwekOASc0m2Ryy5fUnywHGhIN3RMAwZXYYiLUGwTD0?= =?us-ascii?Q?EV9JM55KfK3FPE67mspZ+s5HKJP0kOcF4FZtv/yO5XR034WLbqgu7arQeAl4?= =?us-ascii?Q?hQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 547f7e36-9bd7-49ac-71eb-08dc9d016554 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2024 14:47:30.1202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FXmHlz4zVgaba4k7hLTTUU//E6GnnYRvOULxEjsiOksxeopy6yCwmkFSFR7vIRzoFh7fRv15nO32HcXti0vbGCscybtrxtJK2X3HRmBBkNI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5029 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 05, 2024 at 01:05:13PM +0000, Soumyadeep Hore wrote: > This patchset avoids flow rule duplication which was possible > previously in CPFL PMD. > > --- > v4: > * Addressed pending review comments > --- > v3: > * Addressed pending review comments > --- > v2: > * Addressed review comments > * Added Fixes tags > * Fixed CI warnings > --- > > Soumyadeep Hore (2): > net/cpfl: fix check for opcodes of received ctlq messages > net/cpfl: fix +ve error codes for received ctlq messages > Following discussion with the author, I've applied these two patches and squashed them back into a single commit since both are needed together, with the patch 2 being required because of the patch 1 changes - something I missed on initial review. Patches Acked-by: Bruce Richardson Applied to dpdk-next-net-intel, with suggested minor changes. Thanks, /Bruce