From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCF4C45695; Tue, 23 Jul 2024 15:17:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B641742D66; Tue, 23 Jul 2024 15:17:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id D2B314021D for ; Tue, 23 Jul 2024 15:17:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721740653; x=1753276653; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=1zmkJqtggqHyXSeH6Tqb0cHx1lQt7Z/cK+1Te2Bh2YE=; b=Vat70EBWR2BSaijm0PejXHFZkAeK3BLzySCljO4D5P8oYUBZPMKt00ng p/r2RspwzPurm9dQpCVOyaG2V+sN9OQ/YnSyCFTFSSNy3+ypaQ7cwYgwh tVESdB7UO6kHOI863AzwFpjJ0Lgv5DpZ8xgDHRbyj9RQaQM3+mHbiqWrY HK42LhnGf4vXm7X9+4Ju8lPGxea6m/yH5M/YbTZMlI7OExFAiXG5hnmv2 w447KX7z0Ng6dYebMM/ztIg3EKwiktFnUxC/mBIWmSB3j8slxMSTkaBKs u6FtID0MNiJhYC7SB1G5FR0x9ZSLN3ZsjkqJjMafuqR9lGpU6Puodir3N g==; X-CSE-ConnectionGUID: OZrhXh9DRA+wSZvfCHZgdA== X-CSE-MsgGUID: v7w3R7GbS9K5WAi309KLyw== X-IronPort-AV: E=McAfee;i="6700,10204,11142"; a="30748712" X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="30748712" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2024 06:17:32 -0700 X-CSE-ConnectionGUID: Hw9c4Id6QfaOOX/AnnTGSA== X-CSE-MsgGUID: mjH9MwcqRYaUXFjNq44T9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="51903509" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jul 2024 06:17:32 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 06:17:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 06:17:31 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 23 Jul 2024 06:17:31 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 23 Jul 2024 06:17:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bdOOVWKUqkE8fXUDXeJ5q0+uWi6s0dLy8CrKjCZnx6wi1V7plpVJKIOvFKyetoL7OFS8UJ/EMJQENNK2IAMBA8x5GZqMQl1Sq8Yw0y3/dT7R8D80HjzUgcMGV68rqNOkx9KRLRpBmb4aNH3/wg2d0L/8XnE3m483XL4Znv49NuJcbpD3nISrda2DBq68mhFHJdRc+jyPcvAFe8EQ7SS3mn5EHL6ZMztIhFYG5ApZ7+3PG2JDqxAYheNSUvRk4SDDfzVDc+XQriLrywVNk1PdjbtO+sYJo1hSjVXnbPo86TWe4p3m5GE3dojrp5U0EhMRZKTt5Wdj9EHFmwuTqvdSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ja9Gq+YUaVb+TmZMTNVFqoVi0vLHZwvcDsADjaqjjvY=; b=cU5m84+Jj8pzaTep6m3bV2zB1xpILWe5xEqKJBGnJ0KWSE57s8d7F/SrvxHl0dC754r9T0AWWF5ydHjqSrjjMelvJB0JZjCf4pSX2SqgVIXNMTsuXryVRZe6SiHZRL3WPRRfMLIB3/0yZbC4JBphDBPLGxd5tk+ReOCI9rFeZr9KUkJQX8oEDJYcCblQxkD9cveWmdhLr7VntvrTcEbMaAKI0BYdIGNcGrl6SvOAZRi/6nL9ZkCi9iIyEvu3QfT+28cIBz6H3GzB10snUcoDoQO2A+j04+yiRFxPYCO5ZT8MrALnUFGwb5GJRY5eDLSmmB4YtYLtCmb8JIFpqc0sCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB6001.namprd11.prod.outlook.com (2603:10b6:208:385::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.28; Tue, 23 Jul 2024 13:17:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7784.016; Tue, 23 Jul 2024 13:17:27 +0000 Date: Tue, 23 Jul 2024 14:17:22 +0100 From: Bruce Richardson To: Anatoly Burakov CC: , Paul Greenwalt Subject: Re: [PATCH v1 1/1] net/ice: fix E830 PTP phy model Message-ID: References: <1f6ca9415c22415fc73d7bd72f220e09b5f79025.1721740015.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1f6ca9415c22415fc73d7bd72f220e09b5f79025.1721740015.git.anatoly.burakov@intel.com> X-ClientProxiedBy: DB9PR02CA0017.eurprd02.prod.outlook.com (2603:10a6:10:1d9::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL1PR11MB6001:EE_ X-MS-Office365-Filtering-Correlation-Id: 4022e700-8104-4e20-ad83-08dcab19cc61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2TN1SEsFUgml8HfCBvYaoLcC5Ma7BYBgBIv8/bnG9XWSZxe1InEcJYVD6wfj?= =?us-ascii?Q?SoRV4dUqcD9DxDBI3JwCLggXSYIeX34ijMrT8RLquqFVKjMBt8HEU6YSeJut?= =?us-ascii?Q?FcVQwp6rKLrD57rmhrKNQVZnogujFnd9sHKOupmkO5eREO2kTFuRYoGzAB8Y?= =?us-ascii?Q?zMK3xz++JSppCcWrF9kRn/DfZ/23PFO9hp8vi7vNr+O892onI7XtSGlE3JiK?= =?us-ascii?Q?wKdQ0EoLeLhdIvB8AzxFecvV7YQ6LDEPLOdmDKqdZPD0nkHgVh24ycAY6Hmn?= =?us-ascii?Q?bih9NhUxIemwvUPAuGxfWE3I3MZPh9brLseU3AZQkMDcFsQhMpMmiUvg4vMU?= =?us-ascii?Q?BstpeFfCFb1lN/4ftPwfGlxtvmAv840XcCA81Taca3btGjjzOEMWhkszIX6W?= =?us-ascii?Q?MgWmGsHegZVJII1H1JaPjtZpacSPXqpvSaCrjU5J66CrL7W6FqCeea7E98nL?= =?us-ascii?Q?0SwR3tDT2Qtbz2+1+YjMPM7dnY436wHoXYCMNjENckqwG+ikVlT/4uEhGv6D?= =?us-ascii?Q?0CoSARDOncPVZY83hT6PtF3UMuDuuygBW7zh4seoHBNxMVu29MEc4IM8Azxx?= =?us-ascii?Q?/aIzH0P1cS6HBk8VQP/ug5bwdeLgiCbfM6iFRisUDGre+bpkhAa9hbGnGow8?= =?us-ascii?Q?SPCpHXqVOJuiYU4tAhfwnpzBv2a7JrZBPXMYxgHBeS6FI25ord8tZ3qAEwxf?= =?us-ascii?Q?JbnfelrBzbHunzfpo8+Tl04TL361MO4VqO+2bpETVoCPnwpHdL7hvphKEbIj?= =?us-ascii?Q?lxkJvX/wZ2rR9MjMCm5yatrnRgloljxzzwInDlhrOeb0GASw2UxT90eQGQ0Z?= =?us-ascii?Q?MSG3bnIELRfTqfCSi0II0KXX+1bhyH1TjikAfvt3zOqPPorYkrmHfr5UTcBB?= =?us-ascii?Q?yByYEYfSYE/86CwD+Xp2Q3y0hGC3TPfqGJjmJ7ztiWDh3YfCAAgP7DxVmf1r?= =?us-ascii?Q?ualtpwfK7U9fPaBcu3ZTBESPVubO6KCwJ4Z0XA006dMXvzsX9GPkkznfZUEA?= =?us-ascii?Q?sH32oQT8p2KPTCh4OnzgkLWlI/f0C1hsnaGyJwvyI7poj0zgJd20vgEyWOAy?= =?us-ascii?Q?m/FmZuFKjpnOk1I48T8V0wfIcf5Rs/Dy8wMSVkVxmh7DwW6sCgxV8IEXGdUK?= =?us-ascii?Q?3MsKOeO+k+YZw3lM8bt2k+A4cB5VL4Sq5AnuC43zt4oQ5K3aogfHuAdcNu9z?= =?us-ascii?Q?2aXdlpsTEj9P8HT5eagQZUngyTZsg3wVlILyx1LuJ8lA7Ki73k4mHtLNmhzd?= =?us-ascii?Q?uAejFsFQI+t+VG8N5CsT89ALs4DJrKpGdB9VVgfpDapwCeHdNhC2uodrQPiO?= =?us-ascii?Q?U0FBiutpdLphyi80QOSmgQsN7w5Y6I8bv5tTGSDFILxXkw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/Rn9JenHXrwRqXR2RZxWIExoY7GwgssIl8cCWwu1aL/cTHgQ+fwsQNP1UB7Q?= =?us-ascii?Q?6G3ohwDlOqp+0d2qofgtN6OHTetQojt6yNk0qrR7ZyDcO6uwnx5sx1BRngVW?= =?us-ascii?Q?qi7JbLYqNp3a0lcnMZU8es1CKYRmZkarKx4Po6wEvxkFz53bnO6C68EKsq5c?= =?us-ascii?Q?CyjTFze8lqxpm0siopGDl5y+QkA33teYM7ZFRNnd9BYm1+ZC9L57MRAODA+e?= =?us-ascii?Q?QYBYslRNtOi0+eZfsxO03vW6/2duY08wCOdrgyI+5d4RWFOkPAtczUFE4xbf?= =?us-ascii?Q?/aHcKkKKTJwjb4NtKKY7I+WMbIPNF4Q34/b3vrGR3JaWMJqAa6NyYfeF0uMi?= =?us-ascii?Q?7P/CR4YBheusTrzyjmJBNuSOG2LB+ih/ifZ/2BIVp5fQDbWw1BFpXmNlCMU1?= =?us-ascii?Q?ELpALRpfNhTOPquv9aOFW5luEUkjFDY1n1jQO9R0LYb220xMC2hCbOrjuBoL?= =?us-ascii?Q?8zSESVCXD6fwb5tCsuedov4Kiq4Dp8d6GOETRqN1AiJqD9CelDQQEQKLCPgF?= =?us-ascii?Q?RHwUwB06Ual0CeSwZSitehX9zeHAxf27eaUZCXhJOwngbIbNunpBiCTBGm9d?= =?us-ascii?Q?w5ybJxIE98yUKgavk/brUd6PTQ5uCPkMoDrcZPUArMKUQRBwt4MunozbCUzR?= =?us-ascii?Q?RDUY6VL5r3yJjRjSxZwhdjQXNNP3JqPLp+SIHdBJty7SHwZ7FTujC3JuOQvg?= =?us-ascii?Q?ce09JT5xfqfNISJ4hJDCEZXX3KB26AxgATDhRdLtL5SxibwtBnOLDIlAVFpW?= =?us-ascii?Q?Xw5lhA4bv2UbQlr672XilJq3KqlIqOy9hGwziqplGQXpbEycF7acxztp2lhY?= =?us-ascii?Q?uRPQg6lUrPsQERPZhg0lIf3XlsRuOikL8PJkkc7fP6ui4oeOi7xKCQ0ez7qv?= =?us-ascii?Q?Y8xzTwBk7gsGJ16E8SBqRCHlP/akyKWOWRX1j3MUZ+VDhhmtz3G6pTIVXta+?= =?us-ascii?Q?S0hb34EFbOqIc8802INm6xNeJhbEJrpNCeDWBKeU7ur5EVzWWX0AfbZ9oJBD?= =?us-ascii?Q?Jq/gtwI2lbu7liofCPM8zKEQCxyVxI7izTtL1rEGEJwP8AfuUgRPUJ/W/GvV?= =?us-ascii?Q?Xwl/OxxDQPVastbHMdwrdsysCTfOmqc6TnuayO1iIbzbO18Ts9jipImLm/ib?= =?us-ascii?Q?oaiuURvVItuTceyYz7SEGQd5ZXFE4sm8YO+RG9iyI764iGxLDpBadP9kfZhy?= =?us-ascii?Q?64xSIWXeqpHDK5W8WjSWTix4J9cFEkKG7ND0iw/UVU+PA4MEJZjEG2q8fYNb?= =?us-ascii?Q?8hm5XwcmVwhfR4XbBfXs33v4y3h1w0E7GuFjHyWztQ7DRU8TqX+EMj8akDLl?= =?us-ascii?Q?hjZBmoz+/ad84NSxEERu426IycmhjqBVInmib8emJLc3YK1DARDtKh5+NOPm?= =?us-ascii?Q?/5Z9KbdTMb5qOWV46jR0Mh2dDNFKEaRf5x08K+GfnnZfCpqWRXUKBonY+EI6?= =?us-ascii?Q?ooSDfnGDIVt/vBUcOq8sDnERggCPOQ9g/q3Yp09OEjoGIYAzNB1EosEklhoK?= =?us-ascii?Q?xz2Eyb6Xe8oZxwbRFOf64/copDfRczPkAX88wS0Ah4ELkdN5m+yKOWpoDVvu?= =?us-ascii?Q?ZnOFvmVyrQIct2PDgRfCzXdT2YsfRYwp7+T545ew87c04u6KA/QIaqMzm3dq?= =?us-ascii?Q?6A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4022e700-8104-4e20-ad83-08dcab19cc61 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 13:17:27.3905 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A73ex10xrYS04/G0foq5YEqU7SMfceI3FNn2z5qIZAAsDgGY9tL9+AnyyB8jA94M1Py2uNjlHCHSAsYHhCocAveelGZ2Jbh/wO11Wr4yCUo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6001 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 23, 2024 at 02:10:56PM +0100, Anatoly Burakov wrote: > Currently, we manually set PHY model in `ice_dev_init`, however we missed > adding case for E830, so for E830 the initialization ends up calling E822 > code instead. This results in incorrect phy model being set and having > several downstream consequences for E830 as a result, ranging from a > stray error message from attempting to start PHY timer, and up to > inability to enable timesync on E830 devices. > > We could've fixed it by adding a case for E830, however there are several > other missing bits of initialization (such as `phy_ports` field). All of > this can be fixed by replacing manual setting of `phy_model` with a call > to `ice_ptp_init_phy_model()`, which calls into base code and initializes > the fields appropriately for all device types, including another option > that is missing from current implementation - ETH56G. > > Fixes: c3bedb7114f2 ("net/ice/base: add E830 PTP initialization") > > Signed-off-by: Anatoly Burakov Reviewed-by: Bruce Richardson > --- > drivers/net/ice/ice_ethdev.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 29509b4329..304f959b7e 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -2496,10 +2496,8 @@ ice_dev_init(struct rte_eth_dev *dev) > /* Initialize TM configuration */ > ice_tm_conf_init(dev); > > - if (ice_is_e810(hw)) > - hw->phy_model = ICE_PHY_E810; > - else > - hw->phy_model = ICE_PHY_E822; > + /* Initialize PHY model */ > + ice_ptp_init_phy_model(hw); > > if (hw->phy_model == ICE_PHY_E822) { > ret = ice_start_phy_timer_e822(hw, hw->pf_id); > -- > 2.43.5 >