From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B42145681; Mon, 22 Jul 2024 17:09:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D293B40A73; Mon, 22 Jul 2024 17:09:28 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id F29EE40662; Mon, 22 Jul 2024 17:09:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721660968; x=1753196968; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=T8o7RS7PMIIeg/43kGjNqEMvFM/Q2lyTz6m4Iu2vaps=; b=mDmJrNzMgI+l1N62JoWpGXIj2kaeS+e4mUxf4FMdNIkEi7qda1o2ePa8 VPQmIgl8W+F05h6wcGWgplTInyoeh2izEF4pvWVmpmVYhEYHK2NdVlTfw xrzMLB9h0+RxuKK138L7tdYgnIauRGsdrjqRAmF7XZU5NhzxcVDjEB6a0 k+VMn7b6630w/UclgmCVTlm3OyPmGjlr89MbV6t6D6sggKIhtHjPUkP4q 1Djtd8HHXFE4tDltLE/QU8Pq0b/kDfXO8GCzmJbQg49PjosL7OUwo+B0h sbs+6I66OFSLb1w6yzmZKodcVeYims7/gK5oWiPzJqkkDMwH55VZ8xzvb A==; X-CSE-ConnectionGUID: CXftvadVRxanybX/DaNW0w== X-CSE-MsgGUID: 1l8fI+DaQLKueCZietgy4A== X-IronPort-AV: E=McAfee;i="6700,10204,11141"; a="19363827" X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="19363827" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 08:09:27 -0700 X-CSE-ConnectionGUID: OmvBCoBgTJedxirJuhXMlg== X-CSE-MsgGUID: tVlWme3TSwWkg+DW0koXjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="52650511" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Jul 2024 08:09:27 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 22 Jul 2024 08:09:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 22 Jul 2024 08:09:25 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 22 Jul 2024 08:09:25 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 22 Jul 2024 08:09:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=it04B3Gznr02AoU932SHQqHy4Oste7N2u/JHvh95nMWbyDz/PMzkqho4etXDBLf6KpoUwojTmpTYx2bBPl++9/zSQUvMzAyVqj0n1/8lCknXuwyZ4yOHx3c75RjS5RnGYArr0NzgJ7rIbvMwZDYMoNrCY0zS4zQ4u0vFDF6dHaf5FgoYZQ1FxyM5bHI/WlqRAmgngOMftYK3zaxQoOXw9ZMeZA+SKbBNN++c0ND7/CYSJvkR1vYJsp3WOqBFhQCZ17FTd90WAyoFSeYfai+P6oNhfzuBNsLSjrzr9p6hmIzSFNvkNjhZZnemmSxKPDxd/AzyA9Ck+UNO3CJl7dgPTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TmMAws7e4yqp5ntNrUrDLa/Doz8vnG/oLS1yxgCMJjo=; b=jLjn2pjAP3uJmFxH9ZE2NXhl7bV1q/8CXiA1GF3jt1zq7Cax389NEWME1PexaUajXTIlTnDGwbkJFSGxZdMV6CofQwVISao/2wAiHVJrUTAJANevbGFtoHj61xJjJyEIQ4bbSObYT1Rxo1R++NcQE/D/2F6EKx5wo3yRYRoDPhIIVJDBi6dBicYS3c/Kaj6Re4ZBiKZK81nIUOdSgVJK0FbDeGZclw+HCndAOAeH1961gcYLNCsyXcmi96PfC7q3okG9HrXw7ZQ5KknEx+LJNEyxyslooL+7o6uEQ3W58q35h6oJdUqBdBTjiUu8arEKEEyiSftMeKgqFfYc3gfetw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB7074.namprd11.prod.outlook.com (2603:10b6:510:20d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.19; Mon, 22 Jul 2024 15:09:21 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7784.016; Mon, 22 Jul 2024 15:09:21 +0000 Date: Mon, 22 Jul 2024 16:09:15 +0100 From: Bruce Richardson To: Vladimir Medvedkin CC: , , Michael Theodore Stolarchuk Subject: Re: [PATCH v5 1/3] net/ice: fix possible memory leak Message-ID: References: <20240722105950.199804-1-vladimir.medvedkin@intel.com> <20240722135046.285868-1-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240722135046.285868-1-vladimir.medvedkin@intel.com> X-ClientProxiedBy: DB8PR04CA0013.eurprd04.prod.outlook.com (2603:10a6:10:110::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB7074:EE_ X-MS-Office365-Filtering-Correlation-Id: 53bc6c9c-a76f-4b8d-0eaf-08dcaa6043ef X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Lk0IHMvm0AHK+4xg5Ygfc9fZzGJKbVIQw+NWLqxm4O9DL1IyLSmjhSrrLJn0?= =?us-ascii?Q?/quN0JDo0Qxk5HTxO9vl2/u5g+g9OCVEdIeCNuKJsqJvMGKpFsWbGD1SQgjP?= =?us-ascii?Q?yJW/v57aO6EiKfGiDdnVPUGjSIjb/eQN6ZXWH2H8tYcKmON8UT7r6Zz3P68x?= =?us-ascii?Q?aw8OjQ2bRoiBCqhgQKe5BUmei1KAe7F3HR8y+SclOHke3WA7TBN6hTk8nfOr?= =?us-ascii?Q?AYDw6gJAwGpHEOizSaIZKIQUc5JK7/xCP/JBKREnGqOOm1z7SmVpo1j82LVw?= =?us-ascii?Q?pd+Kqq3/jkiVbhRiBif8RT/uOdFiIBU/LagmToW2xLURfJUOIshPS9VfTYp3?= =?us-ascii?Q?G9SSIKDtApk0v5vW+J8mDiwooz0yz+44VB2UBNs6ae5HUzNbVR19PdZEkk6I?= =?us-ascii?Q?O9CMsztZyRPGqH3VqN1OPcdYOhtt6xeKMZtgZSFL535b15uqqlezgKjoTXpi?= =?us-ascii?Q?x+EbLeM/mw1tlR2k4tfZobnE0EkngqGbYeYjvzprqMqb9ra1ZO91w14dZmhz?= =?us-ascii?Q?m5dJGiUDZTf8qGeqKcBmncqeaJRrO6dGc1x1Hc6NhMYD5dADJfZiuQfxXDtK?= =?us-ascii?Q?ZjO/ajPy3cmO5AEUNNJrmGAq7H8Hltt8XHfudgv77FcjDoVOzrCNaV2ciq1Q?= =?us-ascii?Q?GmgFplj7lqaQOM6V3Z1t+1qVfZgyXTQzPgx8Bm6hKfMZV8QVu1DrTSjmQS7J?= =?us-ascii?Q?Jm6GbdEid3GZCZiafLwUj5sg7VNbc/qiVC8qq5VHMPggOjOSQosC5S9h3+aj?= =?us-ascii?Q?3/5pzY341hhRcTfE/NOHJ8vwwFeHEfIZs2Qa0C4qVughxsxV6FY9borleFRC?= =?us-ascii?Q?fbu8ZNWYKHxXyNidTsRAgnllunKu2x1WVV4FbXpV3pETPq3/Aty7+d0UzvXg?= =?us-ascii?Q?wymcYLk9uRDV6DLnxBKoiRVzDe+9ENM9wz+24TD6n7V/C4wP4K6EOr3292t+?= =?us-ascii?Q?dNL/HYVfBn3ZAY6JImWw6wzHLntIAPgRepA1Hlpc0I/l8V/uxUd8fbqdymyK?= =?us-ascii?Q?+yOtNCp+t9RapV9MVRmRw9MyM2KPdGy7GqzC3eAjWtLzdnnwgWpWKeExInVV?= =?us-ascii?Q?1tPTfgfHjHOp7ETKkpxan5azDCyNYDOipQt7ghZ9xm6URAIj32R3nx/DrkgG?= =?us-ascii?Q?2OVhOmelNkOi9qhCz4wPdEXUgyRkvfKeusWnrUnjFYacc8ISFDd9SZjs+ify?= =?us-ascii?Q?RqAowW6XF1ZGNbZRJctw3xgL5ZfHnFxs4d1e4AwDv5luDw56+oPrYsuh7l+v?= =?us-ascii?Q?JkyHcvsxHvEfcW1PRUQK3Tim2ihj3fSkr1JCABuqLJWuoB7cQzGxK6+NHsAE?= =?us-ascii?Q?nNJXB37CEOeBVWjCjX8A/sGPf5nr0WqbbXhzqRiDpjA1aw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r7GL5/cPDUsaEEFjHVygWB7Itvx3Bi6t4q3jWzDo4R/k2M2JiyAsbMBh/SWs?= =?us-ascii?Q?9bTT/O2MLRa+W5YT0eYAPKMYOeau3FW2s79ez8wYoW68LqZX+zrJkSVBGpKr?= =?us-ascii?Q?i9WmQ0/T1FFk10VoHPvo7wzq0asX2eeri+hytW5K1XcoycLswNsAE+LwnDTC?= =?us-ascii?Q?JYSxUkk3giJqd5z2riSz7cYKWFhmPZYSC8V8PynhJDvXdmRFbGRcbT0ZOsXR?= =?us-ascii?Q?bRbmLyegrRykBDC7d3tJ0dPw75gBjJczY5E5wTTVgnFgO6VtMTz8sMuXh1jJ?= =?us-ascii?Q?ffzWR44EEmKqctPoiv3sqciiv9kwZ5p94KyiPKVz1ZazdslzvdMbYaXxzOVe?= =?us-ascii?Q?qnjy5V9uMAa6u9DlNQPq1FxPvrVRuRnNeWdYjXxJS2UAmKCXQYzRVpeCvAdL?= =?us-ascii?Q?DiBqiGGza6YX8GOurbrFiBJTCVFINKj2TqbZ0cHsaioxFbd5ufE6AozKYRs8?= =?us-ascii?Q?MzWCeILx1k6amxx6iJ8svuyVM9VotMw3Is/Ddfuw8YHnJV85btvJQsqpuXh8?= =?us-ascii?Q?lh69nP2fGG+14SjSICxwol2HpHbKDh6MvNZSirXgUETHlRPe8a7cH7NGY/Z1?= =?us-ascii?Q?kV4K2OCCwGaQp3eLU7JIjQB9greyELZr+H/sXGR5Cxh2NinJHfD580B25d2Y?= =?us-ascii?Q?+mNqzvxMOIlKZ4EzEz9XQkKkEQkbFJAfRIJZmMedlqY8Xol+WoN3wQsa0gYF?= =?us-ascii?Q?znDVWW/HasaQMFqYWxcpBA9wNa/e9dNKEGwjJ/ogZ+pBnkbWfNoiqyJ5lOPJ?= =?us-ascii?Q?lCcVIPUqWsaQFXVI0FEeymGscakIzxKhM7LHDtZlU7Kk7qvF28I33AdjD0te?= =?us-ascii?Q?CoehtJifRjMEoyyCmpyYxeRiNYK8/C2u//v5pu39WrumxV2Fq193eqWG9nkI?= =?us-ascii?Q?XMPLWAF0wGO1BOkJlQKgDjW3saQx8SGdyXP5kPq87J78/+ZcUDSrnU88xw+D?= =?us-ascii?Q?UlCSKU8Jby/NETi2om+ptPqbBVrRWwZcs9nNXhRtflTRGd+dBWWG4d5Cutyb?= =?us-ascii?Q?r9Aq35Wg5fc+qDmM5Rf6JX9NhK5ZGuAlWM7U8UVJUvknbYb+KqEQxIZPaITj?= =?us-ascii?Q?q0eGSB46Vi/0Lj63TvdqJ2tuCWSwpFhaeRgFCT9yc+oPXuCRjRmfbvnIXb+m?= =?us-ascii?Q?V1mAcdCFuDzXNmhqmFi/Imr/kScxfwGWbJWzv3941zRJJrTTxzGd2A+eoJlo?= =?us-ascii?Q?u/xdzpiBq0yHb5f/DGDTuIzCy1kUsBMfUPFYxXTM6dwJxmcttbcBM76pgwaI?= =?us-ascii?Q?zK/LBdqsg7mtOBySufwDMX/S6o5xT7e6vVzSndXex8v6CIQNAhMdCHytIH2j?= =?us-ascii?Q?dJhYDrvnLyXxiW980GHXb5nQK/U6zndL3Ba/uVJDb3CyhrzkZR4ESRgQk33v?= =?us-ascii?Q?itShMHOWSdZ4b1tJzTUTQ5WdbnkqgIuu4hk8+8zqwKXxsgXF9YOykonTcS/L?= =?us-ascii?Q?wD5MpnW9NaMyfFA6ggpZSpA77ucMF3JOIV0VTBLtc1CLooGD72hnhCr0oMXa?= =?us-ascii?Q?g5+54uat+ysSgDKGwiw58BfGB76Jc/larefGhhWZfOw49CoKQEHbMpD70fJ7?= =?us-ascii?Q?Q3gLsEv1LPIWvr9gpqElC8b7S2NAv1n+AYhchNzeoG3I5x01AZc+9hhIx7J1?= =?us-ascii?Q?iA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 53bc6c9c-a76f-4b8d-0eaf-08dcaa6043ef X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2024 15:09:21.4903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GKv2F850Y1m+JGJJRMYfpPoHD29Y6kxd6r+meJX8iX1TNLf4Hw5PDC+980XfaLF8BXBpLCxsRExU1XTfkEpTA3KEovM35YX2Cy2hovl6vRY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7074 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 22, 2024 at 01:50:44PM +0000, Vladimir Medvedkin wrote: > This patch fixes possible memory leak inside the > ice_hash_parse_raw_pattern() due to the lack of a call to rte_free() > for previously allocated pkt_buf and msk_buf. > > Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RSS") > Cc: stable@dpdk.org > > Reported-by: Michael Theodore Stolarchuk > Signed-off-by: Vladimir Medvedkin Acked-by: Bruce Richardson