From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C828945681; Mon, 22 Jul 2024 17:11:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8A7B40B95; Mon, 22 Jul 2024 17:11:50 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 15E6940672; Mon, 22 Jul 2024 17:11:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721661109; x=1753197109; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=e4BAliq4oLcA1HpGdAk6mPY5AoB7V3y3IPVdJWi35Os=; b=OZe9y8iU1yP76zSgpR0spdI8D43rSWzj69T2XJuEwwrgT4/LakErCNMu sE3eSy9hPdi/ar+/KChlwNvMPbwBy9fk+4vPLFTgD88QI2W42CzWyZ61a pVtje8PV29sqTbCl7t2lG2fQqNq1OTOB122ks7y4WpZAtiSDMLoHv6/sy yY5OB+zVqUqUSZCZ9QlUN3BMmcTBxyzjtSGoIk4Qrk2wEDn/KuFd1M1ID FFEgZJrcOGDap0qqH3h2KNzdstsAcrPdwFwG7X1JFauEWCSZMvvwBqX4K gIJopQc88yQvF9FBL8mLyE1d3onbEPvgh1RKnJft0Lm7H3TOwLQPKZ1Hl Q==; X-CSE-ConnectionGUID: 125O4LvCSfiDKxu/0Him+A== X-CSE-MsgGUID: BnYHECXyQ2OKk1Ri/6uOyQ== X-IronPort-AV: E=McAfee;i="6700,10204,11141"; a="29821521" X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="29821521" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 08:11:47 -0700 X-CSE-ConnectionGUID: L17AjamdTsWWLpm/7kBMrQ== X-CSE-MsgGUID: S+refsybRsWOr2u7Gd6A5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="51843957" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Jul 2024 08:11:47 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 22 Jul 2024 08:11:46 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 22 Jul 2024 08:11:46 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 22 Jul 2024 08:11:46 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 22 Jul 2024 08:11:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k+m4T4CoQnn6MGH4R+kodGSkbsNe4sp7iRa3OyckKHLENDrhN7Vjjv9yJXNlD3vTS2haRFnsZM1vZLWVZxM5PAcV51VvsPg3w2lQzcA8BBRIXJqkIEwZ/s4RNMvJdKWLLWF/9XdFDvJACzh4Ol5JzL8Gv2oR7Gipg4tXhhhtnKabe1NnIWHmc6v43RIYvGDYFJGl8iSj/L6k+Pyl87qnYja7LpyAnqMIgHqIwG8vkltO/UGAyMcFdSeNI+/vgXTBE+He8HaIq/HJPl57xfZsN6es0ks31Kgjm5Cxoqm34J3eHRzALAG5bQN+wMf6GoW5c5xbnaT6REv6GHG2ZIm6Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O9Dp1xu+p5/Llb9ORgw0FZCnnIdSQsGO67DuZQbJ8Hk=; b=Cq9n3x7cBeMw1K3BKIg79hC1Ea8Qt65qb48lM26hWCNjHnrQKcf224CnoQjgVeG7zf/3KS2/eRrgX6YWJRSy8vywLPQCn7TDUAFAPUr6Kpg40ntQdHKzOU2eSitKBSjHX6RaNUvGOYQAbsOm49Cp1/xwkO0mi/Km4if3tHoC6VFAv/9aAaxXnEsebrcvsQQc8njhyhmdQewfx35mliZ4QdCsHc/HWrO5ecdcSVRJEW+fq9L7QAoKI8i4Us2K7yf4KxauHZW1gvTgqam9WK39H7swuEYOEqNmI751NyuN37qg2soYXn49xxgvSySwZZSSOkQwve6yOlRawNdPP7hRtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA0PR11MB7305.namprd11.prod.outlook.com (2603:10b6:208:439::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.17; Mon, 22 Jul 2024 15:11:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7784.016; Mon, 22 Jul 2024 15:11:43 +0000 Date: Mon, 22 Jul 2024 16:11:37 +0100 From: Bruce Richardson To: Vladimir Medvedkin CC: , Subject: Re: [PATCH v5 3/3] net/ice: fix return value for raw pattern parsing function Message-ID: References: <20240722105950.199804-1-vladimir.medvedkin@intel.com> <20240722135046.285868-1-vladimir.medvedkin@intel.com> <20240722135046.285868-3-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240722135046.285868-3-vladimir.medvedkin@intel.com> X-ClientProxiedBy: DB3PR06CA0022.eurprd06.prod.outlook.com (2603:10a6:8:1::35) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA0PR11MB7305:EE_ X-MS-Office365-Filtering-Correlation-Id: 0852a85d-2c2d-4553-583f-08dcaa609849 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?2iBHfOG75AsAaNo1ApzoNRqidoHKULMDoek01qAPvWLa+ptn+YUDgfjBACWU?= =?us-ascii?Q?o+the+hXhr87e0/v01lZyGON7Phvm1FN9NCQiArBqW7wPTIqGP6c1S5p6sFM?= =?us-ascii?Q?M94UeFahx+vJyuAww9kAHwoain3/z02XiYJAKKi1RtwilrpkS8RoJfKi8qww?= =?us-ascii?Q?BT40xCcZIMl2+F7xloJqxAxkvAoJeSp+MoYpBBKAxreiFrlQfolnr0VhihVL?= =?us-ascii?Q?Fag+j95DgVJXKB422HN1cgLFLy+x3pdQ9XSZ3Om8S2gYKsIWaOb8p7Mc8HS0?= =?us-ascii?Q?anVSTQWh/FS9tdBw9DjPqtx+Ry6IViBXEsT39gexLNBuEZ+ehC0UdFrPv0gZ?= =?us-ascii?Q?bd093BztQLdtlpG5JdtSunQPxdDCwZiqO/w6uoSvvTANi8RdVzRua2jMFoza?= =?us-ascii?Q?aw+WEUKw7qUMOlDXrYD1HQJjVPBII/n/5X4I8JWhf2IYk8TUw1EWVu5lIfwE?= =?us-ascii?Q?Yl14mEzEFuToLzBNAabMdSGYLm/qDecr1UePEMykUQbjdB8fr4Jg4L5nDz38?= =?us-ascii?Q?8wnQA1xaE2OOzpkAevdWCWVqFrdSa1oSP5/DBuDeEbOfPtxcXdzWmQwLR0DQ?= =?us-ascii?Q?yjiU/SxbVu5DuDd3dfWKoU7KcpLsBCbvUY7akyKCRH6K1XRI5AeJZsUDvMCm?= =?us-ascii?Q?RL3JZzEVoq88Azf4sC1BEUGjcT2ywQpXUEjLGHK1+d/B/rhiR8AHeMy6kUdH?= =?us-ascii?Q?qrFx6do0kfPD1SbWGXqiujJ3zeimieKv9tcqDkpLIgiDSHMhIjiJce1uk+8v?= =?us-ascii?Q?BhCEIzD8Yc37g7DaCzbhlcNdy28FwsW0EU27WNMk/YFIa18weS5APWGk3S6r?= =?us-ascii?Q?ntkWHk7UYwHWy9/1kUJAKmPT2onOVQEQkaXPdbBGk/PhP5mOXN0+njcfSzYA?= =?us-ascii?Q?WKWk4uTmuNLS062tfH7vlcR/sN2fy0Be4dOntCnu3oCjpoRAsEuZPhVQfxX/?= =?us-ascii?Q?1+cSjSi4u28WeXJeNNXLXbhzvH7aSnYIQpLggJU2Be4hGb8mZF4dlzG7g1xd?= =?us-ascii?Q?mZSEWrvFNibi5V9rawegjVlGwRhDgcqYb9Xvm0+gGIPPtF2iC1abTPsKFtu9?= =?us-ascii?Q?Bfum1LWdY/LzgwQffqWEc4BE8EH46VX20jLtSy7VIgF9R6HNkGS6QMZWOeSq?= =?us-ascii?Q?YNpFM1aYUTE99zFQyUkubwiokBVKRu7hqXVI3ghzXzqi9s550kRl/9+ZK3hQ?= =?us-ascii?Q?YzkAmJIb7rhv/ypgStPP05p3+uSppUGlA5SbIltxG3fVTBdCErktzdmuFq3G?= =?us-ascii?Q?GxQy2Xg+fNWXNaE7NE7qSUdRgMmBD+k5TeEfWfjp8fk1neWSlCGQqvi+AdF+?= =?us-ascii?Q?WLFFZrA+QIc7lfSZsfkc3EwJ8tOz+U53XC0Bc5DVw5d1Mw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iadsevi0f+Bgxtpk+06YRlC4j/4FwoI8W8gH2oZr3HnYCLnORMp1Y8oFPPNp?= =?us-ascii?Q?crgmc8+EECwjUQhiH0mmTPryysa4eFo3VH6YnrXr0IiJS9dO4f2FyzoZn+VJ?= =?us-ascii?Q?HywNdrdFjkZ85ZBeaADvFKe12fWj24GdOF/3IhZPdTYKS5/4vH6nW8/Py7mD?= =?us-ascii?Q?Tvz4HH/VRf50nbrdM0we0zqx5OkVbG0NFSSfZVg6rayTbmfRutJS5V7aSQYm?= =?us-ascii?Q?rzF95Hr8a4gPsieVojGI26T9wUZI2NyRno/nroD/taqP+zAr+AnufVG/Vd69?= =?us-ascii?Q?DpiMUYthjyYzmbyzyL9duu/Yq6vttIUmbfE/fyC73CeHXeyivKxgrj8ZaXOH?= =?us-ascii?Q?bkHCa+58t/cnmZyCEFI8xqb+M5O24EgeilPulIX4ehDaldCyjGC2gIECNj79?= =?us-ascii?Q?cwl6onsFrPOk9d12BOdCwI6Fj0kmJGp8tLCtY/BsqXurJ4S7sW55uNJcIDNA?= =?us-ascii?Q?9la1Ja1vfRF26yyuUt5mTmtqGyRl6/YoQSqQTHVKJIBOasMnjeekkXugpeWb?= =?us-ascii?Q?61typIv9CdlmFhwFPWSaeJtVpl0mhgIGAB1TgGk9qpKDbucotbTRCNTpEql2?= =?us-ascii?Q?wLk6waP7+TwvJalFIn4AkcINkfyPO11LQ1HZsLdo6EjvvlLshCh/jaqm1D9F?= =?us-ascii?Q?e+M2uney7Tocn96XmsG+QhTXlzjRM38+spUrIBB3OiIb6XhJiXVdifzwkP8u?= =?us-ascii?Q?n32Z5Ov8eRIg2tDBJDCqBEn1zb7cODd+AOP7YaiJ30T8Y6KY0jS6EnC7Pup4?= =?us-ascii?Q?PwYbrp8TpkzsfXKoWaB6pxslA69vHNg+cVABzUOoN1v04NJQ6KG07SL5vAW5?= =?us-ascii?Q?3jwGLNPiiR6UjWXnT1sUR9bWefOmPp9j8nLQ5898gkzhEJButV6RcJnG5m9x?= =?us-ascii?Q?JbBzA7u/JOOiRHJNpLWf20JUi3a1jXfs9LLUAOviuwiqwOZ2Em2P3QDudJCe?= =?us-ascii?Q?cbm392yc2YcCBE0RiopVtZVnNUi+Rm4+HECVLVqXLd8w46VqQWKy2//3rCWE?= =?us-ascii?Q?t7idjefrEPnJCIa//A2Xx6THseGIaURO8gcUdcayv6ABrQoXzo2Qyj3taNmr?= =?us-ascii?Q?09uM8JI9J/BcZqLgkoTCJnmSEtogk8XHYmh9hftrKMXuikpxlwyptBaGlJOw?= =?us-ascii?Q?Lm4LEJrtbNPafGtl4/BsTETCX/s8lGoM560SdScQR/n/hlCLeEUrFcfN4alR?= =?us-ascii?Q?4X+9jupZ/s4w1F1kXoRrWATgX53d4MmEidAtNMOnm93WQetOoc8zUDziJ2sB?= =?us-ascii?Q?fZIy0d19rZKeslnHrwPfLQQAQxnUHh+XAmWO9ikB0h6g7vCge5/YdxtuVwdL?= =?us-ascii?Q?sPUxFDIhG3NaI6gOK7pgaxKf5kdIwUOh/tDZdiYXc+okEtn2eivsidSS8Ivh?= =?us-ascii?Q?MNzyY1lHIn85wDBz9xKj7EF5zQ7ZXUbrbHWt5jrvnhgWMIXBcJRRQZKntrd0?= =?us-ascii?Q?dLhAXOyDkoDjOg+M4kcRZSYavfXQlc/d7s2WdjrC2YBQfRcLhhp/nnp7RCP/?= =?us-ascii?Q?Vhx/SnBiUsd9pSPEXlmQCtaDi9FyKkJQ/4T3uQdDfvCDwA86G4ja8ZLd+juW?= =?us-ascii?Q?pm1Sp/DtPRXuyY6WXfJp9t2Q0tU+s+hqI8orpPhbI08afaV5CrFetLiIwtgW?= =?us-ascii?Q?Ew=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0852a85d-2c2d-4553-583f-08dcaa609849 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2024 15:11:42.9387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: skhAgwxgVhJsWe8F2jBQa/cF7mN6kodQtL1ReGPXMVqUwzxTvzMbnqR1GYvpayBHnlscrbYhG7qcFfd37SVEZEhx/iu6bLxRRIgR9uilxYY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7305 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 22, 2024 at 01:50:46PM +0000, Vladimir Medvedkin wrote: > If the parser was not initialized when calling ice_hash_parse_raw_pattern() > -rte_errno was returned. Replace returning rte_errno with ENOTSUP since > rte_errno is meaningless in the context of ice_hash_parse_raw_pattern(). > > Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RSS") > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Acked-by: Bruce Richardson > --- > drivers/net/ice/ice_hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c > index aa76718313..b720e0f755 100644 > --- a/drivers/net/ice/ice_hash.c > +++ b/drivers/net/ice/ice_hash.c > @@ -653,7 +653,7 @@ ice_hash_parse_raw_pattern(struct ice_adapter *ad, > int i, j, ret = 0; > > if (ad->psr == NULL) > - return -rte_errno; > + return -ENOTSUP; > > raw_spec = item->spec; > raw_mask = item->mask; > -- > 2.34.1 >