From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE31545616; Mon, 22 Jul 2024 17:18:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D3E640B90; Mon, 22 Jul 2024 17:18:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 08EDD40663; Mon, 22 Jul 2024 17:18:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721661512; x=1753197512; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=SIa6ZQh4j7007FzHybG7ERa0ZPMMHzTONM3Z1rpaRQQ=; b=ja6WNWyOtRVa8A00Ft4xsPJziNb0zHvGBi6RmAMUAJTp1UENJNenfPvZ Kn9CMr6sSznpQPgEL6DGx/ipdPvEAg3NNpbv0uZY4uMr0kFUqUCPllgI0 payVNs3gqgmA7TLnnQLOyYkG8gsZX/r4boh+Z3RdwqgrRFGO988Ggfr7l HYzWWMn/uKOsbxIrlmWAUp3vZzaOurmcUnWXJ2LL1CBuR41URSRLQC9jD tmKK7+/+RUyINgjx+hcDG9ln2KQ5fR8RpUDMX5RiuBlJnMnVVqx2oauE/ VeYFcKQ3L6bd3damnEFR59uWb0IPUBYtLTwrHVG1I6xbhTaeBtW6Y+6yP g==; X-CSE-ConnectionGUID: XauP4fyvSQm+78doSRSMXA== X-CSE-MsgGUID: AP1OaN+GSiCXHZAiJlmDUg== X-IronPort-AV: E=McAfee;i="6700,10204,11141"; a="30661891" X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="30661891" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 08:18:31 -0700 X-CSE-ConnectionGUID: 7BHYzawkQn+xBf0hsgY0Kw== X-CSE-MsgGUID: PvHoaEZWQaqkxW1craoP8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="51808364" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Jul 2024 08:18:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 22 Jul 2024 08:18:30 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 22 Jul 2024 08:18:30 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 22 Jul 2024 08:18:30 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 22 Jul 2024 08:18:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CUsuVPcRwomS2neLJoUs9VFOyvbTXZ9477lv5u8VTbADV5EAWiLErvIqL3pzi3cDtwDi2umv69ntzkCOkGe1hHVyQoUTrtu5Fn1+lVSex094Qbau0Z0kypzRDKIEXyW1jci3oOm1CBsKBopSWUEnjxWM1UlSQkwPb3AzDzwaLQwizXIL/KijvZ2atSdIBlX7DyqS4AFvR2M17xJZHZ5tpUOOR3WhDAMB1KIdgte70ig58f7akhUBe/Go4dvyoQFLjxQadXvPTldztIaARkozj9sYLOkH6Umf61FvCnOF2b21dbV7ZjfaTO+iDHOJCRnXg9u6I57yDyECcUTgZJQqFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nvOi2t3LGpKlgRZrT0lwbxN+DpaSjbloq4r/EL8y1rk=; b=U/u7dvPhFY5wIsij9d4r+LCufxbf6NJU3I/HIFrtYB6qXf1MS6NGuW3x2qD+dZHsvTXVSamShycbYNmoZibHdD0mRRcl3drzU4TvapfIRp+2nfN8BmHGbigm9TtuBQDVxJdr2ORcWgNLN0yDoHVMFCNthDedt6S/MsQzlg3VRaHegDkEHMJ4A+R7X6kDXO4wjMny2rmidzf3nzySm+8GrvFoCVnLi5rdsP34O/XveKS6dcFz1cHp9VqnJAwpbFKqm+R+iNKiqoCp2PoTC93baVuixQLZVJ5OS4tV3xleTBN89rrzQrpHyoCEFSB5qZbuv29vioKVlX8kbh1QHBCGLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7529.namprd11.prod.outlook.com (2603:10b6:8:141::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20; Mon, 22 Jul 2024 15:18:26 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7784.016; Mon, 22 Jul 2024 15:18:26 +0000 Date: Mon, 22 Jul 2024 16:18:21 +0100 From: Bruce Richardson To: Vladimir Medvedkin CC: , , Michael Theodore Stolarchuk Subject: Re: [PATCH v5 1/3] net/ice: fix possible memory leak Message-ID: References: <20240722105950.199804-1-vladimir.medvedkin@intel.com> <20240722135046.285868-1-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU7P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::8) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7529:EE_ X-MS-Office365-Filtering-Correlation-Id: d3908f99-8e2e-436f-525a-08dcaa6188d7 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QTyp0TSpVC4XIJTNgURgktP/yvwFMlhXdoAx5ccYjZFYcZhhZRPu0fNyrhSz?= =?us-ascii?Q?vBvX7Hux/DmJ2hsK9VBZxZl+ouoHegrztVRMWzcwORMb02KLW4V+8Bkexl9o?= =?us-ascii?Q?DOsNs9lKH2vs0tDJpyPCob37W74krYZOZwbpweoogiQUREtDS3vAUNyWiK27?= =?us-ascii?Q?xgW+fNkyC1Art4cWcmOa2a0rWKbQ6QTbM0PWdpO2hMp/JfJXM8r4KNbOhDd/?= =?us-ascii?Q?9nR3emVevbxgsKRXYkFYXCMsbgBVeai0K/2SCMknty26uuOwkGO3BC7jfw0j?= =?us-ascii?Q?4kN5ar9wulVQHc71UCfdPM3Cn5Puv1BH7jisI9l2O57j3Vgtbz16yHTvhZa8?= =?us-ascii?Q?xWQD/ShgcT40A7PglFBrBesBDG/U6R7MD1BHZNz40puIdhS9sYN2HHyp0mfb?= =?us-ascii?Q?RM8hOj5nDxm8/qPhqyE8G1ue0XL3XsrEDJqslpvIgZQskJFTT06lvrPkyFiu?= =?us-ascii?Q?6ZojGvAoA6hjAmM3NG43/EUILRNrv7zuSPmNaXYVlG6yLf874RWVycLiv/9i?= =?us-ascii?Q?//xdsZQTMfPb4NSLYVxGrRtsQAGbjktgytfDHDr9uCbTUdnKBaehnjCnZtDZ?= =?us-ascii?Q?OeA9ZVGRva3RetChreCPpMWqKAGlfa5dmD/tj6T2yxjte5rjrACnHslgysDT?= =?us-ascii?Q?ttQXnmJ0i9BJRf8NaTWMmJ15KCjhENc6fvnAAtR/jvvlPKZsksZI7WCRMFFx?= =?us-ascii?Q?lioDmzeI00D7G3okyunoyss1BA2Zl+VQ+LMwCWi+Fm8xoXR+L8bIoM9AB4xO?= =?us-ascii?Q?iM6Vty3pi9Rhu9PmruhP51f0njKdVroEmElu8ZQLxoZcpGIxh8XPJEuXmD/j?= =?us-ascii?Q?NsPNTiQ9j9og4yaXVzIeLO/Zg1JWh4vVB1cnbAITsPTjQD2FDZfRSngvF/pb?= =?us-ascii?Q?Vy0AVH48WLWYRGAcoO9Rf2PJ79tuPPkZcxf+YF7ETeRfd/U8QnKRdDo2rqqz?= =?us-ascii?Q?iQHL5Fom5bb8xO2oW25wwGa5AmWYJYfF/6aC+epYigbBMEi9SNmElH6sc346?= =?us-ascii?Q?Mk3Q7iII/JxQb9ozT4ujBDfYiLfv1lI7T4mwZa3UNjzxKAAZ0xWDrt8zXwCe?= =?us-ascii?Q?v4wZ/jV+AQqTtjM4gaTZPUG5ZjdmBZq9BbSaoOTjB+D57TmKBolXJOlA+wcv?= =?us-ascii?Q?hdjnDBUyV02Bf/UPgFcXkfjM3idSvucZx7VieFFOYgtfgMmXFylvsqYQIGwP?= =?us-ascii?Q?eotGdS2dcdjP9n13qA46hscU33nwzBLWZFtpqHSGgwmoU6+fh/hGqbsXTIEL?= =?us-ascii?Q?GIs4BwAp5LjMbPqN6V5f1Tep7u7Rc3wZ3s28xzax4vPdGcXFJY+aK//y3WJF?= =?us-ascii?Q?NXKxFAYNIv/dvdu1yH1wj9XoDjRg1kEB0kziMwAoATFkaA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i6jQ3CmdlbShIdJlzo3lod8DumESwIV/tntSe6UsGao0Me0AhwImJ4xFj1JC?= =?us-ascii?Q?fACj7WBjgKxhEidKh/oeNrQY1+453hKTnqLQe6SM0flYmNGx3iOsIyE0Hb89?= =?us-ascii?Q?Xx9ZyHx5Yd9x47k0r9xndsb1ytTrnkshhk5F/PMNC+RA+kionLtLZMn4eiS3?= =?us-ascii?Q?LZYoLmBwwyAjqAtHLa7UC2o8z8b3BEsA0jMgqvpBtJPWlIkO/W7SM5WboSmH?= =?us-ascii?Q?dSuQ7A7qWK0yow4aRAFB2g4flQnei0haugNBtVdEfJV+JNEuM+wA213h0tGc?= =?us-ascii?Q?Y2DlVDuSGGJsH4xYu+lR+SN4T55GuKTe8Ou5nASQBFBzhYUv0LYBd0wc3PSt?= =?us-ascii?Q?r6q166QZVVd+9otKXwv0ENA8TOkGXL93QZXFHFrDTPZz/vMilg8GDZtBcvB1?= =?us-ascii?Q?QCj08xKf5ZfGqoJVXCcTpgtWCHB7W+RN/Zj8kjJoDJPf3tZU6RtMwdibDhC1?= =?us-ascii?Q?Pfa+FIW14XTlkTuUUIWGu5YtRXxNHUEUOlEkWtVFGpQNVRFfOy5RYAshvEyZ?= =?us-ascii?Q?GdOzf2QRfk0V0G39Tt8qEo/UYnuhW1thBCi/xwLCgfaPMhiIBAZT6y/x/4jO?= =?us-ascii?Q?jUQmzL8djfHM1eyqcy9b886IxFwuEci2FED3S7wRsmKk2ezpZ6iv02O7RFWt?= =?us-ascii?Q?CrHOW86CvXs+Pjxd5LxYcmpcQR4ij6oF9UK3RaywE70ib9OyHoDNOqpZRMQ4?= =?us-ascii?Q?mYWQ6QNXw3x1YQyLPVhO8bFZS3jKmvVRFRgFWKm1EP4MmBjJ9t3YvE3Zbyhp?= =?us-ascii?Q?yZdAzvBQbWt+//hqFHlkKluUkh4ARs+2EwxwHMxsmz/U11kegMjpqw2e2Nmy?= =?us-ascii?Q?oBfZCpIARo75P30uy7RlzT7Vdh9O0bbxLieVWBpfTnyfoLnTkgHFP9X7BYo/?= =?us-ascii?Q?KbNMaNG5XCZFdXdq3Iwe38lZhakfNaem57LnPQeKYPGUzmUboMem+VwHF5UF?= =?us-ascii?Q?iYbXLRsdA0m4s8ajoLhf/B5rZ03HGu5xzZlV9PmwVADt5DEQjeoLH5f4YG42?= =?us-ascii?Q?hEYNBf5nEgzsxp/nWouH8mVM8ScqjCC4uJOEA8uwCHHQvlHQhOAY8NnUX+xC?= =?us-ascii?Q?vkm1OYESKPty8okPXcvgrpMe64NE0vdrKE6rWsW7tzbstacKNigixLIqV+2M?= =?us-ascii?Q?T6H+wE0/Gx0Chc10WBxtg4SY4zhtxLxRacNeDDWCFFl0mdHQ+9tmgVC3gaOU?= =?us-ascii?Q?/sYcGx2zA2aRsY+z876iepkWOtU3oaUVtb16y3s06G3P9s7nvRkeMnf1YK4A?= =?us-ascii?Q?m/37HLLFLyW5t3ZWk+ikZAOHl/VCA02H+Ial5gNYqdEReWvNEiirTuScRd2q?= =?us-ascii?Q?mdPW6CnLofd/WMjrvACmSeDlOAdHbgqcy6zDm1K8R24vEtdqphTy4BvXgu7S?= =?us-ascii?Q?AJTkO686bB0/l3Q9d19SCX9msq9OSvGrliP/xQgQURXEuf4/84XMh1dC80Yk?= =?us-ascii?Q?Oi5uzE1IaPpFavd0NR6ZUmvs6tQt6vjAUqX0u53vR8490aZKIMxBSMpqYxcF?= =?us-ascii?Q?OyHM3QTVQdqxNdPmRCSfMFt6emPcpojdmEa8KVl6vSbQnSw08Ifl4+M43s+A?= =?us-ascii?Q?y2EzsbXoRIM72dJemjcrlmtLZBdmbj2QjjuSCiAep78Ed2jHlm2SEa3547/J?= =?us-ascii?Q?Ug=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d3908f99-8e2e-436f-525a-08dcaa6188d7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2024 15:18:26.5134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: udCogalZk08d8Lee1Q+7X/9cAq6l96jQMyVYlvG6DJLrliFcfE94hJS7JyxEPjhfos26ZFr3+jzKlSrIOCv4FtuWXKuoAGz8BIf+974VAj0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7529 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 22, 2024 at 04:09:15PM +0100, Bruce Richardson wrote: > On Mon, Jul 22, 2024 at 01:50:44PM +0000, Vladimir Medvedkin wrote: > > This patch fixes possible memory leak inside the > > ice_hash_parse_raw_pattern() due to the lack of a call to rte_free() > > for previously allocated pkt_buf and msk_buf. > > > > Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RSS") > > Cc: stable@dpdk.org > > > > Reported-by: Michael Theodore Stolarchuk > > Signed-off-by: Vladimir Medvedkin > Acked-by: Bruce Richardson > Series applied to dpdk-next-net-intel. Thanks, /Bruce