DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jun Wang <junwang01@cestc.cn>
Cc: stephen <stephen@networkplumber.org>, dev <dev@dpdk.org>
Subject: Re: [PATCH v1] net/e1000: do not update link status in secondary process
Date: Mon, 22 Jul 2024 18:08:40 +0100	[thread overview]
Message-ID: <Zp6SGGyLIc-o91tK@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <202407141626262115324@cestc.cn>

On Sun, Jul 14, 2024 at 04:26:26PM +0800, Jun Wang wrote:
>    >> The code to update link status is not safe in secondary process.
>    >> If called from secondary it will crash, example from dumpcap:
>    >>     eth_em_link_update
>    >>
>    >> Signed-off-by: Jun Wang <junwang01@cestc.cn>
>    >
>    > Wouldn't it be better to fix the code in e1000_check_link to work in
>    > secondary process. There are network virtual appliances that use
>    > secondary process for all processing.
> 
>    Yes, the e1000 virtual network card currently does not work properly
> 
>    in the secondary process. After skipping eth_em_link_update, I tested
> 
>    the e1000 card and it was able to capture packets normally. For the
> 
>    secondary process, I think eth_em_link_update is not necessary.
>    __________________________________________________________________
> 

Hi Jun,

can you provide some instructions as to how I can go about reproducing the
issue? I used a VM with emulated e1000 NICs on it and was able to run
testpmd and dumpcap side by side. Similarly, I was able to run two
instances of the symmetric_mp app side by size without seeing any crashes.
I'd just like to verify the issue and confirm this fixes a problem before
merging.

Thanks,
/Bruce

  reply	other threads:[~2024-07-22 17:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 11:30 Jun Wang
2024-07-12 17:17 ` Stephen Hemminger
2024-07-14  8:26   ` Jun Wang
2024-07-22 17:08     ` Bruce Richardson [this message]
2024-07-23  2:07       ` Jun Wang
2024-08-22 15:58 ` Bruce Richardson
2024-08-22 16:02   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zp6SGGyLIc-o91tK@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=junwang01@cestc.cn \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).