From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8B7A45683; Mon, 22 Jul 2024 19:08:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BD8E40431; Mon, 22 Jul 2024 19:08:56 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id 17B8640272 for ; Mon, 22 Jul 2024 19:08:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721668135; x=1753204135; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Xya7pWtlls7CCQeD3Rok4TTaCjPqOCfdQNaLZxUVOk4=; b=bIa6j5bBc9/Cw5mOaO9ghTA5sHRH7zUZp46zHwlSyksNNioh55gLd6vP YIsvOt8nPw/tFNjBJCf0AEBkxmAPo96Rjk9+CpVIn7U0aIJsGOEZVm6Dk ef812EYv5y+kR66tDDMRwnT71exHbe1BbEWUVqBZVDwjs2x8rvhXTrIs0 hQFjgFjgWI+R1un3m4wREzmFC1RB9JQVhO4ew0LtIVJEYvXFT/vD0sAyc iG2xegoe7pGn4VkS5Pr7PFaVh6aGohIdu9gYZ8Ihn8G91MWFvqXb7QB53 N55IBicnVh5P9nToM4PhzGmutrO0eelIoRXBrjSyWG5gUG3b6nVH83iJ3 g==; X-CSE-ConnectionGUID: L0IFzhjhQMidIPG1RRKsiA== X-CSE-MsgGUID: P//cVAOeR4W6sbFikQB4AA== X-IronPort-AV: E=McAfee;i="6700,10204,11141"; a="19381612" X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="19381612" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 10:08:53 -0700 X-CSE-ConnectionGUID: MzEmjD8LSs6oMc3i7106TA== X-CSE-MsgGUID: 1fKJOhYTQR6OKctLzRUHPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="82583433" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Jul 2024 10:08:54 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 22 Jul 2024 10:08:53 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 22 Jul 2024 10:08:53 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 22 Jul 2024 10:08:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZOYxIqzARa6c28le8nEC1pF9QSFuTmddpJM31FtmHSxd8OJ/rp4U5lLDEe5mLshRwczf6OV+Bmox/js0YbvkM8jdw/BgsGSHdgDsNzMc3/aSADzl5P7kyitpwgOy6XlowM7uS+zaBoRYatlNfLsaaE1/hnv48b0GpYPtP9xmz6hf47lhTpyNfnFMrslxYaaq+RRRKcWEkPN6PrHERroNm9s4IQ9rY5BrmfraagQxbS1OWVd7TYI16ZeC7C4FNM45WWwU6QEGDtubyzuTII8+BSFgryUqEtdYaUhGvS75R/KQB5uG2pzwPB8PXtpVizXoti3rhTtrRIDOe1+AWC0E+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TQIPdY9eOa+spt5KqLRgKSIZVIb/Ze0CQ+Vtc0Uubo4=; b=PS6IYe08umH5T+pRTRL+DrS0g4uA4Nnz6a6sVU0noqvCRw//K3Yr2x1GrTMGQHpM0i8LbmgM0zaUA99/66LZ0HOzXDYHsWz0eEyo6fsRQcnzjFQa6YbzgrJP+UmK6KIdGoRfEaT3Mcf+IIjgf1V7kulTbQlLQSSaLuvtHVtUU6IWtX8OTIBEPnEhES2Z6DenSz4wAyBjU7C2smlm+I8Uk9p1PAPjnbbsZ3036v08MLga1FxjhYOnVFO6mhgowuVt79IcZJoPPWq4uRQ0YyMl00vT46BpTGVCk+EZsejn70z82MobxhSugDISLP6+qFrTS+9vYpqqh1gY7ktro/cCag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB8592.namprd11.prod.outlook.com (2603:10b6:610:1b1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Mon, 22 Jul 2024 17:08:45 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7784.016; Mon, 22 Jul 2024 17:08:45 +0000 Date: Mon, 22 Jul 2024 18:08:40 +0100 From: Bruce Richardson To: Jun Wang CC: stephen , dev Subject: Re: [PATCH v1] net/e1000: do not update link status in secondary process Message-ID: References: <1720783847-12292-1-git-send-email-junwang01@cestc.cn> <20240712101704.20e3f8a3@hermes.local> <202407141626262115324@cestc.cn> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <202407141626262115324@cestc.cn> X-ClientProxiedBy: DUZPR01CA0103.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB8592:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a3411a9-e9e7-426c-1eff-08dcaa70f1f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KJ3Cwx5KIGt8rmNwZq+QHDfXc+vF+KeQU0kdf2qBfYhcROSiRVuWeBNHQhcA?= =?us-ascii?Q?6K8cXWC/TlaTQV1ZkfHz9h2go6+DeSNGJOD6wYPnXf+UuFdv+5HMvoVYpwtH?= =?us-ascii?Q?6XDr1UlUiQMyRIKUNPLEzWfX9HX5ZCvnAgTSdguvvCTtdhKswUGD5NkBrcUd?= =?us-ascii?Q?ViPVTBO9Txo7Dc2RHyyGvB29dHp3jRcN75i9QVtuSQNqobBeJGj6EhJEvQC1?= =?us-ascii?Q?qgbgPMixsMyl/8hfhgfuSDCcZj65eYD9lO3GbRDairRI2hmzbOr0mquBS/HK?= =?us-ascii?Q?iCQeBSKw2N6ycYg5N5IwGlOLH0tp5bzPuA3vuJtvRK+t/edDM5cSiiE/Vw/+?= =?us-ascii?Q?8vtWJ2txv8Cirsf2+i7YtHSQ6McOcABwy5hQw0KR1GYDG1KrADqfA/qwBzvb?= =?us-ascii?Q?kgHbSMxipD4KOY/CHkx+PveccaGlIa2OLrPhG+asuYIPprYj2md7tqhy/Rx5?= =?us-ascii?Q?8Q7oJCGVG//YKqpBaLUn1W4zFB5uC2445qkqIra18Ph00pvL/yE2P7TyuR9w?= =?us-ascii?Q?QVnlThUaBSo4otEtzmaj0QrKoRGXM7/0n5YWFUPlpbt0pPfea8Ca3UlKu3e2?= =?us-ascii?Q?Yya+5ME3fqMMzUtBlX2bC9NnqlFKw1zI+ThrVbVxq4Mhf8qyOOY9Nd8A9GLI?= =?us-ascii?Q?oYLY7tgua9gXWwHGJ8y3NwsIftYNo0+b1MhDS1ilsIxjv6OVi0sPJJe+q8dP?= =?us-ascii?Q?+/y/xo6fpZnRSmlk9voyKTaJIEXhTQOjqArvXkFtOcsD/MTdrbdjPJK5BtBn?= =?us-ascii?Q?1mmi6kVLQmL5s7Du4RicRgM4MSHL6Spra+eRU/XjfdmfFj/XjGjALRoVtpXq?= =?us-ascii?Q?vI5xDC24um0QSZZ1maK49p0LwxbGWJ4R1nEqhj2+4pmk7MY7yqyKsCMDdrzj?= =?us-ascii?Q?lndFIYW+6D6GHjx6tvlA1qcEfpbeTCJg+rKBO64gPBlnZoOhdX3xU2z6iMAq?= =?us-ascii?Q?G3wyIF+SoF9NzVfTpu7TUikVPXpg+4ygvrD4581XSghk+BeVYcjA9WBlfK0z?= =?us-ascii?Q?mUUNDBuDyy3V9wymT6Rrg1nsKaa5keutM7LE9aDNuIg03nw3QiH1IYDzSIhg?= =?us-ascii?Q?VDWk69B5cQd5EhKrnsnenFJcxw5PLdH1CTXvIJW1mJra3TZPRD1507MtNMLI?= =?us-ascii?Q?CLz7F7zNZ3qEnWKxhA4EUAItPGmKdLKw1lp9cC3fm0CyetyPvCZGGNYV/q0J?= =?us-ascii?Q?owdN1xuiGPaXHiFFbU8MetPVk0M0nEIrpNMbDlf4g9ueQOIbMidCDCDa2wNp?= =?us-ascii?Q?IEFhpUjWPE68f9EjYmnWmCY9ki+gZxZngSUfLanbhPfEYEDdbC7jWVxtd2sf?= =?us-ascii?Q?MLe0m7wBtM0VC/M66NTSbnvkZ3Huqz2zRvN1HsMX3RYcmA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q9Xi9yo2rvPGI5hlAX2OvDSQYCtDZaNEB9NapQE5HFpua7eEkfg+kj5Sk02O?= =?us-ascii?Q?bfuh+MxY2EnLpRDFVbrUEe21ET+qb+Bh3KGAkqb9HeueNfXHIEsVFTcu3R08?= =?us-ascii?Q?OFFd2AnbHWoqbr2A95AsmctheY/vE5Tegb47QJWbWmkUdRn0MmobFYakB1Z4?= =?us-ascii?Q?DTWM7tn9WEgZe6PrtUTz+94laiUWCNkV6WFih7ZhFve4485adkXdoeE/PP+9?= =?us-ascii?Q?M1ma7ggEtlZoMPHQJs4sFRV6+1PJhzLc/LBWO1xPgLQl2R1mMJgMEADrDURR?= =?us-ascii?Q?V7ZMH3ZAuDHTy8gYJRxhXFgr/bclA659ojiUnN+yoiJHxixW3ChyfM7kD+Ti?= =?us-ascii?Q?lbe+uEoBHAMmmAReQtvZJ0qjmTWqsF78erwI+X479MeO0+Ru7sHhg7fjGNHQ?= =?us-ascii?Q?H98S3O7fHXePhQygCfKkAwZhKZnzQDErZUgRDE6ka59gZEjNVQVnD6cTSh9Q?= =?us-ascii?Q?RD9Ox8//btU27iAFDgJOk9Uu69ulm8zO5NugEq57hsFQy/BaTDLWy6nPA0F3?= =?us-ascii?Q?DwV9YcM9jSVbhWRYNUuzNlLSpeVeLMqCTgLqXax7qozXNpghqn1VJMk/HvpJ?= =?us-ascii?Q?80/Dw7RlFlgqcqnwPYHkgZxjzl3bXFK6yHzxlIBV1j716Pa1Sn6pkxVvXjmo?= =?us-ascii?Q?DlBDI8Q4m6H6fcaN7g/6AsQrpBHjcUZGK8JEgthJsCS2PeXhFZogp0zg4y51?= =?us-ascii?Q?zZF0K2pC3p9WAG2hLkPy22u/y0c+7ZoJ3mrCqwOQxFgoUezmlpe7gDLuqAWy?= =?us-ascii?Q?sV2tCdsghelkbJnVGcY8rwTv/iuqckRgjreSMtohjXRUOUe55hFi5jluk5MC?= =?us-ascii?Q?jIh+j7p1w80v4Go3jzGUrYnqcvTvK0m5xOfkLalcFbWdEAxhfIkQ6gfIJ5Vd?= =?us-ascii?Q?6BG9ShMfdoPPfOQrkEkvjAouiWIxVw1e7mXsjZJyuW7eD0H4cg3Cs90mFuzh?= =?us-ascii?Q?wEKhJA4BJlZ/u8pGRBudQuHdY0Qv9EJy6T48lBclZ+V/n7j+nQuMnXfUFBJe?= =?us-ascii?Q?utKhM40lx9x20HUwIfHmFLnCZAgWSCvpJ8lSC7o21RWWrDcHfXTZx9ppN7J/?= =?us-ascii?Q?bSgMNpHuEFdz4yFL18yFy3llYlGeBcsRWrkNZCGBkR1w9MsEx+spAb1TsU4k?= =?us-ascii?Q?APSmh6EhQ2rKCD3DhIGHsJlHJQQkijxOABEfEZXVVrlnHXxo/wEgrcSC1aEm?= =?us-ascii?Q?WQwYxsevFsoYZcf9tGBu4DHs2AtVVNhzCSX3xvMwdjjaNe1tb0M60aN+M6yy?= =?us-ascii?Q?xbZs/LyGNbtWXMZ0NVGg1hYY5BNcZonEhTJXz/w9kf1Lz43fNQR2wubJ8SoE?= =?us-ascii?Q?qj2sGg0yg2XXpmsNL2dbomjSruJ9PPvqV4fkBpV0ImkqD134/CQ7RvUFsyr6?= =?us-ascii?Q?8N8Ly5phP884cwcO3EJLz6jRmVQgWp31Qi+ByHn4RGtw80jcxYpumUyRee4J?= =?us-ascii?Q?OvTJJYuIKGqhohk6HG6Zs5uhOr4d1yf8Lr0AHFasPLW7EKL+wi96DaqhdTk6?= =?us-ascii?Q?y5awM2E8NS4lPJQ/oB/PKDQigkENydC/sC1mIP/GkuRK5R/S7gWr9y3qjrto?= =?us-ascii?Q?8VtP4pm4m06j3UXvhPwWEypZvjZn2Gd+D21VmCdjitI8Sldqe/pQyEUgZ7tJ?= =?us-ascii?Q?PA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2a3411a9-e9e7-426c-1eff-08dcaa70f1f4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2024 17:08:45.4114 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ShYLSu/NYrbpD5q61VwxQeb/5DNKXQkYHHQceYmd+SSdYcxzpe0aiiIPXuL5QvHWhbMhyP741wrfQTdn7Rhup5m5Vw8qZe4XLVsnls+lxCY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8592 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Jul 14, 2024 at 04:26:26PM +0800, Jun Wang wrote: > >> The code to update link status is not safe in secondary process. > >> If called from secondary it will crash, example from dumpcap: > >> eth_em_link_update > >> > >> Signed-off-by: Jun Wang > > > > Wouldn't it be better to fix the code in e1000_check_link to work in > > secondary process. There are network virtual appliances that use > > secondary process for all processing. > > Yes, the e1000 virtual network card currently does not work properly > > in the secondary process. After skipping eth_em_link_update, I tested > > the e1000 card and it was able to capture packets normally. For the > > secondary process, I think eth_em_link_update is not necessary. > __________________________________________________________________ > Hi Jun, can you provide some instructions as to how I can go about reproducing the issue? I used a VM with emulated e1000 NICs on it and was able to run testpmd and dumpcap side by side. Similarly, I was able to run two instances of the symmetric_mp app side by size without seeing any crashes. I'd just like to verify the issue and confirm this fixes a problem before merging. Thanks, /Bruce