From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD93D4560F; Fri, 12 Jul 2024 11:34:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9465402B3; Fri, 12 Jul 2024 11:34:26 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 8224D402B3 for ; Fri, 12 Jul 2024 11:34:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720776865; x=1752312865; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Aj/UFDwept89WfB9UqeCWts3pppwSg951jcETzVVVd8=; b=OpuQu0xaJbfu8HRvhTGjPEanc2oycxM3RJ2b9RcXFCXT7YFN8Wc5AicJ HUvvfVpFCzyLf82QH9wQLQzm+cgjI0Z5JfnTf82dgqGLZxOCGUa8rQ+MH Pz4ihTZPm0I4xYX31RCoVNRYa8zYJ7d7sf23/L+QpRT29fl0DWRctNNKr 9hvxQHLNbNIf58p9weTv36WnZO0B4JHwXIFWjOaqDSDIj6YPI1BV/GCbk gJGzKMYn4b5ZwphqWaa+PktchADu/W+59wVYwwM2jzSdDDK4XMMa5RG25 sJATGzrGsABHvlBkqq6hK5YqLiZau/TV4ieZDGBFX2ZUPcPndj0hNXlKD w==; X-CSE-ConnectionGUID: NEYcb6ZnRdW3DrNl0QSSwQ== X-CSE-MsgGUID: 9KlIx4u2Snmp/nenvbgm5g== X-IronPort-AV: E=McAfee;i="6700,10204,11130"; a="17825643" X-IronPort-AV: E=Sophos;i="6.09,202,1716274800"; d="scan'208";a="17825643" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2024 02:34:23 -0700 X-CSE-ConnectionGUID: jXrMCTVoSSiXLOGtA+8y4A== X-CSE-MsgGUID: nnS7jVCiSGyNzJNfX71mCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,202,1716274800"; d="scan'208";a="48745491" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Jul 2024 02:34:23 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 12 Jul 2024 02:34:22 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 12 Jul 2024 02:34:22 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 12 Jul 2024 02:34:22 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 12 Jul 2024 02:34:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JealKoqU/9fpjmF4cSriO74pruGGvzcV0uaCJdgOSH/p9Yhx/vh7ZMsNOIDUZhzMxBl5TfimHeXMwT5jkl90eHOPUw5Dcvmdj/vYyK7purYhG2LQrsXaW9KihvQkOy4Vs6xTDlfHnhICQKTHl0fOCBIW1W9xTy7vckmD/hwf7BYcznLnH8ddlGbfJeL0PnzXiVRWjWdM8/S2ieeViuAuERefQ7wt5Dbqr9IHHg0LiO+M5W8z7EzyZDl3k4YhfbTbnyMfX+jlBto47mR0jRSXKCRw8YWo1Kv74rMAWAXjyxlWLbhpfTjijA6kXt7rAdPpcGCO9VfEVIU830czYNvF4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ygay78NsislU8AA5q+GTGSAS0ywcW+hVOw2k3/soKuo=; b=KHRI7sHuMGLOOAwjnQlP3zwHhYPQ4THAGtm0s0kz9P0W7PG4MA1atNPa1/TWAhGfn0wC1/jwcB7z6zTavgktmdIhiEOoNIonqBTpM+v3zDnCdbga5EGfTlDDmE6HlroDShXaf5Mq1sv4KpjpkWz0CBR5Bxf4QhYUHvpv0lWvkZwDjEUFWAmc5nCqSpn7jNfDKAF9OGiw0JXQ7fWyY6DvmDOYe9AdWcZrv0DtbXvV3WnTDXD+0qamkN5NJ9s0boTSx12SPJtMJpm6ieiwEmbWbRantFvKGvrCKXSHI6YnmRrtccCpZll64dFMHZZISUn4jHBjdlianU9g+a4Q97EoVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB4795.namprd11.prod.outlook.com (2603:10b6:806:118::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.22; Fri, 12 Jul 2024 09:34:19 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7762.020; Fri, 12 Jul 2024 09:34:19 +0000 Date: Fri, 12 Jul 2024 10:34:11 +0100 From: Bruce Richardson To: David Marchand CC: Subject: Re: [PATCH] net/ice: fix sizing of filter hash table Message-ID: References: <20240711165728.1105073-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU7P191CA0019.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::33) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB4795:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fab23af-23f5-4b8d-e364-08dca255ce30 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZUNmZXIzd0JxbXlzNSt5QVY0dEJFeWg5SW9iYjZsdGlHTXdRZkh5aHhPRUFt?= =?utf-8?B?eEVXM2krQTllNklkME42RUpNVUxrTWtMbjFiOElZTmdaMXBienQ1Y2lQdit1?= =?utf-8?B?LzhtRmNMU2MzYVhZSUlqZmxFUnhiaGdPbjBJVXVwTEpmazRJeXhQRWlkYUJ4?= =?utf-8?B?OCtUSjVRVTFYWEU4VWQ1QXU0WWwxK01tV2Fkc0NIU3NVTVpqelZUN1FINit4?= =?utf-8?B?MXVrMEVoNzVJYmg5OXQxU0VVeFQ4cVRZVWhaRko2WjIwbWoxRmFNSXd0aU5x?= =?utf-8?B?R2dPUy9WZHQrUldJdUFxTXdHbWJaS3FXZWdOQkxmRFNEazN3anRVQ3MrVHpG?= =?utf-8?B?d0V3eWd0dEkvTXpTQnozRGhrVmFUZzIyWk9rUzFKQWFtQXJaYjFTbStqTWF3?= =?utf-8?B?N2F2WXFwM1dVcUN5OUNXSHpHSEVjUTVULzRFSnNLWDlQM0VjN1dRckM4dTZJ?= =?utf-8?B?cVArQXNSOU5zelBqQ2haczVBMlpEQUVrS1N4Z2h6TW4xOHNkU096elpUYjFD?= =?utf-8?B?R3puL3EzbWhNL1k2Y2pHNXhEemFUSVM0R09wN2Q0dW1jRC9qYkE3R2VSYmVR?= =?utf-8?B?eEg0VDZYK29vNTFiSGlJYWFwT09VeUMyTXFZRXY0NElpT2FNRmsvdjYrb3V2?= =?utf-8?B?N0FpMFhmanZpUUlsNjF3TkVDc3Jkb0JjTngvQ0NWa1RxeTYzdEFldnNTUXRE?= =?utf-8?B?UzFXVnlMOXRjRm9VYyt1MlNsZSt2d2xQYzZoOEtIZ3hXN01mZktqcVI0anpq?= =?utf-8?B?dlpqRFVxNU9lTmxDUFhNY0lvK3UwQVNhaVlneDR6Y2VNdUNGZlVzSlF5c3Nj?= =?utf-8?B?b0QyL2F4NFhRclM2MWhMZXUwak1ERGZSbWhiQXZsRnZPOGhPTklpM1VMNXF0?= =?utf-8?B?TllkbGovd2FKcDV4NHJ3NmRJTUNyclNiN3NTalFCK0x5WHhNaW9TeXB4VEJX?= =?utf-8?B?ZWZ2NmZnNmxMRkZ0bllzMUMrWDVMS0srTC8rUS9FKzQ4NmROdHpYaDNHajFh?= =?utf-8?B?KzlPc3ZnMzRsbTUxcGtnSTQ3ZWlGVTR0YjhSVXIydk94K0NtaWRoTmpoNU1L?= =?utf-8?B?emZ1bG83NDJMSkZTSUNINVVGMDZERk0vZGwvWW1OeDhsTnpZS2hhNGtqTE5I?= =?utf-8?B?WEJjZStZMTZrQzFwcG9TdmpxZUl3WE9KZzB3VjlkOGZNNkk3TkdtS0xQMHZq?= =?utf-8?B?OXVsRjFFOEVQRU9kdG5tSkdiV1JWdndpQ1BwdHBwQWZIdlZGMGFlY1JGcDhl?= =?utf-8?B?UVpKV2NSVDBsT0Nzc1VzVEdQSjArWGVsRTNFcEtsbEtTalR2eHkzclRSYUFo?= =?utf-8?B?YWdKb1FyOS95SnBiamFzY2g4T0M3RkwvUzZ6QzBpRnd3QjhVQzNDSFNLdjlo?= =?utf-8?B?dTQ3cHRPdmtJdUNySzJYZWVZVTFYOEhKTmUyVTdhVU0wSFY5YVFNN1Q2K0Q3?= =?utf-8?B?L3BGY08yUDhOZ0tMY3ZNdGFmMHRpNEtCV09iRHBCOG80bGlEaHhJM0l4UWhM?= =?utf-8?B?NXg5VnNsMU40cEZ4a08zN1NyaFo2anZ1OWllOUdMSXhESi8wVDAyOEVtNHpV?= =?utf-8?B?d1orZVVkRlViZjR6NTV6d1BhbERHZ2ozOThYVlBuaGlZZjc0WDRiRmNJNVBE?= =?utf-8?B?YUEySVYvanhqcWFPMkF0b2xFSnNxSGsxOTBjLzRza0hLbUV3NEFiTG9GWGRw?= =?utf-8?B?L2t6TEtMTWY5bVhVQmRnaXlQeXhNV2FUalltOGROdTNxbDM4dUpCN3VNOE5s?= =?utf-8?B?bWFjRzk0ZEg0a3VJYmhsU3RiZFRBTmMzTEpyWVp1MmFLYnZPN2dpaE5Vdjdy?= =?utf-8?B?MG1OUmVmNjlUTDN6Tm44UT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFZyRW11c1A3Z1JFdzJzaVRWMy9uci9pVXg3Q21NN3p1L3o3L1p0ZHY2YitD?= =?utf-8?B?TCtZRXdzai9GY3pNbDBOeHhKcnBXMEZLSnFaWksrMjdIcGlqNDNUVEl5L0FL?= =?utf-8?B?UmpCN05Ic25Va3lKdmo1T3dRNGl5QUl3Z2xiM0U0WnFYTHpNOTRqd2N1cEQv?= =?utf-8?B?MFJ0clc5eXlVWVdwVit1bHlPb1FDY0xJa1lucXQzcEFQOGpkY3BUV0NFSFU3?= =?utf-8?B?RDUwZUVVMVhrUWFGTmRiaXVERFNRclBPTGlMbERDaWFIeVB2YnNjVGJMc2M5?= =?utf-8?B?Y3haYUoraC84TVNCWHBoZlFicnBTWnQveUVNQ1VMcm9qM0c4c2xlTk9qVWd1?= =?utf-8?B?aUozaTJpNkZsRDNmaDJVVkNvL3kyOTFseThDYVhyNUsyUFVWRHVPOXV1NEZM?= =?utf-8?B?aldkRk9KQU9Xb3Y1Y0RjWkxkZ3BwbjNYRlB0NmNuRlF1VUVnMnZPSjFJR3lM?= =?utf-8?B?RlpsczNSaVlMME9odzZuNkZ2bHRLVGExL2pZdVd1cVk1NGVHaHd3Rno4SW5K?= =?utf-8?B?dXd1M0UyTmpGNWkxd3hPcWtsTHlIS2ErU295MTAyaCtEcjU5NWtidE9yYXFN?= =?utf-8?B?MGtXWkFTNVM1Sk5mK3IzWUJBWWtHbzdPS0ZhZWNpc291RkZmOFU4Y3dWSVh5?= =?utf-8?B?TkhkUjhrb2pSeWx0SWpwRmp3Y3pFZjYzWFJ3aUtzT09YL3JhRzRpR1hORURD?= =?utf-8?B?MXRaa1pGVmtONjl5cFpSZDZYUGdtZU9ZZHlLYlpURVpUZGxRK0kvenhUSk00?= =?utf-8?B?SjFtU3U2SkNJWXpLSWVhNDd0YnVqaUFNYjN0OTFtN3IrT3RYd2NKWmZGNFFI?= =?utf-8?B?OUlDeVZEL1d5RlJlREJySlBIY0Z0Y3VUbVc0bldSdVRaVFJ3ck85QysvVzBE?= =?utf-8?B?YjFab3ZyRlVDSkpENzhFY1V1cG5IUHR3eG9BbVExRWtwOXhZTDBmMFIyb1R1?= =?utf-8?B?WUFHVEY2c3ZYOS9lV2NCR1dVbHUxK0dqTG9OYWRvNzZCc2haR1ljelpyR1NS?= =?utf-8?B?WDBBbThnSmRoZTZKbG93akFzK2RGOHBtWGg5VHYrWEJMb1VqWm9DbmNtZXl5?= =?utf-8?B?SmZSM2luNlQwdnRWR0szcWl1U3dLdmtvRWx0ekJzZlRDbVkxL3htQW9Rc0ZK?= =?utf-8?B?T1VNenp3NSt6MkQ3a2VxdlZzcFVxU3NRNThTZUVycVhBSlNWaXlZcGNDeUlP?= =?utf-8?B?TE91YTN0aXB5eFNJU1h3QStnSVBYd0szcU5xblRBU3Q5OHhOMGtYT3FOdjVO?= =?utf-8?B?WGtZU3J6RHJ6TmpDdVpWSEpTSHVCcTFlRy9WaHBZZHNEZVcyN2dUYXFtY29v?= =?utf-8?B?ZmlqeFRYRHRWL1J0UW1SelliSUFZRjhxeTBvakJsQ2tjQ082SmJhaUpRWUdG?= =?utf-8?B?OE90VlRzUkNDNjNSRElwaEQzRE1xdlZ0VjczRGFYMVFsVWwyQkVTLzdiMTFB?= =?utf-8?B?aWdDV2swVVJ5VjFCbENyVFhlbFU1dWdXalpkUGZPLzBTUERaZDJpMnR1dy9y?= =?utf-8?B?dGxad21ieVlSOURIN1U4VUQxRkgvU0hpMTFtTC9vZUlUOWczcjlPaTNsa2pj?= =?utf-8?B?VHVqZVFyR1p0ckMwR1RPam9Md0FJRGp1eW9JZFUyclZ4dUpEbG5iLzE4VWs0?= =?utf-8?B?citRMWRxZVEwTHJQWW1pWFM5eGRLZ3NYUnJrRm5XNXc5RWFmbE1pREtsd1BZ?= =?utf-8?B?Mi9YK01TMG9HdzF5OWsvNXlmWG10b05NRVBIR0ovckMrN0JTOUF3eFBveWVN?= =?utf-8?B?RzlOakZRMitCNExwNzRiM2R1dHIwT1hQS1UrTjVFdU5vRXFHWE9UaklmTnlq?= =?utf-8?B?M00zbk1KcHI1NXRpZzF5bm5rY2JGQ3VvYWtOMFg4amRVaDRvN3BERlFZck9i?= =?utf-8?B?aHB1SnZWSFgrbjVRc3hudzhXRTZ6dHlwN0U3R21tMkNJeFg0RkVUQ2U3TUdJ?= =?utf-8?B?cFlnRVplS2FBOVBVWG1Lekh3Zk5kU3dXY1RSRVJ5aExna2RJTUN0aVFqdlYy?= =?utf-8?B?ZmdYOGNNWmZlZXJ1V1Y3SytvRUFwL2tneXRIRE9aVDcyajFEbUFORHdhZUtQ?= =?utf-8?B?VnBOajRTaWhSNlBUeTFJVjJlVFNucExYeDNPenVVT015ZGZVbEpZUkkvYlZs?= =?utf-8?B?dmhFaTFDanhVYVlZUWcxeXozV3pLWDlEUEdnUHZXVUJGMkx6bUhRdWNHZ2g5?= =?utf-8?B?bVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9fab23af-23f5-4b8d-e364-08dca255ce30 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 09:34:19.6187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8kDOXYLWnogHljchqpGUfBbhOCL7tyNSwaTqsvbllIbRku7FoH26N3drYLCQ1w5lqD6FRIloDp5wHB2BnPf8DpQdarcZ7KSu2eHZ2PwBQd4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4795 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 12, 2024 at 10:40:02AM +0200, David Marchand wrote: > On Thu, Jul 11, 2024 at 6:57 PM Bruce Richardson > wrote: > > > > The hash table used for managing the filter rules in the ice driver was > > dimensioned to a hard-coded 16k, which is insufficient for holding all > > the filters supported by E830 HW. > > > > Rather than using a hard-coded value which may need updates for new > > hardware support, we can query the NIC max filter support from hardware > > and scale the hash table size based on that value. > > > > Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director") > > > > Signed-off-by: Bruce Richardson > > I did not test it, but on the principle this looks fine. > Acked-by: David Marchand > Applied to dpdk-next-net-intel. /Bruce