From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7728945699; Tue, 23 Jul 2024 19:12:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0740C42670; Tue, 23 Jul 2024 19:12:24 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 97F7040E4D for ; Tue, 23 Jul 2024 19:12:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721754743; x=1753290743; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=0TAPidwd0odsykWHmRepcHc07rfyEqjMt8W947jb4XM=; b=j3B0EsfMpNhDWwkmTi1igGAjik72wOQMiE+mQCM8ztl72PIhp31e86Ux 8+S0UY9tsIXogLjBehqzxvpwkrHHw6tQKnnE/7VCEW+4T9gxxzfAdcU9/ 4DyalOs721BlnoN7gB9c0c+YU6rDpObedHztU4iuFB6ztqI1pLUPDBhag oS1nie/jHs2k0E2KtMiR/m7P1Zsmx3wik/DOnZennDn+C+7UrYOKAqW24 Irshq0lzwyy732OlQS80pUnVZt74vypj3Fpy8a4hBnOsJS9oqM7t7m3DX f/HYbtjT54NhHk7BJ1AzNlw7ZL11IsYpgNSAZYb+gyg8dpYQxt2iEQB+i g==; X-CSE-ConnectionGUID: fktqLpMiQVq2fiGetpZWDg== X-CSE-MsgGUID: 8pgJf/22Qt6etRrQMCUqGw== X-IronPort-AV: E=McAfee;i="6700,10204,11142"; a="29984482" X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="29984482" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2024 10:12:22 -0700 X-CSE-ConnectionGUID: XCFueLXqRLWulglhDKY2RA== X-CSE-MsgGUID: YOBddRIxTMuiouGrzgtL5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208";a="56846392" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jul 2024 10:12:21 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 10:12:20 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 10:12:20 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 23 Jul 2024 10:12:20 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 23 Jul 2024 10:12:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p2wExhcr9085eOBvQt0LYYB/jf/2EsvMPofkbY/PKztUR5LW9IM3yfCEdBSTiCyFNOZ3pqNac1uiBcFAZphx4/ZfKk4iaMh64/+7I8gE8UGLKptkbYqSm19975XBHebZk7Nsw1MPrz5y9aSeOyA/Mom5Ombk1gEbnCza6W7zmjjWS60t6ENAWeP3a4eMz30G0XQ313Z8aCevA8Pg84OnFMEXDFGGVOnJY3jQPmJnUwoX0mrJVXN8zKJtyJtflfjL8viL8nRr2VP0EgGUjoiFF4KpSy0QnbGLp9QsaPEy3VLeIQ+4Cwe+Is8c0D/iKaHw6reQy5eo6LhMtq6dHP894Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5nUrg8KZEiiuppEzMo9tIinjUgIdJhrMD67FYRhz6mQ=; b=cuFtZF5E6/+7pXfpE7E+bu1tBbncJE+3zUkhQcxIAz3RGTWrnUc4OtED3Vzq9T5TcDrCCjupfZ6gAipVIBCYt7vuRBO9pfeDIn9isPiyYc71BDWTL937MOLh4D28xNGWGibKYsvN6hapzugKm3Rr/1RWG1RHrGrFsZmx7oDdXheM/8W+VKzk+QipIRJqvmChps3x8TObToo38y2QTuzDizQOChz/ecFTE0deAgGtePDANbbbgoSDicq/rOOWuitUp+/RNj3i4cOq/aRRdSfEh8dSPYZc1oQftiDwfmay7Hfdt6k0bZRV65lOQislA1omo5UQ7EhsbDNK7xQrFsu4VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB5049.namprd11.prod.outlook.com (2603:10b6:806:11b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.28; Tue, 23 Jul 2024 17:12:17 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%7]) with mapi id 15.20.7784.016; Tue, 23 Jul 2024 17:12:17 +0000 Date: Tue, 23 Jul 2024 18:12:11 +0100 From: Bruce Richardson To: Ferruh Yigit CC: Vipin Varghese , , "Mcnamara, John" , "Xu, HailinX" , Subject: Re: [PATCH] app/testpmd: improve sse based macswap Message-ID: References: <20240716063724.850-1-vipin.varghese@amd.com> <2487809b-ab5e-450b-8d9a-11d3fa32af96@amd.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2487809b-ab5e-450b-8d9a-11d3fa32af96@amd.com> X-ClientProxiedBy: DU2PR04CA0076.eurprd04.prod.outlook.com (2603:10a6:10:232::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB5049:EE_ X-MS-Office365-Filtering-Correlation-Id: fdaba1a0-eea5-4239-991b-08dcab3a9a8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?W4NPE/z0kQiXs/0DySjnSTca8PQbg6vYTEDhUNrk9mOLlC/vX90qM8AGSRJq?= =?us-ascii?Q?RFZfugD/jGOJ5qN9c3rrvRvqS6behy6XpqAsrhjbbBnYM4LZTKknlHRVEGQE?= =?us-ascii?Q?t+HK2wax0HY1hX5JWAez+zCF1xn06iBYNSChKNGF0gkPED9Tek8Z4mwQPBH2?= =?us-ascii?Q?Mwtd5R67tkE1TOgYbbBYDCpgIYxEEV/sdq+CTlTuYYRgjErTei9Up+FrNn1k?= =?us-ascii?Q?SSdEKamkCyufgAg+I0XBzYoyTzhh5MsykdzkG8HHMSadgRCm/bRYiXaXAjZR?= =?us-ascii?Q?PUqeykBieeBIrKfDHd69NUWC63RJFokh70YjzvRJL5PweFkI3u1145mtOzVu?= =?us-ascii?Q?pa1bHOJfVTKkJw3iDjyRrgwsjDqhpgw+oRp/cbYLwurCEcpRbQtIIS7sQiOW?= =?us-ascii?Q?W96ckUCd1cDhaeLZYFky4dIiNAgNAd6+IenqYx3vKaKL3hsgLZCwPGrQiqRP?= =?us-ascii?Q?o9i3/H/FBxG/Cn8pEjoBtYBZageqSEpTh+7EpoY0pq4qSyImZfFVA1K9vzWw?= =?us-ascii?Q?7DkgPvlwSnNojgwZTbjW5ko63FJNHGEY1VfwcmaQQ6zPX/koYjRzBQy7CN0b?= =?us-ascii?Q?YViZaP0BPkVWoO5VOAIeNvly0ogIWZXMTuqiVgxYPNUR0B02qbtF4spdlXlJ?= =?us-ascii?Q?ZKLbI+XTwmKyC/YoXBgjFE5TbSDr6hDHt+PlWVp87sZySkwLvL9xr1cxDu/p?= =?us-ascii?Q?2YihOxpKhOeYYhPQU3+v8G9R6YcvacYDO35s0sxvDc57E0kdUwpABk2uJ0ed?= =?us-ascii?Q?1NgpPaomvK8wtL9j0AMekS0xeMZLg3F3867eiTbkwrdSWSgBdafmjxVO0iLH?= =?us-ascii?Q?IgXMJnCl88qCtFqkhIoHlfJW7DLSQNlFh+xuJtYNQakQcjVuNoBSSPdWc/m9?= =?us-ascii?Q?rFsDoZ+5u38nCT41kpElQK5rM9oBhhUvO0H4Qcmpmy7QLl1q1xoeGGPpDCcC?= =?us-ascii?Q?wJ8VYXh1L7A6EFbrozK/FRVrpprpajs8zdexJwiYdja5Eo+LhVauOUlPqJdy?= =?us-ascii?Q?fJMCOlr3PeFFiHGjR5th1SYaWzuN3q9szgZ9wyKpGb7y98l4lEZ4X6hnbx81?= =?us-ascii?Q?MzNOKgg1tlmhv0zvG6iyKG6wwyU63KfKSudLbXF46Z1vaI1YklhnsBhm7Gwx?= =?us-ascii?Q?hJM/Yy4HQvBXBmzLKVsk05Xdf+Gx9C746S72I5Pn23SkwwMkcoEYFuRIlA1P?= =?us-ascii?Q?BMw/oXseffI5QtZq+VMmmKAAEG4cjyfa3moOMQAJyNiV/UszOBjCjXdVX7T/?= =?us-ascii?Q?Fd20Rk80fficdxxb2oiU/YSpwfuMSbMj99wBYVU9O6Ml1v6ROVOXFVpiOEPp?= =?us-ascii?Q?Kvqmy4R1EyJerfPv7Au56QcrHqfaPA0ytfFQSkmK1Ey4OA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QEplxSYMTYiwEMCOBN4MMSQX2PH0DbN1XVxL8CyDoXCb62tPJS0Ms96JW9KT?= =?us-ascii?Q?qIeqbkO+M3tC4+0ACHFRhk3pcXuRtzQoQQaohXKLgPeHQNcTTARRV+JLC/RT?= =?us-ascii?Q?b4jGrFbrdzrme6ZgJghN85VqNM4uJaffi1SrpIobzbw2xb7+eHE7ftjaXMtN?= =?us-ascii?Q?XENiWHsyin6BZU2vj2w4M8n08f/1t6YebdCgIDi5eC6deL2MLPQYmlU9UDtu?= =?us-ascii?Q?Acwnyfo1/YuKCKN8Y1KOJZGzr14lJcjXKdiHFE8NgqBIymZFGRUOeFF98XpV?= =?us-ascii?Q?AQtrEdxIO98DstPRhfAZAHaAX0U3U+5mTqlKKaCjrvLY7KbgV7MNTAG2D6Ej?= =?us-ascii?Q?aa2HcHzqbRTWQ5eAyDVTSd2DjuOVxu01Y3DQXBphQVUzjC9vLGiA04fqHkG+?= =?us-ascii?Q?iEviUp9We9wJDM14v1QWzc4Y3MO4NV5uUhpikAwIo3ymRFkqjbr/TyfRrmXR?= =?us-ascii?Q?P2HfJyDvR4mLjglxoOHPny4Q94+PdihbFSGhUqEYCwC/nJtzKnvwmg81fWdF?= =?us-ascii?Q?tyNct+M/l/WeVQLI+e1U5GHMZmC8Ojjd7RsHj7uIY/GeI8jwiBhm6IBMKmlA?= =?us-ascii?Q?WkbJL1AQTCcuXRGFxu6DvaRNf31QRtj/7dIY0DThHaUKITAaxws5HbPXelPU?= =?us-ascii?Q?PcFz2BFc1Xq2sFXk1u7OluGGoK9T5Dec91jFAn1at9vnXVe4Vgef0X3Tz1t9?= =?us-ascii?Q?XGhodBfHjWdgh66K/pAasrV1kbm1RZktqVHiuqPfr2Vyi66slrJ7blA4cz9P?= =?us-ascii?Q?U8hGqUDm2GVkFRnYna4yTO4bybusVCknIuf0YsZinAo/TGBAhd5wz4JN7nOA?= =?us-ascii?Q?gGhtLxUMAHZe4MVvsW3okktI//EO/CTJ6RRbDco/OVJR5sWbwdzT6dgSMEJJ?= =?us-ascii?Q?Ai9QfFuMY8C0EEpkIz0kEiuLJ/4YieD2qlqjblxiNuLLh5syPQjTT1eWgH87?= =?us-ascii?Q?eJPDnHAwniDcFIESkAIIheoXBNiipw8vOHyEmmYwQbEdCtIFWq//DcZhQkST?= =?us-ascii?Q?aR5NN50UV1Yb9n0DFxadK/lQPgOOlHzpXR59/tHwHFGQM6U93BbmMvhh7Q1v?= =?us-ascii?Q?kEi+tjduf1Koc531WY2hMtvw1t4uscbVIl2/b2WsadQO47QalESHMC8GNZFc?= =?us-ascii?Q?yAI1+VcsjHjWw7BYRbfXukELl/XgPynZHJ85FD/bivxJjHe6DsvLw89nKqei?= =?us-ascii?Q?yAkxiB407ZMpgk88cEJCbMNcNPiZkdcCj2QwauaAW1aegX9wjZOqnkQIo4pq?= =?us-ascii?Q?PhX2V6umjmyWlHYWG8WVCXO1qJoxWz05cms3B0P+9u+ok8jhq52aBFFJRTaz?= =?us-ascii?Q?eUmdXRCX8fxtOesFjPS9a1jaydgGNb9Rus2PD9w2Qo69mxEwnolJq9muGk7z?= =?us-ascii?Q?LgCTSo+Mv2bCtlhvhqQxisqCaW7Dwx99PvRHHDGt/prW2QdGtKQtDODN+FDo?= =?us-ascii?Q?FMAhytDwCWIrVMMf9U72AYo/2c9sahS1JmYL437kQvAMj4zeSG8/JJ8d9DaJ?= =?us-ascii?Q?tb9lD/D1R/h/OEa3WqbfsHb2MtNiK9/MJYSabm5D4qej2nMvujvgDdfaWQEK?= =?us-ascii?Q?hxPXL30+Jr7ixksBwGDzVXDdwU/EhSIDkVcYGNtARSIrzMsWcXVtoM8YM/xG?= =?us-ascii?Q?pw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fdaba1a0-eea5-4239-991b-08dcab3a9a8d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 17:12:17.1309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: isedgiJvVhmDV67L+5XBhlWcw7b24Er1Eap0IyVcXmr34AF3m8Ivkgg0z4so1u6pooBuV+ukluYoMUMa8fivHJsdahkXwpcLJHMM92zonFg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5049 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 23, 2024 at 05:45:57PM +0100, Ferruh Yigit wrote: > On 7/16/2024 7:37 AM, Vipin Varghese wrote: > > Goal of the patch is to improve SSE macswap on x86_64 by reducing > > the stalls in backend engine. Original implementation of the SSE > > macswap makes loop call to multiple load, shuffle & store. Using > > SIMD ISA interleaving we can reduce the stalls for > > - load SSE token exhaustion > > - Shuffle and Load dependency > > > > Also other changes which improves packet per second are > > - Filling access to MBUF for offload flags which is separate cacheline, > > - using register keyword > > > > Build test using meson script: > > `````````````````````````````` > > > > build-gcc-static > > buildtools > > build-gcc-shared > > build-mini > > build-clang-static > > build-clang-shared > > build-x86-generic > > > > Test Results: > > ````````````` > > > > Platform-1: AMD EPYC SIENA 8594P @2.3GHz, no boost > > > > ------------------------------------------------ > > TEST IO 64B: baseline > > - mellanox CX-7 2*200Gbps : 42.0 > > - intel E810 1*100Gbps : 82.0 > > - intel E810 2*200Gbps (2CQ-DA2): 82.45 > > ------------------------------------------------ > > TEST MACSWAP 64B: > > - mellanox CX-7 2*200Gbps : 31.533 : 31.90 > > - intel E810 1*100Gbps : 50.380 : 47.0 > > - intel E810 2*200Gbps (2CQ-DA2): 48.840 : 49.827 > > ------------------------------------------------ > > TEST MACSWAP 128B: > > - mellanox CX-7 2*200Gbps: 30.946 : 31.770 > > - intel E810 1*100Gbps: 49.386 : 46.366 > > - intel E810 2*200Gbps (2CQ-DA2): 47.979 : 49.503 > > ------------------------------------------------ > > TEST MACSWAP 256B: > > - mellanox CX-7 2*200Gbps: 32.480 : 33.150 > > - intel E810 1 * 100Gbps: 45.29 : 44.571 > > - intel E810 2 * 200Gbps (2CQ-DA2): 45.033 : 45.117 > > ------------------------------------------------ > > > > Platform-2: AMD EPYC 9554 @3.1GHz, no boost > > > > ------------------------------------------------ > > TEST IO 64B: baseline > > - intel E810 2*200Gbps (2CQ-DA2): 82.49 > > ------------------------------------------------ > > > > TEST MACSWAP: 1Q 1C1T > > 64B: : 45.0 : 45.54 > > 128B: : 44.48 : 44.43 > > 256B: : 42.0 : 41.99 > > +++++++++++++++++++++++++ > > TEST MACSWAP: 2Q 2C2T > > 64B: : 59.5 : 60.55 > > 128B: : 56.78 : 58.1 > > 256B: : 41.85 : 41.99 > > ------------------------------------------------ > > > > Signed-off-by: Vipin Varghese > > > > Hi Bruce, John, > > Can you please help testing macswap performance with this patch on Intel > platforms, to be sure it is not causing regression? > Hi Ferruh, We can try and get some Intel numbers for you, but I think at this point it is better deferred to 24.11 due to lack of discussion and analysis of the numbers. This is because the numbers above already show that it is causing regressions - in fact many of the regressions are larger than the benefits shown. This may be acceptable, but it would imply that we shouldn't be too hasty in applying the patch. Regards, /Bruce