From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43BC74571D; Fri, 2 Aug 2024 18:51:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3FF740E22; Fri, 2 Aug 2024 18:51:26 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 7797840E0A for ; Fri, 2 Aug 2024 18:51:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722617486; x=1754153486; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=vkVXy617zoo7COjRgDGO48DF0fXyMBOEQbi6xiIDF4Y=; b=Ch9qxGaQjmLWJKtX52In8h6vtedxqECHvAkz0ygs+wo8o2vD0oJ8FD5u twxicH4JViLds7mav9Io/bx/6NITKGsabnzIhIAF64ywxrJhOCUF665J1 ghrNNqcpApOMtXEecpBDLN9vrcPaScyVQJeEbEjY1o/hht2Vjc5LP5wXf +V7xkSScJdL4DmMFP5Aq+bBMW1wP+vxvn/UfkGK0wIte6XEcLyNtToSSP 4JVZgE8iEFjQ7cAJ/yp+tqduvIdVzNv3mAjrZ5S5BCM4JoLQ7lFNiprMo TmI4CNoNCfhMcKV8Hamu0tKj1nlmeakFmjPPrZCq33OrAaYCoKj1BTdht A==; X-CSE-ConnectionGUID: bIzFeIIfT9OWm0eFMWpW0Q== X-CSE-MsgGUID: zIbNG/JGROOa5XcBQshLZw== X-IronPort-AV: E=McAfee;i="6700,10204,11152"; a="20483775" X-IronPort-AV: E=Sophos;i="6.09,258,1716274800"; d="scan'208";a="20483775" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2024 09:51:11 -0700 X-CSE-ConnectionGUID: CldzVhOxQ+2P9HL9r5m+1Q== X-CSE-MsgGUID: pqB1eREgRNyozElLUefUHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,258,1716274800"; d="scan'208";a="55135652" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 Aug 2024 09:51:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 2 Aug 2024 09:51:09 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 2 Aug 2024 09:51:09 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 2 Aug 2024 09:51:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bjj+xZgedrEJnm6a1Guou4p9ZKYJvI8indRCEMYDItqbGaJcfyc/um57mml5Qxu2+GLDvW3ZjxnNjwuD1fY/Tzcvqzgk0qGJenlelMoUeey8YAUY+TNZLDneRW1HI6ipMkSYq+rM/vJ2YSkm43wRm0bNeQUq/0jS8UZXSEkzvZGCj9n8K9KITLilDGD8rE7lTv0sA/8Pb7pVoPCnNlMZATph+l6nfijvkdJzocnXYE+iSERLYakSQmgbcWOs3kZpmtq82CkK13YdbA4RMljwWH29Pg/1WmpA+APhNHyC45NhbGG9U/dHhrl+Z/MgrFwi8clh2LaYwk4oCOnm5+F2zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2nVg5OiqFdrkV9tXdklARWbzDj9c4sJQWmfAu2y8vR8=; b=giOCYcwh0pGKZBFVQ/QcPdpWD0RMTYAvR/s+b11KWlbUOKNXyfX2JVIoolQ/Sx/kMCH73MlMJkxkKTqZyO4SIwKDLKmqyzIZyawSKJrZOdLtNNX2h8/aySHnzPX8wg5MhB62rMQBkbVhxW+x7XyCQU3AjPilKxlfuWWSfijl1HEzF0rRXrw62exnESUbzJN7LB5mrDFYBB6oP0bYbHLwr31s/t1BxwaizWpLH/6NdVaSzvdws3IFsrFiCfqdOTBM5XOnkRD1U5I6y1Ol3xQTM2L+ORzdz0C8EGFIt0pgY2eeAdlnPwc3a+vvIIijUQlCuXt9iToNC8U5uPa0YbIxdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB8448.namprd11.prod.outlook.com (2603:10b6:806:3a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.23; Fri, 2 Aug 2024 16:51:07 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7828.023; Fri, 2 Aug 2024 16:51:06 +0000 Date: Fri, 2 Aug 2024 17:51:01 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Subject: Re: [PATCH v5 4/4] test: rearrange test_cfgfiles cases Message-ID: References: <20240730225520.83314-1-stephen@networkplumber.org> <20240802164626.389286-1-stephen@networkplumber.org> <20240802164626.389286-5-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240802164626.389286-5-stephen@networkplumber.org> X-ClientProxiedBy: DB9PR01CA0023.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB8448:EE_ X-MS-Office365-Filtering-Correlation-Id: 52f8a434-f4e3-479e-e648-08dcb3134d78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/Q2dfXJ2b1ELGnCRifAp7bLZ7DP9y0eJX0rhmersxd7n2JZCvGC3qvychF/i?= =?us-ascii?Q?qVHK6m+RGJnIPtqYVykg4OEkN7nHzCqEH6XKbYbTuJiXvBuVhnZmfMbjWNYK?= =?us-ascii?Q?7mP+xv9j8Pn6mZEHqfvR7zqyym5TTB5bHJXf5HUqDmG1VK07Dug8aAncF9L0?= =?us-ascii?Q?v8NViosuoRNO3PwewJsr/+PKUnhnxDARFgHCH39J6LXPkxJtQ33rNnHwou/9?= =?us-ascii?Q?IA/hAgXkdP4rfKYDSf8LRzAkbfTixkSP312FXjYnUEDc7NdufuQjUjK7ZqKa?= =?us-ascii?Q?65z2o+ITokdPfevrXft9h6Ii6XQxC9bBrKS7nDW2VM4WF5oHU6hbLVpRRuQH?= =?us-ascii?Q?9vNwrt9P1VZnFpCMujVvztz65EX2CNR/XUYnHfx5yqS2o4fkmjjyQTHArw/7?= =?us-ascii?Q?gKnU143kZ5fcmf+hua0cj9psaVQ/nUrFJG4W6bPDeYXrraGgYLINFLL8CUJQ?= =?us-ascii?Q?KOqKlqaX2D6EHOvhrNznudMiL5su6ZQ2HgWQAMuSgjA/YFc+80hF9kwRzLwS?= =?us-ascii?Q?GcficdUGFVo2Z9aiKKgrobqLonVNZyQwHZObgyhWeKrt4s8NP1A5U1wduedA?= =?us-ascii?Q?76eIOvvJvT5lgnEAAvBw1K42olq8PBlbYI82Yd69vx+tNgeiC5tG81hK6D7r?= =?us-ascii?Q?8yh9SQI6SPsoaMxVupfx5oc7gosakTExMESpr/mGjR2uh07h5ng5uurIq4cS?= =?us-ascii?Q?GYdbZd0fQ1+w3hQMgaCcSUVZKbet7Q5SSj97ePoKk0RAsUjKV5Gho0DKj9ay?= =?us-ascii?Q?3fhSOd4JfVVTMcXcQiPUi5/kRoBhlKumiIdQsxFz5rZPFIIx1lub8OoE7gim?= =?us-ascii?Q?wBFNvvEpBvVpPyqO05niLBaQRH+rFDcjFR1qLkV1R4ZqkZ/5GQp9tSpYstCI?= =?us-ascii?Q?wm6VRMI0fRdI9526yOKphWawIkEYQt+IsQ5/A9d9Dl89ctQOKrNZ6wa/b69R?= =?us-ascii?Q?wgJIyVNs+2rAjP99jXHBCJF7Y+4CEoTYrQcRvBf5kh7J7IJ/WNud3OYiLWzZ?= =?us-ascii?Q?fDzA2Tv0lf+3hemNFtLNovkvCCkScrtAh7cQ22B1Twat6IWrJmr6iDTxecpY?= =?us-ascii?Q?JLwmng7vg1WboOltbNVd1LnBArDvWxaGHB5o3O8679v+MmIGTJ8pFsonqqtE?= =?us-ascii?Q?D9vVZq7OPk8HydkK45+ly+MlD0UDF6aeHOPbwtp0r1ADlg2l0htMhYz2btpa?= =?us-ascii?Q?xD6K7wofMoYZb3AXn4i8+yHN4FxbO2X0YFPDoiqm1/G6tIS4uDs4d/PUgjhu?= =?us-ascii?Q?Dk1+iL4y4axuuBMehZVpxLCMM+YosaODGHUD6IWDAICkMdIQOWPhQfZCyTBI?= =?us-ascii?Q?pcAUO43Ej3shNsJtcx810Vxk6/6dNWDTxmSJy1q3Xj4AMw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ElIL55QsclCiAlb+rl0Ga5Z9NJ0I8gDnz8lDa6CMyTw5eSWsDGjhxyjhWMiN?= =?us-ascii?Q?w1Z3np75jiQRvlmAEa2AAp8DHmg0qe9hjuw99eI/dxSQW3J0PtidIlijcRmN?= =?us-ascii?Q?Nxl0OqkBlmQsGypKfXS3wfUxI07dvj0KvXiJdYYYXvC+C5WwSp/7sbzDId0D?= =?us-ascii?Q?dXD2lT45qSWxnN81rZAtN9pDNzHT3hubvW/DUyM0X8AjugB5PqoJimxnd7O4?= =?us-ascii?Q?ms4I6Kpb5EDnuH54ewiJeD0A4wFpwZP6GT8B3giYuttc+6v1dUvP8c6sfqpk?= =?us-ascii?Q?cqMcxbHtsl9N5AVlDufwvFmpEB/7bg/UxDgB1I9Wws6KAbjOyJwf8pUHc/8j?= =?us-ascii?Q?JUp12AgyHnP81aR9naeNrR+kCNKaF7+PrdKJIeNNNDza7OtPGVrrWG2B8Gwm?= =?us-ascii?Q?UEc/rbEYumQHnIwEsFBoYqh9eoMJQBtXd2cXFENyNTJWBCNk6wSvNSIvKtea?= =?us-ascii?Q?GIrw1N5AAF/tx0hgV0rKL3G/DZ6peup4fI6HhAPLFNjVHuNw/9ytBerhnUoW?= =?us-ascii?Q?nCkQfa3bK0EjTMFfxd0ci8CPMxYPoev9Ki39uIs1S60BRGF4Tydw/3VFsAX3?= =?us-ascii?Q?OjaOlgEGTzTtpc3RK5mvLN/YDlBMe6dsyc2OLxrUIgyoADAQofW6mihf8Apd?= =?us-ascii?Q?BTHaC6uerG93auJ4peBdsD42yjE10SjclfP/YEd+p5/eRmeka/ocKbCpCud0?= =?us-ascii?Q?CBTMDGqMGQSAOvIQmMm7Eil/8m0wJuFP0y2dFrmhLN+cawbA/kwYHgs95Lp1?= =?us-ascii?Q?LFcBvDPMzaFv3YuGVKCULpvm3pqdR7/LFGNGxePcRiTMbh/y9H1erJZxp1UG?= =?us-ascii?Q?kiZoBvFxfB3XV7uOE2zVfonZfbyHQD1U7nGhIs7LlfwRg819GDraekJ22Esi?= =?us-ascii?Q?9AYmhUgMB61t3MnzLCFSy0jS9jAbJHcNhhaNRmMsNLbcUREirtWnQcWZeJfl?= =?us-ascii?Q?oxFAQULkc70m7gHWC4Dlogd6zVRgi8fKyo4Sk2VGQ9MBPZui272RzH9Bciyf?= =?us-ascii?Q?3A80PvrhsIllgH4JajRLfZF3DUmD07EdRGf9JtCdHbl+xaNfB3rGfjHM5ngv?= =?us-ascii?Q?X8Z1GIkbHwuYdPLJdoH+ik9pDrs6Fz9kHPgi5pq13luSXYPuUMatXYq8Msny?= =?us-ascii?Q?+dsca4rPDr69qSMoILatlGNTh7cClIAZNBQUfWaGngrzOYAPtUdzIkV/Bisc?= =?us-ascii?Q?FIYbY15+mfPyCb0VNHoKAdEAIselw5oMVLpvfNfMmPMaGX21vDujNBcAAqXy?= =?us-ascii?Q?a3vPrBu8k2H8ncE7WCZnwfIx5F3E0uY33UOcQfh/2MPDKteEwdexaIRbLQa4?= =?us-ascii?Q?FDw3yGTs5aX87c9kBcITKBk8lhzAMEpF/jcO9jxQJmUSc9dqJ1Z3ybA7wwG7?= =?us-ascii?Q?eSFAKVko0z1ZdGlLVOZTjSOcUBCULXBZDgh19P9Vz9YOYmsidQd8GKyeJ50W?= =?us-ascii?Q?QTyOGmD1ybX3MY9Fdhf+Hv6a4VeBo0DRWMhLrj6SL6K8avVUVU3xsbYBhCI2?= =?us-ascii?Q?WuHVanOaFIopcIWrrnqeXfMhCue0wNHGdekFtc+/FkWxSJqJPc/5FH4FY+sm?= =?us-ascii?Q?imgpdlzU3ilhY6rQVXGQ+0jCIHeuOqS3eJJ/9f6MexicR+h2WsCO/dOWJB94?= =?us-ascii?Q?iw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 52f8a434-f4e3-479e-e648-08dcb3134d78 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2024 16:51:06.7514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KeBkkuGF/MzKNr4kw1QuuzgVriRK/Fsfrdi2LRk8jVdXBRi2RYfOTXKKagig/610vo4SWif/0jlVXNRVOH9DRHCMsNy3m+CA/DkL28U7OFc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8448 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 02, 2024 at 09:45:03AM -0700, Stephen Hemminger wrote: > The input files don't need to be in a separate subdirectory. > > Signed-off-by: Stephen Hemminger Small suggestion - I'd move this up to be patch 3, rather than patch 4, which would save editing the list in the meson.build file to remove the "etc/" prefix Acked-by: Bruce Richardson > --- > app/test/test_cfgfiles/{etc => }/empty.ini | 0 > .../test_cfgfiles/{etc => }/empty_key_value.ini | 0 > .../test_cfgfiles/{etc => }/invalid_section.ini | 0 > .../test_cfgfiles/{etc => }/line_too_long.ini | 0 > app/test/test_cfgfiles/meson.build | 16 ++++++++-------- > .../test_cfgfiles/{etc => }/missing_section.ini | 0 > .../test_cfgfiles/{etc => }/realloc_sections.ini | 0 > app/test/test_cfgfiles/{etc => }/sample1.ini | 0 > app/test/test_cfgfiles/{etc => }/sample2.ini | 0 > 9 files changed, 8 insertions(+), 8 deletions(-) > rename app/test/test_cfgfiles/{etc => }/empty.ini (100%) > rename app/test/test_cfgfiles/{etc => }/empty_key_value.ini (100%) > rename app/test/test_cfgfiles/{etc => }/invalid_section.ini (100%) > rename app/test/test_cfgfiles/{etc => }/line_too_long.ini (100%) > rename app/test/test_cfgfiles/{etc => }/missing_section.ini (100%) > rename app/test/test_cfgfiles/{etc => }/realloc_sections.ini (100%) > rename app/test/test_cfgfiles/{etc => }/sample1.ini (100%) > rename app/test/test_cfgfiles/{etc => }/sample2.ini (100%) > > diff --git a/app/test/test_cfgfiles/etc/empty.ini b/app/test/test_cfgfiles/empty.ini > similarity index 100% > rename from app/test/test_cfgfiles/etc/empty.ini > rename to app/test/test_cfgfiles/empty.ini > diff --git a/app/test/test_cfgfiles/etc/empty_key_value.ini b/app/test/test_cfgfiles/empty_key_value.ini > similarity index 100% > rename from app/test/test_cfgfiles/etc/empty_key_value.ini > rename to app/test/test_cfgfiles/empty_key_value.ini > diff --git a/app/test/test_cfgfiles/etc/invalid_section.ini b/app/test/test_cfgfiles/invalid_section.ini > similarity index 100% > rename from app/test/test_cfgfiles/etc/invalid_section.ini > rename to app/test/test_cfgfiles/invalid_section.ini > diff --git a/app/test/test_cfgfiles/etc/line_too_long.ini b/app/test/test_cfgfiles/line_too_long.ini > similarity index 100% > rename from app/test/test_cfgfiles/etc/line_too_long.ini > rename to app/test/test_cfgfiles/line_too_long.ini > diff --git a/app/test/test_cfgfiles/meson.build b/app/test/test_cfgfiles/meson.build > index 068b61044a..348c78c7d9 100644 > --- a/app/test/test_cfgfiles/meson.build > +++ b/app/test/test_cfgfiles/meson.build > @@ -1,14 +1,14 @@ > # SPDX-License-Identifier: BSD-3-Clause > > test_cfgfiles = files( > - 'etc/empty.ini', > - 'etc/empty_key_value.ini', > - 'etc/invalid_section.ini', > - 'etc/line_too_long.ini', > - 'etc/missing_section.ini', > - 'etc/realloc_sections.ini', > - 'etc/sample1.ini', > - 'etc/sample2.ini', > + 'empty.ini', > + 'empty_key_value.ini', > + 'invalid_section.ini', > + 'line_too_long.ini', > + 'missing_section.ini', > + 'realloc_sections.ini', > + 'sample1.ini', > + 'sample2.ini', > ) > > # generate the header file used in cfgfile test > diff --git a/app/test/test_cfgfiles/etc/missing_section.ini b/app/test/test_cfgfiles/missing_section.ini > similarity index 100% > rename from app/test/test_cfgfiles/etc/missing_section.ini > rename to app/test/test_cfgfiles/missing_section.ini > diff --git a/app/test/test_cfgfiles/etc/realloc_sections.ini b/app/test/test_cfgfiles/realloc_sections.ini > similarity index 100% > rename from app/test/test_cfgfiles/etc/realloc_sections.ini > rename to app/test/test_cfgfiles/realloc_sections.ini > diff --git a/app/test/test_cfgfiles/etc/sample1.ini b/app/test/test_cfgfiles/sample1.ini > similarity index 100% > rename from app/test/test_cfgfiles/etc/sample1.ini > rename to app/test/test_cfgfiles/sample1.ini > diff --git a/app/test/test_cfgfiles/etc/sample2.ini b/app/test/test_cfgfiles/sample2.ini > similarity index 100% > rename from app/test/test_cfgfiles/etc/sample2.ini > rename to app/test/test_cfgfiles/sample2.ini > -- > 2.43.0 >