From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6384545700; Wed, 31 Jul 2024 12:30:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13CE740696; Wed, 31 Jul 2024 12:30:54 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id BB8EC40668 for ; Wed, 31 Jul 2024 12:28:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722421722; x=1753957722; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=RBZTuHKPNP5fo10SE/tH5XVVr1u/x0bHd16ej93hf6w=; b=cr8v8wDd0k6xV9mUIG+JkMBzMznE+POlEXfO17WqVSvOENgmxMAMq+oI o8tVgkX9D7DUxPjDmbuyU1TOO/41ArqnmCtQvheVy2WOBKMV7ZWxHhQMv aim/W6wyDzQaYNsIAt/b/z+McndfWN9exmV+uM2EfQJmfHunF56UfqESi HRQ+C2vcnWPuQhjILtSEeaAFjQ2wyJmTeNoJ69Qb5CvCa6RRT2oDoiDau nTYbagsuSdKVk7XI2ajb8Vgq17JMvMC2gZBCmd2Un5Lm7RoEzxfYnWFCL 2tZgChRlcwrEsMS8QthiiAcQ8X4uRZdxp97wlnJZexrZV+KaXRpXOsdrB w==; X-CSE-ConnectionGUID: OzxWz7UqRj2f7xwXGmSPtw== X-CSE-MsgGUID: dSpFU/TjRemEWOLFiwsFiw== X-IronPort-AV: E=McAfee;i="6700,10204,11149"; a="20413887" X-IronPort-AV: E=Sophos;i="6.09,251,1716274800"; d="scan'208";a="20413887" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2024 03:28:06 -0700 X-CSE-ConnectionGUID: XDlPb2cFQKCt3U4gdT6EJg== X-CSE-MsgGUID: zvpCO/hgTVKuPi+YS6N7BA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,251,1716274800"; d="scan'208";a="54531209" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Jul 2024 03:28:06 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 31 Jul 2024 03:28:05 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 31 Jul 2024 03:28:04 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 31 Jul 2024 03:28:04 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 31 Jul 2024 03:28:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eEG8rewHd+JjAYt4yqQUp3QdjNVklhLWVtQ3GjbeGEXL0SOyXTCXFLA0Tvk+D379lXDSIHLfgrf8CAmmZPhfxN5ES6CuYFmqnLSskrOKQUB82kRyiDvv5/50xuO0NY/2AwfquM0ruc5a9LkFMm0QyPb/Z86uJZtqzCXwm4C4o9/WCKGeGmUjIWDYyMuh5n6fMUHXJBU77Ha0C5VOmGXP2X/b6ojVELCUXw8fSXys8wWBbX2ZX9mDSKJA7/UrWX6OVFk78wW6zi1tMdluKw55UzlVC3kern58WHep5vIBQBnq0UpSdDzmZaxmOKOiN8DUq4TFUwqvLtdUzuzT4Cfy4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oI/d/0stuTiv7OTqJeNGj/eJYAWpfpyv4rHhywKcsig=; b=Nv5hPnCtKe96DULp6VkMAjbzTz2DE4QEBqvLu4UNzjYONBSUmQzQRQFAP+8H2OD+Wv25bfwlzFB3vexLZLGMR14cqYVZmZMr687yA5BJOJuP57q0I9meopq2qHuoIpHtDMd4zHKKFsW0txhR/x7gon3awVyy2iPzyh8HgQzuKN/0bNeO7V+Ki+ZrH8TEjA/WOpk8Gmo7oG2pVwEc+4+CVgxkhzBB2UG1FwFty36bKr7dqA6u3jmAKVGkpn20Noeyyey9t0XjO5K3rJ/GzKGkfw3rKyYmiKdVyd85OeJLhAiSycZPNy+yKW5J7YCcS+QMJJulBEEa88W163wf94y/vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV8PR11MB8560.namprd11.prod.outlook.com (2603:10b6:408:1e7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.32; Wed, 31 Jul 2024 10:28:02 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7807.026; Wed, 31 Jul 2024 10:28:02 +0000 Date: Wed, 31 Jul 2024 11:27:57 +0100 From: Bruce Richardson To: Ferruh Yigit CC: , Subject: Re: [PATCH] build: output a dependency log in build directory Message-ID: References: <20240730145508.551075-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR06CA0039.eurprd06.prod.outlook.com (2603:10a6:10:120::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV8PR11MB8560:EE_ X-MS-Office365-Filtering-Correlation-Id: ca3900d2-21fc-4a3c-cc56-08dcb14b74d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/TGtKCTeT0h0uc0ndEzMz/94OiSxtG7LrNVtooEbID2vT19/+pO5ysZGXL7Z?= =?us-ascii?Q?PxWKJUaioImK2JzXgtN2nZb197fStD6ZKzOhds6I49SubJxzVHAaRf2P/JbT?= =?us-ascii?Q?zLh05wItek0G6gtrDEOJjx1rJ4UolYseCWPFyZ7fS7ANKpLHvi69KOkjTIIl?= =?us-ascii?Q?5sBxiVglGqKJgCq3YjiyK14lPIGCLz62IOeYPwUy+FThKRgIXRjAiB9lUtoE?= =?us-ascii?Q?84sprZb3CSPdRyBDQ8Y1eriz6hoDMBDFBc9kTY+qBJ4TL4h2d+kOawpd0EbL?= =?us-ascii?Q?AeFfv8r0A13R1pKU1fhCNq1mnNBYzG7vOZqIg1PeFUkAfAvChoPPIjcNHKrJ?= =?us-ascii?Q?vc9cvWoMOZvPvixEsIIzrg3NvIxoWLouPeetM0KtaU05mmrnMVG8FgG+NOUn?= =?us-ascii?Q?1KDHYHCHmxQy7unqpLJmjJDJBJBc50Z3AnDx1ZxcuYAr0VflIB/mBIdeKK0Q?= =?us-ascii?Q?8zvIF0xs3CIJfLiWSo7thKeNPJZMSUDAX190BjF0EXAUGuAnB7BIm1m6G7lc?= =?us-ascii?Q?v7/uafZWOGM3QJEWAzTcqjSOMA3KfKVL1T8JrRkT6R/gy1ydEo3LwUzByMP1?= =?us-ascii?Q?i6x+KbX7dQ5k0XWcALhIMXGjfpXiFC6JwC90Ed086c2msL7CD48c2q6t+947?= =?us-ascii?Q?yC+5ShEAGmE6/0awZFpJnh28yZy4hQSAdqj/9ao6B4FNXo8wCEL1EX+DExCN?= =?us-ascii?Q?BKltcQiV5r0s4TQuNf/voWz1UX3HGSQVSD/96+oM0VEO4BcJ26c4vSimFXEh?= =?us-ascii?Q?ooWYa+7V/u6zNCFuUAPdUmqsYSOfzDOu86VkogjqNUGeWIu3a+FVKYsE0Wyt?= =?us-ascii?Q?Zjsr7cK5tT5ll0fnCi8+esK4Kc40pQpvenDdeJznfx/IVuWVV5evmGX7DW/R?= =?us-ascii?Q?gciKHeQLAN4X3sfZ9NUdfKkQVxwbKvu6MW9rebFHB7G6/muEciQeWTa2P5IQ?= =?us-ascii?Q?u0kK7szdvDXZPSu3YfxJ3EEahK+6mNr8kvQOuLU4XIhZMggUU9xGi2K0pDN/?= =?us-ascii?Q?dW8I4x3Px7IRmBF+PQ4nW2fc8rqulz2EYV2ghIGwWt+7dWIBwrb1o6mJ0Lbk?= =?us-ascii?Q?RpeZ60LuGqM32/lW2HeyBeMJfPfiUnh3S7cvoufq+ZJdFiF766+zKDxYow/y?= =?us-ascii?Q?rG+5S2PQWGYzOAWWFRdBcbsHPaxEGhARU7/9y51u9K1oKat5exPiGGZyqbSM?= =?us-ascii?Q?Q80KMtYrZpmkkaOLOMRPEb41Xj1/EcHqUhQGwFGOv7zs4sgC0gWKINsYSIki?= =?us-ascii?Q?JKTwzBsefCKymFGp5Pu6rhPOjqx9ZnrvDhMzhZ2sDBaLxrITFPuLXm8PGGZI?= =?us-ascii?Q?wTI+f6LHlYA/+R9ks5IKRiDd/HPz3GADA1LNRuFPLyI/aw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j7Sbm9GeMMg02ewm8GUTYQttEHRbOX1WPq0RTUkHHU7XbM04XbpM5oYbbaPb?= =?us-ascii?Q?fCTDX8veUBelsC59VCKVgeOjHreA9mY3mnKQ30Rira559LE16oGY6BB0ZzOj?= =?us-ascii?Q?Gs3KwG5oZjHuAdtDoSmkn9ZUYHJVN9mjZfmYySrRQxmKdxMg8bBzXr6QCupP?= =?us-ascii?Q?0dlRZkmpiyuinD4Jax9gBBtx7b2YbBMLzlB60q4Mp4R7KvFs89SRgvhcXWmK?= =?us-ascii?Q?Q+7T1nYL2K7Uy5ACVkZU+cerSLpwTfHmKrci5jx5BF43aqPbo2YWVlKjHbab?= =?us-ascii?Q?yqNM2CIThcRiMulrWCVGDaPNmryqoVckeoR0Jm6MDA6RhTcOOi+ofnXsXS7b?= =?us-ascii?Q?Bpds8aqilR+FfaBGpgok4Mu5cqEv7XjgScgBSyDxSIkGO3S+ORX9pD9Htahl?= =?us-ascii?Q?EikJTxg/CRcKGXF/Gm9la4SJMCIdWe/lDp5/pEVcWeYwZDtFDqP8rlprKCqL?= =?us-ascii?Q?nH8HWQJTT5La+czgC2m4HTrL9ElM+nNtytTuozExpSUulJnnm8XbmIXd3dNG?= =?us-ascii?Q?KdsPJb18qTpqgPVmOzYZ+ZJXKs3CtycANc9PWYM0x3zq2QO2kdevXnqQ1tTC?= =?us-ascii?Q?19ZwMG3IocG8/53/VcxBkFrj5u+Uvx2qCU5SvdI4lp3q+joE+QoDX4FpAGU+?= =?us-ascii?Q?nFw7fZSjHNYmhx3/OrvG+BZB/i7fNz0H4Jk7s2+3dBrloIYDkMbEPygEUyr5?= =?us-ascii?Q?BTXK6BBLmK9yO71yNXxUL97KB+Uolzd0mzt1qwuuPeMY3ljeGRgM2KN6SDux?= =?us-ascii?Q?FLQY7Mvmg90hwTEE8JxuQIda75HiQVaxVrG+u2hu44HNX9s9Je/dzFof7u8w?= =?us-ascii?Q?t7KGs1c4IDyJNCIlNpBGuDUeZvltmniF1nQzA1VyHh370dhvnOuUoL5Qivnm?= =?us-ascii?Q?D4losm6dVEujLFDd5i8Pumrhm92HvWhlaf/8vD75UYqvjISvDzEf4aPI4hAs?= =?us-ascii?Q?wxJgcBbbGLpypmqvQ1a7A6i7tlRBhHYbJ7ivBRAfyeezy8c714MlQw52Yfn5?= =?us-ascii?Q?WSVZMakrRPmJaIYMQb5+DhV8W+qMKHpWoF2MCUBhkuG/asEi+ab1VrHVKGat?= =?us-ascii?Q?f1Nnkio4+/XahneL2Uc3qEL72TdWtry9lquokGjYzysbfl4HZjiTmU+f0+xj?= =?us-ascii?Q?l+48MgIRZdw9YWeCM+Rjc50GhqeQxVm0E6yeCeJULIqxsXPVvvStYbGclPoo?= =?us-ascii?Q?h4pxfe57lmm5iy9CB3HlRbsBfL7SE/G4Cb2IrExLMrxA/2f0pynzy1kfQbCO?= =?us-ascii?Q?XaZl9TfencaOT0ObKQB8ZHm6x5+m0tOmfxM8qlK1px5Nuf0/6Q58zzvfxRmB?= =?us-ascii?Q?LILOD8UKk4dixPzbHRkL06V/4uphdzXFmBk2UNSNwRuuhKykVtwYf55cdCfK?= =?us-ascii?Q?rfVulDONwiPAidQYrAZXha3dzXu7+f/I1ci+IRXIsiCk9sfFQ04/ddbYzmDL?= =?us-ascii?Q?sA3eVhylUcZZQQ2P5aUrIEzdRFcd6Y3BIhDA8fYFDSG53/SyozdZFsrq8Hw0?= =?us-ascii?Q?f0V+Mg86d12wMMTU8NQLWzr2/JdgTJwS+w2Q7dNAnTjDYo9ZcgUwAKwDfpYy?= =?us-ascii?Q?G+lbAOoqfwyH02y1BFZFyb7DPmAcxXcgl3N9zrhWqmJrYgRWdvX8c/+FvTaQ?= =?us-ascii?Q?Ow=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ca3900d2-21fc-4a3c-cc56-08dcb14b74d8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2024 10:28:02.2703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TBhP9AuDKztZQqYzLxTbXj1UjPY27K5AtbhIhbCqJQcssX+uxKDPQaFueZtJbzW42Y8h2QfnF6uhPZ6kl5lVdo0hJAqAqseLNZ/Gr4huKQ4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8560 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jul 31, 2024 at 11:17:54AM +0100, Ferruh Yigit wrote: > On 7/30/2024 3:55 PM, Bruce Richardson wrote: > > As meson processes our DPDK source tree it manages dependencies > > specified by each individual driver. To enable future analysis of the > > dependency links between components, log the dependencies of each DPDK > > component as it gets processed. This could potentially allow other tools > > to automatically enable or disable components based on the desired end > > components to be built, e.g. if the user requests net/ice, ensure that > > common/iavf is also enabled in the drivers. > > > > The output file produced is in "dot" or "graphviz" format, which allows > > producing a graphical representation of the DPDK dependency tree if so > > desired. For example: "dot -Tpng -O build/deps.dot" to produce the > > image file "build/deps.dot.png". > > > > Signed-off-by: Bruce Richardson > > > > I tested it quickly, good to have this dependency list, at least it > makes some duplicated dependencies obvious from .dot file. > > But generated dependency graph is too large to be useful, does it make > sense to have a new meson option that control this dependency generation: > -Dgenerate_deps=apps > -Dgenerate_deps=libs > -Dgenerate_deps=drivers > -Dgenerate_deps=all > I had indeed noticed that. Right now I'm focused on cutting down our dependency lists to make things more manageable - I have a script to automate the identification of excess dependencies and I already have a patch for cleaning up the libraries to a minimal dependency set. I also think having separate drivers and libraries charts could be useful I wouldn't want to add a build option for it though - it's not something that should be necessary. Instead, I will look at other options, perhaps even doing multiple dependency files - they don't seem to slow meson down, so why not always do them all. > Not sure about what should be the default option, > as this is not always required/used, disabling this option by default > saves unnecessary work, > but disabling it by default may cause not noticing when it is broken, > perhaps this can be addressed by adding this option to > 'devtools/test-meson-builds.sh'. > > btw, it generates following warning: Oops - will look to fix in V2. /Bruce