From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 972854575D; Wed, 7 Aug 2024 15:43:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C4954028C; Wed, 7 Aug 2024 15:43:58 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id C4C124027B; Wed, 7 Aug 2024 15:43:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723038237; x=1754574237; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=wKNDQgilsXjrplkrAcYLS0GzTaXgO0395mKqSBc4msw=; b=LhWBHpXSA17Y/X/O7J/WrkL5xrWFDNdujB8Pjfaf5blqG4RcYCenAQgs r037VVxqrfd8q4z/qEnRY2YvBx+NR73pO3z6PyH9huMxirQrDrSOYg2mB 1xi22UcD+to04d1dIBCcPr3BPPoZio+9Mw5D4+iqhYc+4TlBPKk+sL1rA M+qqbIlNN1+7WCOSDTl7ddbRNw4Oz82TINOeumYWRPk07GRZ5ewNx36x3 GPL3uCNtdYWGmkeHz5sGMSMkXacRTaq2c8lV4ulB37CQaOWXue1emIfiK spfyRObvMoSVCRESKJSVPCtkx+HpKMFqVJNFdfRA6RVeOLKmPzqD7LX1U g==; X-CSE-ConnectionGUID: 6ZJ6MoezQgqi6tQ9FmbDKg== X-CSE-MsgGUID: c6FE72nRROitvu7k2EXXmg== X-IronPort-AV: E=McAfee;i="6700,10204,11157"; a="31680247" X-IronPort-AV: E=Sophos;i="6.09,270,1716274800"; d="scan'208";a="31680247" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2024 06:43:55 -0700 X-CSE-ConnectionGUID: Zp57Bsm8S2+MUzaObfCvXg== X-CSE-MsgGUID: fMwdCy0aQhiRFN+eSoZ+sA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,270,1716274800"; d="scan'208";a="87793174" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Aug 2024 06:43:55 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 7 Aug 2024 06:43:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 7 Aug 2024 06:43:54 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 7 Aug 2024 06:43:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c/Z7LuhFS5/+uok0UfW6bLf7j8db/pEjm2cGRr7K+yAPPyfv869me5qTIHRfNkredH8+QznH4SCHG77h+fohJog7zBqQSnjAzthrTuTex/KMp9vTohUWb6tbCI3SaVPAQGbkiEfxbPOjSte9ypAiOcPtGzGJGTf9CQqEC2wFgdTxbR9iJyT/GVwF/zYOPyiKAN+kYq2mWSn9rceSRQTtchNNwbuF+hg3bbT9+rhlGeF6xkV3fiLlcTm+5qoqdUYu1/8DGjWqZAA1G3bBPUp25eUHXHzwQpIxpPf92697lyfS7vXT7SWjVzGgNbLaNCNNt5eqGl6D+st8t+ejZ5gEQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ln/UIHt+6uALXMlS7yo01a3hGqy/lJqnkN2hDFabI38=; b=JdiREl6PKfvjBAiESY7H0eTX3S/aWmLT3wmUGy0NCuGbHur3FPcNsPpqHLNymQLSVKzIDTlT+mf8kMUGvs0deNB7zTsnmFqqT9DV5UA1vPxuORRRl0SASRukXZA7Yjy4Z6O7gAGyYAL4jSTlLaDzBoTQDn3oDoqo21IY9D5gPdTt2Gi/zlbNObtnbt9CaCVzIY3ZpswDeSULya9KVQQOrvDXYinPmqBK9Umpxy+IjjxVPnuAPwGfDJkl20mvGIEDYERIgfHbJNRe+joQaDQsTUE2oJDYtKSRbia0/Zw/m+ssQBMa6PmpwwG3ZY88VoIS5CXATRfJnk1us906v3iWjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CYYPR11MB8387.namprd11.prod.outlook.com (2603:10b6:930:c8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.26; Wed, 7 Aug 2024 13:43:52 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7828.023; Wed, 7 Aug 2024 13:43:52 +0000 Date: Wed, 7 Aug 2024 14:43:46 +0100 From: Bruce Richardson To: Robin Jarry CC: , Subject: Re: [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject Message-ID: References: <20240801100153.41779-2-rjarry@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240801100153.41779-2-rjarry@redhat.com> X-ClientProxiedBy: DB6PR0301CA0070.eurprd03.prod.outlook.com (2603:10a6:6:30::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CYYPR11MB8387:EE_ X-MS-Office365-Filtering-Correlation-Id: e2ce3957-352c-4573-0078-08dcb6e6f931 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PEqnLN3UuRLwwLwwXwgxt+w99RTbKA1m8GWLoEetAX9aUhn9zgS1x95ZCGr9?= =?us-ascii?Q?zFhz3trC2Th+amD+iayqTBSHRoPaHk0aUWj8l57ceNOVdASfo58S46joORZj?= =?us-ascii?Q?Jk0InUlgwhmehS6HzNELGis5I07yTP9c/8VgLWwM3pur2dIRg80NoX57JkTy?= =?us-ascii?Q?U9DnPyEXPkq5AJ27dnRBshpxt2CmhUPRdcxJG0GnjBJaBtLHyEvj54X5q4ro?= =?us-ascii?Q?OrsPYudm7aSQnNsncKNvNbMbFK/Kbnaak64BYgvy+P5ukbX3aLgZjSeLIsaq?= =?us-ascii?Q?v5MpKuLgqxlXw7HYi4JktZAJC+HPQoORUqXUkml02j2OeWWTQAYzmyhSqAl/?= =?us-ascii?Q?WPWwxXwn2FhT7IzRd9CJWrWYziVVr351wFnpS6qr4FYmiPORS1W/miDctPbm?= =?us-ascii?Q?XCI9DJYcXtuNqkZFgNFyoefP4HjFZCPHK4KlcQ5sDQZTTSyRQZwV4vp3rUT7?= =?us-ascii?Q?Z/mKke91IpjiIwfsj2BDKZZVNHuG6Oxgea2Np3bRGTPexC/Bl26w5mcJrLXl?= =?us-ascii?Q?82Og6KlAb+Shak6H2/mPLHfCT7FALpm2K8H1XKQnro3/5raQFC1S/EC4HWi6?= =?us-ascii?Q?Uq//9pbjEAA7I9lnJkc7r1IkNGSOHuzE53nT0evKw3RGSl/pNTIoCykL9d5r?= =?us-ascii?Q?Ywp5BPjkX07JXTIWBxQCxmiCR4AT4TpOtn1MI/Rnr232pHNTqR1UvFdfOq18?= =?us-ascii?Q?H/3s8vRgPHOx1Bz/zXS8aMPorFYy2gNFw728bcr5UIjE4prOMS73tUIusVFD?= =?us-ascii?Q?cjGFRyFg/C0Xbjxj3xpXvbEjQ+VhdR2xzTggvs/abPuaF/656icO26gfEd8+?= =?us-ascii?Q?gidVV57AfuolsQhJ6ZPSP4uTefgBGjFrP8AsKzv2I39EVJlhWfEYS1l8ULwc?= =?us-ascii?Q?X9gj8fQL1bd4w/xfh7FZb2FlRB/FJPgsXxhSzTPlTEiHxMMe9Fm/joGCTmNZ?= =?us-ascii?Q?XL395Hv29kgXF46n5oa0PPvX4McsRUkYOIJMIGcdNyhBz7Fiu1BLxxA1yGM8?= =?us-ascii?Q?SHITxw/JrNOuMCyRoUKNR+7IImCdO900gco7U5c/quuk5HqsNn3Bj8CvK3s8?= =?us-ascii?Q?dzdavnkir7LEJfrQM28DnZ9odocz3MXrJqsbMHJRMOzcZmBrq1IOqFsGGWwN?= =?us-ascii?Q?tnnA8HiHZFz66ou9/7lawAaPDM2rvO9x7tvA9AyiQ88ZlevYGauXTrHAJ2XA?= =?us-ascii?Q?CEFnnFlJ7lfEaLT1pk2ywThf0wgSvmPMXbxTb+bNLrDWzHIJe6kB7YZ/AJ6P?= =?us-ascii?Q?1xKez/ZqEcHMII9RCPEuQ+UiXal5BWZH7Q2IFlW5D7LA+oup79LDWcUHAugb?= =?us-ascii?Q?oa9MApuLr5XvoJQVFv83p7HmFn7EzBSrMKvfk8t9IpHxUA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mu8F44yQNtG26BNQNYyTwdJpb7tGFlBtOMRoEKlIKzJeyE2nBKWoNc+eaWE2?= =?us-ascii?Q?p0wqhPfjlZHXdXsEyuQX9ML/bmOqFmCX61m5DcxjH8Dbck9rEgDNSFbfLO1n?= =?us-ascii?Q?wN3e1zZegCuliGfQEz2lLUnwckyWjg4Tp5/hMRhcsYOETimD27QE2Q3FSbgL?= =?us-ascii?Q?CG6O+jSF7LzagIAX+npRANwHN7AX5pYaw/9SFihfb2f/vs2vGoQC1tWcalSM?= =?us-ascii?Q?fAWlcYKF70JGbkyI7zn8Y17hKsihkSgPbrRmboXByJt9CUE3Jg2ZDdB5X35R?= =?us-ascii?Q?M3gkHPQ5rHz8qo2g3y2kzVedKnOq5YDitaqtCH0bVTuprOZzqYRaCddWYxKN?= =?us-ascii?Q?Hz100+ivoj1AGoy55m4yKVRM8/hrl1r3AjNITTx/XPxTMATMbBvKfzXLCAOQ?= =?us-ascii?Q?HncAytvEKoPxxX516kESZ8Ia2SwWdohcVxQE+FGgdv+HDCptuk9jh4wWLIgP?= =?us-ascii?Q?JmUbImUOcgiKSytEsnAWB0TkolucFlWQVKUrFZ+n8f4AVAkVptkzRBrefCqr?= =?us-ascii?Q?q/aKaZunWQzZvT5+jg4jBPdGyQiM05HMxgh3RHQ/BJqVd5L3hNcpfrX04QoJ?= =?us-ascii?Q?ofS2EmLqBjib/Lk2Ugk2jxtdGwxP+Z3XhTqrNsiXVIJEk9tPHti8PXfJ3nKR?= =?us-ascii?Q?vNea0jQsW0Td/yygtG9VaH3qznHCsJ4+HANdk3v5XiHDJfEdTY3VLjqcHrPJ?= =?us-ascii?Q?WK6A4SOr+azx4iIb+Wo5U2R4zdnlGzSaFmeKjKC8g+xJ/vJpzkhg7VHvmyER?= =?us-ascii?Q?B7FKFCE6jKyhIwohT5XVt61+5lIrRusrPxJoxWjqVK7HW4T+zvGMzcyhi6ax?= =?us-ascii?Q?7unSdbpN4Xeovq/lYH/NrGrdoHj/SycK2kh+vFENRqTT0XIwpPAH0W/Tfkqt?= =?us-ascii?Q?0ZcmMXcnfxofzaITW9embs8jan/Gh9SGCOoPP7tAk7YhUC+svJP3iSxc2Ouq?= =?us-ascii?Q?Zb77xVtZs6lksItFnqiuvg1mo9Qria0XKDpDHeEmLnPQaZ7I4bqdwurrD/ns?= =?us-ascii?Q?XKzilbXN1Kd8AyfsWOhmESJZhmz5Z0OgbltSWMKnz7WeDJ8eop+h9iCYrYRj?= =?us-ascii?Q?W+8A7jdd0plcFxDAtUId/DstU3CJfY1veIPemBdpCEmxvsKXQfKvo3tN9LOf?= =?us-ascii?Q?1FLIi6FUmwEtOrrOi2dTMnjoFc6WZUTiAd2k8W9CM0FQLXaut0EaY13s36ze?= =?us-ascii?Q?f9yKKR25LHufreUxAUVSuV8Ur2SDwVTfFOvgqFs7xe1DHbjWxZOgnLdpSAB1?= =?us-ascii?Q?mlLe9VIMJ2Clg4D0mq6fAqP1yz8+0P6o8y7858ByqhEdvhxDGs0hBexbxqhT?= =?us-ascii?Q?B6yexJYLbhACHTjH7oTATq8uGjyJWpgI+4YlS+fwZS8im1pe+JmCoOpmsh3W?= =?us-ascii?Q?V0FaHRhL0Hvs9xn7FB2/BukLa3v0aFTNwQmLArHtYv+6NjfXjdycFme7DBVU?= =?us-ascii?Q?aGVEpkMgal42LpOjSip4OWqWKAU8VEqA7QDt09NPruDqmzd3nO5JqGlziQHt?= =?us-ascii?Q?5kBQMH2SJNcjHXC/sWB5sjRLV50gGeZOHT5nGISGe5cmqbplB5rRsqMtRLvG?= =?us-ascii?Q?6Ww3bTES+lA1ynbZCk2mJbdmct7IHrlmaRLcSAeIsTGJUv9dzg349JYyf9zE?= =?us-ascii?Q?bg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e2ce3957-352c-4573-0078-08dcb6e6f931 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 13:43:52.0893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G7t/3JUXbYDo9yEhLEkkInIG3vK913i+XTEtNSxFDEbSsbYDPEcCCMbVemXpank0q9mcesSz6Me3vAVMNpE4RSp3nC0+rJzROR8N1DUmo/M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8387 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 01, 2024 at 12:01:54PM +0200, Robin Jarry wrote: > Fix the following error when using dpdk as a subproject: > > subprojects/dpdk/buildtools/subproject/meson.build:28:56: > ERROR: Unknown function "file". > > This was obviously never tested in its submitted form. > > Cc: stable@dpdk.org > Fixes: 7d8c608faa7f ("buildtools/cmdline: allow using script in subproject") > > Signed-off-by: Robin Jarry > --- Good catch, and easy fix, thanks. Interestingly, even without testing the build, vscode meson extension flags this issue in the "problems" tab of vscode: "Unknown function `file`" Acked-by: Bruce Richardson