From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85FA2457A1; Mon, 12 Aug 2024 16:18:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79517402BB; Mon, 12 Aug 2024 16:18:31 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 15BAF4014F for ; Mon, 12 Aug 2024 16:18:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723472310; x=1755008310; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=O+1dhY8el5Qpokqdb7I3PUrTFk7u2fW7860xOoDbJSI=; b=NDyYwUZOJ54zR78on9H8mQyVPfUFrU2l6s9XZskB/7g3MrGxkapcOgzl 3y7hleOEFpYTS8wTXiDeeUxfog7Rx3b6Vk7hbXQDqVgaR1JEY3xM3bzGv b2ADCa+qca+cfvPVneLlSQGeUnJLfK/dyBEIGkc9rqXU9UahGSNjAM0FB 0IA2pRRsshVDVLS/MWsb0esLtUp+KVdtxK4xHDMO5i/Elj40d2vtJdXrb ClypoJF5MEVOGKwHIs9Q2dVLgB+oOgSSF+0pzf2fqFCUxeHb4c96K4kNO 7JGZFiYWLaknRdrs90yxKc0u4BMEfYiai7/v9iNsthXTOEOZ/BnPQwcN4 g==; X-CSE-ConnectionGUID: +Ahy3UgnQO6iQU0a2Qu4XA== X-CSE-MsgGUID: Lu+oV+emTWKgxqT02EhJQA== X-IronPort-AV: E=McAfee;i="6700,10204,11162"; a="32263128" X-IronPort-AV: E=Sophos;i="6.09,283,1716274800"; d="scan'208";a="32263128" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2024 07:18:29 -0700 X-CSE-ConnectionGUID: /Ad6fGAXQm+sP374bTXZFw== X-CSE-MsgGUID: k4qmvJ4rRPKa6B7DNvTljg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,283,1716274800"; d="scan'208";a="58854241" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Aug 2024 07:18:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 12 Aug 2024 07:18:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 12 Aug 2024 07:18:28 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 12 Aug 2024 07:18:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N/WfCoT+N1VTRczWbSGPlbw6Kao3XfyfIqzdaQ8Uc1lFCmsaEe5nQ8pmOKCwCpWCN1ua2v+QeBvWEyqQw7IGy7h80h9Qmcqv6KAwtyP5cs9shHh1hXQy+BrELnObJdPFFCInV1bdoj4AwaEqUonVUTMscTLI8Yeb4c+s7dOqJ/8QYkH5zoxnhj5BDG3EINmevlct5+6CBzNpFh8uzRhQ+8K1YAKoxZQoVEdg9Va0I3abCo+7ukqjf7Z33gLDJ2FZwfS1+CiZ/6VWCxA92U8TLU5ihEnH3vJ3qUsDOVbz6ThSwlAcjd1KrfPzOi9MfuwqvgXjngZkqRedzB9B2QUriQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0t0ZOGiw/dAz/z6Kc0qiW3escbfPY/b3rjyp5rTC8yo=; b=ZCKEbz/wp4xFmJNyUZZVvBqMh3LH0Slj/jXR2Hpll+hvt3bjTHlu6vaWmKQ0lU0a0P2fKwgXNlHki/ds6Vj6OBnbaXqgwzw/GA6wZtwZ5ESPpuYbpA/+O8d1eZPpyio7io16KOxEGUitwChdcEa0QblKcztPC615tVci7P13aczKFQAGaW8Bxx3jBFBkOMS3ccNr19zroMLk4TsW9wWK1YiYB3zG/y5VwB1x4QM5Ph2zzDh4+r/0GW+ugxedXrDOCbwZnN2D5U7r9S2HSCo/JpB6ga98PA2MseeN/F5h4RdHF+JFx+A5nmnkwBrHudjOKfimhSXNKMj4mgHtjOb6jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA0PR11MB4541.namprd11.prod.outlook.com (2603:10b6:806:94::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.30; Mon, 12 Aug 2024 14:18:25 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7828.023; Mon, 12 Aug 2024 14:18:25 +0000 Date: Mon, 12 Aug 2024 15:18:20 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: , , Subject: Re: [RFC PATCH] config: make queues per port a meson config option Message-ID: References: <20240812132910.162252-1-bruce.richardson@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F61F@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F61F@smartserver.smartshare.dk> X-ClientProxiedBy: DU2P250CA0005.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::10) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA0PR11MB4541:EE_ X-MS-Office365-Filtering-Correlation-Id: 1190fc65-7c47-4429-e53f-08dcbad9a126 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?C7vFMr8q6pXtXpu6uGaiD0mA9VTTcDWZaKmfcFWfkdfG2RllmOrGZtaLl6?= =?iso-8859-1?Q?8oy12wYKrueaAIMvcNTyMQLGUeW13G08cGCzkWOF/hdm5E1SgoVNhYX1UI?= =?iso-8859-1?Q?gFOz8c3LQ/bPDIVS6Ce4EuDwRSfoOodjk/H8Y7NxGz+Gi3a2m8jFg8Jz9b?= =?iso-8859-1?Q?AMQTYsqE2T0x8feSKf6B2FXKqTHZiMHc0RzuX2luV4OY8kQGMd5Qa62uxm?= =?iso-8859-1?Q?Ll1hJWtUEh/N6Wi9jOvRnZmUVMOB+8CvdnS5j0kV9mPENZLSXraithVQNG?= =?iso-8859-1?Q?2/+AVAd4QQsrOZB/GAdrBGhPSe7N9RSFw9Q2M4Zyf54rlPOY6Bb/GdELy/?= =?iso-8859-1?Q?nWsn9TppLy1R0JjZJkJ7edc/MJvD5+fhdU5W0AAyO4LC+ozA2hLWW5MdJ7?= =?iso-8859-1?Q?2hA2PNrraZ0H1SZROjfHPV02ZCTpRzyH4hxp0SX4Rs73CvkYNvKqwyd42R?= =?iso-8859-1?Q?NyK/V4DaG84ut2XdPBZQhMIEji0QFl2BvYQFjsDEMEPX6cnrhLDFLfgAOS?= =?iso-8859-1?Q?1f8zoTmwVxoyH0GT9qs1moWOhLycPALP//BikkKVGLQgFBicjM0h3Vl/PP?= =?iso-8859-1?Q?L4T2mLg6PDUbrfrWnnmFe4h+2ZH/W1SUpyGsb+Whmtox0mxmbI8iASbddT?= =?iso-8859-1?Q?pe3iaAKrvmAZ1wg1MtV2fN0QDzlZuhfolqrBEymuvpSdhbPFDEvdCZ6Mxs?= =?iso-8859-1?Q?c3b9a9FEpoyvzkXnML0byrDm5THg+MX184RyOWPkMi/L6mP7gUPN+17skK?= =?iso-8859-1?Q?k3Fe98IjUfe7NzqsTv5nmxGG4WQheOkQiKeCre2LldfRoNRKqueJX2soTq?= =?iso-8859-1?Q?/2ZzpISftR9/kmEFgWHq4nBMTRbVMTSFGG0Uu/jCLwfd+aq4Pi/nIbrL31?= =?iso-8859-1?Q?Zc5zE4S712OmSGvoxUPd7hmUjmeI4OFXSYvZ/QoPJ+uQ18l0xHC+31Nq1i?= =?iso-8859-1?Q?hI9aF+ptrZVyJEx+1ORZ37vVPVIMYhicwp7RQfII4jl42T8x/AKpDsGJa8?= =?iso-8859-1?Q?UPTJNmucGxwIvdGaRyYzKLxxnoC39uc7ufom7nKI4qtGIcGhXPztoxrl7C?= =?iso-8859-1?Q?kTOpqOncGNEofNtO3mE0sfWuHxXnAtgwEvCEFXLDKSDMzokbt+5PQvquq2?= =?iso-8859-1?Q?J6LuiohsaHb05ejuwS1CdJtIf46rfk3DegIR39PiqEh/T1BJvxW5Wp6tWH?= =?iso-8859-1?Q?9M733xGOUMBZSER3OJuqI9yPKaZOWvB8pELXGe+ohhviWmohbOba/E66pY?= =?iso-8859-1?Q?PmngBVPYlCurGtc6F2jmg6AqXSc5RWtT69gku5Oy68YztlPY4nLm2q6DEh?= =?iso-8859-1?Q?5/WPkGsDMuMi7/6qecnIyzVQFfduuUrl5xpIyQnK4p+hEuq04m6GSNKmfo?= =?iso-8859-1?Q?kkmJz5cGGUc8D8UamsNib5BUMarE7/4A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Cf1T1gFGiJpcDToJnID6ilB0V5adPXu85kCeNesuNlYjABZjcdzDAgvXmT?= =?iso-8859-1?Q?pu7DZ4/5pYuBLG0lNPcJHSTUROkXzJDdMcEJQXMB7mUm7YK1KcpO0Pi3Cy?= =?iso-8859-1?Q?A83h7nTxppcR7KqE3KAE3ptT3dw/rwzqBN11ZAewlgy+Cv/qk/9OXwC6Ys?= =?iso-8859-1?Q?97XJCgkX34mIS+uSPDY0qSf0FloE9dQb68Db6UZNG7KjLb9wo7Nw4dqFS9?= =?iso-8859-1?Q?YO+RElyj5qGQAaMEmBykNGd2Zi0kwXLEoZHP6Yp7/s4vH1EClIIZDfJhZk?= =?iso-8859-1?Q?g2cmRGb5nQoye9xkrf6Irs3UQrN+imAEjyUM9zB+LRYjYd7aqMw6AM3eWX?= =?iso-8859-1?Q?WQ7/oWlqJt18goNWDTUu8bMEqzaJ2pVxbW2tB/Yz+ips3XRB0WspBJIee7?= =?iso-8859-1?Q?RsDJGSUzBW0mppLxGVPWTskALEaZTh94Ftap3R/bokswQ/YwPkHPjAn3/T?= =?iso-8859-1?Q?q106mIvtf7Fe15IFqveC+jYcBQcZQas1O3WncNJXrDbjExCw2FIow+YLxn?= =?iso-8859-1?Q?Oyxmj21QOuIel+8bO+61SZRASrs2tcc/KcVcudsf82pFrB2n72g3ZA8Alz?= =?iso-8859-1?Q?097g8Ftm4oXpDdXrynERi2x82FpopBCxE+YutWVHl61YSJykZIWYBYPBtR?= =?iso-8859-1?Q?4NjLRVNDlRdpyRQUOHUIgcdaJ04cG59W+nsmKCSPT12d7j0GXlHDIOQ9xD?= =?iso-8859-1?Q?YnwCT/3lAL8XT+TCvhEZ40xSIPvgMlfrt5hkSfCJ+n/Ors2RsKTdo+tqaB?= =?iso-8859-1?Q?VuDzqf+HShdenHqT5vraEGHAh6+XGt7EGxzf6d+/qqWoegCtKObhQ2g08Q?= =?iso-8859-1?Q?Bdm9aaIAuZAMK2fJcLKKDmn1YpnBoc8wzlaCZMbkYkmc2HJzSeciUhTW5j?= =?iso-8859-1?Q?vLzlzs2myug4Rd/Ur1oS5fphb9m9Gl+d3kgpxljV8AeMnJXO6fm1UgxW6D?= =?iso-8859-1?Q?Ller75UdmYGyrz9EI6u/TJVuquWgP2WvnAmBYSBmQnhmy56Xb5+bd7JHmH?= =?iso-8859-1?Q?N0Dm5hmtDllioLkk/arbxIrABgdDcURkBC+1vbWQu36cWmx3DvlGAAwMaU?= =?iso-8859-1?Q?vmIQsBNptPrdPUqGZ7MO+iF4yYAqohXW1i+lw3lHAXTCO7gYU2ozrLza0r?= =?iso-8859-1?Q?YX1Ai2I4ziYP8xVsUDqpv8lOuiboGgxAtcWC02GZdx+ik1NdvWfmtPMikH?= =?iso-8859-1?Q?UE9FFAL4SRfZQgxEVqHzKKxIZjt3e1yLBzK4ipdUu7D8d1IAteT/eQ1FFp?= =?iso-8859-1?Q?xMpFp99ujLLqPjdW0P/6GipCj/tP758Q/s/sKA8Jw4l8m+s0c5wEqJdokE?= =?iso-8859-1?Q?kizItzbB8Pw2feNphpkxhFo7UAjLtSMPuKU/0ZfZg5S0FXqtmkrOwEED0g?= =?iso-8859-1?Q?SkAZ59gRMpoUSXq9m92sFIAxeNjakn+HrfsvkSQWAG5PWUsMYWr5/6oMlC?= =?iso-8859-1?Q?DiVmPOzsKDGW97wvzDM6Cdp7XFV+a1ZMHoY7B6k6qPhX6lm4LMsN+jbxqJ?= =?iso-8859-1?Q?7wycVOUwhEHq4gzhg2QLFOtrN0o7d0zRtfHBGbuuiF/V8KxqLKy+4SjkBt?= =?iso-8859-1?Q?AnVeCfglwKgVNAEDnk0d0LEoADR6QkXaImhqpuMS8KRlhXTrn3f2cng9w2?= =?iso-8859-1?Q?Nrrc2Nh1W1uXx5c5V6aMEWKbrRc+R7STJSfkgyagHIFtN651a+/iqDZA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1190fc65-7c47-4429-e53f-08dcbad9a126 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 14:18:25.6480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K+gTMAJm2qKB8Suvm0mkiIJe+FncFkNIVJOmas4H/WHQe+L7Ksds9FfESZDW4JF5n5GY/IcpaB2o3mPGtnz4J8lmYDOj2uDa1BgatUFGgxo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4541 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 12, 2024 at 04:10:49PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > > > The default number of ethernet queues per port is currently set to > > 1k which is more than enough for most applications, but still is lower > > than the total number of queues which may be available on modern NICs. > > Rather than increasing the max queues further, which will increase > > the memory footprint (since the value is used in array dimensioning), > > we can instead make the value a meson tunable option - and reduce the > > default value to 256 in the process. > > Overall, I agree that this tunable is not very exotic, and can be exposed as suggested. > The reduction of the default value must be mentioned in the release notes. > Yes, good point. I'll add that in any next version. > > > # set other values pulled from the build options > > dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports')) > > +dpdk_conf.set('RTE_MAX_QUEUES_PER_PORT', > > get_option('max_queues_per_ethport')) > > Please rename RTE_MAX_QUEUES_PER_PORT to _PER_ETHPORT, so it resembles MAX_ETHPORTS. For API backwards compatibility, you can add: > #define RTE_MAX_QUEUES_PER_PORT RTE_MAX_QUEUES_PER_ETHPORT > Agree that would more consistent. That would probably best be a separate patch, since we'd want to convert all internal use over. Will make this a two-patch set in next version. > > I wonder if it would be possible to have separate max sizes for RX and TX queues? If it can save a non-negligible amount of memory, it might be useful for some applications. > That is an interesting idea. It would certainly allow saving memory for use-cases where you want a large number of rx queues only, or tx queues only. However, the defaults are still likely to remain the same. The main issue I would have with it, is that it would mean having two build time options rather than 1, and I'm a bit concerned at the number of options we seem to be accumulating in DPDK. Overall, I'm tending towards suggesting that we not do that split, but I'm open to being convinced on it. > > With suggested changes (splitting RX/TX maximums not required), > Acked-by: Morten Brørup >