From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B552457A1; Mon, 12 Aug 2024 17:09:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC521402BB; Mon, 12 Aug 2024 17:09:20 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id 0E3994014F for ; Mon, 12 Aug 2024 17:09:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723475360; x=1755011360; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Yw3JpwQW7iPCjjTrRWHwok6pUWBaU13x+RJ2+dfZ6aQ=; b=g1KO+X3HLgn96RBjvAAjrBGqVOzjj3kajp5cOZXZjZbyDZzNG2LulUL4 onyETXImZxXglOHm5elwDhbheDpR51zCllLXPIINTQcbwr8hsMhRcemGu HIjbYMB13C9HA+OOgwBazPza5Za4K6W0q0aMnIvYK6n37SDeTsuabtsnj YIWU1WOmsZM8lQx9e1hAcVtWqqRN5qzWK7zlzhg8ahEJTMmG0x2iaTLD3 0ElU9TEbF3ro6VohOht8flIE5BaBjn0dKoKUD+oO5tuweNDaeFVYk4YA9 UOeCuL6Ftyal8GYqVKMUb1MZWTw65y8ky45sJjBSoysDV6wEe2JfN3ZlM g==; X-CSE-ConnectionGUID: cPRj/mQjSIKEyRkgjS180Q== X-CSE-MsgGUID: NR4XA7G/Q/WieJkdWtYv6w== X-IronPort-AV: E=McAfee;i="6700,10204,11162"; a="21567092" X-IronPort-AV: E=Sophos;i="6.09,283,1716274800"; d="scan'208";a="21567092" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2024 08:09:18 -0700 X-CSE-ConnectionGUID: YqnzaeokSb2BjcbkTZaZcg== X-CSE-MsgGUID: DXajsVnKStujDWf5pCBzaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,283,1716274800"; d="scan'208";a="57941771" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Aug 2024 08:09:18 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 12 Aug 2024 08:09:17 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 12 Aug 2024 08:09:17 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 12 Aug 2024 08:09:17 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 12 Aug 2024 08:09:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ry16tKZo6n5yTxXnuwif1Zvs4lvmLZ0a7IrLKN5qcJhSqT7STDRaL7ewwDZRELz26yo15GdFDQy6PCWnNyfq0lw6x72V+9xesr07WIKSnBy6ySaT7xu818lbhsRDx6px98G9TfmEh+fqxlz7m+qRG5VRhst0hm5w5g+Ehi6RG4Inim3uVmxCIz4urempDthKov/BWOmuvkWS5ExIMlvIACUC6VG1gOBgEcpD5n/xx3jiZqEePdMQygBeZ1C13ftRDLyqS74L+G9Tt14WxkzCUpsULb/lpxKsWSXbuRnrzZxZNJ0682mo8zvgDbaIksnmaLU/IUgBO2GQY5YjUA/f2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KSKtAbtbEbuPMkmGpceztaByMB8C1cAU4RDsTKz3QSE=; b=ks8URZ7XGVVnCcCV2CPlRHYxAV+rQq2GG5AHBax8/5CByXvkaJ4cUD7V46Lml+9XctLCZo8l9sRiIgy45OCKsNtvOZt8nYJKF7T25DrfJp+cwvEwhl3F2ZBZlbvoaxsDeaMt6pepHueQ1JSZgwbvFtjoPITyQdLo04szHViByAALXW8mvS2d/GPBxPJuZcLARKiFyWFibcyMgyi72okXMY8ut6OB+J79oG6Nc1FFMiSp8nWknUEQbP6YldAblTLbmzTYqwCJQ8mJViOrGddKfnbhkAh9uGcJJ/pRk3U5lkfs6dbL5DkvSB4Dv5MknyzBSTE2IyFobMXaVXr8a4vk1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB8476.namprd11.prod.outlook.com (2603:10b6:806:3af::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.31; Mon, 12 Aug 2024 15:09:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7828.023; Mon, 12 Aug 2024 15:09:13 +0000 Date: Mon, 12 Aug 2024 16:09:08 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: , , Subject: Re: [RFC PATCH] config: make queues per port a meson config option Message-ID: References: <20240812132910.162252-1-bruce.richardson@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F61F@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F620@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F620@smartserver.smartshare.dk> X-ClientProxiedBy: DBBPR09CA0024.eurprd09.prod.outlook.com (2603:10a6:10:c0::36) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB8476:EE_ X-MS-Office365-Filtering-Correlation-Id: 934666cf-53e9-4796-55d2-08dcbae0b9c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?GQGpMYxZvUbE3UNxVa4IxK5T6bFkKsb9PJhdaKmtaBNX3rv0c9jvhH/raG?= =?iso-8859-1?Q?esVAqy1G67XoRcrX+AJZyqVrrrrK5D2NAK7uO5GE8qfhGUhXSVjrQX5Wmq?= =?iso-8859-1?Q?vaw07hpBMEq6eTIL7n5EE85OmMj8cHTstTCPfBuEGre9HXMyQg+GmihxSf?= =?iso-8859-1?Q?Y0OVfMLc+4sVYz3GDfl5tE2jJzXhPhaqxfLCMwW1WKMLAQ8+e4cEU8qQpY?= =?iso-8859-1?Q?FbOjHsXVFELEIjXHLbl0mr8qKjmj1zmPatIcCnnD00yShWXOWxGlkuoOie?= =?iso-8859-1?Q?jfHSXLpjt2zCkWYNcA8xUVB1qyDxpaLaOBKxXelmH8K3C5g1nTN4hAyx/6?= =?iso-8859-1?Q?3ke0OLPutnAYZ2kcqfH2PyBCr4FKuIN95CqUtJSfMh3f8xKW7CweXuYGmk?= =?iso-8859-1?Q?L8fyz/J9T8U2DraQ+fpH6JXnmXiimE6iuexBnp8bxBuze6FlK5RkxuYEcv?= =?iso-8859-1?Q?4isG9zCO35eJJHd80yOaE+rXqLHCOGsvHnyA3yfvok+LRpCTYSVkrmeGCI?= =?iso-8859-1?Q?vXpZOwoyHvUJXsrkfbIs3MiIt4tARS/CNwLm/LZ3s8H29wnLo9l2YqAW+c?= =?iso-8859-1?Q?X1kVseJxNBuUjkU53hMPfbBo9B1IQPFuwT+KDyuiy2uQwTdL4Z8l55iHKJ?= =?iso-8859-1?Q?ugtYp+CkMPlXcZTrL8WhXt1wgPE8bkFr++znzgXeb0uQKSn7FNqb+eCM7E?= =?iso-8859-1?Q?1nSNh4RzDI/s0ChMcCR5kV4V2sooHCitbLKVZ/9Ir4F3t7C97opnLuTr9k?= =?iso-8859-1?Q?Ebpd0E8BHJLwswe0aviITEY6G6ZQ8TIzYOvzMP10PeIdjGVwGRYpyoeczy?= =?iso-8859-1?Q?K4CVTCixp7pspMF0bGItKp4ncckWXbYffF2fOeTlh06vpTfAUfCM05Ht2t?= =?iso-8859-1?Q?mSjdK7dlOmnPLnoNn6V7orJpWwMNZ+FeQ/xA62JsD7XzKcmv2i2nygCFaG?= =?iso-8859-1?Q?Xxlw7sMTAkvpBbkSAKUu/d6e8Eei2+lpf62okeuNnLVYbaXi9tBqWAjxLy?= =?iso-8859-1?Q?3blI/L2MmV1JrqtUgJcOM8ikMHf7qDBD2UQisf/kokxS8Qrf3t7MMdwkwP?= =?iso-8859-1?Q?JfgHYur0JLaryM+gYzAgcC9A4qAs5iJwT5mzot0Lt5iwaY8XSBsCX+w5+5?= =?iso-8859-1?Q?rVzPwOtQ9JPFS/T81bmNm+GiyhxAuI6C8xg5lur4SzCqXOxzpmMXQf6rll?= =?iso-8859-1?Q?KA5wX6WMRaG5+hooKOfXLQDhvUp3ZCkJTnNNJ6uQiCAIfT4dJ1fMHKxdjt?= =?iso-8859-1?Q?P9qRAFzkbINS/8X3VI0PfyAeBdaX+lfmYSG2Am2rawsjtsKzEmC8IAcHx+?= =?iso-8859-1?Q?gFi0RpGDEfuDGTsXkq8uQJZz0xmIVG4i0nd82bfFQlG4qx/oeahxgvOS4e?= =?iso-8859-1?Q?Eop1kOQZKSRaB9I0ktjkwQdQWkRB77og=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?W88owMyZUJij1OM3RNszFiGEBbLM4e8AXNZIvm4yEmhNvHTNmpt1R8qhhD?= =?iso-8859-1?Q?pqat2Kpph5gdw1BjGp5AK9q7YCpa3TxNhJ8qHb9aHWqLrJhwl7HenWrLZt?= =?iso-8859-1?Q?GTmPvtqiQ/BBEhkQAp7p+FTYlWCTvKZm0FVnJEFbIx7WrkcKh3dhiU0zrw?= =?iso-8859-1?Q?+YhkxzMdWxw3DBSywK/aMn2R6RU/uPD+/O76J64uFO8kufmyvZ8k474cCX?= =?iso-8859-1?Q?QvWURO3bKUXSEbLl+3WS95EYvFNuBVi0ZHyC3+RtqBXd7nR+XVsYUYG/Vb?= =?iso-8859-1?Q?zIm//bivBHCRLKG2Y/7pFBB1JdsFrNSULO3ejmUm/0C5RDotg1fSZHsyKm?= =?iso-8859-1?Q?7sV0fC3c+NbwAg9s6ED83ooBHnbyk1TbE7rjkbSyCIa67gs1W8d7Lj6TZa?= =?iso-8859-1?Q?mw7QkH5B1IRTB0wu+qjyd9lc1X+2py6iFbjrZlqRJTdUOkoEfGLqDIUicw?= =?iso-8859-1?Q?VCXYiQftxQnvXefLkW3QY9KgkFzCH3ue+8GldEDQK1nCPgRWUiVoIon3Je?= =?iso-8859-1?Q?8G7RQmEl/N1zhr2C4SMu90t2QBP+dLTNhdPDVz1QdELrwDi6bYQMf1GPy3?= =?iso-8859-1?Q?PP5NQZbLaQCr0naybhTAyOFZsfLjF06U7+z8jVUnxEWgqjf+NVmC+3jjdX?= =?iso-8859-1?Q?u47+PsUV5R3nS43XqRHoB7T5TKtRBVzIauC3U+/Cy26baT7LvEy1cqFu5K?= =?iso-8859-1?Q?3DaceUvS+LSme6ds1qCnb0XJQTcdpkyeOGOszMvcO25Gp1XJGRIajsJxxa?= =?iso-8859-1?Q?JhjTcbGyMjTwDch9AfDlgKoi9bNJLK1eraiNODRZiGzksLXF+yg1X24QRC?= =?iso-8859-1?Q?zpJyMl0Ua30Bw3yBY8M6xRP7kvRnRXW++D9O+ap9gifZJcztSrE9xBsVzR?= =?iso-8859-1?Q?mV9EcXhH1/qhkgzJVH5wEzbXVg2MUNlTNlNKmmkRc1EZQtAqxEPZYsGQg1?= =?iso-8859-1?Q?hP00xjYv7ZjngxnqG1CJIiF4YPNXDtWtUp1BMA2vPyCfT2YElnTFQKNP/0?= =?iso-8859-1?Q?mzbiJIL7nMFywcRD9IAil/uoXeoQkzDJYCJXuj2IOsEZVal9vIQCkmqIDv?= =?iso-8859-1?Q?dKFPNQWeWfVZajNgJmkrUniT+wjCku9FcZDwR5YmYug9jo5bZLV1H3txIb?= =?iso-8859-1?Q?a+de3rT56pS/MI+C1jydGFpRe0EvqNXPO3UBMv+cGy9IsK5udryp82mCCV?= =?iso-8859-1?Q?YdjAN4Yz12bAY6TaPMcVVRgr5pkRR8CjMGS2KlTxc7g0P69TuUo2VFuxGN?= =?iso-8859-1?Q?FLDts5rssnvva9aifwb3jcIM+yLpyzkQRyrPEzVL78e6wPliju3eeQkrz+?= =?iso-8859-1?Q?qdL92XyQwPpwcUtRgjIM4Y9XJPbMNFDoH4kCarMoEv/gMd9RDNt5XQzeYn?= =?iso-8859-1?Q?0CT68NDa1vqu3uXvfOtYt6Bl3boi3Y7o7jVVa+R15qhLbH/9HyEjlNvxAt?= =?iso-8859-1?Q?AUnJJOc1k5jG9yxUn3siVZaXwao3SPCx1RMOsYdHArVTxrbfcvlm9eMc8N?= =?iso-8859-1?Q?xpRKT3nwxKJ40XO/1s+izVydCZNqw9W/+JCUCYjyeroJt3o/PoKJJi8mBx?= =?iso-8859-1?Q?ZJ6CDF7X41fahMs8FQZ3lqA2IJwY7s8a8LzmKSzU1gA4Ug+Zg7gtzuZUKw?= =?iso-8859-1?Q?F0jge3sDdfOfYJWfrHQWLE+uvloERWhzzr0GkWTGQrtv5qdjg6x5qm5Q?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 934666cf-53e9-4796-55d2-08dcbae0b9c7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 15:09:13.4432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aV21hzXj2DUyfShCzwlB8ZjST+TIaq1d2D+0wW1zhjVqyllnzOfv3WR5F0aNt+Qe3qIiLIrAjWp/5vzpZXLduCWIDFnfx32/Yub3/WMJo30= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8476 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 12, 2024 at 05:02:11PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > > > On Mon, Aug 12, 2024 at 04:10:49PM +0200, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > > > > > > > The default number of ethernet queues per port is currently set to > > > > 1k which is more than enough for most applications, but still is lower > > > > than the total number of queues which may be available on modern NICs. > > > > Rather than increasing the max queues further, which will increase > > > > the memory footprint (since the value is used in array dimensioning), > > > > we can instead make the value a meson tunable option - and reduce the > > > > default value to 256 in the process. > > > > > > Overall, I agree that this tunable is not very exotic, and can be exposed as > > suggested. > > > The reduction of the default value must be mentioned in the release notes. > > > > > > > Yes, good point. I'll add that in any next version. > > ACK. > > > > > > > > > > # set other values pulled from the build options > > > > dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports')) > > > > +dpdk_conf.set('RTE_MAX_QUEUES_PER_PORT', > > > > get_option('max_queues_per_ethport')) > > > > > > Please rename RTE_MAX_QUEUES_PER_PORT to _PER_ETHPORT, so it resembles > > MAX_ETHPORTS. For API backwards compatibility, you can add: > > > #define RTE_MAX_QUEUES_PER_PORT RTE_MAX_QUEUES_PER_ETHPORT > > > > > > > Agree that would more consistent. That would probably best be a separate > > patch, since we'd want to convert all internal use over. Will make this a > > two-patch set in next version. > > ACK. And agree about two-patch series. > > > > > > > > > I wonder if it would be possible to have separate max sizes for RX and TX > > queues? If it can save a non-negligible amount of memory, it might be useful > > for some applications. > > > > > > > That is an interesting idea. It would certainly allow saving memory for > > use-cases where you want a large number of rx queues only, or tx queues > > only. However, the defaults are still likely to remain the same. The main > > issue I would have with it, is that it would mean having two build time > > options rather than 1, and I'm a bit concerned at the number of options we > > seem to be accumulating in DPDK. > > > > Overall, I'm tending towards suggesting that we not do that split, but I'm > > open to being convinced on it. > > I would guess that many applications have an asymmetrical split of number of RX/TX queues. So I would argue that: > The reason to make this configurable in meson is to conserve memory, so why only go half the way if there is more memory to be conserved? > > The distros will use oversize maximums anyway, but custom built applications might benefit. > > Here's a weird thought: > Perhaps RX and TX maximums can be controlled individually by changing rte_config.h, and they can be overridden via one meson configuration parameter to set both (to the same value). > > > > > > > > > With suggested changes (splitting RX/TX maximums not required), > > > Acked-by: Morten Brørup > > > > > My ACK remains; splitting RX/TX maximums is not Must Have, it is Nice To Have. > Let me see how much in involved in trying to split...