From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E408D457BB; Wed, 14 Aug 2024 09:51:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73120410D5; Wed, 14 Aug 2024 09:51:33 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 226AF40647 for ; Wed, 14 Aug 2024 09:51:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723621892; x=1755157892; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=2LxxmCxu3sGlOF96O9KD0mc1TW2LfIwO73/vXXUAwE0=; b=WdQpI4UsC1AgWIh7cYfJIVqexWCmbXUhlNvFxaRnChDzowoHGj1Zm2/1 8luliMLlgtrlBRi9TdS+iRQUUmjX7VPexgw2qyGYyrD2oZKGLs3D59k23 F3WpNqaLRGYOYZq3hslj4UxVRhR0zTvGOHDWnBU76L5xjSjzHnzjOau4Q LrNR39l42g1K8V8O6dlQtGnY+fhOM0QYql+Qw6vg34E55KMGhx3CkwLJ7 TIn93Z3B5amT5EKEtEDCYu6+mHAkBAiYp+D05/NAJ7Oy3iD8/NwK2mn0u AlFYyIFjmLQd3WcKG/IScY9w+QAtNqG78Fb+ijo4KXhD4s6tEBlDMkbZQ w==; X-CSE-ConnectionGUID: CnZCSFzoRGCH/XibtBUV5Q== X-CSE-MsgGUID: ATszhAs1TxiMmAHjgDEiIg== X-IronPort-AV: E=McAfee;i="6700,10204,11163"; a="25683852" X-IronPort-AV: E=Sophos;i="6.09,288,1716274800"; d="scan'208";a="25683852" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2024 00:51:30 -0700 X-CSE-ConnectionGUID: CbZV7/BnQPyASI0iHh4KWw== X-CSE-MsgGUID: bhjkX0JyTZC1tbhiBtevtA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,288,1716274800"; d="scan'208";a="59500052" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Aug 2024 00:51:30 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 14 Aug 2024 00:51:29 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 14 Aug 2024 00:51:29 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 14 Aug 2024 00:51:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SmWigmPK3YoaEShOMOCeFnNFf6Mxma5djJcGFMxx0vUkkuuxbUWbg8C7KYsjZPrwrMTPbntklnpuJcfssh/io7aK11aqIt6Da0ngSr/gvOgwYzOlch0m59G8XldewGjjJxnMnYwTmjs9nAaQ/9j6NinVsWFfEtiixU14qDg1BgfGm2Oe17D6Cn/qEvqCVSHiKcPCpAki3WgvKpwCnPo+oqWZ5kbXhv7NKk94eFpAMEYnqHp5P5EAvPAj09NZt4AUeDugfY2esaGSL8CArNlD37oJ52We7e3k6sBQbvYOTfTnrGlRMH1d9Am28p/02KoRtjIifeDATxmYYiLjHul9Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=25alOcHXnndMOn96LfmtVaVrWa4YB+5p/iwCPwCSah4=; b=VJOZeg2XBlVOQQLKM5LrQDqv7vtLB6Sax1q4oVcPNm59/BMx1cSNHwX0JN2+kX5FJCvWs59jmTezIAaodDtL0Widl6HJEXaFrYWgqfDF/HSrh8EbsKhpJuosAjU412XNmNlkj1onbcOXvTb2WS8UE71VCFyspYeNFrhgUptSpxY8ZDZeANEaZHMFgN30rbshOh5yHxwfxL1JXXTLt5waHISspJUzY37GGhv4r0yLXyUkG7C4InmU+5EYjE4QVn1tM6mFfHbm8A9qf06umGpJpERTeBhW4j8sGG2Jw2wdouwzZ1FLsgcCCnhka4ArQxxP8dc2Y2gx6MO5SDI2o0z+Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB5094.namprd11.prod.outlook.com (2603:10b6:510:3f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.21; Wed, 14 Aug 2024 07:51:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7828.023; Wed, 14 Aug 2024 07:51:27 +0000 Date: Wed, 14 Aug 2024 08:51:22 +0100 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: , , Subject: Re: [RFC PATCH v2 00/26] add meson config options for queues per port Message-ID: References: <20240812132910.162252-1-bruce.richardson@intel.com> <20240813160003.423935-1-bruce.richards@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F62C@smartserver.smartshare.dk> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F62C@smartserver.smartshare.dk> X-ClientProxiedBy: DU2PR04CA0199.eurprd04.prod.outlook.com (2603:10a6:10:28d::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB5094:EE_ X-MS-Office365-Filtering-Correlation-Id: d633dc0f-f1c0-4c7b-837f-08dcbc35e6d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?IJp9ktlgipO3PfMHY9PhzLrJUr/8eCLybBqvXFctsB1/RmaEUJPx8PQB7U?= =?iso-8859-1?Q?Y1WE1AN37Y726Z3C1xMipBfQ2o45Ojtrfv7ua2IPCUKFKU6xDmkKOp6ELl?= =?iso-8859-1?Q?T/zfeir06xOD5VfNYwvH3roCN0/eGnv6fx9pD6SOkXJ3c76UOwE3NmA97d?= =?iso-8859-1?Q?1uCmoQUdx4DjrbkGMrqbRzK2TKBJjMxCSnDleEsQhdb0zD6anKbe5dxVST?= =?iso-8859-1?Q?1Tz8A2Pdi3AJNcxOrKSedEic8h80+zGq9cW3OXDYUXVP2P/7941p+0vtGq?= =?iso-8859-1?Q?OGzlsiYkLk/lomnFKv5uxy3O94GE2CYJ29WicZWn9ZkuBo+Ex9Xu78rQV5?= =?iso-8859-1?Q?AbE3U3R4vnqjq9vzy+v6JDaYjGXZr0z75R20bwWiV2MkDt9TxYFtNey2jn?= =?iso-8859-1?Q?NpqrSMKqrSjTmYActTwXxrMEgDiM33RDCuHAi8FgsKrvRPGilv6WNXCvhw?= =?iso-8859-1?Q?jbtAatBH9Klxl/cgArQ3yKNtKSd8huqg+nwaEHGgz1IZ2D2AqayFhr4Cl+?= =?iso-8859-1?Q?fjc+qsobepa0uXgiD99t9vObVohIIUAetF374Hxi06k16m9FaCDUUCyhz5?= =?iso-8859-1?Q?myue6nTXxau0j1h7xdhja1NFFLVXxhpNZS93a2li6KBf+NQRU5g/FkVvVa?= =?iso-8859-1?Q?DXKSJTfX5DZkVJouuvd4SO5scUBVd1Qsy6rBlIzO2cRhNeeNS45U3rrIJK?= =?iso-8859-1?Q?zVRHzSOhh2O8PLvVocKQ1aj5dtGghxyf0cMm+5HQmTdZujp7e5Nxo1JkGQ?= =?iso-8859-1?Q?ONug9vpuaazSb6Wq6eh0pTlmrcGULVMNmAQt05Hy9FRDL2i1mdome3bb0w?= =?iso-8859-1?Q?B3A3S65Zo7GLC692Fxnkr+j3aT/cEkuwg4uVFie0gS92dBnXE5R+fUocQv?= =?iso-8859-1?Q?4lRGNCpeUfq782Rutb5bFFmVlUXKd6Liu7TUnr2ryd2dCmDpBo03VvDvrb?= =?iso-8859-1?Q?rw8k8g9hSmLY2NW2C350sT90SIDMSnWf7FF36VBnQp4ZeouN45rbhRu5zR?= =?iso-8859-1?Q?BWPsD0+/HnZJiT6wrwRb1iXj48wwc4nqpcqg157Kg5oiT75NUm28ii0sVr?= =?iso-8859-1?Q?E4fDZgTE9gQpk9liuEwuZ3m6ECQhA1YL/E7Ot58E99qiqZAmOW+BBIfvjd?= =?iso-8859-1?Q?gy7q9lGYG52auc567fdTGFOx0I3b7gO67l2IOZSqBd7ynxpDuavIYF8Mfw?= =?iso-8859-1?Q?1s83QrNNEJnR7Zz+e720A3HCGoVSE7xt4vHPGunEOrDd7beTnLnw6970Zf?= =?iso-8859-1?Q?U/uoaBjJVU7na87LbUvagxmxn4YWKEPke4lSEpIVce0c3R+cmm7vdZBvBf?= =?iso-8859-1?Q?iorFEMrQsephQqkb49HKmNblAyzezHMb70pVWrKkvJwVLCz673SAWDU/B4?= =?iso-8859-1?Q?/55W1fkATDpZKMzYj+N5TkN1iUI1D99w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?vZ8qNS+qVO8LVBjYJNRQGJVXdV/DUHkE4Fk5BNSHPRsOQhcjlvc4ohXohD?= =?iso-8859-1?Q?tR82YlXOZFy8J41yW+6/qHHq+xrpJ9WUdgaEqR/D2Yu9AyXzQE45q6kwr3?= =?iso-8859-1?Q?/Bi6em+UNX03+D43gGQedteB1reD+goSTvR5DrT7zTApjAoOYrVjW3T4qz?= =?iso-8859-1?Q?hIliQ0UZLHurn8DsQt/lYVuZun75SDxTGLorCnGTRk5rEp3sjPvnHWb3FW?= =?iso-8859-1?Q?vp1xuG3OL6nDPOVnqcDuAQGIiSaOW2FjmsnBXTf2D9chN4zovxzMYiASbs?= =?iso-8859-1?Q?TJ1MvY9cIA06Yia1lR6iCHZXUUAtD2/+UGyhOhBiLVUlwZEv2t0SCah+6C?= =?iso-8859-1?Q?JIkKNbFyUAjsp0J4rGlejupH3Rv+P0xDNzwXdv3NgAP2SaSTkv9P/HPJ9u?= =?iso-8859-1?Q?7xHjkIUZCHrjkgUAJ6OQLxtsYR8LThNqv/ZTGfjuoKY99k6kbXP8a1kqU8?= =?iso-8859-1?Q?4N+O2Agd23SmDXtvAI9Ja+ZYRHw9MNPU6N19HZi/od7zuQ1LXbnAwkOuW5?= =?iso-8859-1?Q?EHXkd2fXxmkzJQpNxPfBQ+wZ81Njqa9LtIFEqiwiOAh9vC1/dzCxBW3a3M?= =?iso-8859-1?Q?vI2sj20R0eMmDkA3GdEoAw8KV+r+77OLMCQl5KQdFfkxccOGvKviYoLJEl?= =?iso-8859-1?Q?cq4dNl1rXbpSJFnIwTQFEBWSII2gQI6DFXRbebD002xlgcELLlRH6dJ9yb?= =?iso-8859-1?Q?5Sxn0luRdsS3jeJqVY8hDWcEss76j5zXIa7zt7MUg1LQt7la+3NSNreUZX?= =?iso-8859-1?Q?CKo1I2ZECXXlmC4LPmBnfMeyBk4zDBJ8V2NAlQs0cGYiXYjjXhWGHgR698?= =?iso-8859-1?Q?d40I2jyo6Iq82+wu4CwmeDXdXm/Z4q2zXvh1SWH/E6e07Q0xsy6coisrAJ?= =?iso-8859-1?Q?R+eE43AwaqPFF6yiKIBYMGeSU+OaoZ10jRYQ1I9YncacleTz/6cjt+8i+s?= =?iso-8859-1?Q?TCjoSjxbAU2gzTcA/tKru53GtCQ8hTwzo+/NoeH2R7UZcfpnKtZvhdSK/Z?= =?iso-8859-1?Q?tocCMheeo1AcnL1BaNWIV7A0NwELI3FHsj9Hk11W8XbBSya62rZkJrzLq9?= =?iso-8859-1?Q?hmJjZSH09N2VyQYZQpI4EdHAAmzGJ1OzlZZ6DMGZxFIzFMzxxv4xxLH8sY?= =?iso-8859-1?Q?M8aaJlp4ZKXvjS8FSBzSX/szyU/zOPeM1b1Iip1u9dgshwmuGbau+q+1Py?= =?iso-8859-1?Q?QKp7y0W2d6z4f7CUn5CCnGa7299OILiOY3ptnL8sYOdQO7v+ULcPKVr20X?= =?iso-8859-1?Q?qHXaO8q6sBLj8xHj7N0+h9VP/vA72n+F5rX2hKbM/IkWvKaTETqoTUsPek?= =?iso-8859-1?Q?FrdtghaTjmGOWnoT+R1JHdG2w53XxM1fcex9RP+HSkA/wWonLd8v4ucJdJ?= =?iso-8859-1?Q?MBwouTIpgvYyXurzi3yH/n8sQDRZTHqQnxQqqotm1m2peO21LB2IucvJSJ?= =?iso-8859-1?Q?9xwZ83iHUF+oqj+OqtTveCdD5CXmIPd6chjPwPZ0rnJSPREkFRItRIAj5a?= =?iso-8859-1?Q?nB3IeYkagvfIlUUW/aPxdn9Q2TesSoVhhFQostk1JqsGFmyynqaJ8z3tvL?= =?iso-8859-1?Q?FjZ062VkO0KYkVKvES0dOFurZLqZeMfpqb68S+BEi6C//hpQPWH4QCpbO0?= =?iso-8859-1?Q?VGDvWPKD6x8vc1sxiPj96X5/BXs/9uLtYjKe1lXkKOaIqqMPS12/J7mg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d633dc0f-f1c0-4c7b-837f-08dcbc35e6d3 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2024 07:51:27.2610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +skGEGC3VKMu2cmHgoNx/RY/oKOIUQpVymZuqfwxgCk/iYVOWD7Xu8HKLyc+ba6WNOiyVnZ5nOlv9aJ0Sip0PSDUivAei6ECo3OLIimHM68= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5094 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 14, 2024 at 09:48:46AM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richards@intel.com] > > > > There are a number of issues with the current RTE_MAX_QUEUES_PER_PORT > > setting in DPDK that are addressed by this patchset: > > > > * The name does not make it clear that this is intended as an > > ethdev-only setting > > * A number of other libraries are using this define rather than having > > more relevant defines for the particular usecase. > > * The define is hard-coded in DPDK source code and is not adjustable via > > a build-time/meson option > > * Because of the lack of configurability, the max is therefore set to a > > conservatively-high value, wasting memory. > > * There is an assumption that the number of Rx queues and Tx queues > > should have the same maximum value. Depending on application, it may > > be desirable to have fan-in with multiple Rx queues e.g. for > > classification/filtering, feed a single Tx queue, or the opposite > > where, e.g. for QoS Tx scheduling, a few Rx queues feeds a very large > > number of Tx queues. > > > > This patchset therefore addresses these by: > > > > * replacing the single define for max queues with independent defines > > for Rx and Tx queues. > > * adjusts the name to ensure that it is clear the defines are for > > ethports only. [ethports being used in the RTE_MAX_ETHPORTS setting]. > > * replaces occurances of RTE_MAX_QUEUES_PER_PORT with appropriate > > defines for non-ethdev use cases > > * replaces all other internal occurances of the define with the new > > per-Rx and per-Tx definitions. > > * adds meson config options to allow build-time configuration of the max > > Rx and Tx queue values. > > > > Naming Note: > > * The new meson config options are called "max_ethport_rx_queues" and > > "max_ethport_tx_queues" so that in the meson options list they appear > > alphabetically beside the existing "max_ethports" option. > > * For naming consistency, the new C defines are therefore > > RTE_MAX_ETHPORT_RX_QUEUES and RTE_MAX_ETHPORT_TX_QUEUES. > > > > V2: > > * What was a single patch with "3 insertions(+), 1 deletion(-)" has now > > become a 26-patch set! :-) > > * Created separate Rx and Tx defines > > * Ensured that the name makes it clear that the define is for ethdev > > * When updating internal use, created one patch per component for easier > > maintainer review. In most cases it was obvious whether Rx or Tx > > define should be used, but a few cases were less clear. > > * Added documentation updates for the changes (release notes and > > deprecation notice), spread across 3 of the patches. > > Thanks. > > For the series, > Acked-by: Morten Brørup > > @Bruce: There's something wrong with your "From" email address; bruce.richards@ bounces. > So I resent this reply to your bruce.richardson@ address. > Yes, indeed. Something has indeed got messed up - probably in my git configuration here. I'll resend a v3 to try and correct it, so that others don't get any bounces. /Bruce