From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 136EA457C4; Wed, 14 Aug 2024 17:12:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9998440661; Wed, 14 Aug 2024 17:12:58 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 19409402C4 for ; Wed, 14 Aug 2024 17:12:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723648376; x=1755184376; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=2wSDlCs5Zg8+uoQOojKoh9squ8TRaI5mY96oU/aUho8=; b=kyS1Y7QKxoVe3hTCUgV6TovbKGbUz6DBu7qYqkblO4U5R0Wbz926x9ag 8NRsvG/VBEOLZ+T2mdRJuhaiC2gF2B0EfyizIJPJcWefeFVW14aGFUabs ACXBlUAw8BbYqlbFDiYE8kDaSWYnY9LP+LUPPPPcaXJlnVv4Cih1d7dT7 GHz9NBHMYRrflPNaDwpUV9eXPfb0nhlx4ryQB1QYmeSL4bWm6jmna9xNe /t7CRB7Ee5PBRwapBvyCBKIfcyBSNx+7FBAFcLsl6AXBvjzm2ARsGGzXP +IsLgJ+55wTDRxonxA6iQnf5C0xz6i6CJsrLhKUj0WK2lPV83riga8IE3 A==; X-CSE-ConnectionGUID: pLMAlZkLSYKfEGEKHCF6gg== X-CSE-MsgGUID: UCKI0/tqRxyJDvxiDrzAOw== X-IronPort-AV: E=McAfee;i="6700,10204,11164"; a="25738699" X-IronPort-AV: E=Sophos;i="6.10,146,1719903600"; d="scan'208";a="25738699" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2024 08:12:55 -0700 X-CSE-ConnectionGUID: RbdZhbabSPKsLRiuPRKYWg== X-CSE-MsgGUID: iHTeDk00T1atFvhDzmrjVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,146,1719903600"; d="scan'208";a="63192020" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Aug 2024 08:12:55 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 14 Aug 2024 08:12:54 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 14 Aug 2024 08:12:54 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 14 Aug 2024 08:12:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jVjyBLBUpGu+WU0iBq6QSh9YQGpukOJos8Wa9wrcON/zKGVpM5aSexH0PtH6kK1EfPhAoYPaHqPUVhdaAXEAXHEnRCOceeJ2KBIFM4hBu8lxfJB+Sfm96iz1EWgPhwNksKCfTDb8OlYsN6xsK14ryAbkzsMk1zSD7GVs4dph58crDF32T+b74QbwrnZjzfvvGb2/jUnZ5e2+5H6byPw/Oa4mhWkMV8sCETBjbCcCl896xHeSQbFpueQcntOFylHbu7tc4Jb9b8bRqDG0xfCaSXh+54Vfo+dAIU8GoeoUucvCesM3RgFI/ck6ediMkrT093hanw8OIx1H73j9qJ7gcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tq2NF29BrBpXXXZnU6ASXJyGqZwzyPFDrPBKdfdDHJc=; b=pEBN21/2/7XkHxzbf/nTUYeVxZPTRf5CP80c3LMQ9SrvJcvKKNfkUJF2YRBhDisfKvh4qYZAmqRCYo98bQxFKB7xXHpGh/GyklmOxUPexjBMHV3S2ArjW4WcuxoHJ6LwM4EWxNWUbr9fkxxYeWEjm1EXBTOYjwMboKzNoCcrGuw+u6xmi9FVFgKOKLwAbvibfgMEus1VGnQJu0mSYFbHQ06YNNPAVqjbBvNwsm7cFsRPghkUT5BOQSDsVXN4InVrCNXFuNBQKFLmK3cmRIjNAFe3evTrkJN3u1FEwEwB901o+gkCfmWuf9tOeS1AqlwBanHjs6dZ6qqGTcHgfh2H9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB7648.namprd11.prod.outlook.com (2603:10b6:a03:4d3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.29; Wed, 14 Aug 2024 15:12:51 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7875.016; Wed, 14 Aug 2024 15:12:50 +0000 Date: Wed, 14 Aug 2024 16:12:45 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Bruce Richardson , , , , Subject: Re: [RFC PATCH v2 26/26] config: add computed max queues define for compatibility Message-ID: References: <20240812132910.162252-1-bruce.richardson@intel.com> <20240813160003.423935-1-bruce.richards@intel.com> <20240813160003.423935-27-bruce.richards@intel.com> <20240814080119.3c1b3fbd@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240814080119.3c1b3fbd@hermes.local> X-ClientProxiedBy: DU7PR01CA0034.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB7648:EE_ X-MS-Office365-Filtering-Correlation-Id: f1fddadb-f5b2-47a2-33ea-08dcbc738fd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XlsFeqERcQiZz/Cbj9eGh260Vm07qg5Pu8Q2tzhuhlqQcnVtkNNTYIasHVFv?= =?us-ascii?Q?svyOG/Lm467mDGJBBlYKEbp9Hqy8ATs9YeATUiIatIgS7rP6PoSDD3Jj4FM2?= =?us-ascii?Q?/PO1CDx8xwrPgq0HjOC7yBJ0F1Uz0NhNNpYOm6uEP/IH1d4DwotkdG1UkQLl?= =?us-ascii?Q?zEJPwnx2gluR3icUDY1WpPHwxbp0YXzRXZ5RMx3yaz9hqMxlCTc8qHCYKVeC?= =?us-ascii?Q?GKAtYEx7nRkQ5z3JfMSPcAeE5zVBk9pDu5jK9sGtigLSq63VMLOoB5uLNqZ9?= =?us-ascii?Q?bITGzlpPrp6phnG0lg8mfKL72yqA1OqR2K4+DcTxhHSkzrcmU94WSkF46i5v?= =?us-ascii?Q?X0TKeXtp69Xf+BSQjjv+zOvMRQojXbQ2NUknxsf9L/Y1ip4dclyafZrCqj8V?= =?us-ascii?Q?0mhAaHc/VFIHpxo+I6iUPP8Vq7WKVczBpMxdyMrFqZSEWMIGj2gzwzoAYZGZ?= =?us-ascii?Q?dwDL6TdBtoxF2yywWrS7ti8k9v4ymvT4Xc54fXFUwrMPsB+rgn16dA7bA57G?= =?us-ascii?Q?OzXVRuyNFSC8/JUtdkZh0145SAxZA9sXaovkMvd7rveY5zuT3HVonlnTrKxb?= =?us-ascii?Q?rSCEp0ZG4PkRhuk8mqrxZ44wV1n87hfxBbrZqT8+9azP+CQn/8AVzM56JwN+?= =?us-ascii?Q?RjnQoXuGUVxMZc5hgHd0zIfa4R+2w60fE5Bp4lW23axkdVEFU1WS9DEDjiD0?= =?us-ascii?Q?v9qN0ahctd+3WAghia+VKRG0wl9MO5pykrANOWHN+xwDe+2e1d/u2Kqx2AL9?= =?us-ascii?Q?CNkoBfu31uAjbuyKHVWpAwnoDv6acDEetT+WMC0WRiU8N7ctLLty/eyzhhnG?= =?us-ascii?Q?7tsp+ch5LW6D9ANcQ1adCwd9JbiGxIeCTIg8Q+rYa+lEaQUi87mUDRDadZMp?= =?us-ascii?Q?VEJ4xC+Fu1VJs8zkuoTjwujNI4UTWpXjqc6JnYdeHbou8YcBF7fDLe8M1NMz?= =?us-ascii?Q?T3gTHLCA2W9QiH04dm3FI/EsKQfOwp8U2gmuWLyB6K6FGuuUTWmEey8H2pgt?= =?us-ascii?Q?+bUNbBjq5d2HbPVfYe596Wo2sUxIlMX0WlHLKBby0tIjaeb6Vppac+O/eJKW?= =?us-ascii?Q?WoJUyOGdtyVthGYnlRsFVB9Z2/zkB7sIW85mKtQXsz4157/f1pbAQXQ0hZBr?= =?us-ascii?Q?yp5/mhggF35TI88f7WaaVu4UD7qlg7UdubOXOl7/6P7UD1tYPlyV8WsFEE6f?= =?us-ascii?Q?umyHlWceSA54/5SMm+YiXQRhqKq5PY+W/ZwerAWKUBOWver/3EowAD961RSv?= =?us-ascii?Q?IYj7KM6U07rkDk+9hIiC6RjGpxvZmxwMkERJmQKtcO0lvWzBTpRiKsARi0Vl?= =?us-ascii?Q?sdSsvfJrvhiyIczWeuF3KxeYgnSi6+7zZjlJZeXUtjEAqA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/FmjtCm0k23wckPjr/rPGxUzM+R2KpSMoyK/KYEMmg6rz/KJEjK4PYRLYS05?= =?us-ascii?Q?tyoafjx+REGluJ9kyaHT/rOfdPD4fhWB178760+pyQ/H2FpaoyeG9WvLhBYT?= =?us-ascii?Q?21HUc+YZJf8bbTrLhfP3wcwNd5gElnMRzybMO/zqZXVa4q6pckRPYhREGDo2?= =?us-ascii?Q?jFUvE8byYaFjRGHNTmwnsSUCN6hdp2A1yc75sIozAtL8dssCEQkpGDggn2L/?= =?us-ascii?Q?xgTH2sZsI7J7L792swa8Wombvv0RpRmqMoUhy1FaHNj2JzYSKqtlJxew3smn?= =?us-ascii?Q?IvyShBIUMNcAXAM8l+jtnXYijPyU5qrSJ0l4jJAMtUlochT4KPw2b8qc1C2Y?= =?us-ascii?Q?iHcdH0PPrusaWdpmLHNHhN7UzreNCUo6aghq0rs7RI9LcBd1d5cbHAPmlA+X?= =?us-ascii?Q?CycKN93Q+43Nv2jC0cC9YHDIWsc29bwMfl0zngk1z625OXx5ujjiFgxH6GqV?= =?us-ascii?Q?QsHc16WvQV+T0FmtcxoNztfM3Jm2dFqwoR88EA3aU0w7/s0QAq3PGmFPrMFh?= =?us-ascii?Q?15ZcD2Klm6m/1iDAr/YjPsfJWwTBDlwStsgHyqLrrvrvsQ6sEs5KjImEbT6F?= =?us-ascii?Q?Jvqgj23fdhsb03MsM65PFLu6K//ZJji3w4jzNXP5E4Kv3sfDM+7ktjHOM5DR?= =?us-ascii?Q?RV8CKVmfa0f8KLkHlZRgds2lZiXexnN84xFMcKRe+n3jwUzclmk/yVHswSJX?= =?us-ascii?Q?1XbxmHkUqNwoRgcM8CU300J8QWQhlrHVbVefksl7bzyOSmNXpGcHtK4YHU3K?= =?us-ascii?Q?RsYHe3cudZfummL5OtDsPQ2a5c/mzWFX2xlLuP4R6vGHnseGqCpelib16Rwc?= =?us-ascii?Q?lxJfQKw+hXwNrlBIVDKbglSAaPLNqFar67BmsLw3iBwva+uulRDVp4qPX9qZ?= =?us-ascii?Q?7Rryzkn0QepOggLhyGoco+ua6W+ILx288GICeB0PlrwB3yUWZ63aOWN8GJUX?= =?us-ascii?Q?b4hxUDsFfmmhLT1AeAI8HHJJoC0tPeXowNAx1Lt9/cYt91ioqFYksBl1qrIV?= =?us-ascii?Q?PPdPQrA9P8ILPM+cHsWseRICLOv8vmvgSasKI5noOFi8ow4HJQSPgSe49JoI?= =?us-ascii?Q?nfs+AR1oHJ06ih9A6isUuSxHXUnkn3YsqxuvCwgKEXWBhZkbAw8ZftWQ4inW?= =?us-ascii?Q?BzXCV5CD+2TbWQnbqi537njjK/nCXt9r8I0JTg/KALBy7ygwA5P5MY2VhXOb?= =?us-ascii?Q?5Ntzug/JtEAXU8V3gmaNgeq6EOXKL1moixnEyP53DvQbI0fvAf/nbKF8sn4D?= =?us-ascii?Q?tIthpZVDex1k4olqREyFEKkkQII6JJjLfCvqoYtDB/23H7YJI6tPwbBpRjLO?= =?us-ascii?Q?78pHCKO8NfoXQ7ZesvR8Ld0oDgjqYnXcNAYoWn6vVmxwUQ5hCuFr6OJBBktH?= =?us-ascii?Q?x8Xhno+52uHQD16bSk09sCK0jox5whxrKT6h5/IwwgWw8xG764fYLmKTwf96?= =?us-ascii?Q?Mt4SD2dscEZbdRPWkDRz7Vd7NVRiIJ/PyhpQMCG3eSraeObOrZj4dnZrX2MO?= =?us-ascii?Q?DHE69CuKYgBeHlibOyHyTfmJcCWn8yLUuPXzgALembT/O1wg2bBsp9wdhTVg?= =?us-ascii?Q?BcqVW0kSzcP74+s8XcXVXhOIGjxj8T6RmdAoYbpZPIodGzBJSWSK23GrQjb+?= =?us-ascii?Q?iQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f1fddadb-f5b2-47a2-33ea-08dcbc738fd9 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2024 15:12:50.2419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3hz8uRURoro62E0l1ueyVehxa4ZNGJIHxj0OcUmvqCcolPYikpBvb9Ofl7q+kiCNDBINwUdV69hjGZoH4LawEUVc8NiGb68fXvkEZo7w4Nw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7648 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 14, 2024 at 08:01:19AM -0700, Stephen Hemminger wrote: > On Tue, 13 Aug 2024 17:00:03 +0100 > Bruce Richardson wrote: > > > +.. note:: > > + > > + The define ``RTE_MAX_QUEUES_PER_PORT`` is kept for backward compatibility. > > + Its value is no longer hard-coded, > > + but is set, at configuration time, to the maximum of the configured max Rx and Tx queue values. > > Would rather it just be marked __rte_deprecated because a runtime calculation is going to break > code that uses this to size arrays at compile time. "runtime calculation is going to break" -> yep, that's why it's computed at configuration time using meson, so all C code sees is a hard-coded value. See commit log message, which calls this out too. In terms of deprecating the old value, I'd really rather not do so, as I suspect that this value is likely used in many end-user applications. While I know according to our policy we could remove this, the cost of keeping around a backward-compatible version of this seems pretty small and may avoid breaking lots of end-applications. Then again, we may want to deprecate it for internal use in DPDK. /Bruce