From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20C0145887; Wed, 28 Aug 2024 13:03:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5F0B41132; Wed, 28 Aug 2024 13:03:39 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mails.dpdk.org (Postfix) with ESMTP id 0CA2B40150 for ; Wed, 28 Aug 2024 13:03:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724843018; x=1756379018; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=/rTqyInMVPzdh/N8QZrxHLk5G7g/USaESybfomSoJSE=; b=T7XYVU1vYfXUJdOluTsiDgSrZNs6ZkSbBMDUdQkemBnjWwg7KKpSN7lA XEcwIkNNU0arhDNnHxeiTeJKMpVpg7AcupIrDDLqbg2JxkWI/Nrf/bJAx 4L4iT6lf06N4Oj5rVX7ErNSFRtKy5SD1BmfmVWMVtdNqC5/uM9ir5jKtq g3KsVxTNix3TpVrAiVRntzEtgCW6AXKOiyc+UH4uWDU5R4HYW7O1Rgmld r3Hon2pdW9edzoiZv3o6EVTF/Gn7r9buHNiUpDAVUh6FjEDgYmp+4+tp/ 1TGvc2ZM+guRtSTUk4782RVMrkApfjqn4U1UB+Gtx9HPQHCj+9YOD64mu g==; X-CSE-ConnectionGUID: rc3sAS38RyO9A3pkORw7uQ== X-CSE-MsgGUID: WtgLUsmlSZeH0Gov5zdaSg== X-IronPort-AV: E=McAfee;i="6700,10204,11177"; a="23243457" X-IronPort-AV: E=Sophos;i="6.10,182,1719903600"; d="scan'208";a="23243457" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2024 03:53:13 -0700 X-CSE-ConnectionGUID: 0bRh1gtOROymHCVqNp5a1Q== X-CSE-MsgGUID: icpZYMAOSImGmidm848Ybg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,182,1719903600"; d="scan'208";a="68045149" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Aug 2024 03:53:12 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 28 Aug 2024 03:53:12 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 28 Aug 2024 03:53:11 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 28 Aug 2024 03:53:11 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 03:53:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m+GLN3iiBkzQz4KJlfEREQGTocpTffGMbbZJYMqEH79fwLR1C5pTltozsRhq0NKGLWFVdFHQSd2DG2thk+PUWLTgsVxmzxtqAHX0VAmJoAkV4qLN8wAJA0WiVNOxOhKKLXTXZp97CtTWw66fiWISEX7s3BhaJOu6hIAu9+tH8X7E6YaJrmT4TrbSLASuiq8BBX3rLYhfeQlkKQT2PwWLonVZVDBky65G4qlhsJwXVhrLBEcKGwcPdfs/J9vyDrrRW4xmTFbHT7xmanI6tMZcxFTCkzGDkjnr0Dmd29h+4giqRbNGGrIqI4pSIU+W+VNanGZJ1vXDE27toYGf80keLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B/0MXIjEsvvkR1OnrtZwRmPFZDGPrjRVe88N9SlhsUU=; b=v9JuzO9DFWcnnDDOsm6XJQNRk9+RObkCpRb+lNtIl+ErQznlxAwi7dQ0UJxoimUskVBqpTJsfRwCvvdXZXGECO8cOy1r4I22t/g3Xk9Pf+NPokGQyGZjeEl0qRsCGooDYeof8TwC/cUOOPms6pWFF/ozSln62hC96g7c9PLFTEcJ3P0r/iCYGMjdt2o4n6aDsokJRv8ZSMz4l8Ow8zFriGfDkVG1h1U3a0ZawIVw62veRao7++J4/tM0eipvMAuPXuuPvL0/3sHs4Bm8wPsMQ/SLshBPVKBujJmAX1y85rXFfKBYRfR1mlyX6LwaPxIAFGfA3cEfVCf8oYoxBcjAiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7215.namprd11.prod.outlook.com (2603:10b6:8:13a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.26; Wed, 28 Aug 2024 10:53:07 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7897.021; Wed, 28 Aug 2024 10:53:07 +0000 Date: Wed, 28 Aug 2024 11:53:02 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , , , Subject: Re: [PATCH v3 02/12] net/ice: updates for ptp init in E825C Message-ID: References: <20240822185346.221885-13-soumyadeep.hore@intel.com> <20240823095650.349785-1-soumyadeep.hore@intel.com> <20240823095650.349785-3-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240823095650.349785-3-soumyadeep.hore@intel.com> X-ClientProxiedBy: DB8PR04CA0024.eurprd04.prod.outlook.com (2603:10a6:10:110::34) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7215:EE_ X-MS-Office365-Filtering-Correlation-Id: 376bfcf7-1d0d-4775-a074-08dcc74f998c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KUD3PsFjqJcLdklJlvQyQnq0Wdq6WkeRxYkjYEjMSkkVoFZz/KSOSCK/yT7s?= =?us-ascii?Q?E6SFobvcT089ODrGlWyPdSR+Act3wQtxymb/OAssbLxSrp65OI7SDGbdEknP?= =?us-ascii?Q?8xalKe39/KvNjIHiFY6MjkirEovR7wNT4OW9JeHzJuxZBRSHKPVIRa462tFC?= =?us-ascii?Q?wQPwulp7AiDWvRfy2gcb14xWaNIpgHn2V+HVAKQDBVOcv2eVlaAaRHtha5Jw?= =?us-ascii?Q?BIvxClFiY5sDqvzcWOvdX7JtTfKPPBm3NFbHoaxiD06/7Yv6Gpuqpiua21Dl?= =?us-ascii?Q?oiLmBc31HgSwHvNx8Icg7K5cJUifWebxd8RBc5LwdD5dQJhXu4aG52leBGOB?= =?us-ascii?Q?dKSFljWRg5PwwuFO4PLO2zgPDpsKT+Mr6Ul5B+omI9imhg8/NS/NhweSICLi?= =?us-ascii?Q?DYUdhqz07fmnb7skPXxzA9B2dphc+tuaH8UqfHgllbYvrpGbHEToMlATe97h?= =?us-ascii?Q?2CM57o4QNV+f+rQ0z5Gd8dI4wdPFqkk4w+SXs1QCKjqx/SfXVzhM/jxIxfQ/?= =?us-ascii?Q?3GOPxco+4JyeVPDbHpnXRRqr3ZFPcnZdIPVoRIjF8F/VO5YbDBpV3iEPESIi?= =?us-ascii?Q?447fu5UAm68sflGX8RMMd3E/S93kyxkbqTzILSjajzxIKod+pl2QIOkJhIKv?= =?us-ascii?Q?OVYLMLz3J/r1K6YkvH637TZ2YqZhpmJ7/REyugcGVRLvkGy2vnVyM2r1UQ6B?= =?us-ascii?Q?saG1nrfqdhzbvnzSxV9rh0XD9XegNv7Y3NWsavhEcn5CZxSBBZUqpDZ64okx?= =?us-ascii?Q?BltKi7yXqKx+TeZUPBgRHgVcqGkslJGGljxsyaf9ftRyYj7YYG/JW5yi3rpM?= =?us-ascii?Q?+qt2AdZ1dKsZdc63VXjslDbUhb+K/PscnLASqoq7RI7kVgLzkWrqLFmcq2o9?= =?us-ascii?Q?4B4hpXhHjI/xAz9YnyDvx6CJHoV0P+TX43P76KHGLnKXhczdRWzu7S/S1rw2?= =?us-ascii?Q?74HUF+SZnol0XmzzKzuVhp+6EYxQUlY5X2Tgu4eA16lalD6tGU1lewK4PPMk?= =?us-ascii?Q?GXFC7vXM5PsuD2MPpq9JxJ26N97rB4EMMnb11dlD5SRhta2a2qPWz29nSBWF?= =?us-ascii?Q?d4Yv1Kg/zwy8zeg+iS59U24q9hRPWdNnfEJ80xEcCJ0eEvcjo/e+oDv19wIs?= =?us-ascii?Q?znYMNfq8bH8tr6YXYjoMFmLLy2ENuaN7l2K+D+NYeZk07+ytGfSiUN7wp2PR?= =?us-ascii?Q?2YU40dXZxZdfjPN4xclfNU4ty1kwdo5ybNRM7/Jz5sRmrREY1s/qyuhvkeWa?= =?us-ascii?Q?VpqgSEsRpHstRVHG/DwzflXVEz0baYGVs0rZw0P6ebNXgYGKgQgKdRTRP3Qm?= =?us-ascii?Q?ODrc21dpefkjmSqfWu9dXcruEri1zd4/Zsz4KBUTb7LU/w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ejz+n01S33UMI8hwt9gewuAGIwysRCky4d1asEvOB5plSOT+KCGHqpkispgu?= =?us-ascii?Q?p5yFoZ2UAqgSWn0grfC8CxjIP1GU4l3I0YZ8yNv+A3uiv8wGGEkfbUTCkgPT?= =?us-ascii?Q?eR2divwD3zXhyNkxuWroGe6xc+HvSuNHrEUaZ6H+QDAhWxEmLC4WUt6caAIU?= =?us-ascii?Q?EiHEVsgPImVdsytbTTxV5iO1FBbdK4CM5w6HUU9UgUJZYmJ51kCY1djWewpi?= =?us-ascii?Q?P2uNkvOkOJ+xxHvk/oqUlE6bpSpyfVzMjH7r32qADM16Fyzy8AxIvhw4l0XC?= =?us-ascii?Q?GfRlbduWmRrigHSwTuCs4tNVHBfsLMrxIm2YxDBViHhboWy++Yn0SEDwhK9Y?= =?us-ascii?Q?sIdy8EEEhA5yHZ5UWquR7r7VyB+XoyClRQ5B6h/9HLmBQTnCBPMNWw2fnjTE?= =?us-ascii?Q?t18NgrpfHThHyUyXYWLBboGHZWr0vYA0h1LYMug2oJtslRJxKEEMbrvKGxyx?= =?us-ascii?Q?btAYkdeQrntvE6MDnhdkHzKKCEpB4u/7LA1D5ty+JQs3kNysyttdhEpbzrEP?= =?us-ascii?Q?iLkn82u8Zsv6IW9nz/O2HbqORD0uF896CW9WEgmFN5saC2WRw0j7w+nOqJuc?= =?us-ascii?Q?At/vlI3OYpqdfI38E9LOfVGCMx2CxalseBq8d5mZTOamOSsbk0z/lUbihH7y?= =?us-ascii?Q?qR4lWq49wcwB1S/fTmcK3okKg84tFcRxnX7+kbVfA1pB6SB/EdbYLc4Yfcty?= =?us-ascii?Q?uDUx4FEBe4uyu/wSndjKQkyaR2gxNz/b5IF9FKhdRo8vdQHIeFYPT8Opl0/k?= =?us-ascii?Q?QvEgSn8ZGXia6WCGjojOwb1EVf8eMHoHeTNSoVdZo+JVnQKs6JsURAijQdl8?= =?us-ascii?Q?eeSOhiwGm6Dx6w8yalIA4Kbr/jyyBM2DVtMKYBQ7V9Rqoq5k/1fiUi2VMZWO?= =?us-ascii?Q?Q8xAXSCJbWU0eBbRYpzsAwpAcECtZLbdM2d47kJOz7N/xvAdF9r9fAeor6EB?= =?us-ascii?Q?nlaW+MCZyls7jkJDKmlpuBmagM3yJ9Cje4UKfSQo65po/iS6p8VxFKu/GzRX?= =?us-ascii?Q?jtNhPNTPMLdf0yWA6f1+5jAZNTxaFl47PEdWEk4pDxfslgopltUDYiTTWGc1?= =?us-ascii?Q?QCgrM8WRYjbuXvE6ZnrlEBRwPhqvlQPDU8TLS++lNo41rzQVWPlX1jcAmqsA?= =?us-ascii?Q?n4tZPgyDC6KYKoL63vzZaTZyS6qcB7fIs8JcVb1RQfkagIHrRawUD/4S2XrQ?= =?us-ascii?Q?1vTuCptUaC5mWyQT2W42VO//jjCM4wPvtpUMluHyaVje6PBmedFuXRy+TTr6?= =?us-ascii?Q?gFGxc5frr1A+mfgjRzonbz9R0uExdj0DcA/zEq3C1Q2v4B0Cy0LUrbQtYX+P?= =?us-ascii?Q?SPyRGLKnktPATCSMb16nATWUeS12ztCpJKDgXv0VG/pa+viJt/CmGgn7vB/m?= =?us-ascii?Q?/QYX6f8upGhrT0KiKzAzYAPGazhogc2TZZ2ZuZDz7dgp7GZqf3LbVyBHfgZf?= =?us-ascii?Q?K/l34gLVmL9mEZV5nno7CnQNRefZ+f9ewHmGc+k7sKFpyy5VOgnlqzhNNZsp?= =?us-ascii?Q?qCvCvAU5ZdPHYCDtkUlWZ4xuuqTiED2umIxnaMtJmSm30KlTHzaY1Bid+xuL?= =?us-ascii?Q?pXsoTvo11Twp+hFIFC7JUJRzJuwDVOfWkuPEuLfEU0GD45Dp2ZQhyc/S0n6H?= =?us-ascii?Q?+w=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 376bfcf7-1d0d-4775-a074-08dcc74f998c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2024 10:53:07.3854 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2JTvTecC+pg7QwgjxW53Vf1RD+11hxFEkN9TIzwWfY9S62e/IZHBoAW7s2hPoMCH6a6+rHR9xB87bdThHBzjVSOcfkNj1yLSucWtYaltrIs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7215 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 23, 2024 at 09:56:40AM +0000, Soumyadeep Hore wrote: > From: Norbert Zulinski > > The implementation was done incorrectly assuming > the TS PLL parameters would be similar to E822/E823 > devices. Fix it by using proper values. > > Define access to SB (sideband) for second PHY and > CGU devices in case of E825C devices. > > In E825C soft straps of CGU cannot be read from HW, > and therefore it must be hard coded to default values. > Minor FYI here that you don't need to wrap the lines in the commit log so aggressively - up to 72 character line length is fine. Only the title should be shorter. I'll be tweaking commit log messages on apply anyway, so no need for further action on your part. /Bruce