From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37C6445889; Wed, 28 Aug 2024 17:36:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBC0A42686; Wed, 28 Aug 2024 17:36:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 1AF8E402CA for ; Wed, 28 Aug 2024 17:36:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724859395; x=1756395395; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=rHkSg8myUrXkC7dLNkRrZUK1GsuttChcT+a7Fi2c3GQ=; b=GcQ5eB6aweITqgcuJ/BsHRuYZUF6+RIBnuROW3LSn+/aNWjYeQVLTZip oYzXEj7QV7hb3xMZVphnMpOvjJJw2y801Hgi+87oYM/8x+qx6kYSLOSY1 Rw36IgQhq+ZCDARb0iA9ArEG1WV+bZto1d/ogRvqj+2B6Fp7rKWvMLEc5 8Mah+1A0dXZJV3AC3wM/OoPIOiBGE19+TJ6fXhkxSOg1NxFeGU9DAQiWB LXyarSbEl7dGbnKyzpCr0IiUMBizYqUCpWMvIGRyLyaPone02txH+BeIJ X3t+mg/vuE43gSkMd0J3j6iVxbuuxfSE/hkRg6fE25tij4wQpUAb64GlF w==; X-CSE-ConnectionGUID: 9NhTJBmNQ6uc6WELoUy5uA== X-CSE-MsgGUID: jd7le05ETRm5FToZSd8fJw== X-IronPort-AV: E=McAfee;i="6700,10204,11178"; a="26296970" X-IronPort-AV: E=Sophos;i="6.10,183,1719903600"; d="scan'208";a="26296970" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2024 08:36:22 -0700 X-CSE-ConnectionGUID: R9wMJGfOSZ6i++7T1fsGDQ== X-CSE-MsgGUID: w/zOkgrDQrSNh5huzbA00Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,183,1719903600"; d="scan'208";a="93979927" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Aug 2024 08:36:21 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 28 Aug 2024 08:36:21 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 28 Aug 2024 08:36:20 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 28 Aug 2024 08:36:20 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 08:36:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O9UTGLAbBT6rw6Sr0tZ3IvHNEoJD0NZQqjARRpE5mCcplXCBkpjFZhqu8QTwa+rceaJqRsjFoWaez34vZ4jVDO05KCOXjZFPc1FwTMCczn0m3I7XPuQNDgsgVDw46v2S8rKzWOOmGD8yLCtdZdt7TXveHXW3Fk4qtDaFkMbMQOVxxCqFcbhXuzJQzZNm4MOql1k7YItRlL5BBg8I6SY32WLHguo3xQKdTtEPK1kFXV3EdUjk6RfXsfU6GR6LXIwHpxFi1WQn+v6fPqIYfbcXTp+OLrCjt6jqPgTAptnDV1sFmJRkt/7qBOe4dF+P5aAUlkpiGuCNyeXEFhjIWrKk7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xQhwpnpRiTB92zLBgtxrTAeGTT0ckjV4B4N0pnSFUFk=; b=GfgQ2VFFLmu2hdphwQBDUvHoDCxTgzMMCz0XPVCI/Zugyvj7z8xM/faXZkXx6yr3MQQux7ocgdouIZT8xq9fjMz7RjHxkrNtaBA0SrpUVFfk1Qz3pffNjsyWuj7czMnbpaRVcOYlv/TY1IJQOsns/bJeVReyg4Vi30L/0xI5RZe4+JD/2Ehd38XU77wyhVM4JqpJyuAcS7ytEoU1zjNJCnAyu4tTMRbFQYwhEvGaGnvBVKKaU6DRCKJPWXOxvM0rcgj7Y0Wj9HYR5q0dWSL60yFFZKYpcyts9Ud9SVpng85iP7tSiizMfF1k/f3AKwI7tSGfmyW3mhrk5pj/AbFy+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA1PR11MB7697.namprd11.prod.outlook.com (2603:10b6:806:33a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.28; Wed, 28 Aug 2024 15:36:07 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7897.021; Wed, 28 Aug 2024 15:36:07 +0000 Date: Wed, 28 Aug 2024 16:36:02 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , , , Subject: Re: [PATCH v3 04/12] net/ice: avoid reading past end of PFA Message-ID: References: <20240822185346.221885-13-soumyadeep.hore@intel.com> <20240823095650.349785-1-soumyadeep.hore@intel.com> <20240823095650.349785-5-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240823095650.349785-5-soumyadeep.hore@intel.com> X-ClientProxiedBy: DU7P195CA0008.EURP195.PROD.OUTLOOK.COM (2603:10a6:10:54d::35) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA1PR11MB7697:EE_ X-MS-Office365-Filtering-Correlation-Id: 50670da2-b546-4e1f-6c90-08dcc7772276 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aTOo2PZaDUcLcyJiQLYa4u3FelI5tDwU6ayb13SQAD8x57jcf+lP/gf6qv/m?= =?us-ascii?Q?TQQJ2d3TeKmcjEbnqGhb0bdh/xmkaTgmfmy4OdHm6jIZDfiofQS8dQSFUZCb?= =?us-ascii?Q?y6vHFkTabg1E2gdiGgmApzQSt8IK1rY3Hb84Uybyz6D+MIPGzeqEp0bypbnK?= =?us-ascii?Q?+xQl2QuVq1nVVQEUhgoGARcvmUhEMlCUGz/orsN2Lv8NynpN52wacO2Gq/IY?= =?us-ascii?Q?PXUyceF5Jg+0QLNgPAkP35hw5voM3a/lMbcXVhB5k/n8aYED6IPot/P6NYlR?= =?us-ascii?Q?KK/LwZLEbscDSXd+Y/mAJXXn5USKaxk14ipgF+N05daAl0xd2lwiFWMLMhD7?= =?us-ascii?Q?fYJrV/00Vhb08JPcFwszJ1H5AueLPGrdlfsDJUnf+gkKWaZeK+Ql1ZPLU+Cr?= =?us-ascii?Q?VYEzer1WIbFbwy4TNAGWOkjdHXsEjHKHFaNteTT3Flsp6qcNZ93I6i/GDoBG?= =?us-ascii?Q?JHaeLasQsi7+94vgNpeuSSduEwNDF43aYuP1UdDJ+qDJOBnhkdYPpI/+/4n1?= =?us-ascii?Q?WkW9IcDcNknMUwxWQE076q0nQgfd+IBPA3LxrgDjKSWYsMbdHVx+j/eESQYJ?= =?us-ascii?Q?tJ3hWlWZdY2ZzlhS0pfJ/klmhXKm5Vw/nxsigPfWLP0oWkbRkgLB/7ifERUQ?= =?us-ascii?Q?2QFs/M20KRLNV1C8OxJZGUfOLZDPbGzzZej31nAoGnWeaIjIp78pnOAW4O2i?= =?us-ascii?Q?b/3flvBcBc4LgWwqPkqKmlEGDXKI+Te7gvK9vNijNCdRWFw1HXd529k2hTnf?= =?us-ascii?Q?4b5YiOl6MYs8rrZhGBOWBmuVr+nn3SKlxglThJKPFt11rHso7zeejESPXo0D?= =?us-ascii?Q?/N1gkDUNV9fFOdELxT/gD8PHj/bfivTpLPWU+sKF+Xz5W1w/E2D6Brlczctm?= =?us-ascii?Q?DzhVM+bjd22FB9FJR/Z4AgBH3n0OhAu8HboXdLP57DG93pZ+hppqQ/qxMVf9?= =?us-ascii?Q?0pf0hmEewJK04zZUcaJLulwDqjeCDwNmnBLY13K4y/BB3eP035Dtrir6GRTw?= =?us-ascii?Q?TeqXG3We2kmjjPiij9vyKvF/q/F1Qo4dPfcmedfjm39v8u6koKGqg+kE5sir?= =?us-ascii?Q?+2Lqd3CsQRsKjDoTeKaBUDyLdxFaULQmyaUCthwM8aB7hS6GBHOevkBJNevp?= =?us-ascii?Q?+y0L8JFxohrKl1BafBfcXOMu66HT5zVyFgw9yX5myUHtH2wd7AHsa+ZqYkTg?= =?us-ascii?Q?NseYFRvW5m9yWTzRnBzqUMC9EgwBWM68u/U69NxLLdlJIlAhgoTI2LxEJTX1?= =?us-ascii?Q?AlQGdfQIjnAVdfFkitqT+A35vggPsWYo8zTsZ7G82bZaAGBvJfyu0RFK5dJd?= =?us-ascii?Q?qmijdiRVfdE3CCN1pVv+7HqJIuHU86m6sMFj6LO+0LmuEw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rDU0UBJhAiQ41CD/jOEJ/KHphzw3olhgHSGqyN6WdV2mul1ujoqgtexlq4z1?= =?us-ascii?Q?kPp6kexsCzusCE43vcyOkvSXRaGmUcc0eosZGmAv0JZXQ083TNxv6sY9BxSj?= =?us-ascii?Q?J3DVUFVWgFPmmV1tfk9VGPHnw05FtALXnhmprBxZ5/SjNDm5NLOioVHbyKSZ?= =?us-ascii?Q?S4rauDbD6MgBQqo6hz8W1qmEY+i47V134eBwO9YBLdn+l+2AAjw5kxITQcaL?= =?us-ascii?Q?+rV5M/ARvgXGIudv3JkaKgK61teuhbK7dfEupjMXC40PNL+BUP8oYNn+hPqj?= =?us-ascii?Q?9TL5LfEdsOawtjm2Ak908Gb9/P7qg3s6QkBmQlBTkGw0TmFlpMRm9+gU9+Ui?= =?us-ascii?Q?2Ij/UJjkH4+faJj/y/QqPB66vXtHaLe/Aov9BOzL0tUdhy266nan5otWM01x?= =?us-ascii?Q?kaW3LI6yNk4aLykAk2OJPlR1Rjrl4+JXFfOki+Dusr4jJm/DSvYauiXIc9B1?= =?us-ascii?Q?Pnsow5NmOQt9r64jDGMxMZ1Bj2imVFkdi72uIE6BQaiMESYa601LxoMr7FaV?= =?us-ascii?Q?Ome7K6G9PGUrFYJ1xQ5jcwAqhQTgSl0Rt64nhIYOJiaDXMIeJrjOIuqy7KZL?= =?us-ascii?Q?vHgVjFdqT/JLVXeHrN926bhwb3DPdh2ER1wrt1kA7qoAT5bIq1AvXnQZs/S+?= =?us-ascii?Q?fgOeFokv+KENAhnxfM+K7ckuMDGwyv24Exrl2/Fpbig7RC8hpqKwHS2NteaF?= =?us-ascii?Q?AqvD0Q33uLZrXT6hOMIsK2EghOVgs0gMtyLdvCr7/mcRltKrV/w3fH+UJq6g?= =?us-ascii?Q?/Z1dH8+pgClhzM+Qi0LKHzoJmcDYywbnvahBcSzQJClC3l0JtLCrfNXNV3Cr?= =?us-ascii?Q?TZ8ZTrzTuXBgusR2NXX8ufyO0aTpaFM3i+9iP9o8yT7XStX6vg2Rj5gKE7Mt?= =?us-ascii?Q?1/JbcMvfjCb3qGa4jGPqkRoo15F0ane+84WD2+BHEJx1CBYz9ErbtUUrHqyM?= =?us-ascii?Q?FgXLpIbYAAx/o2IcnWlWXwY33yJoPKddI3Qm8fsoipxGG/HRi5pnL3belO7X?= =?us-ascii?Q?kpUyk0NG2lZgNfcEddcyOuzCtmKSbLh75WV/epJEseKB7ZGMjr5Ah1kdkmuL?= =?us-ascii?Q?cLSdraVGzrt9gvaHq2MUqVnvMuEO4VCQ0QGYxPbMERWhz8bnitg9/V83+oIw?= =?us-ascii?Q?zwH9ep8Tz9686iOX8Tpzq35pHDOKZl/Rv0PidVfpjUbFIMxCfjcsDp3+15EL?= =?us-ascii?Q?uPdQW74+B1qcJp3mxRc83ai6hOe5jnkoPUbgkF56X9cJcPefKSpFvPGbcuB7?= =?us-ascii?Q?15P7HNwn50VheSbxRHhJGMCcQCLnBFmZ9krwQi+Fwzofpkx5hBuyHIn7PZ15?= =?us-ascii?Q?rWm1aRQDwE29/DtgqH6HyPfPvlqkGZ7f0kM5Pb7Zf8sGtxXFGRwbi5VOp2/J?= =?us-ascii?Q?BU7HWlt0EofzRD0Tmbui5hT/suBzNPsDAqEFr/5FFypcNnS1+0M2vtOG3KBU?= =?us-ascii?Q?mCEseAnGgjeaVQva8KDNP8vI2YmDeHF7Jb+T2EBqZazKxBFb5aaHx5WI2mlX?= =?us-ascii?Q?Iw6NKixgDUrKQ380SMyDM03TitHFr8wjzPYrwXuPJfNouhSDZKRANraPCkMB?= =?us-ascii?Q?ZH/LguPgmHDBUs2zg0hUhyOjkw0e2TwSui1SorfiNYrEsD7/6VqW+/+MCPwD?= =?us-ascii?Q?hg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 50670da2-b546-4e1f-6c90-08dcc7772276 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2024 15:36:07.5454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k4a7ZRk1gFt9MfChj8N7ZCJ6In5/7RtKX296TBnF3MOcNdaCJx5okaSDD50sC5Rw2+lNn1PlpMRfpbWoqFO0l1oe/HUx27DWjqfXl9ZW0JA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7697 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 23, 2024 at 09:56:42AM +0000, Soumyadeep Hore wrote: > From: Jacob Keller > > The ice_get_pfa_module_tlv() function iterates over the Preserved Fields > Area to read data from the Shadow RAM, including the Part Board Assembly > data, among others. > > If the specific TLV being requested is not found in the current NVM, the > code will read past the end of the PFA, misinterpreting the last word of > the PFA and the word just after the PFA as another TLV. This typically > results in one extra iteration before the length check of the while loop is > triggered. > > Signed-off-by: Jacob Keller > Signed-off-by: Soumyadeep Hore > --- > drivers/net/ice/base/ice_nvm.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Took a bit of digging, but I believe this fixes this previous commit (with code being edited and moved a bit since then): Fixes: 5d0b7b5fc491 ("net/ice/base: add read PBA module function")