From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE46F457C1; Mon, 19 Aug 2024 14:01:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6106940267; Mon, 19 Aug 2024 14:01:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 976044014F for ; Mon, 19 Aug 2024 14:01:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724068893; x=1755604893; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=ZGdfbe+ZlanKptDKKozFHnGykfVdht25VQ5w5oynL6k=; b=KtouSf6nTOTzUTS9PxoToOEaeILuVxKwpePNrbhK+DySIiebZACZIdQg RKHtp9PgFZVMqGbFYb5Pv71jKKWKhLEbD8rJsMWjQDA3Qe1Xdf2GG/puq XwCtldJoRIB4mRb3F8uI5EiPf8KzLUXRKDanX1wTg7kZHYiFYaKkNAddB oQC8eGBNmK4LCp6jEfajalZXgdhHm7OlrjvzkGH7RvyYq+NEDDtkm/I/y xBxkZrPj716C/O+05bMye/DtLzMtlYsSJS6+780SEKliKbszIQ4fcHr/2 CQBLLfWFW57g7A2BIjqkFOsj/k6HTOJYftmbF89q0upN2QkwqCLXFiMLY g==; X-CSE-ConnectionGUID: 9phXsaAWTVaJeoRniF7ixg== X-CSE-MsgGUID: ScXQCkiAQPWfR628OicdXQ== X-IronPort-AV: E=McAfee;i="6700,10204,11168"; a="26177830" X-IronPort-AV: E=Sophos;i="6.10,159,1719903600"; d="scan'208";a="26177830" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2024 05:01:32 -0700 X-CSE-ConnectionGUID: MFPOE9DzRgOR228khNWOUA== X-CSE-MsgGUID: kY5vk9DuQ3yyJvm0Ecp/LQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,159,1719903600"; d="scan'208";a="61125249" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Aug 2024 05:01:33 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 19 Aug 2024 05:01:31 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 19 Aug 2024 05:01:31 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 19 Aug 2024 05:01:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fASk6tgVfvTU4p2fpcBRC+CtYgY+5Z+dxLXJHlBL6Nlmj3iHYLCfevb2a+HHR5+pDPDvRd2MMHvMXySlPfCnfOa0n03xHnSF69q5uc7RgNZAheaLiz+8Lo7nwu+4M3RLr/LEsGFdCagSGg2tnmM0T8j/C+HsPOZWEbAbDmmCJq61/G635Ds3P6YTeM65NXVKQjhxygTW2a3WkpzQEg6XtSpgeS4HRmvsOLm7Bi/pV0bU4+Rk8aL3jLjHxzQlhc0n/3MiIqMd00VQ0va6u/rT6m5HTeYUP9x0AfIhRfQ8sSd+OJBbrwT0sIwXQNHbKdv9LNt3P5Zeu0XbM/n5IiGkLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y7mKZnsPBOGAjLZFf+WE1clA8jlodeWcwVlzo1N04fM=; b=FfaZXwSO+icZYrZzKsT4kZo1yb25gMCOhcYzq+ag/UUSFOT6su9WPjiinxlv2uvEn6zQEjjf/3wOzHYIbGAX6D+t25Uz53t/yMGXDKJw4ckIlsJMuyLvCBT3bAuNjQB9/32UY4fnzOQL1cohKuXq6/TvN3TOYy1Ye4xVgnQNjTo63lV9lJto7fwjc4MArqe0sX1LYuk8D8Ud0F20Dejn0wNG+6UtqPerbmP8wdpUNtSMqAMwa3kDAnwfFCnIm1SAJQgGlaVO/9StGwTVX6dpTxPOlgQ3J5c1Fkj6coVGGJ80qvajbd75bKGhMvCo2t3hkSNk0JRplQ1metu8f7+I6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB8178.namprd11.prod.outlook.com (2603:10b6:8:18f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21; Mon, 19 Aug 2024 12:01:28 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7875.019; Mon, 19 Aug 2024 12:01:28 +0000 Date: Mon, 19 Aug 2024 13:01:24 +0100 From: Bruce Richardson To: Jerin Jacob CC: Ferruh Yigit , Adel Belkhiri , , Jerin Jacob Kollanukkaran Subject: Re: Ethdev tracepoints optimization Message-ID: References: <0cb77372-83b3-49f0-89bb-5c641e0522a6@amd.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0153.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bd::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB8178:EE_ X-MS-Office365-Filtering-Correlation-Id: 96109673-120f-4258-b2eb-08dcc046a86d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?S2RyazMwRHplM2w0T3BDcmZRWnNhWktjNUJ4ZDNTc1E2R2dUaUFOamhuL2NG?= =?utf-8?B?Z3NaU29iZ0NqQmJXSHlNbGhaZ0s3NnhqZHNPM3NiUjJjcldzMndPT3liT2Z0?= =?utf-8?B?dDlSR3RzYjVaY1VBcFdOR3JGN2FBRzB0eXpQWnlubUl1VTRvVkNyczdaZitK?= =?utf-8?B?YWVWbDNiYTR3cDhhQmdnK29GMTVJVk1TNU9kbktsUm52Qlc2VEtjWkxWUHVI?= =?utf-8?B?VW9PRXR6RGZIOFNVM1c1anVWWUdhZGd3MmFYcGdtd2U1RGppT0dnQVN2S0xw?= =?utf-8?B?N05MQWlnVkVRTkZ6R0VMN1BTTWVlSFRWMER6eE53YmZlZG5iQ2xqbnkxVit1?= =?utf-8?B?bjhxL2kzeFFteEVMdnU2TFZ5Ujg2WDBNbHF2UUlOcjNEQlNyQUYxNGNRZzJM?= =?utf-8?B?ZStPR0pXaGtVUm5DenYwenhZRDc4amxDM2Z3NnJFOFFaYWVRdVdiY3VpYlV1?= =?utf-8?B?emt3MU9mekJzeFp6OWVNZ1luRXZFK3BpTlczRWVid1BheSsxMG05aEJjeUZS?= =?utf-8?B?Z0lCQWVLNDBVTE82ZDhTQjJFdk5qU2drMFczWmJ4MC9WTEYyNDFpdCtKaUdl?= =?utf-8?B?UUFObXJzK2txbVU2VktucWJLYkltNFNibllwY2NWK2VrcDZXSG0zZnZmUWR4?= =?utf-8?B?L0tzWnBtblZaR1B3ZUJmQmFvcWtJY2pQdzV2b3o3M2Y5akF4VlNkTlFlV3R4?= =?utf-8?B?N01XTUlOTEo0ZXVtYzhRWjNSeFVGVHU2SGtHWGUwTUpVaGVXUzVXeTJWQkQ4?= =?utf-8?B?RGNONDVoN2xUcWFpb2pYSlpWeVdEQktlRVJnblZjYjdmV0JsbEpFTnY3K05W?= =?utf-8?B?UE9qZEJmSkZZdS90eVRUbG1xOVJQOGEvUi9EVWl1eUozYVNwdmJOR3VWc3hI?= =?utf-8?B?OWJOYTRMVE1SRWVIdVJDWi9tcnVSeGVGQXhHVWMrTTZnMHVIVG9ONGF1dzls?= =?utf-8?B?SGZKKzlMVGQwYUoxeEp0QVFLVkFVL0I4N3RtekoxUDdCcm5qMkFDSFpKN0Np?= =?utf-8?B?d1lTb3R4ZGh2T01ERWxyT1dvWEs4K0VvZ25TTTBKZ1JybGZwK3VSRGFKVEJV?= =?utf-8?B?V0N3czhZMjN0SWpBaGJGVWlJQVRlUWtKZUZtTTRqcWlsSjRHK1R3ODY4Znhp?= =?utf-8?B?NmhaWEhDSmF4K1Jkd0VSYTh1UkFlS1lpNUlkYTdCbTFDam5qdzk4UEs1dXBQ?= =?utf-8?B?V0VyVjdabTZiSGtYWEhnME9YdzcyQnlCOWcyY3RmWTdxcGxNT29LcDFmQnV0?= =?utf-8?B?bHpWQUtGTHBEdDNsYjJ5NWtNbWtyemJQU05CN253cHZuNmlZSW1XaDMzcWlU?= =?utf-8?B?ZXhwb25PYkpaaEJVa0VacXRkTUtnVCtoRXpYV3RSd001VlB2VHpEbmd5R1dG?= =?utf-8?B?WkZGOHhjaG9taG01ZXk3OHVwVDZHSkxSUzBCVzVWb09PMm85VmxlZU1pRTMr?= =?utf-8?B?VlNDbCtDNTdIUVNLQ05CcmNpeTlsQjd2Z3RwQmJJeVRqRTdLQVQzZVpBSWhN?= =?utf-8?B?VHJmRVJUM3NkMDQ3cFJPSlR5NlA5OENYQUpMZUJEZTlvRlZHMi9hcmIrVkRv?= =?utf-8?B?VFhRczl3Mlp1OUcvenZJeUY3ZHNnQ0J0TC9RWXlIdHRnNGFRVjhCS1c3eFlD?= =?utf-8?B?aEY2ZmFPYXdNZzhJRFl6T0VYN0w1M204cEZuQUM1cXdRNm5pTHV2RUlZVTlx?= =?utf-8?B?U1JSSkJjV3ZLaTYzdVc0L1hDbk5WVndINFFtNmZ6NVVoampCQmw0QjQwTEo2?= =?utf-8?B?UW1ENVRVRHBoWmZmWko1czBjUzlTZm5sRTVBZkp5b0pDbDl0V2lkb1hJR1F5?= =?utf-8?B?aDBDeXZSRlFPcjQvdjBFdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmd0U1EvSjE1a2lhRGFRWFZrQWJmWnhLWUw3ckJtYUpCQW1qVzQrQUtDaTA5?= =?utf-8?B?ZWNYc0VaaDRraWpSM0dmeTRyWG1BWGEzS3d1TUIyVVNQU2x0L0hUQTgxRDd2?= =?utf-8?B?NDdUTmFTL0ZaTkF1c0gxNW5hcStqcG4rYUpwZEQvZk1DQ05QZGpZbWFyVHpT?= =?utf-8?B?VXJ5SFJCUmdnanRpcVpaWFNCS2JldXJGWUJtYW1QcHJUU3hoQ056Z0lMU1Qz?= =?utf-8?B?azdYbHhic2JHcVl4TE1xRVlFQ3dWdER1VElvNU53emlXNGhPaHRaWU50eDFy?= =?utf-8?B?aFc5eFlkVFNYa0ljRWcwMGRwdGFRajkzbzJsYUNaMTBWamQ5MGF3WEJlQXdP?= =?utf-8?B?cWF3b1k1bXc4a1QzaWpYRkVLaVBVaHNPbnJqTTFpZHVGbDNMOWJIUnlXUkFs?= =?utf-8?B?b0Y2Z2pwa3YrdnFtT2wvNFlicG01U2JkdVFZVW5Eb21wUXFDa2NjYnVEelBR?= =?utf-8?B?UkRueVg4eFlZLzlTLzdtQWJuOFRjM0s2MTFsOS9qR3dnR1BhMWNNWWRqZm1o?= =?utf-8?B?alBYd3lWRFhWWURHWDZWQTBPdmZIeTB3T0xIR3Q0VnVNMmdkUkN3aU9uaG0y?= =?utf-8?B?Tnc2MmEyOWltQ3ZkeFQ4TzI5czM5SEIveVUwMFFJaHlqUVFXc1ZSa1hMT0Y2?= =?utf-8?B?U3I2QnR0UXl0d1oyL0dPVWRDV3ZMbFZaai9IZS9MTXJ1bDNXNU9LdHhIb3VP?= =?utf-8?B?S0lOVGUrQnY1VGFVL3VpZThPaUlubzBiZC9hR3ZtSVl1aFRyZUkvT0dEamJh?= =?utf-8?B?S3VTN2F0VVFlbzc2ZjFDTXlMOG1KQVFibmdvTUNDWVQ0bjhnMmtJV0xCaHR3?= =?utf-8?B?OTBleDVKRWFEQTVmZ0xmNjdKWTRiUThqSk1jbnRsVDFyR1BKWUdSVGI3SjMv?= =?utf-8?B?REJ5cHlHaHpxZVB4OHp4SXhSSXdmOVQyUTJMdmxKQWJkMEtrenJhQWhtcWZS?= =?utf-8?B?UitDTVVJUHNadWQ2SXpHYW5QYVJzdWVVS3duUE5iZmVGeFJLZVE4Mlo1NmJa?= =?utf-8?B?eUVQK1ZocHlUWkRHbEkzL3ZFY3FpWUNMYVJ0MU9yN0Y3NHloQ2RBUXdVa3kw?= =?utf-8?B?Slc5Y1A5SjZjcCtzOEsxMEZNQW8waTVwM3hzMWthVTFxemI3ZEZUY3BNbkw4?= =?utf-8?B?aC9taGo5MEtlaFNnVDhnMFBxVTZmNVJXMklvZmlhbzY3dS9YejA4VGloSWd6?= =?utf-8?B?ZEZ5VTB3enVFZklhMlkwaU9KZnVORmlGMjV0RjNKQmpkVjBSK2hEN2tmSHJs?= =?utf-8?B?aTNRcmcyZnpoNm1wanhGRUkzUFJuVGZOdVAzL1pNTEp2T0ptRk44dGxDc3Zq?= =?utf-8?B?WTQvNW15Ukt1TmQxR3NDUlFEQXNjYk1XRThZdmpDU3lTdTBiVVF5WlJTUGJ4?= =?utf-8?B?aHNyeGRiNmVSR2s0bEV0c2ZEeGxueXQ3Yjdvd2VSTVpqQXRXWjNqNnJwQ3Nx?= =?utf-8?B?K1VXdHdrcUN5U0VWTk5iVXk2ZGI4Wm8zZDFZcTNMd3h4MmRiZ3ZlbjZ2dnFJ?= =?utf-8?B?eTVNUkJTaGY3NSszR1ZFUlNzZlRoK05xZy94UGdGV3RDWmRMVDB6aWhNSjRu?= =?utf-8?B?dXYzbnBFb0luRE5FTXI5bGdxTjB4Y2JrKzRGTGN0R1I1cEd3U0dRbTVLZ3Qv?= =?utf-8?B?YlJ6cW1nR3VyVENUWFgwQm9kc3l5UUxmcXNObGppMUMvMGF6aTlxTmpxOXBn?= =?utf-8?B?bm5MYlRISnJ2U3MxY0lJOXJuUFZMWlBYOGlwVkgxVjNzdVl6ZU8zZEEweEFN?= =?utf-8?B?eHhHNEJnL3lsMm44RStoc1ZERDEvcTdzMlpqVDdCaFY3R3lIMEZFTTc3clo0?= =?utf-8?B?dmxJNHpKaHN5dmxLOXM4Y1g4M0RpZGdaWTVUNnJNelNlRHZselpjQ0hNODFp?= =?utf-8?B?anRWSW54Ni9JWHFyekpIU1hyUHErZVRZZnJ5VjhNbG9oODNKRkhaZ1hqV2ZJ?= =?utf-8?B?aWthejZobzAxS2tWMEFvcFROSWV4VVJEVk4rZXlSYnZsSnNuUnkyU1lVQjZo?= =?utf-8?B?MmhmeUhCVTNIZlozWUhtYmhGWXl3RnFvbmorNmpmZnk1ekNyLzAzME1jak4w?= =?utf-8?B?Z0YrejFRRTdEU2hQc3lGUjg0VWxOWG1wSjVGeGxZTWFvdUdSWmFQYU51R1lk?= =?utf-8?B?RUNGZ3Z4UUNYTXNNb3JaSTVqRlNaS0xqdjkyZjM2eCtNNWp6cTBDMnBud1JM?= =?utf-8?B?cXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 96109673-120f-4258-b2eb-08dcc046a86d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2024 12:01:28.7760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qgCTdtPV4xYM/cOycLu/KBUXQdPKthxzHY70zyWX8D6NLZjXcjpM9DGBuDt6Qb6bQ1U5d3zbJ045rg+WiVMY+U8dqYFAB5rxr/vTlL7gXSE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8178 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 19, 2024 at 05:07:18PM +0530, Jerin Jacob wrote: > On Mon, Aug 19, 2024 at 4:13 PM Ferruh Yigit wrote: > > > > On 8/15/2024 8:32 PM, Adel Belkhiri wrote: > > > Hi DPDK Community, > > > > > > I am currently working on developing performance analyses for > > > applications using the ethdev library. These analyses are being > > > implemented in Trace Compass, an open-source performance analyzer. One > > > of the views I’ve implemented shows the rate of traffic received or sent > > > by an ethernet port, measured in packets per second. However, I've > > > encountered an issue with the lib.ethdev.rx.burst event, which triggers > > > even when no packets are polled, leading to a significant number of > > > irrelevant events in the trace. This becomes problematic as these > > > "empty" events can overwhelm the tracer buffer, potentially causing the > > > loss of more critical events due to their high frequency. > > > > > > To address this, I've modified the DPDK code in lib/ethdev/rte_ethdev.h > > > to add a conditional statement that only triggers the event when nb_rx > > > > 0. My question to the community is whether there are use cases where an > > > "empty" lib.ethdev.rx.burst event could be useful. If not, would there > > > be interest in submitting a patch with this modification? > > > > > > > Tracepoint is good way to get frequency of the calls, so I believe there > > can be value of getting empty burst calls too. > > > > But your usecase also a valid one. I wonder if it works to have separate > > trace calls, for empty and non-empty ones, and how this additional > > branching impacts the performance, at least branch should be wrapped > > with 'RTE_ENABLE_TRACE_FP' macro to not impact non-tracing usage. > > > CTF(Common trace format) post processing tools can check the value for > each field and timestap. > So it will easy to skip the ones with no packet for this case. > The trouble with empty polls is that they are very, very fast, so if no traffic is arriving you can quickly fill your entire trace buffer with nothing but empty polls. I believe that is the situation the original poster wanted to avoid. /Bruce