From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A787145811; Mon, 19 Aug 2024 11:25:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D1404028A; Mon, 19 Aug 2024 11:25:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 54CFF40267 for ; Mon, 19 Aug 2024 11:25:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724059522; x=1755595522; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=+gcsq/WKw7jcyldSlE+4SiBsqjdHWQB9nyUGbVLFtt0=; b=iRBKYw60EUtvs+scVIIBPi+aqs3Zn65YR2PPXY1eN5TFzYl6uOBZfFsO GNDOzE8V5vBgMEOkGQ61a5EsG5SdE80Pa+N3vM8bxP1ZKSCKlC1YfBA1R Uvrx2zbTiCrINwfakJyPuhqHpHPR5eoih2zrL9cAlYdE2iXZnQ6Un//0/ HXGII9MvnhhP+9plHY71/ngv1JUGP2eUKnsF8CT2Uyt43ODQ8u7E0j+GB EF7g3WG+Q9fVn0CQyRqhb0CxdI3S4QLJaYerOJ3fOY8ooaUreeaUq46+d WGIQhEY/8RjMXa03eDWHuP/bfx4adcOzgAXBC6PW2lJnSTtYOEc6Znuar g==; X-CSE-ConnectionGUID: fxtiDyayRNmMfM+GjJNjOQ== X-CSE-MsgGUID: LzlcdM4/Q+K4Put0VslWFA== X-IronPort-AV: E=McAfee;i="6700,10204,11168"; a="32868036" X-IronPort-AV: E=Sophos;i="6.10,158,1719903600"; d="scan'208";a="32868036" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2024 02:25:21 -0700 X-CSE-ConnectionGUID: SuTj5EH+QeKwPHfEXNAB8w== X-CSE-MsgGUID: SiGZ13j0TGmzpW8n5wtExA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,158,1719903600"; d="scan'208";a="60153232" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Aug 2024 02:25:20 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 19 Aug 2024 02:25:20 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 19 Aug 2024 02:25:19 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 19 Aug 2024 02:25:19 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 19 Aug 2024 02:25:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y//0nf2tPdl4HL44ujuExWReSlH7LwNy/Q8cQTQmcgTY2KrkZrpqOMcj+50P/kQGsOMnIxy5KLSgUf8mnTuOeqWXyMbjT0cR4j1bGdrzXXmWz7VDnVL0Ovih6zm474DAKsFTHLJwotfAVDh2xTsHct73OaMCvDuJJee05p3lqDwRy7sSMkrnKCMt7FagVAXbQZk7bNHQoyjoFq7hK0pmU01PyEpVtIExg3oaAzs5op2ZSYQBZQW6fDCw7AsnMBqatqyP7s4jdLjON7F1kXOU47MFYahN4dXOgjU3V/c9SW5qyIx3EhOUEDJBhXDMDqiLnxU+uV44SBECWVth+FLXBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1nVZalRecuoPSVlJlF9lNqAwrxoxYmFvhgJCupp9y7M=; b=aWWK48zHeuTTNgCTaG8fBRLlmAhTM7n+IXFCR/4C8f1zHfupg+OJBHuG4sznJT9t50AhLl+BgvI4/NfcWwHRJYTvwFi6ZJ+c1DJWvfNRp5kNalvA5VkvgTqsiUaZq1epDth2lg9ibXqkPQcLky+Xt0djitmcalcyqvEQSOPQzruEgvcDSZgmNf69IMxLdGQvIjv9xru/GyhD6WajhdNH08sz6aZHiYAegJPz8hX2gjBXuuixX/ezlSM7/j0MvCplQsnjuLlER5aea+A7FTcx6KzBKsd+bflwSN2SIxOAzefH5MUNwlx4zthmQWkQ/GOO7AJvR8nK2OoH7WNYN3gsdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB6038.namprd11.prod.outlook.com (2603:10b6:8:75::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21; Mon, 19 Aug 2024 09:25:17 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7875.019; Mon, 19 Aug 2024 09:25:17 +0000 Date: Mon, 19 Aug 2024 10:25:13 +0100 From: Bruce Richardson To: Adel Belkhiri CC: Subject: Re: Ethdev tracepoints optimization Message-ID: References: Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8P191CA0025.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::35) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB6038:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ade59c8-c6c2-43d8-846e-08dcc030d6f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bkVXNDhCZFFoNkJtQzBiRFVzcWlIVHRBa2pSQVN0UWs4RDVxRHQ5U0VtWlBp?= =?utf-8?B?TVh2U1BFMVRWY0w2djUreE8zZjAwNm5pNCttOENZend0a3pMcmdXeXdWOHhM?= =?utf-8?B?akdVZjdCa0p3amdCVHdEcENaVzhvZExQVnNyTVBjOWpRWjNzeHdETTdHNkJz?= =?utf-8?B?S285cWdBdTFMTERGd2JBanpkcE9oblVWUm0rMllqbU9TQkNNZlpBRFE5YUdX?= =?utf-8?B?WjRId2FhMFBNV3NVQ05IeGUrUXF6cTB6SThZTm9mSDBZU01BMnc5aEM1b3hF?= =?utf-8?B?OFlpMUNsNTJzUm9XbUdyQ1JlSmhBTlhiU0J3UzdpakppbDdZQ2JONy9OVC9w?= =?utf-8?B?dlZKZ3ZrYTZEZEVlQ0JPSWErWGF1Mjdla1VBV1R4NGZXQitHa2puc1dvRUpF?= =?utf-8?B?L0J4U1pCeWJsclFjUTdHY3RaL1diRWpKUzgvM3YwK2JMbjF1RFNCcmJmSnBJ?= =?utf-8?B?RzJGR0Zqc1ZiY25kaXBveTROemVtZHg3VmhYL1ZlcTQ1TGtUeS9xMFgrTHIw?= =?utf-8?B?dWdhejN4ZlcxYnRXeENscGFXNWdDR2xid2lVMTNnYWlBVnRzTCtRd3dUNUZH?= =?utf-8?B?QXFuMWh3L3V4YVZ6SkhzTW5oNEdJbWIvOUE2aVEwZ0xheEFZYWVEMGlHWURp?= =?utf-8?B?UThGZm5KZ2VEaSs4QUVxUFNERElXblRGMkNRdGRnOUUzZk5PdVRsR0RpMXN4?= =?utf-8?B?QWxYSTJLbGFqRllybU8zeS9OUERvMWdHS0JKNkd1MDVrczNUL08zOEdjb0I4?= =?utf-8?B?VEl2dzBXTGhDak5uUTBhNnBJWHpHbU9KeEdpNmJQS2VSTXBlS0JYY2FuanZw?= =?utf-8?B?MDEvVXJabFdOV0szUUl0ZVN2TkthampYSkw4azRGeGF2TXI1VjNFK2dzU1Zk?= =?utf-8?B?ZFBPd2JITWRaMkM0REs4QWdTeEhwcUROWkNmSCtId0ZuQWl6aVQrTWQ3cDVS?= =?utf-8?B?a1lNbDU2R0t6K3pFQVpJb2JrQ25lMnJlSGZ2czE3N05ZYW5uQUY3TjVyRExw?= =?utf-8?B?SWlpOTRTNlhha2lrMzdrZ0F3dHBzYkMyWjBoNVNaQlpHNTB0TU5heHY4YkNq?= =?utf-8?B?RFpvd2gwT1ByWW55YjZyd05WRnRUSWp5NHpETkhWOXQ3M0pDMlBlalZKNm1E?= =?utf-8?B?WGJIaUk3c2R4UFBjeXcrSmovWFd6eVVXenZnWFFTYUVNbTk1a0F0RzE5Q0dy?= =?utf-8?B?Tk9ESG9MUThBdlA4ZmV2MFE1aWREVEcwcGR0UEhxeVU5ZS9OSVRJaVV6MFc4?= =?utf-8?B?RzJmMGdwR2N4ZGtWaHN4ZFpMOHdUbEUvRkxXaTNNYUF6VUk5RlRrTkV0c1Ba?= =?utf-8?B?aGpRUUFVMVpKY1M2MEhnelFJUlB3TC9UMGVJbnFxQUplRUdFZTZiS2dIZDY4?= =?utf-8?B?dEp5Y1p4V2VLQ05VNVZXeGZPZHlkaDU0QXBIOUNqdUtuWXoyUVErSTA1eGZp?= =?utf-8?B?K245d0lJS3BWcHBUOGdZREZoamlQeTZoMlF2UnlFMUNSVEdWWnU0QUdOVnJQ?= =?utf-8?B?OW5sRWhESTVXcTdSbk81UkJQVXdTSXlLSEdoQTk4ZC8wK254SC9FOE5vbTdx?= =?utf-8?B?aUpXbTYzMmUvRnBOOWpOKzhVZnN4cVdZSStsZjM3SUg3ekYrM2RGTEJselNT?= =?utf-8?B?TmUvQ0xGWk8vQ0dORGhZc1B4ZDR0bmtuWk53UUkyRDBLWm9FMy8rRGkyMm44?= =?utf-8?B?NWN5dU9xRlhadWI4aXFzTTd0NlJnQUptZ2VndHBOT091cmhwV1R0U1IweGZE?= =?utf-8?B?UWMzT2dpZHJDMElJUUdyVnYxVEhJeGdSNEtqSUpQNDByRnlCaE9PZGpCSGx5?= =?utf-8?B?cWJYTlR0OG5LdXozQkFsUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aG9TQTA4R1dUMUxHVEdMYXU3TU9zNmxwc0JCdlBBSjBIdWZjSnhBRmYrS0RG?= =?utf-8?B?enp0MThESmhYOHMwUGtLdXlscFhBRGQyb2RDZXB0YzVESCt2SjBjRk1jbE9m?= =?utf-8?B?dXRPclgrQlN0OFRobjYyWVdHeG5DTVFJZ2lYMFRqY0paZWRNZDd0MWdMYk1K?= =?utf-8?B?dmZGWEJlcVdRbS9UdjZ3eFVIQ2lmWDlDb3lGUVphTEErYlJFUmhyeHIweEFQ?= =?utf-8?B?ZXcvNk5EZ01QK3c0dGRkRXhSaFR3NTE2MFhEakxXS3E3MFRSbFNRWnp6ZGFj?= =?utf-8?B?K3grUEpueG1xcWxhKzZIMlVuMkNRSUxnYWgrblJzR05mZVdxRXA1VWU1YjQ4?= =?utf-8?B?TGc4TlZ1SVBPR3NkWXczam5QdFFnaGVtZGhjckFmTHBMTFd2U2gxVnEwWURP?= =?utf-8?B?dUxkYlNMSlE2T2lnMmVTM2F4MTlBK1BrRkhNcCt4c0FnUENUYVhvY3I4S2RG?= =?utf-8?B?VlJqVGYxTFlQYW9VaWRPS2MrR3ZGZ2U4MVVzNzdkM29XZzQwdjlLQ1dGZXNV?= =?utf-8?B?aWFGMlV2Q1V1eHd3VENRK3ZvbHVZYzFqeDd2cWhISXhsQld3c3ZJUk41bml0?= =?utf-8?B?eWFHekVUbis5TEhLKzBEYnNUZVFJNlE4RzZRZkg0cWQ3NjFJLzBzVW1qVU9q?= =?utf-8?B?ZlZUQ0xWa3F4Umdxc2k0aVJXNWNnRklUL1AwZUhZczBZbUttcDVuQy90RmVW?= =?utf-8?B?NUF6OG5QT21DYlhJVTZWZUYwQzBjelVnU1NBYWdBVXNJRWVUZFhaaTRET2xV?= =?utf-8?B?TWd4NEZiMmwvbW5hOHNvNEFaQzBqU0hYWERoTmFYZm01eCtMcmtsWnY1aWVo?= =?utf-8?B?UEZhRkdBSDg2RGNOZWxwWFlFWWFTUG9odnhEbVlBS3pKaFJDbGtUdGFSd0V5?= =?utf-8?B?bmhkNlZ1bUcxS1RvcWp1cTBhYUs4aE1HM25BcFhDSjlWeTRSMmVpbEZlUFA4?= =?utf-8?B?eTZ4NjcwR0FxalJHOXVuMVhtQjgrTWV4YVhIZHNXZlJDYTBCZXFqRUlQWHlx?= =?utf-8?B?eVViS2VJelcvQ0hmN04vTVJGUFpvZkMwSG9KMVhVU0RESEJrdkF5OVJ2VjRZ?= =?utf-8?B?TTllR0JxYXZjRWlxOFoxZGcvbUJYQSszZ1VGelM1Zml4eXFCczFnTzYwR1M1?= =?utf-8?B?NmUrMDg5SDNvdjNBNUJNc3dMRTU1c1lhNE40Y29pQ0pTa1hBeHhubmoycEp6?= =?utf-8?B?ZFY0M1BZUTJIN1Y4eXUxTG9PTmM5aTZ2SDFWY0gvKzZ5eC9aa0hqVEV3S2hq?= =?utf-8?B?SGpzNExRYmplcGM0dlFUQjU2YjVUdGEyUXR6OWFXTFFFbDhycVUrZGJXTEdt?= =?utf-8?B?WUZPME10OFcvYW8yRUdmTFY3NU83MjNFR0FjcFZxajNSRzlCSEV6ZWFnb1RF?= =?utf-8?B?VXIxRm5IbmlDc3FZeWc1eitZN0d0MGRleVh1aHlRdVgxdmFvVEZEUXRUZW81?= =?utf-8?B?RjNhK1h3ZEhhR1ZLWG5LZFcxME9qVXk1QmhMZjJhUGo3a00wY0dpU2RaUDMr?= =?utf-8?B?bk10eEEvRDkwald5U3E0eEJpUHhpU0hueTRwWDA2RElGR2ZYTjM1SzJrWFJO?= =?utf-8?B?R2RobGsxSm9FajRkTE8zNHYvUTJVM2ZEZTRTTm0zN05pcm9WL3hCYThzK0dJ?= =?utf-8?B?SHZheEQvZ1M4ZXRXUmdvQjFSbWFJenpyRUk2SjNFdDYrVXAweVVNYkhrVGN3?= =?utf-8?B?VERNNlpFSDl3a2tCNStaZStBaHBqbEdSTXZMTkFsSm90VmJFTS9wVjBIUXBC?= =?utf-8?B?dUYvZVdSNGQrU1BreFl1TjVjbUV5Z1k2MHVFNTR0SzE5N0ZFL2p4dVd2cEEv?= =?utf-8?B?MEdjaXZJSzVtZ3BxbVlzTjVnMTcxdVhFUzk4OWlKbWlCYWMvNUdNWFozSUcw?= =?utf-8?B?WG0zTm5OMWVGY3pCTGpTVWU2Q0pXZG8zbVFSVmZ2YUkzU0lyYmJrOGM1eXV4?= =?utf-8?B?aTkyNkhQVU5VZUtsM2RzeE1RQWlGNXJPdnBURkh1MVVIUlFES2V2bFVUdzBY?= =?utf-8?B?YXpMNHhVN3BMSEw1MGRMeXR5dEZGTlVnTlpwNzRGTDJNZ3lxWW9qbDFLSHQ4?= =?utf-8?B?Y1YvSDZRV0VRL1NWZkVxWnFhUHphOXY3eHhCa0hHS0RmWEdheHRFaFJQR0p3?= =?utf-8?B?REh3TFIxRXFzWjdRaURvRm5yQzVzejFqVTZ2bXpUTzNaWkdFRWljdllhSjNS?= =?utf-8?B?WlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7ade59c8-c6c2-43d8-846e-08dcc030d6f5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2024 09:25:17.9037 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k9ZbTGlqrVYmoyh3mGGB5aqOOFapZn3oUf0fEwoipg93Ca8xHSY/Lf/mnCBc/B4SFgazJNss9w+wrzxJ2bux91rVeVMFSQx8OBIRWtO+atA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6038 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 15, 2024 at 03:32:50PM -0400, Adel Belkhiri wrote: > Hi DPDK Community, > I am currently working on developing performance analyses for > applications using the ethdev library. These analyses are being > implemented in Trace Compass, an open-source performance analyzer. One > of the views I’ve implemented shows the rate of traffic received or > sent by an ethernet port, measured in packets per second. However, I've > encountered an issue with the lib.ethdev.rx.burst event, which triggers > even when no packets are polled, leading to a significant number of > irrelevant events in the trace. This becomes problematic as these > "empty" events can overwhelm the tracer buffer, potentially causing the > loss of more critical events due to their high frequency. > To address this, I've modified the DPDK code in lib/ethdev/rte_ethdev.h > to add a conditional statement that only triggers the event when nb_rx > > 0. My question to the community is whether there are use cases where > an "empty" lib.ethdev.rx.burst event could be useful. If not, would > there be interest in submitting a patch with this modification? Yes, there probably would be, but also likely not in such a simple form. I think there is value in tracing around empty polls too, but only in such a way not to overflow the trace buffer. My suggestion would be to trace the first empty poll only, but suppress any polls thereafter. That way we can know that there are empty polls rather than no calls. An even better solution - though I don't know enough about how the tracing works to know if it's possible - is to match that initial empty poll trace with some sort of trace output when the empty polls stop, i.e. we get traffic, recording the number of empty polls received as a count value. My 2c. /Bruce