From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEB4B45847; Thu, 22 Aug 2024 16:46:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C9F542E52; Thu, 22 Aug 2024 16:46:12 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 785F14027A for ; Thu, 22 Aug 2024 16:46:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724337971; x=1755873971; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=lhBiFoJ8krWIOWos8+WEAvF8l2fqwpWdNd842IXf7Ls=; b=C7bmMM2W06Kqmgfol7tuCu0W/zsdtHzRwWEP4mFoMAzsE7XYk1xqUa0t cfxqkDYq/k2gIOOAjtH/aE9gFRlMa/AgiQ4jcTBhnVLrK9Ql3qj0x5eHH 9I+1TF74kKjFlQCeEcuG8HHGQQ6CIT/FBpP1YiL7IofckVK6LjX62IowM u2N9h91ecK1MEY8yJEa4XNPgoHUa7ueCeidUowKiPkCMAS8FTRvKzhV5x 9vtxnG+QU1f4PXu36KEqteBlTyqE/OeEzVpU3rQ6EE34l6vyyvlrNBexO GSlJfZz5EQD3uS1BCUuoehgh5Qu2yPj3RGqt9yVRKb00PdtJSwp277STh Q==; X-CSE-ConnectionGUID: /razno/CQOuXNKWJE8Z9xA== X-CSE-MsgGUID: gIHahtV7TSqiqwNoYO/M9A== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="26508911" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="26508911" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 07:45:54 -0700 X-CSE-ConnectionGUID: BnTXV99jTkaUcYkJNr8vQA== X-CSE-MsgGUID: mUlEbgOiQZ2hEbgB3xmN4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="62005631" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Aug 2024 07:45:54 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 22 Aug 2024 07:45:53 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 22 Aug 2024 07:45:53 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 22 Aug 2024 07:45:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KGQau8G138dLCtXnC7H2IVNLzIwbSAo0r9bndhEYS9CjEWL/sYrWUrKbif+IiPQe6CMv+Vsg0reYzBrLC7z/X+AwNSVccIExSKWjLPjvTfbezLq1wVv9VrTR7TsAs19nCQxCY7g89Dgdh5zWbUXLCaJRvqmhbpQal7v5T+K6nn+UNcil8n44D9xudci6NHAYIIB9nneUY6gmprZ/j7ccrRea4mj3g3X7Xm/GdfQUEi21kSR7y1zSdYHFAdP6Duf3xQe30K++d17i6j5WXkyyK2OrwqJ0bJUbsKECGP8L+N/ItsNUZ3dD1h1lBVLXf2dyOaD+UxtBaMDs4qNqK8+IKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ITVyi74xMmPcIbZ9GU4M5ydLPh/V+ycqMmknInCREq4=; b=UTq9WBO+kZTHfuB8V7CE/e8qwiE9hNz7CYcnYd5a05YF0Ka8FoGrKjqwROpdSrOKiLWqPHEs1gk6D3pintbCHSyglqTq59gtxnDVO2sC7HOM2jo69uQfPg09pKH3YGwVmZv894Q0jn/VLkBx5bCOM7DAqWqPck22XkxAqdxMSA9nBZ7ZDYbVRnb7h5oQllZSfVLZaFQEhb27d2rGCyppOnhNxupstIsGKmtbpggIKJMWwKn9GBSyD+jhQPD1I/gtIMsyC+sfoZnpIT/MjgMz23Nl/CRT02Q8MzjJGnOSxeO/g6/s8JSqu0ixMz9OFJpr8q4cDeUllmVcL7iYNwIa+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY5PR11MB6211.namprd11.prod.outlook.com (2603:10b6:930:25::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.32; Thu, 22 Aug 2024 14:45:51 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7897.014; Thu, 22 Aug 2024 14:45:51 +0000 Date: Thu, 22 Aug 2024 15:45:45 +0100 From: Bruce Richardson To: Soumyadeep Hore CC: , , , Subject: Re: [PATCH v1 08/12] net/ice: update iteration of TLVs in Preserved Fields Area Message-ID: References: <20240822095612.216214-1-soumyadeep.hore@intel.com> <20240822095612.216214-9-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240822095612.216214-9-soumyadeep.hore@intel.com> X-ClientProxiedBy: DBBPR09CA0002.eurprd09.prod.outlook.com (2603:10a6:10:c0::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY5PR11MB6211:EE_ X-MS-Office365-Filtering-Correlation-Id: bad13173-94cd-4b58-e342-08dcc2b91e23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?NPNOHJcUH0/p0W5ZgsXTIB3+KjSOsPo+1MspSZb0QCsWld6tSupf3Hrt1dDJ?= =?us-ascii?Q?XgY7/Fn3GdnWBuVaVPhPEOe/I/2iX1NKFnhORxSZx/uaKpOTjZ4CwWBIrEXG?= =?us-ascii?Q?3zEidyQmqwfGMeiyF1qJRCjCgwk32YxxitjZY1gQWmdy75IoE3/CLqJVUarM?= =?us-ascii?Q?lx+78DmwwJf8D0rZZ7ROKj9gQP6OmcUy0evpNi9Kq9qYSaVfZqlB+pq0ge8O?= =?us-ascii?Q?27SMrOxSDYrGGDSqBLmGqZ18jbVVLoWmW+Sbu7Ime0GnDqAa0tB/ej2O+NPE?= =?us-ascii?Q?x/ozMqgrcUow+ErO0Icdb4FIIxOdkLmQY8H0xy1GjLdzWo4XaVh5XTz7ax9n?= =?us-ascii?Q?qfjYa4gEdtluA1AWhocyEFP66l9NEFX7k3bwslaWz38qIJ9EU6037yqnb3vw?= =?us-ascii?Q?L0acl5VMV+BRMyi9CX3JQBFJs+Fgj415YhyFkd5UuT0vIceB0PIUVn+3qBwd?= =?us-ascii?Q?qwXzbe4yfrZgO8umhgI2ejmM0gvs24m28cQQNdZVZEWYsndAgdGKr2wT4Ys8?= =?us-ascii?Q?HpqDpMeV9+Ds3ucBJP82/EWN26wsC4THfviH+hWwuHDyYNwirVCaQWxk2rnj?= =?us-ascii?Q?09Twc8z4Ulo6G/rJQUY4sssnNpmuXvtedgFyP6KvzdmbWOjJHXCY52a5B3R1?= =?us-ascii?Q?1MC3eosZDMFHCkbHCoTGQJ4i26Kh8FcFxykoynrw+LwAS1RwgoUNpjim+8Nn?= =?us-ascii?Q?Zh+QIXRjpABBtlAmYScXn+wGUdaRv+1bvNXV1yJuwebTUGr24HodG52v5Xoc?= =?us-ascii?Q?dlY53Ke6iH989a6KnKp5G2fTjV2CBtrtl/6y/GWKkRZcqU/xQ7+XlI30sUfD?= =?us-ascii?Q?znsMyYeYMlf4lIf5dPzjM7co82PHEJBoPd+d4HgNqWOmu1gGN0zulla+ld/n?= =?us-ascii?Q?F5BtyKfqUUb6hG5QjG6bUU+aNJaAhQt6vDOuVEBX/UJLdklNrwmmbKAaekt+?= =?us-ascii?Q?XImc0ITYNrm4CLTfiQtANdmIxkeW0DqUkPqj2VafuJkqKOv2K04Sie+eQ4gI?= =?us-ascii?Q?FPnqvYFmFPq0fr+QwYFAaai1KSoY5QUuTZNkBGbK1Bmtt1iGbQqUnVFb1GXQ?= =?us-ascii?Q?pN1qQKGIqmeBpEoOp0hxIZkoLa1fz+728f/gH54B/cXSvH0u2tJj9cvrBfQN?= =?us-ascii?Q?CjjtudQa8AiUnKXxek/aSYJBu+RoQ7bhKQSGBmJFAfEShR+QUyJmpy27JDsO?= =?us-ascii?Q?hknVQYV5j+BGDK/DCRX9zFeua+FVTVS3p/pSrE1YTXJELQHsq88qFHV/VY48?= =?us-ascii?Q?n6EMDYGsVFsp/ckgWrTmyeJxoNyPkfaIqTJdjAnad7QPzsYnNeXAkPxOpGw6?= =?us-ascii?Q?xxrULgR2HrYTmJndASH7RZ4xAML9qDGAlE0UNJRNnuGk+Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SH8R4/VzZYKRuecRHNlA0RHy6Z24UHHwv9KnDJA97iDK5Ms8Oe2IY00rwZHo?= =?us-ascii?Q?NiZbTFbugLJ629hAy0Er2gRIp8sts8c8NrLA213ulRjuxMjd9p7i9GWyIztc?= =?us-ascii?Q?RSFojahL+DXAGRGTR1vX4/qhojL86mO0W1Fn4wuXnAGvKyTR9PfuI3ymIxeW?= =?us-ascii?Q?+PU1fEw0LQNC1WvXwTWmMpI6T/IqjnWJfQ+ZC1ogYXbU6gCbojicSHxLia9U?= =?us-ascii?Q?4yN1gSxKgka9kl2ZjMYx5GJYgexQOUbW4ktR1koA3IDGKREPjZhAT7jZPaNT?= =?us-ascii?Q?3qGXruZccosZ8rSCPH1Rptj8GE/TscmCiqnUc56fN9qkJVDpI9g21bBfl24J?= =?us-ascii?Q?pp0SS6AuvAUYbyOgaeWvB69uUMrgyDwW2F5x1iHCd/gsKTXG8F7hLIijjhXt?= =?us-ascii?Q?dS+tPF0DayvS/2m5MeHyJHIcy+Zv7odGQeywAjG/vY+ux8MXu10lvNsYT7yL?= =?us-ascii?Q?Wdlz2Qym6ozowarXaz/cFYTHSiAItRB8J0uHX2tpYUeKGAKY9gHDQxWLxPHs?= =?us-ascii?Q?89D5995XT6CbiyGUXxcwECDGh9FQXLhMrBn3fLvO2UdeO5uvHx0CXl5VBLFK?= =?us-ascii?Q?Ee6MSs++grIvJ1YoPA0yzlLGNPrsaGMV1Hcn2ql3dtbgJzld3FRrdIHF9q1C?= =?us-ascii?Q?RltrZI9PKyP45XFgkUcqJQGUoWMzAsXDMAZZcq400uhXLmyM2TZ43JWzDxS0?= =?us-ascii?Q?UOLn9+wYno8jRgqhVcPEpHJx5s3LO5aVpc07TZm6Oe1AeZUj9q25yPbyHota?= =?us-ascii?Q?M52SDGJUshNcg5OgSOQhd8+n9xQGasLYZiVA5E6P2EVpnXXqtDQuSizd7ntC?= =?us-ascii?Q?+16jQSFdcc4WoC47vesf75fQzzDbSXmikE0lrNfxfT6nY8J/tOxcRE34ikWz?= =?us-ascii?Q?nLS5CYAPt6sEdE2mPGz15IVgmxXsXdhEAJJBYfAJ2MXq9WtAMsTNcCEss1Tw?= =?us-ascii?Q?6yJqoVG+zRkciWmAwxBOiZvhqYWh9JpXKGb7YJg54AzZBt83W5/k8o6bTzGY?= =?us-ascii?Q?ecljo4lqSJrsa2x+Ko53DdLAIQUKiNQHpRLgV41hqzkXBSKfthRgoWTzy4xw?= =?us-ascii?Q?w2f2jFKOAw45KYHk8xAjy5Jdw2ZEkA89WE9pAgk/YxRGpeUmCfQUqXtArE4P?= =?us-ascii?Q?EfsX1VFAxIwbu9vMet7CRlY+2pdUrX22yGPvaE+6prcc4/DHYADti8PWQWom?= =?us-ascii?Q?/B28a5MR2WqDHKweSBfFEcpET4DQ2Cb0VJ7yKUiDBs0uBV+XolRRnjuo2rUF?= =?us-ascii?Q?Yogwb/i1nDd/gzlG9q9niJxon1Pzj2d9Ic3izK/VGYgFp8EA/FYPOvxMMqwG?= =?us-ascii?Q?0v34ZCIwULEgIEYXZdz0TRQfPTUdk1E+BjpidMg3PtAWJY7VjsrQgkZ5KcG0?= =?us-ascii?Q?PbZLVnDwy4ugRgc6/C14dOUQwnCVi61Um3yv2AihrW+KoYM5iXw82TRSe1jr?= =?us-ascii?Q?l6qsd/80eaUpxXvlrLgeb3TqXJw71lkDAGMVYV+yiyHfiWGUPMx2wtIhnCFW?= =?us-ascii?Q?NPsv3xGuG6R1P6qLNwArDRd7iFNLo6fGJlRB7OO1lN3L+4ioSaBkkE32b/Cn?= =?us-ascii?Q?oU0yzvzeJ5xNR+ROcMQ8mqsMSoYxe6yZGU2wYWKFHNkQZb1xnswr+Ron2MYB?= =?us-ascii?Q?zQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bad13173-94cd-4b58-e342-08dcc2b91e23 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2024 14:45:51.1280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iGwEA6GxNrn1F2mf4B1JctaO3yNNBmuBHxFV6S5nzTBlOIyUpnI5NHBlI53y/PEullWwj1d3sP+jibX1nkKhl6ilPfmgRI7kzCcMymtMxJ0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6211 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 22, 2024 at 09:56:08AM +0000, Soumyadeep Hore wrote: > Correct the logic for determining the maximum PFA offset to include the > extra last word. Additionally, make the driver robust against overflows > by using check_add_overflow. This ensures that even if the NVM > provides bogus data, the driver will not overflow, and will instead log > a useful warning message. The check for whether the TLV length exceeds the > PFA length is also removed, in favor of relying on the overflow warning > instead. > > Signed-off-by: Soumyadeep Hore > --- Is this related to patch 4 of this set? Should they be merged or are they solving different issues?