From: Bruce Richardson <bruce.richardson@intel.com>
To: Jun Wang <junwang01@cestc.cn>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v1] net/e1000: do not update link status in secondary process
Date: Thu, 22 Aug 2024 16:58:59 +0100 [thread overview]
Message-ID: <ZsdgQ5tR3n8I8PbZ@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <1720783847-12292-1-git-send-email-junwang01@cestc.cn>
On Fri, Jul 12, 2024 at 07:30:47PM +0800, Jun Wang wrote:
> The code to update link status is not safe in secondary process.
> If called from secondary it will crash, example from dumpcap:
> eth_em_link_update
>
> Signed-off-by: Jun Wang <junwang01@cestc.cn>
> ---
> drivers/net/e1000/em_ethdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Given this is fixing an issue experienced in the real-world I think we
should take this patch. As Stephen says, a better solution would be to have
the whole function work properly in secondary, but I'd rather avoid crashes
as a priority.
Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)")
Cc: stable@dpdk.org
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2024-08-22 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 11:30 Jun Wang
2024-07-12 17:17 ` Stephen Hemminger
2024-07-14 8:26 ` Jun Wang
2024-07-22 17:08 ` Bruce Richardson
2024-07-23 2:07 ` Jun Wang
2024-08-22 15:58 ` Bruce Richardson [this message]
2024-08-22 16:02 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsdgQ5tR3n8I8PbZ@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=junwang01@cestc.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).