From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7B4745847; Thu, 22 Aug 2024 17:59:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75BC342EE3; Thu, 22 Aug 2024 17:59:11 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id C7ADB42E52 for ; Thu, 22 Aug 2024 17:59:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724342350; x=1755878350; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=KHnoS1oyPvKaZgmi75bIompmpiCIaK+ABOW/FXMa6xU=; b=QkJ2pJN7neBvtNM7DUGcJuTAwAl1g9v9PJnmi+FJ7g6Z6iZ5iCwmzCvE DFSod0TlnevabiFlLcKtu2IfeKAIlFAeFTH5qkXzq4zxWhoyCi0sBKwd/ 8iG9N6A1Ah7fkO10H60OtdfIEqidRHbUZukpbTy/1DkEuvnhK/P5ePLN+ S4HQV7gBNMUlOcjHN3tC56bijB2TbMl4a8nFEmcsE2GELWDL59ElovPRV BqapB7Nil0zABBYlciH17bdENsmAQba4T93Iw8FTB8JuATJsz/tnkG++i wbCJULxdd1ogCS3aJUwRchkeDo/Vv/WVhAgoXNlOJP+wZdW7NZeNDahuA g==; X-CSE-ConnectionGUID: woIwn8hWRFawX307944vSA== X-CSE-MsgGUID: ggZG02gvRpiyyRV+ReAQfQ== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="40280358" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="40280358" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 08:59:09 -0700 X-CSE-ConnectionGUID: M+lL38GLT5m+vycYYuUP2Q== X-CSE-MsgGUID: AkMx/BMcSq2AGKlQt2hf1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="61637789" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Aug 2024 08:59:08 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 22 Aug 2024 08:59:08 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 22 Aug 2024 08:59:08 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 22 Aug 2024 08:59:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zHosels79WSovAdt+23086+eiv5g9nRl8buzd047qZRSTBx4w3RkinU2re2tyl3/zxmz4qXWK1rlA39jvC93NcM8RuaVh4b4QeJEFrhR5f/xXKD8j7+z0lcGDytWpLWCRdI7i/ulGqFKm+iK/6xgli7a72lNqqlqqNUHSDGRz2bJP81P/EoOpBFc3VwTwN3yJuUWj3ZiPLggtBgL24kUoaGlIZJbkhPJEu57WmFhxVLCgpKRXZlACshSNiME8eLznbE6FI6fi+/otjwFm8e2rGog5zJ4huv8rD/snSZQqgTTOSCpJjHa7B/eDrJYaXSPWQ4J+reaQApRw2LDkqRjlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U8QDdhwwX+V8JIWDb6RFnEke5TKF6rFmTGqBIW2AidA=; b=JHNR/w/Xzzx7+Rw5917DlMFQ2WI/6crHHOJmDL1peIcj/fx7kz/sYcLt5m74eFc+pUBd661BGTNg2ZSTgT6uiigEk2SbqdKHFi2ikWuiUNkP1P2uWH7Mo5xftFmKVL0qRbGLDIzRdehLv50uHY0nk+utTPDJ+6p8IDkhOYiB0j7JTbVyprl8/OAFRBGTqgaByZG6kOLRsL7E0USyMIBk9O0gr4aeWEPdXACvOH5rVlUveYepryagwHvk1I2XcLpiEyWfm/9kGxqGvNnnakKwZV7H/mj7/bSObOXnBHMKWmW1Y2xOvrywa+WDIBf4JwYJ0SZyVRb8jaRJVC2NYM1aHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN6PR11MB8193.namprd11.prod.outlook.com (2603:10b6:208:47a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.19; Thu, 22 Aug 2024 15:59:05 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7897.014; Thu, 22 Aug 2024 15:59:05 +0000 Date: Thu, 22 Aug 2024 16:58:59 +0100 From: Bruce Richardson To: Jun Wang CC: Subject: Re: [PATCH v1] net/e1000: do not update link status in secondary process Message-ID: References: <1720783847-12292-1-git-send-email-junwang01@cestc.cn> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1720783847-12292-1-git-send-email-junwang01@cestc.cn> X-ClientProxiedBy: DUZPR01CA0103.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN6PR11MB8193:EE_ X-MS-Office365-Filtering-Correlation-Id: df736707-fabc-489f-d5d1-08dcc2c35951 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1dh3jJs/BrOk3l68rNA5tOt9T+ADUxVmFLXEHVsoKwqWfccEdjtYc8av+7vS?= =?us-ascii?Q?96rt/mZfYMyFFn7HLw4nDOdJ5FlApWO0Nwg1OcErlaZlIRr5ls0tP5OTKYdw?= =?us-ascii?Q?pDchNhhizI/wPVYzbSpgBwjtwkjZ0PqOZOilWQMCzoM1PJyPS9SYx6CFHiV+?= =?us-ascii?Q?S66V9KXufHiTU0REd5JCEcTLwAI+QWr0rxnnuYTvobJp9nDJv4CbQbhoPeYK?= =?us-ascii?Q?Fl6GuU3yUyXhSao4wPnnbtJOIMccgf00pHzcoGEa8yGAmdPtI2P1JDtHvuJM?= =?us-ascii?Q?y2dIhFMsqGV0Yu70NbDhIsdw5vNV7TRi5UXId5ZlmsDnkOIv4Qjg+6ol6mes?= =?us-ascii?Q?JsCJC7DDpHxKT3grnU9fZkiIYy9p5XXvyh7TiMnpB3NiLlZ54jCrzfr/p63q?= =?us-ascii?Q?k4GTJcjsCuz7R/EXB/WK0CYTGtSC124QFwSoFZoiw6L65kT0L6u9bh25bigE?= =?us-ascii?Q?9PK2DioI1Pl7cz9QEelvXi6RRR/GD2AmfwF9prhNbUn2AnQw+/R2XlDUf0c2?= =?us-ascii?Q?SysWraSWrlOdV2dUYSquErZ+EiZLA/hNqIjEutrthZ5TM7jeDeyoi3jRkbUm?= =?us-ascii?Q?S0NzRSZ2+3vPbTzYkvDSDprdFHflAdIfSkurhFH1gfgTmrYJEk05q3zyElwS?= =?us-ascii?Q?F9TZkb73DUkMimakAU0iM2PLXyPlDKsNC7dpcxilVh56xHky19HEq2qgQFUM?= =?us-ascii?Q?ry3D3sIV3tlPx3/6e3QiIxQ0fZiRaS1PaBS7V+I7rO3LWx0CTYCIAIBdxi0Q?= =?us-ascii?Q?Hjmd7JeJXgHe6sd67x4cXvS1CVq+3NpvNfJPRV3GV+8LhsqrSdi4QiKYhS4D?= =?us-ascii?Q?fcXPp6ufL3g4ADmZj2vX4RgJG+iW/hzxM/WOCWbuaIsNDqkL2U83IHrvmQn0?= =?us-ascii?Q?zGF+N3Z+Gnm0kCh8EGhbPs2lw+NBDSt+9beNOR9k0QNAV+scxaHETSaMXnkK?= =?us-ascii?Q?U4RZTFB3TZOAwHNjKRiMbbTGVS5D21dEbkeGqjYKsxubrGobRXobyHJaegrC?= =?us-ascii?Q?MC+utnBHIM11UdTOWDyhlREm6OU9BhA7EQQkQDrZyJvV2CjNYgkCZKB9nnG1?= =?us-ascii?Q?5gDwT3FjcwKqcuxrWgbo0KqOPjwMKhKUwA70qgS9lh/SpI5wbaw5iAhaRWKt?= =?us-ascii?Q?L6Q21CnCpdG/cNEvavoy3J47Pv7u+Wd8rJvdZyXr6zomV46JJSC6DZr7UmuT?= =?us-ascii?Q?6xV1jFJeZBXuKEeUkPr6K2tqPglxbXnTYy+3czCTsNTuGARkX6T5mcaosF/P?= =?us-ascii?Q?FSICzlB6JYvBz8Epojkr5crZT6U18O2K6LHyWtQ83QHhvYzLKL9YcqmdvcIH?= =?us-ascii?Q?qZ6zy/okIThhr73Wz8UwtZoUUQrwvHmMs59YAU/Y5yGAKg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EDqIYfcbbwP63DiLSGOOLtlWQppSMkudpy+hqBOr3y+HQYN0PFiHKcQe6q97?= =?us-ascii?Q?0xVHn0elWYZccQyLdufHap0sd54amLPMDTBPnLQmBaebUr1i+EhTVzWktaig?= =?us-ascii?Q?KsMU3d+D++qhpvEgEze+sskfHSupU1TGuvV0xGPFiEjoYwwT2X5I82dAy2qT?= =?us-ascii?Q?VA7uDXGmLniQxRGcH73Z6vKXeM8jqjNLBUIMyUlZJ6Ja1L1sOyWOAkqPEZsE?= =?us-ascii?Q?6tKVS7kaQO+aZwTsp/5lI+7ReVeS/E332qI/mOyVMQmvssd2rE9VGhfFNkkG?= =?us-ascii?Q?9TBX4tPrbuN1NRq0zi6uydPTQr7ZUr/8TYNMX5M/wVG/956Ly+/bBUyoYMeB?= =?us-ascii?Q?feHInB4oDu2dEmCaEVlYybgsa4G8K7YX1Ydfq8TVs4Oi7mwQSM2Y81mFc5fU?= =?us-ascii?Q?vdWzPy0uWAElwnMYnOHEZcXg3iR3pMX6e4sRJINlUGpV6uELCpDc7NhgqlxW?= =?us-ascii?Q?UqLSqp0LAkJvI10zUYc5YCjtHMA639w3WQz6kLzwYKCw1rGcCBjT5e7Opb3N?= =?us-ascii?Q?DB0fYWA8OIvsf5k8KAsqOmUDkozIdJT4DnzVJ/QPpA9+JomC3YNGwkgps0ek?= =?us-ascii?Q?gjO+JB66XMnOZ1MPE8XBdxD7OHqMhuEHPXclXWp7ekw+w2YZRiUPf0t7nclf?= =?us-ascii?Q?OdSUeh7K4UhuyQnkREc3hlZEVu3tnNNmbzQULmcCGdR5qTXrSfcGETXWXXB4?= =?us-ascii?Q?qAmAEmsEUg2n90gUL4UymDCtmXzHIeKg9oqubaIVJrOYJTCaUSl8frnZjqut?= =?us-ascii?Q?V+RLZcJunYeeO/1vrVIALsKi16X4fbR8GKHxYJtYwdUhMD6LehL/uHW9Ii0l?= =?us-ascii?Q?H8rexN43nIvxSLkE4y2uIFhd6XWeM44Y5XlvaU9JkcWJ8MwgDCRIFopi6cu5?= =?us-ascii?Q?fMBSt+t00QDQSut55d3H+kxEgAIIUNhdZ/FIidMNOvXqGMDHe5W5PnUU1kwJ?= =?us-ascii?Q?glO9W6JpO71jy0hBgQVxigtiF38sq/NFpR+H2szTyGPBGAE+fXXwO8oL18u8?= =?us-ascii?Q?NFyLLq+yNBzxUFxyRK5VPcHNW3bbLj7DYoLasCYgKq4fqP5rg6Akw32DJgJo?= =?us-ascii?Q?kfyxvtXi8YstAUvICa/sqoC/S2jfw/GCIl+1C+we1sorq1nn9B/ziS1X+t3O?= =?us-ascii?Q?7VgL6sIFsO9oHr6fi+A1e0KvVUuyG7sz2/UvEfPPVtkEfMeT4211xUanrvtq?= =?us-ascii?Q?62xBf55ySrRCVvvQ6ZSHybB1KDAiau/0MMXexPrshqr4pV1re2JZhYRXQGGT?= =?us-ascii?Q?GrxLdKLH+rfqW5neanEnO2he+DqAav+j9jUwO2z5ReCqz5P+80/teguaiQ19?= =?us-ascii?Q?PtQp0PbmTHHjzJZEpApv5GNGB48HkBSbxwp2E/KRi/1oN5sWEdUrmrswavCw?= =?us-ascii?Q?AzxZUQdiKwkgeK0li99MlxpLrVAM3FnMw3sVRMlOCzmE5Oo0Lk3AROSla2PZ?= =?us-ascii?Q?2ayH1DvEQigSTIZfgEVgbIw1ZrE3Q0C/gBZMyEZidX6yvWbBgU4jYb5WeTLv?= =?us-ascii?Q?ljnULiLq0hAbNLCOg9sBt7wpTbs/5QanJW+rce8Hg1qU41G94B38SAFYdM/W?= =?us-ascii?Q?N/JCvfqJylcnJZ2p2LykTeLLQZwJ/I0Fil3a601W21BoErxXoxiPRngiytLM?= =?us-ascii?Q?Wg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: df736707-fabc-489f-d5d1-08dcc2c35951 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2024 15:59:05.3978 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v18MbvSMe6SnmYWHtRINO4LJhTD+6kY1JHeefsnsx03raifGMRq1JkOYrd0BcesanKJVX2fFzXTWKQCs/rqSXHfM2WEBCb4mBHBfkhoBaz8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8193 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 12, 2024 at 07:30:47PM +0800, Jun Wang wrote: > The code to update link status is not safe in secondary process. > If called from secondary it will crash, example from dumpcap: > eth_em_link_update > > Signed-off-by: Jun Wang > --- > drivers/net/e1000/em_ethdev.c | 3 +++ > 1 file changed, 3 insertions(+) > Given this is fixing an issue experienced in the real-world I think we should take this patch. As Stephen says, a better solution would be to have the whole function work properly in secondary, but I'd rather avoid crashes as a priority. Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)") Cc: stable@dpdk.org Acked-by: Bruce Richardson