From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C92945848; Thu, 22 Aug 2024 18:02:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A3DD42F02; Thu, 22 Aug 2024 18:02:41 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id F2F4B42F01 for ; Thu, 22 Aug 2024 18:02:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724342560; x=1755878560; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=bnSJEn0HSJczMF/Rjmx/HECDXA7aRCDy9VgQwdXSEBs=; b=GIfF6tly2nf3NGk2v4ItesC8ql5zeQqmvfvYSGpdlo2BplM1r2kPeZMq GLrBFDy4HsbUi5nQiypXnhmf2Xq+YN0rK/fiWXT3x8KZ1T23CTpesaZHi Igw/3kuNm/0h/g4PpkxhM5ZjXgVMaSW+i3luMHUTFjGM4SUR8I/D3F+uo /GM+csS7+ZlY7UADiJc5AbeHmdSZ+LisbKFTiEesAC/b/FkZb1FH3WOPs R8pxUDNbp/Cw4UobglWqHkuvUQ7MqGkr3948DDWclnzzACQCpYw5P2Shu 7ScTMOid2q+rbCGujdiwTERKvsGAgW1p4fyy9GwQdKPhu0nn/d4wjBe25 Q==; X-CSE-ConnectionGUID: Pj/tzyxkTQmVS97DRTYCig== X-CSE-MsgGUID: DKQ17514TPmploZTk/Z57g== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="22931897" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="22931897" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 09:02:39 -0700 X-CSE-ConnectionGUID: CtL7sbxsQ+ezLfL7ydTRtA== X-CSE-MsgGUID: IfdWo6YISx6ifMZW0tOYBw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="61343502" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Aug 2024 09:02:39 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 22 Aug 2024 09:02:38 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 22 Aug 2024 09:02:38 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 22 Aug 2024 09:02:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yFoKuQ+Z/Wk2ez/X4HFwZD12CeuMOdXR3zSNYvdzzU/jrgTLLnAgsgY/8ggKB5GIEVD/cNL3eBMjhqLUKIjzT5JjsbnMfLut7rj4PKQC36HEn0CzQLSX8SMRzklrKHlEryLz60T0cFwjeS6i7k1S+vnWsa3BauiDfIzKcrvu3H2YW5T/eGpGrbSEbapA6VrMvYoDv3lGo/zosSdckjkLBZ9cBHveFiepNzROKGBx9i6e1RDQvNx1Ax3UjnU737YN73T0tzn9kxhdi3t2DPeq36IibLN24DXmv0s64eZtIwtopRtwfuYiVS1LF+3zBkyDa4HySB2pGrHAU5s8b4aQ/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6H+12d+qYGtNO1l4Ptu5ScguwxrASINZ61MGMgbFnmM=; b=edpiqXVR/ai+irdnifLho6oWxf3yK0IuKt12l6UJ5MTNvA/CB0KDy0eplDCzOW4FzzrxCSrVTfjX5lHHWMBAQfVyAgBCqrkAGwZ78+NSr3EZO0RmjpNQZiJ+yW4KQc5loL45lP2Nb2sKCF3zgmZkHZWxr4BHIRo3IPCASXiwD4bl65K3YjqwPsGnBBDDDOF4f0rmaDggKACUhlHkfDUtSrhoJwKSFpGQD8//LjHuF1sinLtT1Zvzy2UrkqJ85qxAlA0/iYi8t0jMZUsROskR2bwbZpr6o+5dI/81zVcKOKKipSY+3Oc2HV1yp0g4OURlcxzsanc94MW5VHELcELApw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7640.namprd11.prod.outlook.com (2603:10b6:806:341::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.26; Thu, 22 Aug 2024 16:02:35 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7897.014; Thu, 22 Aug 2024 16:02:35 +0000 Date: Thu, 22 Aug 2024 17:02:31 +0100 From: Bruce Richardson To: Jun Wang CC: Subject: Re: [PATCH v1] net/e1000: do not update link status in secondary process Message-ID: References: <1720783847-12292-1-git-send-email-junwang01@cestc.cn> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB6PR0301CA0084.eurprd03.prod.outlook.com (2603:10a6:6:30::31) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7640:EE_ X-MS-Office365-Filtering-Correlation-Id: b9dbe1d0-6f43-48f7-ae11-08dcc2c3d69b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HnUUCJOfnqykR8d0vQDfmEp8wQTSZf8LTK9FpcUJ/v9eNadtcoVgHee6QbuD?= =?us-ascii?Q?WvxC3IY0wsJp0SGTWt76yMhfQ/amTJzwWeM3W53gIUv8RvU8MyW7oGWTFKYK?= =?us-ascii?Q?cSpZCne5kf0vjmYbZlbG63Yj1fgK5e9l/FNncCF7ZcZluXUGRc+Y9DGkIAGT?= =?us-ascii?Q?ytcGKMSpCfXCqSTl3YpGlwKOUjZevkMqCbPQMhtPAblKDqCIYDXbhLCCP9GP?= =?us-ascii?Q?H0bfATMpLf3N2NC3AIvMcEimLwWuOnIaD7JRPBcf89Npj1/y4gqY24nuQFek?= =?us-ascii?Q?2kGvg7GK0p/+2bnyGc1Wiar0eBzbzMvnR9b0X79tW13KaaDXTer6bqZghdyA?= =?us-ascii?Q?tfd5ifMdNgy2RtRGeTJ1An0xCqVXZp87XC4f0ptXKyi2veCct4MrHbPmvXbO?= =?us-ascii?Q?clJX1QvscKOf8bWqZ9TkWZm5QLt306L1Jmvw0mWq5Ps4UdVQuB6XN91HIT88?= =?us-ascii?Q?ptuQYy1jZ+S4ZBWWDy2r4fUTRATTAG9Ud95uVhsmZKVgM9JoOBHECvXZhBAk?= =?us-ascii?Q?zHKCD+EzJbzA95p2PZfyqN+OZnJBuqJmbNr9QYYi3MZlQ+I0eYqxiQIcwONj?= =?us-ascii?Q?pPbDbN/LIFDX6BnPnyPy3kh5VwfZCsW9vCV3Hcmr8FhOkdiJF8usbO1E3TJq?= =?us-ascii?Q?sCjH97yaTlVl4opbR+3uC/0YdckpJWhQI84AJB/tZUxo7o3yrh1gw9cU2mPj?= =?us-ascii?Q?bPKeM39IsC27GsbcKox/HjX9cod+MIDWVWyjlTlMsuJNTSlyLw+cqLy6TrsT?= =?us-ascii?Q?XkSALeuUKPgWXVBFsrYauUx8VKRM3c3MV1BFTTwi64shatDCeP2veh0x2iBY?= =?us-ascii?Q?liSUcRfFhdlozJxA+EWFiBRoTD9kjaq1BQvB5N4H6jZ8pZ0FkK3afO5JzDPW?= =?us-ascii?Q?fNRRThokdhqZUNVfdB45sDldskTxhy/bdJ3G+27WD4ekcewwNKHjtOCBOQNU?= =?us-ascii?Q?hh/p+6I4Qe9agdUqjbrJX49GCE/BlsVpLKiZzP2UKQEbE6WdiEKUtDhSxknd?= =?us-ascii?Q?cDL75RYMwRIYPWEhOSJ3YXB7SGUjYGoZvWSwGAx9lp7OvorxuBWdl9RVo2Rq?= =?us-ascii?Q?MZd6lgW5bNnGzHE0R65xwsGaQGOkuNWeoAIDESwOhbdAhCkhd52QlJkvZ5f2?= =?us-ascii?Q?hkhQoxFJNfz+iMw7/Y2VCFGvLkgu1soPInfHVEukpuNBxOFO4jIkzZoluqzk?= =?us-ascii?Q?BuCLC1Kldquf4LP49NQK62l6jgH8qt6dch4wMuXbt/LygvAX9KwWLzR8yOMb?= =?us-ascii?Q?l8EgYr8G5Dg+TfDSkEmEHAjVSQ9GlQj3Nttu8aOTKBu+2EAk4mPKwI/e+JD0?= =?us-ascii?Q?upDgAu4wocBJCHccsGrEZ08SLvk09oF1agGdIKa4WAE8Gw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OrWfzZSfX7+LAFssDAqNQSLHnLfAtYTq/2bHaSZW/s8MLQvQxf/6DzgCEMgL?= =?us-ascii?Q?e12D5xRMjbbkMbsxHIVY/qm5+DdnTQdQziW1pZZu16uhXLaRKSrZPO310pv/?= =?us-ascii?Q?K8lz1r3alN3+KgdDtIiRaoCZGki035TvbSaI61WhD78qeGy/yarEVffX40hN?= =?us-ascii?Q?GonFyEm9Z0twwJe1GAmHBkYouawSWzgBHlTjPLS0cALjyR/NRjUKhGfHYCPb?= =?us-ascii?Q?6OS0l9UjCUd3YAPo1SJcB/MrCsTpWwLeaTmuf6/nYLizHtbHVbNeTHyLktx6?= =?us-ascii?Q?Wh3fZkX/TuUlX5FzjPzpjzkJaSGcFGpFLaO0IVzjrl8O87ilJJO3e19CqBKO?= =?us-ascii?Q?FnMDdKIDrk85y2cf/X0V8gyDut0EFzb2feE8BbHfGs8zKns/gZeksUCc1cQH?= =?us-ascii?Q?zfrIl2+XGACJW9IryOCJcOhtx69OIhDEI4C1jNTuXOl06QoHPlfCxvvSTj0n?= =?us-ascii?Q?RhsEF+QcSRU+6f75M+VCvzHVdfnrgmYmfGOTiqTQP0Ez5Ll5Aao67rxXrq8c?= =?us-ascii?Q?peqJ66NDry+uri0RxrdTkyBbcNWXUSiu8xbL01/lHMDIscDWePsHIQZm/3j3?= =?us-ascii?Q?cxocD/8x7kITEpnph7hpxobhX5Lk7nitchq9LMAnmOVQOJjvyhQGs+IDn/cQ?= =?us-ascii?Q?37sKzTAK6T3q01/9BHpIPlmIpklxtk7B3AfTMc5chsWl3063qj7S329zukR1?= =?us-ascii?Q?kajx77+kW408zEl2KFPBEAlPMdBE7rvuyyhQybOMW5HQwI3Ok6NemBInOlvK?= =?us-ascii?Q?q3/4Z+q0l3jveLuNtLyWBIiyTpetWw5anEFRyjk9iHYa8qHYERSbaX5eyzqB?= =?us-ascii?Q?owiescSpzgWTRTQjg6QH68v9aMoMgq8kbxGxK4kK/FRaOy4Qp68CR9FucrQi?= =?us-ascii?Q?NpJ+aRO5wL61PKL8aWjFjZqmgox+aiYVYtw8d1INkoofolANJbzd+pzL/SgL?= =?us-ascii?Q?Rr9sKBsJpvMJRIVuHr2OKRqjViAndYALVTm6Yor8+2aZ/9/bmbvRA0TSDgUN?= =?us-ascii?Q?UErpF0qfOUrjTWFtjqxPDfC+rdTYyLhs3158798oqKfJMKreLn/ucj2cQwh4?= =?us-ascii?Q?3yfIQwmpbGT8g1dz3C4zN9MEbu2ZiyJDHxRcVW5sjckCKl0dY3WE4rObQGmL?= =?us-ascii?Q?Y/mRlPZv9o4njjGOtLFB/BE/+GrmoJSXmiboGDS2aCNp/vnznPs5J397ckNX?= =?us-ascii?Q?apsf4JfpPB0jAJmKHqNm4gdxSgtwP1R+61xMMbuxEIYUhzovuuMW+pXis4yo?= =?us-ascii?Q?IQequVPOgqu8ZJtgCKfl0IPpfSOcirey35xiZ4jFg8wGeDojSCr66isO/mar?= =?us-ascii?Q?tEMBSA+Pdllgj4Lr2/l02vXraJiBAHqYpN4cBk5s01YmXsYz9hy3n53YdA5P?= =?us-ascii?Q?IJ+ygo1wXtNMb9CQYlAMaq098dCSIsrzOgyyeXYQ47TdhxYUk5LlFxT4U3uW?= =?us-ascii?Q?WfHfDUeE8RAcl9J57W4ynLZenGHrauj9mPrNDvWWn9053d8QP5Rmb+xnLplF?= =?us-ascii?Q?XTVxYy2jIIjOy2s2oDOvONCLzl5kBu3x78+OZNoLim+O7HiJ0j659Pm02tix?= =?us-ascii?Q?M/m4gKz2CClXhmJmLqqdzqmHaaoqf9Wez30leBBy7uSjq2o5V/SU4ZXsfouo?= =?us-ascii?Q?fA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b9dbe1d0-6f43-48f7-ae11-08dcc2c3d69b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2024 16:02:35.5878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pch4kFlb6+h0KPDR8S8GgQgnWyaPuhKuib1gKjL2FKgnS2FxkkxsPQOTbE7XylaRTX+izPwjxiYxViw6HoQtcLXf2Svh4V2Lt0XCq278RII= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7640 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 22, 2024 at 04:58:59PM +0100, Bruce Richardson wrote: > On Fri, Jul 12, 2024 at 07:30:47PM +0800, Jun Wang wrote: > > The code to update link status is not safe in secondary process. > > If called from secondary it will crash, example from dumpcap: > > eth_em_link_update > > > > Signed-off-by: Jun Wang > > --- > > drivers/net/e1000/em_ethdev.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > Given this is fixing an issue experienced in the real-world I think we > should take this patch. As Stephen says, a better solution would be to have > the whole function work properly in secondary, but I'd rather avoid crashes > as a priority. > > Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)") > Cc: stable@dpdk.org > > Acked-by: Bruce Richardson Applied to dpdk-next-net-intel. Thanks, /Bruce