From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02BDC45848; Thu, 22 Aug 2024 19:06:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8845542F08; Thu, 22 Aug 2024 19:06:52 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 1D6FD42F07; Thu, 22 Aug 2024 19:06:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724346411; x=1755882411; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=5AGN4q7ylhmZVYLZNsaQZTZe22pDrhw90hBa4Z6YS70=; b=mP+qxKDTrXKKBUR+wwIBtVdspYCTTSXTNu8hRny3ZdTEdb3JSeGguAtT /FDLEpG7XGbYIUtijoc+rM/zUj+mLsCHKcpMmNMfi2di3Wn0FhsyIJfV0 z/Ehqo2qYvnbWd5onILlZHbNpmEH2xr8Xtn4jVBcMMJcU0/uTqicpFqbq DsjMGpr+/PjrTqQ2D7KMKFBfuZISloERZH9/ItEO7X/bf0Jx1ejSKB2Ic IuMryOHvG+CecSECaSA+tYhs6Ad7ZZkx4RvlYsIxeFwqUpZ4ri5wE8w9O 4BshLMfO+JIM/l4WeJDDFMwzHw6rDzzKEA/HOTf85Kt157fB3yD4h2DAh w==; X-CSE-ConnectionGUID: uceuW0G5RKWz+yfWty8/fA== X-CSE-MsgGUID: fjnsc8I+SvO9WoQVsqTdbw== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="40246859" X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="40246859" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2024 10:06:49 -0700 X-CSE-ConnectionGUID: 0GdZROF4RUmYzNaEVDcFzw== X-CSE-MsgGUID: fvDvopY3Szq7Jm9CtTSH9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,167,1719903600"; d="scan'208";a="61362411" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Aug 2024 10:06:49 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 22 Aug 2024 10:06:48 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 22 Aug 2024 10:06:48 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 22 Aug 2024 10:06:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cQGXuNytj6wUa3GORpQboalTGMcK+kSrUG1WnZYcFrsRKla7axauG4ZyCSXC2o4ABPbucDJKewFHzV1l+Kvsvyydwxd9+ie44dsswQj5eHfHSv9+HZhQE3TgVSY+GRPSx/CGh9zDEDlA+9nOwOJIriWaCQCLPUcUVgo0izGbQMpgAsHbKFwUJW6uI+7YG0fmhZW7rf35lbK/J38wjgt7/pEXk5KSW+i6Ja7JaikEjB6+ijXwH05ysYPMbsiuUynzd8JaJh/TGn1dU6MasItaVTzd348XOezO87PMSFB0vuzxCnrYT1I8UIE13tLrbT8x80Ucaj3I5dFyg3ofiacx4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Z9wM88Goem25y8caWYy4xkgwsrJKjnCDV6b3ZLhLJ0=; b=cZbouVt+mqtCqVzfAjJw6MUWUeEkH7gsu6aNgrrd2451s+DBZC5vbOLA1OFo3HjdhtsigcbOPWTm++1frU09EvY+8wjWh/pvhegmqJu3P0/OJHDokni0zBUGdp6XnzpMMIWndGftv3CTPZS8KWG/hkEbETQX8ahMNoCgEe3aJppYy+kxbHIZzNmmQBtH+j8J5IlqO2HzRlFQSmhoxrSz+Z54DPiks55DsTf37NTTw4UpKaU7IBk8XTh7iP+FZVgLP6zIO2aITiOkbl3pAnXLUAW5d+16JCY+n6oaUOL2L6LGLJ7tkL3R3OmE+ULiaJcroY48YFgfAvtkzAO6RlP94Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7298.namprd11.prod.outlook.com (2603:10b6:610:14c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.16; Thu, 22 Aug 2024 17:06:45 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7897.014; Thu, 22 Aug 2024 17:06:45 +0000 Date: Thu, 22 Aug 2024 18:06:39 +0100 From: Bruce Richardson To: Kaiwen Deng CC: , Subject: Re: [PATCH] net/iavf: fix core dump when the link is unstable Message-ID: References: <20240806003527.2901320-1-kaiwenx.deng@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240806003527.2901320-1-kaiwenx.deng@intel.com> X-ClientProxiedBy: LO6P123CA0043.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7298:EE_ X-MS-Office365-Filtering-Correlation-Id: db06150b-9902-4aa9-b200-08dcc2ccccf4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ITmqJ1e8o5Vd3ejSxqAIeusHk5Yot7u7wSDxqtvZYFUFr5tDvImWQmXA4wA0?= =?us-ascii?Q?VJpt0Wv37xfIU06frMwbzx2hqgBf0iGYm9/vt5hT7LwUtCXLCv+ZVnf/eH0b?= =?us-ascii?Q?SOQR/UefpyGcm9XPaL3ImNqGk0NgDafOx1atoHaLpORa2eSY3vuNl1+/yXdM?= =?us-ascii?Q?xzyFUGZlF0G1Hv2+RLNcXFqWv3BdRyRQmqEHu0YSQZNUqf4MyXusUfCENBDV?= =?us-ascii?Q?sBnwKyv/mtNy6z9oc6igljG4d1Cd3Bj3ibMEME59DtGSMXtc9wFLfOIUKX4t?= =?us-ascii?Q?8uBh+LRWRs4UVkvUDaC1nDspLHzRJac+vgUVbVgLraKaKL2wvZnlpJvyxWPh?= =?us-ascii?Q?9t1IrxgKnsHTflr7AFmf6GE4JeM0Eo680BXMDgLPjiUcruAi9NrbRyvo1v17?= =?us-ascii?Q?9OFEkPuE03JwoELnT7hS4JRI8WSro1mciqHsoUnjDWDCUXea1GGbV06TJVOm?= =?us-ascii?Q?cAApXD8ryvZ1/hl++T3w5+i8ejPyiVkWTLsHv/Wwef98FZXI1KbwqbhQBAjC?= =?us-ascii?Q?kz+zFlsGT3uJyadNYnmoAVccZZcgFjivhOS21OAVlHEpoRZuMrdwXyyTgsDO?= =?us-ascii?Q?t8CT1L1EMTAejQai/HCey8nQ87htgyl1BopSsIk+KBC/j5wSo+4PeD3VfLxn?= =?us-ascii?Q?dZZ0pjvoQCspNGn+mz0363NaBr3x8HH4ho5ugmN3tZqVRvtKcM9CR3Oy0Qjj?= =?us-ascii?Q?sxf7Ww710n+9scJmvoDJjLfwiu4TU7ZmCZOjmeo7q8rHhAQzN9I8+YfsdZhZ?= =?us-ascii?Q?YlUOaWqkR3T1QVZVm5//R7LHQaZxv/z8jZaNYECmNb2/NRhVgxrf4Cp02WqM?= =?us-ascii?Q?4fgHnOMeM6UHlzKQPdq2FgnIerwEUTnRd2dVN8ZJ4u8y3z57Ilvy/VsJF1Pv?= =?us-ascii?Q?uGLPysozNcgP960AEM7ncRBcWuWL/7m44qcwy+2uEAtk8mmXH0mstPCYN6yi?= =?us-ascii?Q?kGUGfhtkgjKW25YH9oIQunhYsFwy/+dMUZU3XYBfpAmPVdxXdTsnuxbO5Ul2?= =?us-ascii?Q?7bu3EAK6QgJpeTUMG4AJbEtzk1P/V2sQWjF61R6a0bGYaqwxvjG6pvP5kcpu?= =?us-ascii?Q?ZTkZ8lYtIKBNxSENd+srMLgOAzLEgIRWgkgF24e4bsYYkC3zWhJWeus0BUYv?= =?us-ascii?Q?S1CrmoP4pTRt0R66iREZnlyK08gxUcW6Hap81wT1uuqWXvvBuSY8vmS91eju?= =?us-ascii?Q?Are9B9tjL6l37sypV2HENRL5hPDSVmYusY/W9QafMvPe2PnYSEmFz+PsIE4i?= =?us-ascii?Q?sGLov1xIL0WSM+XoFIaF6CXuAwTbIBHhpagK9QEmRHdDaDfqxmjL0RNORTk/?= =?us-ascii?Q?/g0u+BrerHnbBqJzwTaOEa/x/VZYTdu4NzIqweJ7IQ63kg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I5feK64XHa4VqmIBBeZUQ5kTlpbmtqGWTaSLR3d04/dsEWep+OyO2HNntvfv?= =?us-ascii?Q?G172JQILRiyJICQxjqMjlhD8jyTj15lVHc/Idv9D1SqqJqUXM0NuADxfYvOu?= =?us-ascii?Q?CecprHxDJ5y/kQU3e2CiXGTqmS18pWA1EQYy4d15yROKG9jGXVRzu5wYPEmf?= =?us-ascii?Q?/mehschwIeLEewH4Nd1NTrTBRc/3FzpIjK/UCTgyThko+jBqWpUVArXAjXLJ?= =?us-ascii?Q?ttTM9Fjbv6Bwj+eIcYMaiDcHMAylRIQOj4iGYL03/1hu9m1A9KIQCsElOQWo?= =?us-ascii?Q?w16Uz9DWJDQErYH/eMycdkY9QO82kDsFs29NXayzCi9ocqvOm/r69pG0p/U3?= =?us-ascii?Q?YFzzrRVMm6n9Iz6XaVHEMhfdSLnJ98DTGbJk6uXrB2gyDrtm6DlCctrtC6eq?= =?us-ascii?Q?ELt5ixWw+iTDnwb1NT7b064e3TfhfefCt9KyVdwr90zGM7qQixyg/o9Q2kpm?= =?us-ascii?Q?GSyNYWnpt8zSgGXLVsfBEvzYJ4r2/f98Ml21gHHgXKUiKzDzGgSWhnMr7GGW?= =?us-ascii?Q?Kh9VEm31hY08J1KtFAm9qzD/qAml4L5596R6qqNsWjOZ9rboeH0JKnzDV6Rj?= =?us-ascii?Q?QJIslgp9g8SYerQUQp2rmeOb+JbVIUNzLqMA8vjIqW7xTmfpVaZGGxvBlhgc?= =?us-ascii?Q?CMfa96SwzscKKtEdV0C+1ky/snMg2kwGhlMmO8GaNiISVbaYAEghsyQZjNeV?= =?us-ascii?Q?8WUp0hIBbURnYlESHQCSowwcd+9ViHgn9nJUy3blo+ZDfsN3L6vGcvLgebI4?= =?us-ascii?Q?CJmBg3ss/FrKh5yQ0Q0kBJE49pk0QT7L4G9XnSUulxEtfCuOhfI/kdYOy6Kk?= =?us-ascii?Q?5x1g0tJ6lRWOwkrZzYIevE1ous0s8SpB384B/A92eQgx4emMCbiG0wWxhRNI?= =?us-ascii?Q?7UlLsNQsLBpr4478UTCEWGlyVItjHgCaHcm7OmbumM5ho2pUt01FTQbSXwxc?= =?us-ascii?Q?I1pBkwibnxT/J1+tWWhiS81XF6dnwCZ1UMp3nFyTP/z4LGVzkyZKmRUgGe+G?= =?us-ascii?Q?KW9pBEMrl1HodwmEyzgmayGySJqqPf03Qf/4CeRhsY32jIYUVkW/4ssWEzXo?= =?us-ascii?Q?NGDuEYw0hfPuhJ7Y0zj7SQENQHRR8UOIB4fUMeynMCgZ/odGKnqubiJ+B2Yi?= =?us-ascii?Q?w+FguSutBRD/vFAg4ZHMb7B6VBbOKzKi6XhMgQGXIwvi1Sgx/QiZ4CZRVg10?= =?us-ascii?Q?CRSnwAkdG19a3Efca212eO7DLOMFaW+/7hWgaQkNlE2eCkf2MBdSIg7aIHwa?= =?us-ascii?Q?yrOWpai3y3Rv9YPAF+MOeNhXH4Apxo5zxkBnDwuqrerTskoUsGRqoxqHJLzM?= =?us-ascii?Q?2fXGSI7w/wxX1Z3VlxwtnxFhErajptb3Hm4kPa23l9WYEB9rAqaS4P8gwEFT?= =?us-ascii?Q?I0Rsbz0VgWi+iUzlXk6gqWOt4y56FuquFjhiEE0x9+WTZ4nf6tP7OUTz1xRo?= =?us-ascii?Q?ZFKznzH3FGcha61KtJbxuirgeqfjx8KiXrYYzosIiubVoRGiGV9TAKNknAcI?= =?us-ascii?Q?zikm0n8hbOmKhczGRERQT7oDxbTd/42RuhSimTQfl8uFMHku9aZwR2i1N9pn?= =?us-ascii?Q?1xpvPOfyJjylZBQpcD3YRqUfhQHPjiADXogBov+113BDC0aSA4J5gcWyQA50?= =?us-ascii?Q?yA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: db06150b-9902-4aa9-b200-08dcc2ccccf4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2024 17:06:44.9948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vex92K8p/ekLjjQtHbMZJLHYwgqQuiMg7CGH+CDN3U/z8HNo+GNCq7g6giAF/b6g3SzSFtiI6tS5B88LJ+Thhwx8ig9A7EllXCXyoy0gjQY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7298 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 06, 2024 at 08:35:27AM +0800, Kaiwen Deng wrote: > Physical link instability may cause a core dump. > Unstable physical links can result in a large number of link > change events.Link change events captured by vf before vf > resources are allocated will result in a core dump. > > This commit will check if vf_res is invalid before calling it. > > Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message without interrupt") > Cc: stable@dpdk.org > > Signed-off-by: Kaiwen Deng Acked-by: Bruce Richardson > --- > drivers/net/iavf/iavf_vchnl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c > index 6d5969f084..b85debd40d 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -255,7 +255,7 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len, > case VIRTCHNL_EVENT_LINK_CHANGE: > vf->link_up = > vpe->event_data.link_event.link_status; > - if (vf->vf_res->vf_cap_flags & > + if (vf->vf_res != NULL && vf->vf_res->vf_cap_flags & > VIRTCHNL_VF_CAP_ADV_LINK_SPEED) { Since we are adjusting the conditional, we might as well fix the indentation of it while we are at it. We can use up to 100 columns in DPDK code, so there is no need to split the flags comparison across two lines. Also the line continuation should not use a single tab indent - that makes it look part of the body of the "if" statement, not part of the conditional itself. Will fix this on apply. Thanks.