DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Kaiwen Deng <kaiwenx.deng@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] net/iavf: fix core dump when the link is unstable
Date: Thu, 22 Aug 2024 18:16:14 +0100	[thread overview]
Message-ID: <ZsdyXtrBi-A7KgIN@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <ZsdwHyPmqvfdTooa@bricha3-mobl1.ger.corp.intel.com>

On Thu, Aug 22, 2024 at 06:06:39PM +0100, Bruce Richardson wrote:
> On Tue, Aug 06, 2024 at 08:35:27AM +0800, Kaiwen Deng wrote:
> > Physical link instability may cause a core dump.
> > Unstable physical links can result in a large number of link
> > change events.Link change events captured by vf before vf
> > resources are allocated will result in a core dump.
> > 
> > This commit will check if vf_res is invalid before calling it.
> > 
> > Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message without interrupt")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> > ---
> >  drivers/net/iavf/iavf_vchnl.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
> > index 6d5969f084..b85debd40d 100644
> > --- a/drivers/net/iavf/iavf_vchnl.c
> > +++ b/drivers/net/iavf/iavf_vchnl.c
> > @@ -255,7 +255,7 @@ iavf_read_msg_from_pf(struct iavf_adapter *adapter, uint16_t buf_len,
> >  		case VIRTCHNL_EVENT_LINK_CHANGE:
> >  			vf->link_up =
> >  				vpe->event_data.link_event.link_status;
> > -			if (vf->vf_res->vf_cap_flags &
> > +			if (vf->vf_res != NULL && vf->vf_res->vf_cap_flags &
> >  				VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
> 
> Since we are adjusting the conditional, we might as well fix the
> indentation of it while we are at it. We can use up to 100 columns in DPDK
> code, so there is no need to split the flags comparison across two lines.
> Also the line continuation should not use a single tab indent - that makes
> it look part of the body of the "if" statement, not part of the conditional
> itself.
> Will fix this on apply.
> 
Patch applied to dpdk-next-net-intel

/Bruce

      reply	other threads:[~2024-08-22 17:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06  0:35 Kaiwen Deng
2024-08-22 17:06 ` Bruce Richardson
2024-08-22 17:16   ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsdyXtrBi-A7KgIN@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=kaiwenx.deng@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).