From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DFD0458F2; Tue, 3 Sep 2024 10:31:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0B2B402BE; Tue, 3 Sep 2024 10:31:20 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id AA7E04029A for ; Tue, 3 Sep 2024 10:31:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725352279; x=1756888279; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=HDPV/iHxJI/zQT4Dc0CsYHolf1EdWe6/M4anywj7UbI=; b=QpSzZ2uQ+zFN87EBqMETIapsT1g/0S/0b7/iRp0flk6izjFKj3o9aKqg 78Ee4O/Iy3BxFdZyL+a7jNf20UpA7Xaec+Kn7wTfvQ2N1BnYAGQAT5DuI 1fHnAs7uNaRuyYae100KDYhMWYBbUp08uvJpuRNTdXxC5rddyz3gJiqD8 lFL+NioXJZQ3pojTqFuVjcMyv4elZYzi2CW4bJTohiKk1eRjqG8IHKwnD wa0fpI66fpdKNX7FsbYnHC7TaM1vzA0bFTvADYUtG7cO5r5+JtVelPg1y rtJfPFHU5JVmkBHQQNLo34Yv29bGhwV2YSdJFvALf/HZoCKGaqaBjiajy w==; X-CSE-ConnectionGUID: 4dn1i+OiQneJl3LtIN+b9Q== X-CSE-MsgGUID: MWpT+G3bS7qYxvAuGss3bw== X-IronPort-AV: E=McAfee;i="6700,10204,11183"; a="34503287" X-IronPort-AV: E=Sophos;i="6.10,198,1719903600"; d="scan'208";a="34503287" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2024 01:31:18 -0700 X-CSE-ConnectionGUID: YW4K4Dr6SMqYxVRDqPkPfw== X-CSE-MsgGUID: KVlMmFwxR0m4a6/HZ9wQEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,198,1719903600"; d="scan'208";a="88078243" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Sep 2024 01:31:17 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 3 Sep 2024 01:31:16 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 3 Sep 2024 01:31:16 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 3 Sep 2024 01:31:16 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 3 Sep 2024 01:31:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jas9lnlSBOSf2CU/XQ5wBeaRRajcV2TSa9oSaUDXX+uBonR4Jnhxrq+7NuX4iJ4zNKddgMAEXPVVNUi48UDI7aQIfPXHeFch/Iq2m6UJnSMMyS3cYSH0sZjah+19lJEjnNAKnXgyZvUemwe9khpuVysQ4ifzpKoVSy9w9kF6evoH8VzgYbAFFsXl6TVLkTtSwx84P/bW+sP1B8/l0GNRTejxkSRCBfSt2CdHnKaXi+pKi0xWRN6xgImCYxk76tzHc53h9AK7Fa3+gfYIXdcGfI/J27nWialXMRgRwTI7G/QT1tlC0hig7LtUe2PFv6AohZGZC0G5my4aNdTWJ+AISA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7K9RUW+ue1fZ3gb5ubZgE8ocAteQGOrWp1c4cAWC8N4=; b=A09l0bTq9Giwu68iPRjYsQJTbEnNthNfTTTqMzPOo84xzpkl9S8iEaLkECpkL1zKOP8RoImRxExWPn0slUJpKoVXf7uhe1dtgT9R6wth9hc3boLUBehaxL9y/al8nWeF3pHIAGRaVYHQURXJsRc+i6I/66R5drDBIk6+8EA9HD5FEEwQsb07e097BUEWfiR1YijbS37pj5MGSSVej0DzotDcLJAumAVMrq6vNWeC7uWuRNfXR3MnPaXjr7F/VVy7txtmZA2TghMyU+zNDjpwFqTApxDOhLvmDprFsEpZr/IGavhyEb79YT1o4ze64Mvxcl8MBAdMqL7sG7lIEgvUcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH0PR11MB5315.namprd11.prod.outlook.com (2603:10b6:610:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.25; Tue, 3 Sep 2024 08:31:08 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%2]) with mapi id 15.20.7918.024; Tue, 3 Sep 2024 08:31:08 +0000 Date: Tue, 3 Sep 2024 09:31:03 +0100 From: Bruce Richardson To: "Burakov, Anatoly" CC: , , Subject: Re: [PATCH v2 1/7] build: output a dependency log in build directory Message-ID: References: <20240730145508.551075-1-bruce.richardson@intel.com> <20240802124411.485430-1-bruce.richardson@intel.com> <20240802124411.485430-2-bruce.richardson@intel.com> <4631e10f-0588-4160-a3ed-68eca322f4e6@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4631e10f-0588-4160-a3ed-68eca322f4e6@intel.com> X-ClientProxiedBy: DU2PR04CA0205.eurprd04.prod.outlook.com (2603:10a6:10:28d::30) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH0PR11MB5315:EE_ X-MS-Office365-Filtering-Correlation-Id: 295cd81d-336a-46c9-7c9a-08dccbf2c259 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?y5LvcYcdM1j5iKEuJNvOr6puE9/WO9+mg9UMgNYmX2EK35+CQUWFhK8M4Sht?= =?us-ascii?Q?f8CwAQrU/fpMfBcUQcMOqL0pwnDAcVvHJLUN6IjtfZAaC62nNEJ/CLhexb7T?= =?us-ascii?Q?VrXHEdZBpolCwLmkguu+anXtBs5d5GeIYte/U70MdtEkMiwsI2dmb0OzA9Ip?= =?us-ascii?Q?fxNU0Q1ogw6Dld9oLVDp/4yi8xe1/X+ZeHo1fQQaqdSM6cEt8XAyy4hAopeL?= =?us-ascii?Q?NaVhDjt6g432JJzyGR7Vzm2PIxk4H5dreJWk9g9tvaFMrjjLE3/Jnk/swF3+?= =?us-ascii?Q?H599JPCK+OF61c0nvGpiyrEHcI/h+a768i25yHSBYTBEBMAuwrOrRoA46kEx?= =?us-ascii?Q?Cknd5WsV3ApjIIQLaew876zGQ/wSxZq+2uUuhHozo/tsPpg2ZxjxwfSqKokG?= =?us-ascii?Q?ieioINBDeXd0eLG0OKkL4Jsj3job9wF/PhpTAeu/jexInay5fD1tUal4MoFq?= =?us-ascii?Q?tmxNPI8T/9rGLpRTPQXw2DWFcMtfhLThgroW9HxH37Wu4hfu1gzFAXHC4GRd?= =?us-ascii?Q?2smWnjjwWKF27KiHuHUHIgqWh1ppDE7+Fmh7abwxsb2E7oK/hHoYiXZwnenw?= =?us-ascii?Q?cxsvKcPpF5cH4yGPqPVYeo42/qB6618nV0VPhgu3bBSoUsK7Fnh1yjLiL09Q?= =?us-ascii?Q?xQJkbW6vp/JR0ZoHdBkh7JLvbvHRMj8KMThFDD0cF0/ZNfPOw5A1g6TtCLBe?= =?us-ascii?Q?f7vAflXmnjZym/TN5tCnEQqLLNP3QDzprPPS2ONJtuhOMpFadCTXqsfQzKDB?= =?us-ascii?Q?X/ipFUuBH6d85QaefGs1NL8vEYNPMjo7Teg7oIi7Rvg74wy0EOsTuBctXvRQ?= =?us-ascii?Q?UsEMaRc3Src4VPQ5LWCsImWmW4T8c89wNKwpgyQFXRjfVHPvwHpMpHVcIDXx?= =?us-ascii?Q?p+wRL6WNA1wWi+/DFn8lnL5BXICTnqy/lAuGA2Ig5UXxXxQoTwgwde8bvm/I?= =?us-ascii?Q?VN2C0b3Jsd+tL19Qza0ilo2HXM/Q2Ya0VmDq8Va4foik2E6ya3xJrdZUnxoz?= =?us-ascii?Q?Ct31Dry9OscZEOtgOdPI1+yg4XCT1Ypf10Dum3bTbczC+s6sEGU4cTYuorzQ?= =?us-ascii?Q?HSrsfiaUwcUF7+XmSlCe47FXBN9ep2bZY6T/IdJ8Un6ggq56bZXjQ+vEuwXk?= =?us-ascii?Q?MJayUgZLNMz5i7Whn88S4pjvPeviUeQW1/Asoqjf9SwcJn+bZANkQs/bTieD?= =?us-ascii?Q?DIMknrsoWyOoFa0wEUWGyqVnZMSVW60ExgKlkamGnS3E8N24++53xcMsYSzU?= =?us-ascii?Q?nYHCrC956rZ8cuYL7HvM8XmRTTPr2UYjaEyBOiQFoM9+q3/tH62ySEmvAfx0?= =?us-ascii?Q?aA9Csm4O2FakqUk1uCFbpuWSkWqBTjaotEb3f10B1gtFfg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RzC84HkIzPD9uCKdbI41zxcLESjX1qPyVXJ0ht67g6TeAiJZIL4Ly5Sm3g0A?= =?us-ascii?Q?CUcT6FX7TDx+C68qAl8UL1z8rUxBH1DgdBuK7BiJLuLsh3tgEyT+XsW0Pknj?= =?us-ascii?Q?6yrZviZYJ+8l1TKOFoOt8u0PSu3mXInKNSlbtCm+i4eKgfUeaMezQLF6/LOb?= =?us-ascii?Q?OHPQGWqg+KMwgQyaUOlQNJ5TqPwVROf01hldKeXNbdmgu2M0Qysj1hjxMyAB?= =?us-ascii?Q?E7zBNIaWno62LgVtaIb9s/UV2WiCX5ToKyUCWhe6zJgw5a//vpEnKpFKLU6o?= =?us-ascii?Q?/OP6z6LT/+g6NjEgJ2EnvHSwZ3WIQyX/9kjfM4k5NIubBdM+tfKArpTzsf96?= =?us-ascii?Q?JAXv/GckRO6LSICwzMCtEeeeeyo72WKe4GxiY5HxrAukCX3ptjc2kcR22cmr?= =?us-ascii?Q?6sa7PYdGK8fj8J9bMXuJ1hjZMckyqS1XPxUf+scutZ0T2jOMMCgr9b05g9b6?= =?us-ascii?Q?55nKEGAYQWyYsJZKCFFmKM9T8SSzS0qO6iLBTnk9gKgQ8SYInjQM+wcSluu4?= =?us-ascii?Q?vPk4DfaCZUtvQP1szfkdCyzsDRZDJguhic0BkBlAXhVk/JE3V60beIal7vTa?= =?us-ascii?Q?QK6TPFamS53b6TEUfqPcExxOepn4SwKrFjSCH54jSZ795tT56vhPlw80lEMY?= =?us-ascii?Q?Mlgftl/Dq4hLzmNK6ym5oZ6uYRZyzfrv4PQ/J946fBQDWDDZQ3OTqdkWzOvp?= =?us-ascii?Q?r2K369SWRE5iUbuGexpU5dGnzU95J20BTrJOvJIV1yERZ7BVcoWZTUpUJA4+?= =?us-ascii?Q?2y0cX+Gvjs9AYnpn9HcgTyipMGiztG2+S3JiZ9RUyWkXTPF9wND0XTOj7Qqo?= =?us-ascii?Q?dNvFIDpZCipTmQlAfqX1s3Rhv+VHZLwTcAISKyauorJvSHuedvdhLlkqWW6K?= =?us-ascii?Q?Ji9Uw/Hy/3ec4nKQ26QR/Jd9O1pn1vKjRY+Uk50r8MM4GECEy6pj8svTyiSb?= =?us-ascii?Q?Pu9ER3Lrz02Ka3M9rPYvdwu+7EAt6vyRqGh3qwXAF0QgvV9r9eZqO2HK8XXR?= =?us-ascii?Q?4i+DMXl1FKiodcSY2J2yg/tVuhMXRXaZrC3abcfFlDmK/icoxrGHMeZKQ7gZ?= =?us-ascii?Q?wZlFp26J6ENu71rLJL6/Izf4zpLDArQXMGq1Daple/HjszmcU+klLAzvgRlm?= =?us-ascii?Q?R0cLqZybdBqYvLc6JXtt2ec/KrmZQLPzCTRecSxooxU4AIC+omz0uivW05uE?= =?us-ascii?Q?EQP9OCcFb6Ql6krYdR8v1GPsUKmkMReO+a57xam+sJItM8XnoY5Hdky2p3K8?= =?us-ascii?Q?TVFW41pgV65WuTTYSfINQWWztqLLr2G2Z9oOFyiO5O/SYGdz9EeEIMat/R6T?= =?us-ascii?Q?mTOhUhFid5QSFFlgVYFDetpfh5pQa4wandeI0vrltC/8c1SdjzlkWl02JhOv?= =?us-ascii?Q?BK/gAV+NoEkWlGTbg+3Z87uugrom7FS3C6KpSJBtwUbojKj5S0MNVvFZTyjp?= =?us-ascii?Q?Le6Q4Gau45zEYiMVU082cGnIEkfarUhvm5/5zzjMqFMnDCboryP1V7u3P95x?= =?us-ascii?Q?ZeY2xQK+2LMPOFq1vWTTUAmzW58bRISHcvF/yw18+uF/iLR54N/G1df4fFmr?= =?us-ascii?Q?eGWu9tTeAmoVyAxPtBCpVYy5azCdpkH9FJxhZ0vVknGqFi51wx2cd5WCgsR2?= =?us-ascii?Q?mw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 295cd81d-336a-46c9-7c9a-08dccbf2c259 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2024 08:31:08.5108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6ZpQ29Kq71NS7a2VTFcniwJ630F4J0LYJHMhSFEFfD+/0DKI0uA5m80F2CF4IHIC78Ogi/HN641V6z61v8KCKLkjbhKl6keVfmd6c7M+1xY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5315 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 02, 2024 at 04:34:34PM +0200, Burakov, Anatoly wrote: > On 8/2/2024 2:44 PM, Bruce Richardson wrote: > > As meson processes our DPDK source tree it manages dependencies > > specified by each individual driver. To enable future analysis of the > > dependency links between components, log the dependencies of each DPDK > > component as it gets processed. This could potentially allow other tools > > to automatically enable or disable components based on the desired end > > components to be built, e.g. if the user requests net/ice, ensure that > > common/iavf is also enabled in the drivers. > > > > The output file produced is in "dot" or "graphviz" format, which allows > > producing a graphical representation of the DPDK dependency tree if so > > desired. For example: "dot -Tpng -O build/deps.dot" to produce the > > image file "build/deps.dot.png". > > > > Signed-off-by: Bruce Richardson > > Acked-by: Konstantin Ananyev > > > > --- > > > > > +try: > > + contents = file_to_list(depsfile) > > +except FileNotFoundError: > > + contents = ['digraph {\n', '}\n'] > > + > > +component = sys.argv[1] > > +if len(sys.argv) > 2: > > + contents[-1] = f'"{component}" -> {{ "{"\", \"".join(sys.argv[2:])}" }}\n' > > This is invalid syntax prior to Python 3.12. You're doing escaped quotes > ("\", \"") inside a f-string block ({}). My machine has Python 3.9 and this > breaks the script. > Thanks for the heads-up. I'll do a respin when I can.